Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all pending cops #1902

Merged
merged 1 commit into from
Jun 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- Add new `RSpec/ExpectInLet` cop. ([@yasu551])
- Remove `RSpec/Capybara/FeatureMethods` cop. If you are using this cop, change it to use `RSpec/Dialect`. ([@ydah])
- Support `AutoCorrect: contextual` option for LSP. ([@ydah])
- Enable all pending cops. ([@bquorning])

## 2.29.2 (2024-05-02)

Expand Down
64 changes: 32 additions & 32 deletions config/default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,15 +146,15 @@ RSpec/Be:

RSpec/BeEmpty:
Description: Prefer using `be_empty` when checking for an empty array.
Enabled: pending
Enabled: true
AutoCorrect: contextual
VersionAdded: '2.20'
VersionChanged: "<<next>>"
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/BeEmpty

RSpec/BeEq:
Description: Check for expectations where `be(...)` can replace `eq(...)`.
Enabled: pending
Enabled: true
Safe: false
VersionAdded: 2.9.0
VersionChanged: '2.16'
Expand All @@ -170,7 +170,7 @@ RSpec/BeEql:

RSpec/BeNil:
Description: Ensures a consistent style is used when matching `nil`.
Enabled: pending
Enabled: true
EnforcedStyle: be_nil
SupportedStyles:
- be
Expand All @@ -193,7 +193,7 @@ RSpec/BeforeAfterAll:

RSpec/ChangeByZero:
Description: Prefer negated matchers over `to change.by(0)`.
Enabled: pending
Enabled: true
VersionAdded: '2.11'
VersionChanged: '2.14'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ChangeByZero
Expand All @@ -202,7 +202,7 @@ RSpec/ChangeByZero:
RSpec/ClassCheck:
Description: Enforces consistent use of `be_a` or `be_kind_of`.
StyleGuide: "#is-a-vs-kind-of"
Enabled: pending
Enabled: true
VersionAdded: '2.13'
EnforcedStyle: be_a
SupportedStyles:
Expand All @@ -212,7 +212,7 @@ RSpec/ClassCheck:

RSpec/ContainExactly:
Description: Checks where `contain_exactly` is used.
Enabled: pending
Enabled: true
VersionAdded: '2.19'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ContainExactly

Expand Down Expand Up @@ -306,7 +306,7 @@ RSpec/Dialect:

RSpec/DuplicatedMetadata:
Description: Avoid duplicated metadata.
Enabled: pending
Enabled: true
VersionAdded: '2.16'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DuplicatedMetadata

Expand Down Expand Up @@ -367,21 +367,21 @@ RSpec/EmptyLineAfterSubject:

RSpec/EmptyMetadata:
Description: Avoid empty metadata hash.
Enabled: pending
Enabled: true
AutoCorrect: contextual
VersionAdded: '2.24'
VersionChanged: "<<next>>"
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/EmptyMetadata

RSpec/EmptyOutput:
Description: Check that the `output` matcher is not called with an empty string.
Enabled: pending
Enabled: true
VersionAdded: '2.29'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/EmptyOutput

RSpec/Eq:
Description: Use `eq` instead of `be ==` to compare objects.
Enabled: pending
Enabled: true
VersionAdded: '2.24'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Eq

Expand Down Expand Up @@ -423,7 +423,7 @@ RSpec/ExampleWording:

RSpec/ExcessiveDocstringSpacing:
Description: Checks for excessive whitespace in example descriptions.
Enabled: pending
Enabled: true
VersionAdded: '2.5'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExcessiveDocstringSpacing

Expand Down Expand Up @@ -456,8 +456,8 @@ RSpec/ExpectInHook:

RSpec/ExpectInLet:
Description: Do not use `expect` in let.
Enabled: pending
VersionAdded: "<<next>>"
Enabled: true
VersionAdded: '2.30'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExpectInLet

RSpec/ExpectOutput:
Expand Down Expand Up @@ -496,7 +496,7 @@ RSpec/HooksBeforeExamples:

RSpec/IdenticalEqualityAssertion:
Description: Checks for equality assertions with identical expressions on both sides.
Enabled: pending
Enabled: true
VersionAdded: '2.4'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IdenticalEqualityAssertion

Expand Down Expand Up @@ -533,7 +533,7 @@ RSpec/ImplicitSubject:

RSpec/IndexedLet:
Description: Do not set up test data using indexes (e.g., `item_1`, `item_2`).
Enabled: pending
Enabled: true
VersionAdded: '2.20'
VersionChanged: '2.23'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IndexedLet
Expand All @@ -558,7 +558,7 @@ RSpec/InstanceVariable:

RSpec/IsExpectedSpecify:
Description: Check for `specify` with `is_expected` and one-liner expectations.
Enabled: pending
Enabled: true
VersionAdded: '2.27'
StyleGuide: https://rspec.rubystyle.guide/#it-and-specify
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IsExpectedSpecify
Expand Down Expand Up @@ -610,7 +610,7 @@ RSpec/LetSetup:

RSpec/MatchArray:
Description: Checks where `match_array` is used.
Enabled: pending
Enabled: true
VersionAdded: '2.19'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/MatchArray

Expand Down Expand Up @@ -643,7 +643,7 @@ RSpec/MessageSpies:

RSpec/MetadataStyle:
Description: Use consistent metadata style.
Enabled: pending
Enabled: true
EnforcedStyle: symbol
SupportedStyles:
- hash
Expand Down Expand Up @@ -711,7 +711,7 @@ RSpec/NestedGroups:

RSpec/NoExpectationExample:
Description: Checks if an example contains any expectation.
Enabled: pending
Enabled: true
Safe: false
VersionAdded: '2.13'
VersionChanged: '2.14'
Expand Down Expand Up @@ -744,7 +744,7 @@ RSpec/Pending:

RSpec/PendingWithoutReason:
Description: Checks for pending or skipped examples without reason.
Enabled: pending
Enabled: true
VersionAdded: '2.16'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/PendingWithoutReason

Expand All @@ -770,7 +770,7 @@ RSpec/ReceiveCounts:

RSpec/ReceiveMessages:
Description: Checks for multiple messages stubbed on the same object.
Enabled: pending
Enabled: true
SafeAutoCorrect: false
VersionAdded: '2.23'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ReceiveMessages
Expand All @@ -783,19 +783,19 @@ RSpec/ReceiveNever:

RSpec/RedundantAround:
Description: Remove redundant `around` hook.
Enabled: pending
Enabled: true
VersionAdded: '2.19'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RedundantAround

RSpec/RedundantPredicateMatcher:
Description: Checks for redundant predicate matcher.
Enabled: pending
Enabled: true
VersionAdded: '2.26'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RedundantPredicateMatcher

RSpec/RemoveConst:
Description: Checks that `remove_const` is not used in specs.
Enabled: pending
Enabled: true
VersionAdded: '2.26'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RemoveConst

Expand Down Expand Up @@ -831,7 +831,7 @@ RSpec/RepeatedIncludeExample:

RSpec/RepeatedSubjectCall:
Description: Checks for repeated calls to subject missing that it is memoized.
Enabled: pending
Enabled: true
VersionAdded: '2.27'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedSubjectCall

Expand Down Expand Up @@ -888,19 +888,19 @@ RSpec/SingleArgumentMessageChain:

RSpec/SkipBlockInsideExample:
Description: Checks for passing a block to `skip` within examples.
Enabled: pending
Enabled: true
VersionAdded: '2.19'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/SkipBlockInsideExample

RSpec/SortMetadata:
Description: Sort RSpec metadata alphabetically.
Enabled: pending
Enabled: true
VersionAdded: '2.14'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/SortMetadata

RSpec/SpecFilePathFormat:
Description: Checks that spec file paths are consistent and well-formed.
Enabled: pending
Enabled: true
Include:
- "**/*_spec.rb"
Exclude:
Expand All @@ -916,7 +916,7 @@ RSpec/SpecFilePathFormat:

RSpec/SpecFilePathSuffix:
Description: Checks that spec file paths suffix are consistent and well-formed.
Enabled: pending
Enabled: true
VersionAdded: '2.24'
Include:
- "**/*_spec*rb*"
Expand All @@ -931,7 +931,7 @@ RSpec/StubbedMock:

RSpec/SubjectDeclaration:
Description: Ensure that subject is defined using subject helper.
Enabled: pending
Enabled: true
VersionAdded: '2.5'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/SubjectDeclaration

Expand All @@ -945,7 +945,7 @@ RSpec/SubjectStub:

RSpec/UndescriptiveLiteralsDescription:
Description: Description should be descriptive.
Enabled: pending
Enabled: true
VersionAdded: '2.29'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/UndescriptiveLiteralsDescription

Expand Down Expand Up @@ -979,7 +979,7 @@ RSpec/VariableName:

RSpec/VerifiedDoubleReference:
Description: Checks for consistent verified double reference style.
Enabled: pending
Enabled: true
SafeAutoCorrect: false
EnforcedStyle: constant
SupportedStyles:
Expand Down
Loading