-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maven packages #193
base: develop
Are you sure you want to change the base?
Maven packages #193
Conversation
…s so that they can be referenced in any application that uses a build system compatible with Maven packages.
Just out of interest, what changes would be required int this Maven artifact definition, to include target platforms other than |
I forgot to mention the |
I'd need to add a line to the pom to pull in the
Does the |
To be specific: https://github.com/readium/readium-sdk/pull/193/files#diff-fc48f08e2ee31a43a379d7e21209839aR38 It would just require another |
I think so (need to check):
|
Right! |
I built it last month, and the answer is Yes Cyril Cyril LABORDRIE Cap Digital, Business Cluster For Digital Content and Services De : Daniel Weck [mailto:notifications@github.com] @io7mhttps://github.com/io7m Does the x86 branch produce both an ARM and x86 library in the same build step?
— |
These are functionally equivalent to the POM files added in the PR readium#193, however these use an org.nypl.readium group ID to prevent accidental use of the packages.
This adds all required metadata for OSSRH, adds optional PGP signing, and adds the x86 library that appeared some time after the original project files were written.
The latest changes added metadata in a similar manner to readium/readium-shared-js#207. Importantly, the extra changes also add support for deploying the |
We'll need to figure out how this relates to the SDK as we move to Android Studio. |
Android Studio will nag you to switch to Gradle, as that's the train wreck Google are currently recommending, but it should use the existing setup without modification. Any packages produced with Maven and published to Maven Central are automatically compatible with Gradle. |
@io7m there's a great AndroidStudio+Gradle setup with hybrid Java / C++ debugging, here: readium/SDKLauncher-Android#84 Have you tried it? |
I haven't tried it. |
This change simply adds a few Maven POM files that will produce standard Java jar files that can be deployed to any Maven repository. This allows anyone using Maven (or a build system that uses Maven packages such as Gradle) to access the Android APIs and native library without having to import sources, or manually attach libraries to their project. They simply declare a dependency in their project files, and their build system fetches and handles all packaging for them.
The change is entirely opt-in: If you don't run Maven, you won't see anything new.