-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Produce Maven packages for shared Javascript components #207
base: develop
Are you sure you want to change the base?
Conversation
Thanks @io7m |
Yep, there's no technical reason for not adding |
Updating the version of the |
Re. version updating: Perhaps |
Note: Need to review this with respect to updating the versions in the various deliverables |
ACTION: Mark is the owner. He will work with Daniel to ensure we are not introducing conflicts. Note that there is a dependency on other PRs in SDK, SDK readium/readium-sdk#193 |
…entral OSSRH requirements.
…c" jar, as these are requirements for the OSSRH repository.
Ok, I've pushed the changes that were necessary. Currently, the version number is manually set to |
I suspect I'll be the one actually pushing the packages to Central, as I'm already set up to do so (have PGP keys, have a Sonatype account, etc). |
Note that no Readium NPM packages have been published yet to: More specifically, the POM / Maven build artifacts (single RequireJS / AMD bundles) would eventually match the NPM ones (same "semantic versioning" strings): |
This change simply adds a Maven POM file that will produce a standard Java jar file that can be deployed to any Maven repository. This allows anyone using Maven (or a build system that uses Maven packages such as Gradle) to add the
readium-shared-js
components to their application without having to import any sources directly, or use git submodules.The change is entirely opt-in: If you don't run Maven, you won't see anything new.