require sphinx<8.2.0 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Lamb <jlamb@nvidia.com>
jameslamb
added
improvement
This was referenced Feb 21, 2025
seberg
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Thanks, probably good to just put it in to keep things aligned; it doesn't really matter when exactly we check again if the issue needs a fix here or not.
I don't think nbsphinx is used here, so the issue(s) are probably different (one was a default parameter in a .pyi file, the other seemed like myst extension related).
|
Ah ok thanks, I wasn't sure what led to that
Ok I'll merge this, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A pin like
sphinx!=8.2.0was added in #30, I'm guessing for similar reasons as documented in rapidsai/build-planning#155.That can't be removed until some upstream changes are made in
nbsphinx(linked in that issue). This proposes changing the pin to<8.2.0(to prevent CI breaking again if an 8.2.1 or 8.3.0 is released) and adding a comment explaining when it can be removed.Checklist
./build.sh testfor local testing, see CONTRIBUTING.md.pre-commitchecks are passing see CONTRIBUTING.md.