MAINT: update rapids-dependency-file-generator to 1.17.1, fix docs builds #14
Conversation
Signed-off-by: James Lamb <jlamb@nvidia.com>
jameslamb
added
improvement
Signed-off-by: James Lamb <jlamb@nvidia.com>
jameslamb
force-pushed
the
sphinx-pin
branch
from
af7e016 to
b39b96d
Compare
jameslamb
changed the title
| ../../CONTRIBUTING.md |
There was a problem hiding this comment.
I saw 2 warnings treated as errors in the docs builds:
/__w/legate-raft/legate-raft/docs/source/CONTRIBUTING.md:25: WARNING: Unknown source document '/__w/legate-raft/legate-raft/README' [myst.xref_missing]
/__w/legate-raft/legate-raft/docs/source/README.md:49: WARNING: Unknown source document '/__w/legate-raft/legate-raft/CONTRIBTING' [myst.xref_missing]
Renaming CONTRIBTING.md to CONTRIBUTING.md should fix one of them (the reference in docs/source/index.rst was inconsistent with the actual file name), and maybe both?
There was a problem hiding this comment.
Ahhhh ok, so I still think this renaming (to fix the spelling error) was a good thing, but it did not resolve the failure.
Interesting to note that the docs this is complaining about are totally working in the rendered docs. You can go to https://rapidsai.github.io/legate-raft/README.html and try clicking "our guide for contributing to legate-raft" ... it leads to https://rapidsai.github.io/legate-raft/CONTRIBUTING.html successfully.
There was a problem hiding this comment.
Oh! @seberg I just saw your comment here: rapidsai/legate-boost#212 (comment)
I guess it's sphinx 8.2.0 that is causing these warnings? I'll try pinning here too.
There was a problem hiding this comment.
Right, that was one of the things I saw in legate-df.
There was a problem hiding this comment.
Ah got it, ok! I've pushed a sphinx<8.2.0 pin here, it looks like it'd fix docs builds: https://github.com/rapidsai/legate-raft/actions/runs/13502337421/job/37726967372?pr=14
Signed-off-by: James Lamb <jlamb@nvidia.com>
jameslamb
force-pushed
the
sphinx-pin
branch
from
3edd10d to
f905f1d
Compare
Signed-off-by: James Lamb <jlamb@nvidia.com>
Signed-off-by: James Lamb <jlamb@nvidia.com>
Contributes to rapidsai/build-planning#155
Miscellaneous small changes:
rapids-dependency-file-generator(1.17.1)sphinxto<8.2.0(MAINT: update rapids-dependency-file-generator to 1.17.1, fix docs builds #14 (comment))CONTRIBTING.mdtoCONTRIBUTING.md(fixing typo)