Introduces a key to look up a candidate in various dictionaries #406
Conversation
| @@ -281,6 +281,10 @@ public class VerticalCandidateController: CandidateController { | |||
| newIndex = 0 | |||
| } | |||
|
|
|||
| if newIndex == UInt.max { | |||
There was a problem hiding this comment.
I think the same commit to OpenVanilla should be carried over here too. That is, a UInt.max check should be placed in line 297, and these three lines (284-286 currently) are dead code anyway, because newIndex is always set to 0 if newValue is UInt.max (from lines 276-282).
|
|
||
| "MOE Dict (Holo)" = "台語萌典"; | ||
|
|
||
| "MOE Dict (Holo)" = "客語萌典"; |
There was a problem hiding this comment.
nit: "MOE Dict (Hakka)" instead?
Source/en.lproj/Localizable.strings
Outdated
|
|
||
| "MOE Dict" = "MOE Dict"; | ||
|
|
||
| "MOE Dict (Holo)" = "MOE Dict (Holo)"; |
There was a problem hiding this comment.
nit: Missing entry for "MOE Dict (Hakka)"?
Source/dictionary_service.json
Outdated
| "url_template": "dict://(encoded)" | ||
| }, | ||
| { | ||
| "name": "MOE Dict", |
There was a problem hiding this comment.
I was wondering if this should be called "moedict.tw" since "MOE Dict" sounds like the officical MOE dictionary. Or should this simply be called "萌典" without localization just like "教育部重編國語詞典修訂本" below?
Calling the three entries 萌典、萌典（台語）、萌典（客語） also removes the need to localize them in English.
The PR helps users to know about the detailed information about a candidate. When a user opens the candidate window to list all available candidates, he or she can highlight a candidate and press on the "?" key. A menu will be opened to list available dictionaries.
Then, the user can pick a dictionary service from the menu, and McBopomofo will open external web browser, dictionary app and so on accordingly. One of the options is to let the user to see the character code of the highlighted candidate.