Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces a key to look up a candidate in various dictionaries #406

Merged
merged 20 commits into from
Dec 27, 2023
Merged

Introduces a key to look up a candidate in various dictionaries #406

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
f91f4be
Fixes a potential crash in the candidate window.
zonble Dec 24, 2023
713541a
Implements the feature to lookup a candidate in a dictionary.
zonble Dec 24, 2023
feca5b5
Minor bug fixes for dictionary lookup.
zonble Dec 24, 2023
9907a32
Updates localization and unit tests.
zonble Dec 25, 2023
4313477
Adds tests.
zonble Dec 25, 2023
c99820b
Adds additional dictionary services.
zonble Dec 25, 2023
8b310e1
Adds additional dictionary services.
zonble Dec 25, 2023
aeed903
Prevents duplicated code.
zonble Dec 25, 2023
9668794
Simplifies the dictionary services.
zonble Dec 25, 2023
5a07cda
Remaps the key to do dictionary look up to "?".
zonble Dec 25, 2023
9fd2070
Fixes tests.
zonble Dec 25, 2023
d17d75b
Adds a menu to display character information.
zonble Dec 25, 2023
88339a9
Fixes tests.
zonble Dec 25, 2023
e85a7f3
Applies the key to look up candidates only in Bopomofo mode.
zonble Dec 25, 2023
ae0f210
Allows user to look up current marked text.
zonble Dec 26, 2023
cbd1172
Merge branch 'master' of github.com:openvanilla/McBopomofo
zonble Dec 26, 2023
7433b4c
Merge branch 'master' of github.com:openvanilla/McBopomofo
zonble Dec 27, 2023
caa7065
Fixes tests.
zonble Dec 27, 2023
c63ee83
Cleans up the list of the dictionary services.
zonble Dec 27, 2023
e628dff
Fixes a potentiaal crash in VerticalCandidateController.
zonble Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Packages/CandidateUI/Sources/CandidateUI/VerticalCandidateController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,10 @@ public class VerticalCandidateController: CandidateController {
newIndex = 0
}

if newIndex == UInt.max {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the same commit to OpenVanilla should be carried over here too. That is, a UInt.max check should be placed in line 297, and these three lines (284-286 currently) are dead code anyway, because newIndex is always set to 0 if newValue is UInt.max (from lines 276-282).

return
}

var lastVisibleRow = newValue

if selectedRow != -1 && itemCount > 0 && itemCount > labelCount {
Expand Down