Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change exception for gosec linter #600

Merged
merged 1 commit into from
Feb 20, 2025
Merged

chore: change exception for gosec linter #600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/check-manifest-generation-diff.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ name: Check for diff after manifest and generated targets
on:
pull_request: {}

permissions:
contents: read
pull-requests: write

jobs:
diff-check-manifests:
name: Check for diff
Expand Down
4 changes: 2 additions & 2 deletions api/v1alpha1/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const (
// DefaultRegistryCertificateSecretName is the name of the of certificate secret for client and registry.
DefaultRegistryCertificateSecretName = "ocm-registry-tls-certs" // nolint:gosec // not a credential
DefaultRegistryCertificateSecretName = "ocm-registry-tls-certs" // #nosec G101 // not a credential

Check failure

Code scanning / gosec

Potential hardcoded credentials Error

Potential hardcoded credentials

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical

Hard-coded
secret
Loading
.
)

// Internal ExtraIdentity keys.
Expand Down Expand Up @@ -35,5 +35,5 @@
// Ocm credential config key for secrets.
const (
// OCMCredentialConfigKey defines the secret key to look for in case a user provides an ocm credential config.
OCMCredentialConfigKey = ".ocmcredentialconfig" // nolint:gosec // it isn't a cred
OCMCredentialConfigKey = ".ocmcredentialconfig" // #nosec G101 // not a credential

Check failure

Code scanning / gosec

Potential hardcoded credentials Error

Potential hardcoded credentials
)
3 changes: 1 addition & 2 deletions pkg/oci/repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,7 @@
}

func (c *Client) constructTLSRoundTripper() http.RoundTripper {
// nolint:gosec // must provide lower version for quay.io
tlsConfig := &tls.Config{}
tlsConfig := &tls.Config{} // #nosec G402 // must provide lower version for quay.io

Check failure

Code scanning / gosec

TLS MinVersion too low. Error

TLS MinVersion too low.
caCertPool := x509.NewCertPool()
caCertPool.AppendCertsFromPEM(c.ca)

Expand Down
Loading