chore: change exception for gosec linter #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morri-son
changed the title
morri-son
added
area/ipcei
Mend Scan Summary: ❌Repository: open-component-model/ocm-controller
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| const ( | |||
| // DefaultRegistryCertificateSecretName is the name of the of certificate secret for client and registry. | |||
| DefaultRegistryCertificateSecretName = "ocm-registry-tls-certs" // nolint:gosec // not a credential | |||
| DefaultRegistryCertificateSecretName = "ocm-registry-tls-certs" // #nosec G101 // not a credential | |||
Check failure
Code scanning / gosec
Potential hardcoded credentials Error
| @@ -35,5 +35,5 @@ | |||
| // Ocm credential config key for secrets. | |||
| const ( | |||
| // OCMCredentialConfigKey defines the secret key to look for in case a user provides an ocm credential config. | |||
| OCMCredentialConfigKey = ".ocmcredentialconfig" // nolint:gosec // it isn't a cred | |||
| OCMCredentialConfigKey = ".ocmcredentialconfig" // #nosec G101 // not a credential | |||
Check failure
Code scanning / gosec
Potential hardcoded credentials Error
| @@ -143,8 +143,7 @@ | |||
| } | |||
|
|
|||
| func (c *Client) constructTLSRoundTripper() http.RoundTripper { | |||
| // nolint:gosec // must provide lower version for quay.io | |||
| tlsConfig := &tls.Config{} | |||
| tlsConfig := &tls.Config{} // #nosec G402 // must provide lower version for quay.io | |||
Check failure
Code scanning / gosec
TLS MinVersion too low. Error
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| const ( | |||
| // DefaultRegistryCertificateSecretName is the name of the of certificate secret for client and registry. | |||
| DefaultRegistryCertificateSecretName = "ocm-registry-tls-certs" // nolint:gosec // not a credential | |||
| DefaultRegistryCertificateSecretName = "ocm-registry-tls-certs" // #nosec G101 // not a credential | |||
Check failure
Code scanning / CodeQL
Hard-coded credentials Critical
hilmarf
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
change exception for gosec linter