chore(package.json): Serverless v4 support. #271
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
neverendingqs
commented
Dec 31, 2024
Comment on lines
+16
to
+17
| serverless: ['2', '3', '4'] | ||
| node: [ '18', '20', '22' ] |
There was a problem hiding this comment.
TODO: update CHANGELOG with changes to serverless and Node.js support.
Rationale:
serverless@1doesn't seem to supportpackage.patterns:, causing a circular reference in integration tests (see below)serverless@4requires at least Node.js v18 and it would be simplest to just support active LTS versions
neverendingqs
commented
Dec 31, 2024
Comment on lines
-16
to
-18
| "devDependencies": { | ||
| "serverless-dotenv-plugin": "^6.0.0" | ||
| }, |
There was a problem hiding this comment.
Pre-existing issue: uses a specific version instead of the version in the PR. This change along with the npm link ../../ addition should resolve this.
neverendingqs
commented
Dec 31, 2024
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| service: my-express-application | |||
|
|
|||
| package: | |||
| patterns: | |||
| - '!node_modules/serverless-dotenv-plugin/**' | |||
There was a problem hiding this comment.
Avoid circular references due to symlinks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #264.
Blocked on serverless/serverless#12969.
Description
Checklist
Exploratory Test Notes