-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(package.json): Serverless v4 support. #271
base: master
Are you sure you want to change the base?
Changes from all commits
e523180
febae23
5ae1ae2
103c67f
fc23287
1385da4
42a4288
78f3b08
6ccd26a
7b1f194
208f45d
2780422
0392000
25b3c8c
bfdade7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,10 +13,7 @@ | |
"express": "^4.18.2", | ||
"serverless-http": "^3.2.0" | ||
}, | ||
"devDependencies": { | ||
"serverless-dotenv-plugin": "^6.0.0" | ||
}, | ||
Comment on lines
-16
to
-18
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pre-existing issue: uses a specific version instead of the version in the PR. This change along with the |
||
"peerDependencies": { | ||
"serverless": "1 || 2 || pre-3 || 3" | ||
"serverless": "2 || pre-3 || 3 || 4" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,10 @@ | |
|
||
service: my-express-application | ||
|
||
package: | ||
patterns: | ||
- '!node_modules/serverless-dotenv-plugin/**' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid circular references due to symlinks. |
||
|
||
plugins: | ||
- ../../ | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: update CHANGELOG with changes to
serverless
and Node.js support.Rationale:
serverless@1
doesn't seem to supportpackage.patterns:
, causing a circular reference in integration tests (see below)serverless@4
requires at least Node.js v18 and it would be simplest to just support active LTS versions