Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tour navigation dots and button to use theme's primary color #228

Conversation

eecavanna
Copy link
Collaborator

On this branch, I made two changes:

  1. Update the color of the navigation dots in the tour popup, so they use the app theme's primary color (instead of the NPM package's default color, which was a different shade of blue)
  2. Update the "Dismiss" button on the final step of the tour, so it matches the other buttons in the app (specifically, so its background color is the app theme's primary color)

Here are before-and-after screenshots:

Before

  • Left: iOS
  • Right: Android

Light palette

image

I think I didn't notice the dot's blue shade before because the app theme's primary color was not present in the popup (out of sight, out of mind).

Dark palette

image

I think I didn't notice the dot's blue shade before because the app theme's primary color was not present in the popup (out of sight, out of mind).

After

  • Left: iOS
  • Right: Android

Light palette

image

Dark palette

image

@eecavanna eecavanna self-assigned this Feb 11, 2025
@eecavanna eecavanna linked an issue Feb 11, 2025 that may be closed by this pull request
@eecavanna eecavanna marked this pull request as ready for review February 11, 2025 02:10
@eecavanna
Copy link
Collaborator Author

I consider the change to the dot color to be a "fix". It is an issue that I didn't know existed until I made the button use the app theme's primary color and saw the two shades of blue next to one another.

I consider the change to the "Dismiss" button color to be arbitrary (not necessarily a "fix"). In hindsight, I could go either way on it (i.e. keeping it blue—like most, if not all, of the other buttons in the app—or reverting to the light gray background).

Copy link
Collaborator

@pkalita-lbl pkalita-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement!

@eecavanna eecavanna merged commit e24c01f into main Feb 11, 2025
1 check passed
@eecavanna eecavanna deleted the 225-button-for-dismissing-tour-uses-incorrect-background-color-android branch February 11, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tour navigation dot color does not match theme color palette
2 participants