Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tour navigation dot color does not match theme color palette #225

Closed
eecavanna opened this issue Feb 10, 2025 · 0 comments · Fixed by #228
Closed

Tour navigation dot color does not match theme color palette #225

eecavanna opened this issue Feb 10, 2025 · 0 comments · Fixed by #228
Assignees
@eecavanna

Comments

@eecavanna
Copy link
Collaborator

eecavanna commented Feb 10, 2025 •
edited
Loading

Two things:

  1. The dots in the tour popup use a shade of blue that does not match the app theme color palette.

    Image

  2. Also, I was using the web app in "Material Design" mode today (?ionic:mode=md) and noticed the tour dismissal button has a light gray background instead of a blue one.

    Image

    Our other buttons have a blue background:

    Image

    I don't think this is necessarily a bug. I like the way it looks on iOS (with the non-elevated button), but not on Android.
@eecavanna eecavanna self-assigned this Feb 10, 2025
@eecavanna eecavanna linked a pull request Feb 11, 2025 that will close this issue
Update tour navigation dots and button to use theme's primary color #228
Merged
@eecavanna eecavanna moved this to In Review in Field Notes Squad Board Feb 11, 2025
@eecavanna eecavanna changed the title Button for dismissing tour uses incorrect background color (Android) Tour navigation dot color does not match theme primary color Feb 11, 2025
@eecavanna eecavanna changed the title Tour navigation dot color does not match theme primary color Tour navigation dot color does not match theme color palette Feb 11, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in Field Notes Squad Board Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eecavanna eecavanna

Labels
None yet
Projects
Field Notes Squad Board
Archived in project
2025 - Sprint 56 - Feb 10-21,2025
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update tour navigation dots and button to use theme's primary color microbiomedata/nmdc-field-notes
1 participant
@eecavanna