feat(compat): migrate BCD table to Web Component #12580
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
force-pushed
the
compat-lit
branch
3 times, most recently
from
c6e3fed to
6f02696
Compare
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller
Unchanged
|
caugner
changed the title
caugner
added
browser-compat
LeoMcA
reviewed
Mar 12, 2025
There was a problem hiding this comment.
Some initial lit/jsdoc notes:
There's a few // @tsignores in here which don't fill me with joy
I'd also suggest adopting the convention I've taken with lit components which is to prefix all internal state/properties/methods/etc. with _: it makes it super clear which are supposed to be used externally, which are lit-defined lifecycle methods, and which is "our stuff"
github-actions
bot
added
plus
Used GPT-o3-mini-high and refined manually.
LeoMcA
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Looks good! Limited my review to the code, rather than testing.
I pushed a commit to tighten up a few of the types and remove most of the @ts-ignores: to do this I had to move a few of the types back into a typescript file, jsdoc just doesn't provide the same ability to define types: perhaps we want to move all the @typedefs back to typescript?
There was a problem hiding this comment.
Initial thought is that this is a big file/component, but I'm not sure if/where it really makes sense to split it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the Browser compatibility table to a Lit-powered Web Component, and applies some enhancements:
window.open()(to avoid issue spam), and it is accompanied by a "View data on GitHub" link (fixes From the Browser compatibility tables, link to the actual JSON data in BCD #6596)..0in version numbers (to save space in the Node.js column).Screenshots
Large
Before
After
Medium
Before
After
Small
How did you test this change?
yarn devand checked http://localhost:3000/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl#browser_compatibility, among others.