fix(compat): fix types, removing unnecessary @ts-ignore

client/src/lit/compat/feature-row.js

@@ -3,7 +3,7 @@ import { html } from "lit";
 
 /**
  * @import { BrowserStatement } from "@mdn/browser-compat-data/types"
- * @import { SupportStatementExtended } from "./utils.js"
+ * @import { SupportStatementExtended } from "./types"
  * @typedef {"no"|"yes"|"partial"|"preview"|"removed-partial"|"unknown"} SupportClassName
  */
 
@@ -101,6 +101,5 @@ export function getSupportBrowserReleaseDate(support) {
     return undefined;
   }
 
-  // @ts-ignore
   return getCurrentSupport(support)?.release_date;
 }

client/src/lit/compat/legend.js

@@ -62,7 +62,6 @@ export function getActiveLegendItems(compat, name, browserInfo, browsers) {
     }
 
     for (const browser of browsers) {
-      // @ts-ignore
       const browserSupport = feature.compat.support[browser] ?? {
         version_added: null,
       };
@@ -71,9 +70,8 @@ export function getActiveLegendItems(compat, name, browserInfo, browsers) {
         continue;
       }
 
-      // @ts-ignore
       const firstSupportItem = getFirst(browserSupport);
-      if (hasNoteworthyNotes(firstSupportItem)) {
+      if (firstSupportItem && hasNoteworthyNotes(firstSupportItem)) {
         legendItems.add("footnote");
       }
 
@@ -82,7 +80,6 @@ export function getActiveLegendItems(compat, name, browserInfo, browsers) {
           if (versionSupport.flags && versionSupport.flags.length) {
             legendItems.add("no");
           } else if (
-            // @ts-ignore
             versionIsPreview(versionSupport.version_added, browserInfo[browser])
           ) {
             legendItems.add("preview");
@@ -115,10 +112,7 @@ export function getActiveLegendItems(compat, name, browserInfo, browsers) {
     }
   }
 
-  /**
-   * @type {any[]}
-   */
-  const keys = Object.keys(LEGEND_LABELS);
+  const keys = /** @type {LegendKey[]} */ (Object.keys(LEGEND_LABELS));
 
   return keys
     .filter((key) => legendItems.has(key))

client/src/lit/compat/types.ts

@@ -0,0 +1,17 @@
+import type BCD from "@mdn/browser-compat-data/types";
+
+// Extended for the fields, beyond the bcd types, that are extra-added
+// exclusively in Yari.
+export interface SimpleSupportStatementExtended
+  extends BCD.SimpleSupportStatement {
+  // Known for some support statements where the browser *version* is known,
+  // as opposed to just "true" and if the version release date is known.
+  release_date?: string;
+  // The version before the version_removed if the *version* removed is known,
+  // as opposed to just "true". Otherwise the version_removed.
+  version_last?: BCD.VersionValue;
+}
+
+export type SupportStatementExtended =
+  | SimpleSupportStatementExtended
+  | SimpleSupportStatementExtended[];

client/src/lit/compat/utils.js

@@ -1,16 +1,6 @@
 /**
  * @import { SimpleSupportStatement, VersionValue, CompatStatement, Identifier, SupportStatement, BrowserStatement } from "@mdn/browser-compat-data/types"
- * @typedef {SimpleSupportStatementExtended | SimpleSupportStatementExtended[]} SupportStatementExtended
- */
-
-/**
- * Extended for the fields, beyond the bcd types, that are extra-added exclusively in Yari.
- *
- * Inherits all properties from SimpleSupportStatement.
- *
- * @typedef {SimpleSupportStatement} SimpleSupportStatementExtended
- * @property {string} [release_date] - Known for some support statements where the browser version is known.
- * @property {VersionValue} [version_last] - The version before the version_removed if the version removed is known.
+ * @import { SupportStatementExtended, SimpleSupportStatementExtended } from "./types"
  */
 
 /**
@@ -33,8 +23,8 @@ export const HIDDEN_BROWSERS = ["ie"];
  * Gets the first element of an array or returns the value itself.
  *
  * @template T
- * @param {T | [T, ...any[]]} a
- * @returns {T}
+ * @param {T | [T?, ...any[]]} a
+ * @returns {T | undefined}
  */
 export function getFirst(a) {
   return Array.isArray(a) ? a[0] : a;
@@ -308,6 +298,5 @@ export function getCurrentSupport(support) {
   if (noSupportItem) return noSupportItem;
 
   // Default (likely never reached).
-  // @ts-ignore
   return getFirst(support);
 }