-
Notifications
You must be signed in to change notification settings - Fork 598
Simplify reference architecture and evolve scale docs #7893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
spirosoik
commented
Apr 22, 2025
- Simplified architecture and splitting server from Monitoring + ES
- Update scale tables with Azure instances
- Simplified architecture and splitting server from Monitoring + ES - Update scale tables with Azure instances
Newest code from mattermost has been published to preview environment for Git SHA cc11de6 |
Newest code from mattermost has been published to preview environment for Git SHA 273967b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great updates, @spirosoik! Thank you!
Small note: If we're changing /deploy/quick-start-evaluation.html
to /deploy/try-mattermost.html
, a page redirect will be needed via conf.py
to ensure docs visitors with older links reach the correct destination.
thanks @cwarnermm for pointing this out |
…ious user capacity tables
…into fix/server-architecture
Newest code from mattermost has been published to preview environment for Git SHA 353f09b |
Newest code from mattermost has been published to preview environment for Git SHA f3329fa |
Newest code from mattermost has been published to preview environment for Git SHA 4a78cad |
Newest code from mattermost has been published to preview environment for Git SHA 5e95e8a |
@streamer45 @agnivade could you have a first look here, we did a couple of updates on reference architecture. What's not in scope for this PR and it's coming next:
@cwarnermm if everyone is ok we can merge this and I will continue with another PR for a few more improvements |
Will defer to @agarciamontoro |
Newest code from mattermost has been published to preview environment for Git SHA 2b81562 |
@spirosoik Are the Azure instance classes mapped on a best effort basis, or has your team conducted tests? |
Correct @streamer45 it's best effort. me, @stafot and @angeloskyratzakos worked together on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good overall. I'll defer to Alejandro for a more fine-grained review. One question I have is about Azure Blob Storage: do we have native support for it and documentation on how to configure Mattermost with it?
Not native. there's a work (PR here: mattermost/mattermost#30639) to start supporting this natively. Jesus plan to finalise tests/etc and have ready for review till Monday. Of course this needs extra testing/review etc. |
Newest code from mattermost has been published to preview environment for Git SHA 3d2cb24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for updating the images, they now render perfectly :) I only have a couple of general suggestions:
- AWS data is backed by tests, but Azure is not. Should we add a disclaimer about that somewhere? Maybe something like "Every setup was tested to support the corresponding number of users in AWS exclusively. The specification of Azure instances in each architecture is extrapolated from the AWS data, and while it should generally work, it has not been proved".
- Non-blocking: if you don't know the Azure data is there, it's hard to find it: the way the tables are rendered, at least in my screen, make it seem that they only contain the AWS data. Unless one sees the horizontal scrollbar, the last column may be overlooked:
@cwarnermm I would like your input here.
There's an issue in multiple places with this. |
For the horizontal table scroll issue (and lack of Azure data visibility in said tables), I don't have an elegant fix, but I do recommend noting on the page that the user can scroll to see more information. example here |
Newest code from mattermost has been published to preview environment for Git SHA fd0b657 |
@cwarnermm fixed the scroll.
@cwarnermm any good ideas how to incorporate this? I |
Newest code from mattermost has been published to preview environment for Git SHA e701e5a |
@cwarnermm @agarciamontoro we can merge this to have the collateral and we can continue the improvements. |
If this is very urgent, yes, we can merge. Otherwise, I'd appreciate discussing my proposal, I'm open to rewording what I suggested, it's in no way set in stone :) |
we want to have the collateral public and we can add your proposal, as I have another multiple set of PRs and fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unblocking this, then :)
Incorporated Azure testing feedback re: #7905 |