Skip to content

Simplify reference architecture and evolve scale docs #7893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 29, 2025

Conversation

spirosoik
Copy link
Member

  • Simplified architecture and splitting server from Monitoring + ES
  • Update scale tables with Azure instances

@spirosoik spirosoik changed the title Simplify reference architecture and evolve scale docs [WIP] Simplify reference architecture and evolve scale docs Apr 22, 2025
Copy link

Newest code from mattermost has been published to preview environment for Git SHA cc11de6

Base automatically changed from restructure_nav2 to master April 23, 2025 10:47
@cwarnermm cwarnermm self-requested a review April 23, 2025 13:37
Copy link

Newest code from mattermost has been published to preview environment for Git SHA 273967b

Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great updates, @spirosoik! Thank you!

Small note: If we're changing /deploy/quick-start-evaluation.html to /deploy/try-mattermost.html, a page redirect will be needed via conf.py to ensure docs visitors with older links reach the correct destination.

@spirosoik
Copy link
Member Author

Great updates, @spirosoik! Thank you!

Small note: If we're changing /deploy/quick-start-evaluation.html to /deploy/try-mattermost.html, a page redirect will be needed via conf.py to ensure docs visitors with older links reach the correct destination.

thanks @cwarnermm for pointing this out

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 353f09b

@cwarnermm cwarnermm added the 3: Reviews Complete All reviewers have approved the pull request label Apr 23, 2025
Copy link

Newest code from mattermost has been published to preview environment for Git SHA f3329fa

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 4a78cad

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 5e95e8a

@spirosoik spirosoik changed the title [WIP] Simplify reference architecture and evolve scale docs Simplify reference architecture and evolve scale docs Apr 28, 2025
@spirosoik
Copy link
Member Author

@streamer45 @agnivade could you have a first look here, we did a couple of updates on reference architecture. What's not in scope for this PR and it's coming next:

  • Elasticsearch architecture for enhanced and optimised search
  • Monitoring etc.

@cwarnermm if everyone is ok we can merge this and I will continue with another PR for a few more improvements

@agnivade
Copy link
Member

Will defer to @agarciamontoro

@cwarnermm cwarnermm added 1: Dev Review Requires review by a core commiter and removed 3: Reviews Complete All reviewers have approved the pull request labels Apr 28, 2025
Copy link

Newest code from mattermost has been published to preview environment for Git SHA 2b81562

@streamer45 streamer45 self-requested a review April 28, 2025 14:26
@streamer45
Copy link
Contributor

@spirosoik Are the Azure instance classes mapped on a best effort basis, or has your team conducted tests?

@spirosoik
Copy link
Member Author

spirosoik commented Apr 28, 2025

@spirosoik Are the Azure instance classes mapped on a best effort basis, or has your team conducted tests?

Correct @streamer45 it's best effort. me, @stafot and @angeloskyratzakos worked together on this.

Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good overall. I'll defer to Alejandro for a more fine-grained review. One question I have is about Azure Blob Storage: do we have native support for it and documentation on how to configure Mattermost with it?

@spirosoik
Copy link
Member Author

It looks good overall. I'll defer to Alejandro for a more fine-grained review. One question I have is about Azure Blob Storage: do we have native support for it and documentation on how to configure Mattermost with it?

Not native. there's a work (PR here: mattermost/mattermost#30639) to start supporting this natively. Jesus plan to finalise tests/etc and have ready for review till Monday. Of course this needs extra testing/review etc.

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 3d2cb24

Copy link
Member

@agarciamontoro agarciamontoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for updating the images, they now render perfectly :) I only have a couple of general suggestions:

  • AWS data is backed by tests, but Azure is not. Should we add a disclaimer about that somewhere? Maybe something like "Every setup was tested to support the corresponding number of users in AWS exclusively. The specification of Azure instances in each architecture is extrapolated from the AWS data, and while it should generally work, it has not been proved".
  • Non-blocking: if you don't know the Azure data is there, it's hard to find it: the way the tables are rendered, at least in my screen, make it seem that they only contain the AWS data. Unless one sees the horizontal scrollbar, the last column may be overlooked:
    image

@spirosoik
Copy link
Member Author

  • AWS data is backed by tests, but Azure is not. Should we add a disclaimer about that somewhere? Maybe something like "Every setup was tested to support the corresponding number of users in AWS exclusively. The specification of Azure instances in each architecture is extrapolated from the AWS data, and while it should generally work, it has not been proved".

@cwarnermm I would like your input here.

Non-blocking: if you don't know the Azure data is there, it's hard to find it: the way the tables are rendered, at least in my screen, make it seem that they only contain the AWS data. Unless one sees the horizontal scrollbar, the last column may be overlooked:

There's an issue in multiple places with this.

@cwarnermm
Copy link
Member

For the horizontal table scroll issue (and lack of Azure data visibility in said tables), I don't have an elegant fix, but I do recommend noting on the page that the user can scroll to see more information. example here

Copy link

Newest code from mattermost has been published to preview environment for Git SHA fd0b657

@spirosoik
Copy link
Member Author

@cwarnermm fixed the scroll.

AWS data is backed by tests, but Azure is not. Should we add a disclaimer about that somewhere? Maybe something like "Every setup was tested to support the corresponding number of users in AWS exclusively. The specification of Azure instances in each architecture is extrapolated from the AWS data, and while it should generally work, it has not been proved".

@cwarnermm any good ideas how to incorporate this? I

Copy link

Newest code from mattermost has been published to preview environment for Git SHA e701e5a

@spirosoik
Copy link
Member Author

@cwarnermm @agarciamontoro we can merge this to have the collateral and we can continue the improvements.

@agarciamontoro
Copy link
Member

If this is very urgent, yes, we can merge. Otherwise, I'd appreciate discussing my proposal, I'm open to rewording what I suggested, it's in no way set in stone :)

@spirosoik
Copy link
Member Author

we want to have the collateral public and we can add your proposal, as I have another multiple set of PRs and fixes.

Copy link
Member

@agarciamontoro agarciamontoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking this, then :)

@spirosoik spirosoik merged commit 6a47281 into master Apr 29, 2025
4 checks passed
@spirosoik spirosoik deleted the fix/server-architecture branch April 29, 2025 15:33
@spirosoik spirosoik added the 3: Reviews Complete All reviewers have approved the pull request label Apr 29, 2025
@cwarnermm
Copy link
Member

Incorporated Azure testing feedback re: #7905

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Dev Review Requires review by a core commiter 3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants