Skip to content

Deployment Section Restructure #2 #7852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 23, 2025
Merged

Deployment Section Restructure #2 #7852

merged 19 commits into from
Apr 23, 2025

Conversation

DSchalla
Copy link
Member

@DSchalla DSchalla commented Apr 8, 2025

Summary

Follow up to #7816, which introduces multiple bug fixes and enhancements.

@DSchalla DSchalla requested a review from spirosoik April 8, 2025 09:10
Copy link

github-actions bot commented Apr 8, 2025

Newest code from mattermost has been published to preview environment for Git SHA 63fc34b

Copy link

github-actions bot commented Apr 8, 2025

Newest code from mattermost has been published to preview environment for Git SHA 1daeb3d

Copy link

github-actions bot commented Apr 8, 2025

Newest code from mattermost has been published to preview environment for Git SHA fa9f367

@wiersgallak wiersgallak requested a review from esethna April 8, 2025 16:10
Copy link

Newest code from mattermost has been published to preview environment for Git SHA f082be4

@DSchalla
Copy link
Member Author

@esethna Good notes - I'll update the pages later today and re-request review. Thanks!

@@ -27,6 +27,9 @@

</div>

.. warning::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to this docs warning, a Forum announcement post is also required.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spirosoik Did you discuss this one with PM/CS already? Would you be open to prepare the forum post?

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 608f7bf

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 716ed9b

@DSchalla
Copy link
Member Author

Updated the PRs, outstanding organizational questions re: deprecation notice and preview orders, but otherwise good to go for second review.

Spiros will prepare a second PR for other changes.

@cwarnermm
Copy link
Member

@DSchalla - the following build warnings are present via this docs PR. In all 3 cases, the source file isn't defined as a nav pane item. Can I get your help to confirm whether this is intentional or not, please?

  1. configure/configuring-cloudfront-to-host-mattermost-static-assets.rst -- Has this content been accounted for somewhere? Is the source file still needed?
  2. configure/using-outbound-proxy.rst -- Has the content been moved to deploy/server/preparations.html#outbound-proxy-configuration? Is the source file still needed?
  3. /deploy/server/setting-up-socket-based-mattermost-database.rst -- Has this content been accounted for somewhere? Is the source file still needed?

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 0c9db0c

@esethna
Copy link
Contributor

esethna commented Apr 14, 2025

@DSchalla added one comment above,

re Azure vs Docker being the default (and if the docker image can be E0), we don't need to block the PR since @spirosoik is out for the week, we can follow-up when he's back

@cwarnermm cwarnermm requested a review from esethna April 15, 2025 13:26
Copy link

Newest code from mattermost has been published to preview environment for Git SHA 654e350

@cwarnermm
Copy link
Member

@DSchalla - There's 2 questions outstanding ahead of merging this PR:

  1. https://github.com/mattermost/docs/pull/7852/files#r2042575435 - @nickmisasi, can you help answer this one?
  2. Is Azure VM the recommended way forward for production? This can wait until @spirosoik is back if necessary.

@nickmisasi
Copy link
Contributor

@cwarnermm Azure VM (which has yet to be documented here) is simply a bundled version of omnibus. That means it would follow the same recommendations (or lack thereof) as regular Ubuntu omnibus - ie, not recommended for mission critical production deployments.

I'm actively working on documentation for the Azure VM offer, and will have a PR open in the coming days.

@cwarnermm
Copy link
Member

Thanks, @nickmisasi! Currently the Quick Start Evaluation page notes that both deploy options use SQLite as the database and are configured for demonstration purposes only, but the Azure Marketplace option notes that the Azure Marketplace image comes with PostgreSQL and is more suitable for testing production-like scenarios.

Curious to know if there's a contradiction there we need to fix?

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 40961dc

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 692face

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 241618f

Copy link

Newest code from mattermost has been published to preview environment for Git SHA c81a18c

* Add documentation for Azure AIO VM offer

* Update documentation for Azure AIO offer

* Update

* Style fixes

* More style fixes

* More style fixes
Copy link

Newest code from mattermost has been published to preview environment for Git SHA 171163a

Copy link
Contributor

@wiersgallak wiersgallak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DSchalla DSchalla requested a review from nickmisasi April 22, 2025 07:06
@DSchalla
Copy link
Member Author

@esethna Can you re-review that merging gets unblocked? Thanks.

@spirosoik
Copy link
Member

I created a separate branch to improve the reference architecture/scale pages and in parallel working to update deployment for AWS/Azure. This PR is in WIP #7893

I will finalise this tomorrow.

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 6572e92

@DSchalla DSchalla merged commit e410778 into master Apr 23, 2025
4 checks passed
@DSchalla DSchalla deleted the restructure_nav2 branch April 23, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants