Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Multi-Governor #148

Merged
merged 10 commits into from
Nov 28, 2023
Merged

refactor: Multi-Governor #148

merged 10 commits into from
Nov 28, 2023

Conversation

deluca-mike
Copy link
Collaborator

No description provided.

@deluca-mike deluca-mike added the enhancement New feature or request label Nov 25, 2023
@deluca-mike deluca-mike self-assigned this Nov 25, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2023 •
edited
Loading

LCOV of commit dd15933 during Forge Coverage #613

Summary coverage rate:
  lines......: 67.7% (361 of 533 lines)
  functions..: 56.1% (129 of 230 functions)
  branches...: no data found

Files changed coverage rate:
                                                  |Lines       |Functions  |Branches    
  Filename                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================
  src/DistributionVault.sol                       |55.3%     38|80.0%     5|    -      0
  src/EmergencyGovernor.sol                       |23.1%     13|20.0%    10|    -      0
  src/EmergencyGovernorDeployer.sol               | 100%      3| 100%     2|    -      0
  src/PowerBootstrapToken.sol                     |50.0%      2|50.0%     2|    -      0
  src/PowerToken.sol                              |85.7%     56|76.2%    21|    -      0
  src/PowerTokenDeployer.sol                      | 100%      3| 100%     2|    -      0
  src/Registrar.sol                               |96.7%     30| 100%    10|    -      0
  src/StandardGovernor.sol                        |76.0%     75|62.1%    29|    -      0
  src/StandardGovernorDeployer.sol                | 100%      3| 100%     2|    -      0
  src/ZeroGovernor.sol                            |58.3%     12|44.4%     9|    -      0
  src/ZeroToken.sol                               | 100%      1| 100%     1|    -      0
  src/abstract/BatchGovernor.sol                  |66.7%     63|33.3%    30|    -      0
  src/abstract/ERC20Permit.sol                    |46.2%     26|45.5%    11|    -      0
  src/abstract/ERC5805.sol                        |12.5%      8|33.3%     3|    -      0
  src/abstract/ERC712.sol                         | 0.0%      8| 0.0%     4|    -      0
  src/abstract/EpochBasedInflationaryVoteToken.sol|88.6%     44|85.0%    20|    -      0
  src/abstract/EpochBasedVoteToken.sol            |75.8%     95|72.5%    40|    -      0
  src/abstract/ThresholdGovernor.sol              |52.9%     34|40.0%    10|    -      0
  src/libs/ContractHelper.sol                     | 0.0%      1| 0.0%     1|    -      0
  src/libs/PureEpochs.sol                         | 5.6%     18| 5.6%    18|    -      0

@deluca-mike deluca-mike force-pushed the feat/multi-governor branch 2 times, most recently from 933543b to 8a5efcb Compare November 25, 2023 10:07
@deluca-mike deluca-mike force-pushed the feat/refund-proposal-fee branch from 94a58b8 to 3c54ce3 Compare November 25, 2023 10:08
Base automatically changed from feat/refund-proposal-fee to main November 25, 2023 10:08
@deluca-mike deluca-mike force-pushed the feat/multi-governor branch 2 times, most recently from 72b7fe4 to 0ff223f Compare November 27, 2023 16:41
toninorair
toninorair previously approved these changes Nov 27, 2023
View reviewed changes
@deluca-mike deluca-mike force-pushed the feat/multi-governor branch 5 times, most recently from bd761fd to e817e13 Compare November 28, 2023 14:25
@toninorair toninorair self-requested a review November 28, 2023 19:35
toninorair
toninorair approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@toninorair toninorair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deluca-mike deluca-mike merged commit b1233c8 into main Nov 28, 2023
@deluca-mike deluca-mike deleted the feat/multi-governor branch November 28, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toninorair toninorair toninorair approved these changes

Assignees

@deluca-mike deluca-mike

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deluca-mike @toninorair