Skip to content

Commit

Permalink
fix: PR review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
deluca-mike committed Nov 25, 2023
1 parent e580ea2 commit 933543b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
2 changes: 0 additions & 2 deletions src/StandardGovernor.sol
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@ import { IZeroToken } from "./interfaces/IZeroToken.sol";

// TODO: Determine standard way to inform externals about which token can vote.

// TODO: Expose `_proposals`?
// TODO: Implement `QuorumNumeratorUpdated` (`quorumNumerator`, `quorumDenominator`) in the DualGovernor contract.
// TODO: Get rid of reasons and descriptions? Possibly even the exposed functions themselves.
// TODO: Emit an event in the Governor or Power Token when a voter has voted on all standard proposals in an epoch.
// TODO: Consider non-standard simplified versions of governor functions.

Expand Down
6 changes: 2 additions & 4 deletions src/ZeroGovernor.sol
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,14 @@ contract ZeroGovernor is IZeroGovernor, ThresholdGovernor {
) ThresholdGovernor("ZeroGovernor", registrar_, voteToken_, thresholdRatio_) {
if (allowedCashTokens_.length == 0) revert NoAllowedCashTokens();

_startingCashToken = allowedCashTokens_[0];

for (uint256 index_; index_ < allowedCashTokens_.length; ++index_) {
address allowedCashToken_ = allowedCashTokens_[index_];

if (allowedCashToken_ == address(0)) revert InvalidCashTokenAddress();

_allowedCashTokens[allowedCashToken_] = true;

if (index_ == 0) {
_startingCashToken = allowedCashToken_;
}
}
}

Expand Down

0 comments on commit 933543b

Please sign in to comment.