Skip to content

Commit

Permalink
Update per comments
Browse files Browse the repository at this point in the history
  • Loading branch information
lazarkov committed Jun 19, 2024
1 parent 8a3dae8 commit 77d2074
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 2 additions & 1 deletion examples/tv-app/tv-common/include/AppTv.h
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,8 @@ class DLL_EXPORT ContentAppFactoryImpl : public ContentAppFactory
bool UninstallContentApp(uint16_t vendorId, uint16_t productId);
// Print mContentApps and endpoints
void LogInstalledApps();
// TODO: method to retireve list of mContentApps
// TODO: method to retrieve list of mContentApps
// https://github.com/project-chip/connectedhomeip/issues/34020

protected:
std::vector<std::unique_ptr<ContentAppImpl>> mContentApps;
Expand Down
3 changes: 0 additions & 3 deletions src/controller/CommissionerDiscoveryController.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,6 @@ void CommissionerDiscoveryController::InternalOk()
if (!mAppInstallationService->LookupTargetContentApp(client->GetVendorId(), client->GetProductId()))
{
ChipLogDetail(AppServer, "UX InternalOk: app not installed.");

// TODO: Prepare app to be installed or add it to the mContentApps
// Draft PR: https://github.com/project-chip/connectedhomeip/pull/33982
}

if (client->GetUDCClientProcessingState() != UDCClientProcessingState::kPromptingUser)
Expand Down

0 comments on commit 77d2074

Please sign in to comment.