Update per comments

lazarkov · Jun 18, 2024 · 8a3dae8 · 8a3dae8
1 parent 7e05e43
commit 8a3dae8
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/examples/tv-app/android/java/TVApp-JNI.cpp b/examples/tv-app/android/java/TVApp-JNI.cpp
@@ -240,15 +240,15 @@ class MyPincodeService : public PasscodeService
 };
 MyPincodeService gMyPincodeService;
 
-class MyAppInstallationService : public AppInstallationService
+class SampleTvAppInstallationService : public AppInstallationService
 {
     bool LookupTargetContentApp(uint16_t vendorId, uint16_t productId) override
     {
         return ContentAppPlatform::GetInstance().LoadContentAppByClient(vendorId, productId) != nullptr;
     }
 };
 
-MyAppInstallationService gMyAppInstallationService;
+SampleTvAppInstallationService gSampleTvAppInstallationService;
 
 class MyPostCommissioningListener : public PostCommissioningListener
 {
@@ -382,7 +382,7 @@ void TvAppJNI::InitializeCommissioner(JNIMyUserPrompter * userPrompter)
     if (cdc != nullptr && userPrompter != nullptr)
     {
         cdc->SetPasscodeService(&gMyPincodeService);
-        cdc->SetAppInstallationService(&gMyAppInstallationService);
+        cdc->SetAppInstallationService(&gSampleTvAppInstallationService);
         cdc->SetUserPrompter(userPrompter);
         cdc->SetPostCommissioningListener(&gMyPostCommissioningListener);
     }

diff --git a/examples/tv-app/tv-common/include/AppTv.h b/examples/tv-app/tv-common/include/AppTv.h
@@ -150,7 +150,8 @@ class DLL_EXPORT ContentAppFactoryImpl : public ContentAppFactory
     // Remove the app from the list of mContentApps
     bool UninstallContentApp(uint16_t vendorId, uint16_t productId);
     // Print mContentApps and endpoints
-    void PrintInstalledApps();
+    void LogInstalledApps();
+    // TODO: method to retireve list of mContentApps
 
 protected:
     std::vector<std::unique_ptr<ContentAppImpl>> mContentApps;

diff --git a/examples/tv-app/tv-common/src/AppTv.cpp b/examples/tv-app/tv-common/src/AppTv.cpp
@@ -635,7 +635,7 @@ bool ContentAppFactoryImpl::UninstallContentApp(uint16_t vendorId, uint16_t prod
     return false;
 }
 
-void ContentAppFactoryImpl::PrintInstalledApps()
+void ContentAppFactoryImpl::LogInstalledApps()
 {
     for (auto & contentApp : mContentApps)
     {

diff --git a/src/controller/CommissionerDiscoveryController.cpp b/src/controller/CommissionerDiscoveryController.cpp
@@ -231,6 +231,7 @@ void CommissionerDiscoveryController::InternalOk()
         ChipLogDetail(AppServer, "UX InternalOk: app not installed.");
 
         // TODO: Prepare app to be installed or add it to the mContentApps
+        // Draft PR: https://github.com/project-chip/connectedhomeip/pull/33982
     }
 
     if (client->GetUDCClientProcessingState() != UDCClientProcessingState::kPromptingUser)