Add build tests #67
Merged
Add build tests #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierDipi
force-pushed
the
build-tests
branch
4 times, most recently
from
88e7ffe to
8ae76bc
Compare
pierDipi
force-pushed
the
build-tests
branch
from
8ae76bc to
a5fa3de
Compare
|
/test build-tests |
pierDipi
force-pushed
the
build-tests
branch
from
a5fa3de to
0c1e3a2
Compare
pierDipi
force-pushed
the
build-tests
branch
from
0c1e3a2 to
a3fe210
Compare
pierDipi
force-pushed
the
build-tests
branch
7 times, most recently
from
10d622b to
f226e10
Compare
|
/test build-tests |
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
build-tests
branch
from
07daa3d to
8500dfc
Compare
pierDipi
force-pushed
the
build-tests
branch
2 times, most recently
from
a22ea86 to
abe0510
Compare
pierDipi
force-pushed
the
build-tests
branch
from
abe0510 to
ce9a12e
Compare
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
build-tests
branch
6 times, most recently
from
6e4ecd1 to
2733a49
Compare
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
build-tests
branch
2 times, most recently
from
3d303c4 to
85e3b5d
Compare
pierDipi
force-pushed
the
build-tests
branch
2 times, most recently
from
397daf0 to
ae66f61
Compare
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
build-tests
branch
from
ae66f61 to
3af2327
Compare
pierDipi
commented
Feb 18, 2025
Comment on lines
+21
to
+22
| # TODO: To enable the builds in build-tests we need to disable the "push" | ||
| # build_integration_images || exit $? |
There was a problem hiding this comment.
the integration images build is trying to push to KO_DOCKER_REPO, so we can enable them later when we figure this out
matzew
reviewed
Feb 18, 2025
| function build_transform_jsonata_image() { | ||
|
|
||
| if (( ${IS_PROW:-0} )); then | ||
| docker run --privileged --rm tonistiigi/binfmt --install all binfmt |
There was a problem hiding this comment.
that's the multi-arch builder image?
There was a problem hiding this comment.
that's installing qemu packages so that docker buildx can emulate instructions for other platforms
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title