Skip to content

Commit

Permalink
Run binfmt installation
Browse files Browse the repository at this point in the history
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
  • Loading branch information
pierDipi committed Feb 18, 2025
1 parent bcf4237 commit 3af2327
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
3 changes: 2 additions & 1 deletion hack/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ trap 'err_report $LINENO' ERR

build_transform_jsonata_image || exit $?

build_integration_images || exit $?
# TODO: To enable the builds in build-tests we need to disable the "push"
# build_integration_images || exit $?
8 changes: 6 additions & 2 deletions hack/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,20 @@ set -euo pipefail

export TAG=${TAG:-$(git rev-parse HEAD)}

export KO_DOCKER_REPO="${KO_DOCKER_REPO:-kind.local}"
export TRANSFORM_JSONATA_IMAGE_WITH_TAG="${KO_DOCKER_REPO}/transform-jsonata:${TAG}"
export TRANSFORM_JSONATA_IMAGE_WITH_TAG="${KO_DOCKER_REPO:-kind.local}/transform-jsonata:${TAG}"

[[ ! -v REPO_ROOT_DIR ]] && REPO_ROOT_DIR="$(git rev-parse --show-toplevel)"
readonly REPO_ROOT_DIR

export TRANSFORM_JSONATA_DIR="${REPO_ROOT_DIR}/transform-jsonata"


function build_transform_jsonata_image() {

if (( ${IS_PROW:-0} )); then
docker run --privileged --rm tonistiigi/binfmt --install all binfmt
fi

docker info
docker buildx ls

Expand Down
2 changes: 1 addition & 1 deletion test/presubmit-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

# shellcheck disable=SC1090
source "$(go run knative.dev/hack/cmd/script presubmit-tests.sh)"
source "$(go run knative.dev/hack/cmd/script infra-library.sh)"

function build_tests() {
header "Running build tests"
export IS_PROW
./hack/build.sh || fail_test "build tests failed"
}

Expand Down

0 comments on commit 3af2327

Please sign in to comment.