Skip to content

Commit

Permalink
addressed Pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
AnilGadiyarHJ committed Jan 20, 2025
1 parent 9444fe4 commit 8a12065
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 30 deletions.
5 changes: 3 additions & 2 deletions plugins/modules/dns_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,10 @@
DOCUMENTATION = r"""
---
module: dns_server
short_description: Manage Server
short_description: Manage a Server ( DNS Config Profile )
description:
- Manage Server
- Manage a DNS Config Profile
- A Server (DNS Config Profile) is a named configuration profile that can be shared for specified list of hosts.
version_added: 2.0.0
author: Infoblox Inc. (@infobloxopen)
options:
Expand Down
5 changes: 3 additions & 2 deletions plugins/modules/dns_server_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,10 @@
DOCUMENTATION = r"""
---
module: dns_server_info
short_description: Manage Server
short_description: Retrieve a Server ( DNS Config Profile )
description:
- Manage Server
- Retrieves information about DNS Config Profiles.
- A Server (DNS Config Profile) is a named configuration profile that can be shared for specified list of hosts.
version_added: 2.0.0
author: Infoblox Inc. (@infobloxopen)
options:
Expand Down
26 changes: 0 additions & 26 deletions tests/integration/targets/dns_server/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
# - tsig keys
# - acl


- module_defaults:
group/infoblox.bloxone.all:
csp_url: "{{ csp_url }}"
Expand Down Expand Up @@ -206,7 +205,6 @@
- dns_server_info.objects | length == 1
- dns_server_info.objects[0].custom_root_ns_enabled == true


- name: Create a DNS Server with DNSSEC Enable Validation (false)
infoblox.bloxone.dns_server:
name: "{{ dns_server_name }}"
Expand Down Expand Up @@ -671,24 +669,6 @@
- dns_server_info is not failed
- dns_server_info.objects | length == 1
- dns_server_info.objects[0].minimal_responses == true
-
- name: update a DNS server name
infoblox.bloxone.dns_server:
name: "{{ dns_server_name }}_update"
minimal_responses: true
state: present
register: dns_server
- name: Get DNS server details
infoblox.bloxone.dns_server_info:
filters:
name: "{{ dns_server_name }}_update"
register: dns_server_info
- name: Assert the DNS server exists and has the correct minimal_responses setting
assert:
that:
- dns_server_info is not failed
- dns_server_info.objects | length == 1
- dns_server_info.objects[0].name == "{{ dns_server_name }}_update"

- name: Create a DNS server with Notify set to true
infoblox.bloxone.dns_server:
Expand Down Expand Up @@ -930,9 +910,3 @@
name: "{{ dns_server_name }}"
state: "absent"
ignore_errors: true

- name: "Delete Dns Server Update"
infoblox.bloxone.dns_server:
name: "{{ dns_server_name }}_update"
state: "absent"
ignore_errors: true

0 comments on commit 8a12065

Please sign in to comment.