addressed PR comment

infobloxopen · Jan 13, 2025 · 9444fe4 · 9444fe4
1 parent 0a89c88
commit 9444fe4
Show file tree

Hide file tree

Showing 3 changed files with 97 additions and 8 deletions.
diff --git a/plugins/modules/dns_server.py b/plugins/modules/dns_server.py
@@ -1108,7 +1108,22 @@
             elements: dict
             contains:
                 algorithm:
-                    description: ""
+                    description:
+                        - "Specifies the cryptographic algorithm used for DNSSEC. Supported values and their corresponding mappings are as follows."
+                        - "RSAMD5 (1)"
+                        - "DH (2)"
+                        - "DSA (3)"
+                        - "RSASHA1 (5)"
+                        - "DSANSEC3SHA1 (6)"
+                        - "RSASHA1NSEC3SHA1 (7)"
+                        - "RSASHA256 (8)"
+                        - "RSASHA512 (10)"
+                        - "ECDSAP256SHA256 (13)"
+                        - "ECDSAP384SHA384 (14)"
+                        - "**Deprecated Algorithms:**"
+                        - "RSAMD5 (1)"
+                        - "DSA (3)"
+                        - "DSANSEC3SHA1 (6)"
                     type: int
                     returned: Always
                 protocol_zone:
@@ -1142,7 +1157,22 @@
             elements: dict
             contains:
                 algorithm:
-                    description: ""
+                    description: 
+                        - "Specifies the cryptographic algorithm used for DNSSEC. Supported values and their corresponding mappings are as follows."
+                        - "RSAMD5 (1)"
+                        - "DH (2)"
+                        - "DSA (3)"
+                        - "RSASHA1 (5)"
+                        - "DSANSEC3SHA1 (6)"
+                        - "RSASHA1NSEC3SHA1 (7)"
+                        - "RSASHA256 (8)"
+                        - "RSASHA512 (10)"
+                        - "ECDSAP256SHA256 (13)"
+                        - "ECDSAP384SHA384 (14)"
+                        - "**Deprecated Algorithms:**"
+                        - "RSAMD5 (1)"
+                        - "DSA (3)"
+                        - "DSANSEC3SHA1 (6)"
                     type: int
                     returned: Always
                 protocol_zone:
@@ -1491,7 +1521,22 @@
                                     elements: dict
                                     contains:
                                         algorithm:
-                                            description: ""
+                                            description: 
+                                                - "Specifies the cryptographic algorithm used for DNSSEC. Supported values and their corresponding mappings are as follows."
+                                                - "RSAMD5 (1)"
+                                                - "DH (2)"
+                                                - "DSA (3)"
+                                                - "RSASHA1 (5)"
+                                                - "DSANSEC3SHA1 (6)"
+                                                - "RSASHA1NSEC3SHA1 (7)"
+                                                - "RSASHA256 (8)"
+                                                - "RSASHA512 (10)"
+                                                - "ECDSAP256SHA256 (13)"
+                                                - "ECDSAP384SHA384 (14)"
+                                                - "**Deprecated Algorithms:**"
+                                                - "RSAMD5 (1)"
+                                                - "DSA (3)"
+                                                - "DSANSEC3SHA1 (6)"
                                             type: int
                                             returned: Always
                                         protocol_zone:

diff --git a/plugins/modules/dns_server_info.py b/plugins/modules/dns_server_info.py
@@ -162,7 +162,22 @@
             elements: dict
             contains:
                 algorithm:
-                    description: ""
+                    description: 
+                        - "Specifies the cryptographic algorithm used for DNSSEC. Supported values and their corresponding mappings are as follows."
+                        - "RSAMD5 (1)"
+                        - "DH (2)"
+                        - "DSA (3)"
+                        - "RSASHA1 (5)"
+                        - "DSANSEC3SHA1 (6)"
+                        - "RSASHA1NSEC3SHA1 (7)"
+                        - "RSASHA256 (8)"
+                        - "RSASHA512 (10)"
+                        - "ECDSAP256SHA256 (13)"
+                        - "ECDSAP384SHA384 (14)"
+                        - "**Deprecated Algorithms:**"
+                        - "RSAMD5 (1)"
+                        - "DSA (3)"
+                        - "DSANSEC3SHA1 (6)"
                     type: int
                     returned: Always
                 protocol_zone:
@@ -196,7 +211,22 @@
             elements: dict
             contains:
                 algorithm:
-                    description: ""
+                    description: 
+                        - "Specifies the cryptographic algorithm used for DNSSEC. Supported values and their corresponding mappings are as follows."
+                        - "RSAMD5 (1)"
+                        - "DH (2)"
+                        - "DSA (3)"
+                        - "RSASHA1 (5)"
+                        - "DSANSEC3SHA1 (6)"
+                        - "RSASHA1NSEC3SHA1 (7)"
+                        - "RSASHA256 (8)"
+                        - "RSASHA512 (10)"
+                        - "ECDSAP256SHA256 (13)"
+                        - "ECDSAP384SHA384 (14)"
+                        - "**Deprecated Algorithms:**"
+                        - "RSAMD5 (1)"
+                        - "DSA (3)"
+                        - "DSANSEC3SHA1 (6)"
                     type: int
                     returned: Always
                 protocol_zone:
@@ -545,7 +575,22 @@
                                     elements: dict
                                     contains:
                                         algorithm:
-                                            description: ""
+                                            description: 
+                                                - "Specifies the cryptographic algorithm used for DNSSEC. Supported values and their corresponding mappings are as follows."
+                                                - "RSAMD5 (1)"
+                                                - "DH (2)"
+                                                - "DSA (3)"
+                                                - "RSASHA1 (5)"
+                                                - "DSANSEC3SHA1 (6)"
+                                                - "RSASHA1NSEC3SHA1 (7)"
+                                                - "RSASHA256 (8)"
+                                                - "RSASHA512 (10)"
+                                                - "ECDSAP256SHA256 (13)"
+                                                - "ECDSAP384SHA384 (14)"
+                                                - "**Deprecated Algorithms:**"
+                                                - "RSAMD5 (1)"
+                                                - "DSA (3)"
+                                                - "DSANSEC3SHA1 (6)"
                                             type: int
                                             returned: Always
                                         protocol_zone:

diff --git a/tests/integration/targets/dns_server/tasks/main.yml b/tests/integration/targets/dns_server/tasks/main.yml
@@ -144,7 +144,6 @@
           - dns_server_info.objects[0].comment == "test comment"
 
     - name: Create a DNS Server with Custom Root Nameservers
-      #tags: dns_server
       infoblox.bloxone.dns_server:
         name: "{{ dns_server_name }}"
         custom_root_ns:
@@ -262,7 +261,7 @@
           - dns_server_info.objects | length == 1
           - dns_server_info.objects[0].dnssec_trust_anchors[0].algorithm == 8
           - dns_server_info.objects[0].dnssec_trust_anchors[0].zone == "test-infoblox.com."
-          - dns_server_info.objects[0].dnssec_trust_anchors[0].sep == true  # Ensure 'sep' is false
+          - dns_server_info.objects[0].dnssec_trust_anchors[0].sep == true
 
     - name: Create a DNS Server with DNSSEC Validate Expiry enabled
       infoblox.bloxone.dns_server: