Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change brand to imua #309

Merged
merged 26 commits into from
Feb 21, 2025
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
9be9d8e
ci: rename workflow job names
MaxMustermann2 Feb 19, 2025
b17c3bd
rebrand via replacement + deps
MaxMustermann2 Feb 19, 2025
8e75fef
another round of refactoring / renaming
MaxMustermann2 Feb 19, 2025
45fb0c3
fix tests
MaxMustermann2 Feb 19, 2025
d724d4e
fix some obvious rebranding errors
MaxMustermann2 Feb 19, 2025
2af0057
fix docker localnet build
MaxMustermann2 Feb 19, 2025
39342b6
fix(proto): lint + regen
MaxMustermann2 Feb 19, 2025
046adfa
change e2e network name
MaxMustermann2 Feb 19, 2025
4ca30dd
fix localnet docker build again
MaxMustermann2 Feb 19, 2025
168555b
update to imuachain-test-tool
MaxMustermann2 Feb 19, 2025
fd559c7
validate bech32 string in testutil
MaxMustermann2 Feb 19, 2025
e3350df
update README to avoid repetitive text
MaxMustermann2 Feb 19, 2025
eae3906
fix(build): remove CN goproxy on github server
MaxMustermann2 Feb 19, 2025
327cccc
resolve AI nitpick comments
MaxMustermann2 Feb 19, 2025
5b3df09
disable GOPROXY in Makefile
MaxMustermann2 Feb 19, 2025
185e5fb
fix: regen proto
MaxMustermann2 Feb 19, 2025
6257d46
fix: regen swagger
MaxMustermann2 Feb 19, 2025
e9834e8
fix(ci): golang lint
MaxMustermann2 Feb 19, 2025
a88a006
fix typo: imuchain -> imuachain
MaxMustermann2 Feb 19, 2025
1675397
Merge upstream/develop
MaxMustermann2 Feb 20, 2025
33cc20b
fix(local): use correct chain-id
MaxMustermann2 Feb 20, 2025
484a8f3
Merge upstream/develop
MaxMustermann2 Feb 20, 2025
2683d70
chore: lint
MaxMustermann2 Feb 20, 2025
22040d2
fix: change chain-id to imuachainlocalnet
MaxMustermann2 Feb 21, 2025
9ba9677
refactor: exoslash -> imslash
MaxMustermann2 Feb 21, 2025
b59f659
remove old TODO
MaxMustermann2 Feb 21, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 2 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ I have...
[type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json)
in the PR title
- [ ] targeted the correct branch
(see [PR Targeting](https://github.com/ExocoreNetwork/exocore/blob/main/CONTRIBUTING.md#pr-targeting))
(see [PR Targeting](https://github.com/imua-xyz/imuachain/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link in the PR description to the relevant issue or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all required CI checks have passed
Expand All @@ -36,7 +36,7 @@ Code maintenance:

I have...

- [ ] written unit and integration [tests](https://github.com/ExocoreNetwork/exocore/blob/main/CONTRIBUTING.md#testing)
- [ ] written unit and integration [tests](https://github.com/imua-xyz/imuachain/blob/main/CONTRIBUTING.md#testing)
- [ ] added relevant [`godoc`](https://go.dev/blog/godoc) and [code comments](https://blog.jbowen.dev/2019/09/the-magic-of-go-comments/).
- [ ] updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/consensuswarn.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ permissions:
pull-requests: write

jobs:
main:
consensus-warn:
permissions:
contents: read
pull-requests: write # For reading the PR and posting comment
Expand All @@ -26,4 +26,4 @@ jobs:
- uses: orijtech/consensuswarn@956f047a43f56021a28afdfb2a2291a20955f48d
with:
# example.com/pkg/path.Type.Method
roots: 'github.com/ExocoreNetwork/exocore/app.ExocoreApp.DeliverTx,github.com/ExocoreNetwork/exocore/app.ExocoreApp.BeginBlocker,github.com/ExocoreNetwork/exocore/app.ExocoreApp.EndBlocker'
roots: 'github.com/imua-xyz/imuachain/app.ImuachainApp.DeliverTx,github.com/imua-xyz/imuachain/app.ImuachainApp.BeginBlocker,github.com/imua-xyz/imuachain/app.ImuachainApp.EndBlocker'
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Lint
# Lint runs golangci-lint over the entire exocore repository. The `golangci` will pass without
# Lint runs golangci-lint over the entire imuachain repository. The `golangci` will pass without
# running if no *.{go, mod, sum} files have been changed.
on:
merge_group:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/proto.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ concurrency:
cancel-in-progress: true

jobs:
build:
proto-build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -33,7 +33,7 @@ jobs:
make proto-gen
if: env.GIT_DIFF

lint:
proto-lint:
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
Expand All @@ -45,7 +45,7 @@ jobs:
with:
input: "proto"

break-check:
proto-break-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/security.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ permissions:
security-events: write

jobs:
Gosec:
cosmos-gosec-security-scan:
permissions:
contents: read
security-events: write
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/semgrep.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ on:
jobs:
# Update from: https://semgrep.dev/docs/semgrep-ci/sample-ci-configs/#github-actions [removing GH Security Dashboard]
semgrep:
name: Scan
name: Scan Semgrep
runs-on: ubuntu-latest
container:
image: returntocorp/semgrep
if: (github.actor != 'dependabot[bot]')
steps:
- name: Permission issue fix
# semgrep for some reason sets the working directory to exocore/exocore
# semgrep for some reason sets the working directory to imuachain/imuachain
run: git config --global --add safe.directory /__w/imuachain/imuachain
- uses: actions/checkout@v4
- name: Get Diff
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/super-linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ on:
pull_request:
branches: ["develop", "main", "master"]
jobs:
run-lint:
run-super-linter:
runs-on: ubuntu-latest
steps:
- name: Checkout code
Expand Down
50 changes: 25 additions & 25 deletions .goreleaser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ before:
- go mod download

builds:
- id: "exocored-darwin"
main: ./cmd/exocored
binary: bin/exocored
- id: "imuad-darwin"
main: ./cmd/imuad
binary: bin/imuad
env:
- CGO_ENABLED=1
- CC=o64-clang
Expand All @@ -19,10 +19,10 @@ builds:
flags:
- -tags=cgo
ldflags:
- -s -w -X github.com/cosmos/cosmos-sdk/version.Name=exocore -X github.com/cosmos/cosmos-sdk/version.AppName=exocored -X github.com/cosmos/cosmos-sdk/version.Version={{.Version}} -X github.com/cosmos/cosmos-sdk/version.Commit={{.Commit}}
- id: "exocored-darwin-arm64"
main: ./cmd/exocored
binary: bin/exocored
- -s -w -X github.com/cosmos/cosmos-sdk/version.Name=imua -X github.com/cosmos/cosmos-sdk/version.AppName=imuad -X github.com/cosmos/cosmos-sdk/version.Version={{.Version}} -X github.com/cosmos/cosmos-sdk/version.Commit={{.Commit}}
- id: "imuad-darwin-arm64"
main: ./cmd/imuad
binary: bin/imuad
env:
- CGO_ENABLED=1
- CC=oa64-clang
Expand All @@ -34,10 +34,10 @@ builds:
flags:
- -tags=cgo
ldflags:
- -s -w -X github.com/cosmos/cosmos-sdk/version.Name=exocore -X github.com/cosmos/cosmos-sdk/version.AppName=exocored -X github.com/cosmos/cosmos-sdk/version.Version={{.Version}} -X github.com/cosmos/cosmos-sdk/version.Commit={{.Commit}}
- id: "exocored-linux"
main: ./cmd/exocored
binary: bin/exocored
- -s -w -X github.com/cosmos/cosmos-sdk/version.Name=imua -X github.com/cosmos/cosmos-sdk/version.AppName=imuad -X github.com/cosmos/cosmos-sdk/version.Version={{.Version}} -X github.com/cosmos/cosmos-sdk/version.Commit={{.Commit}}
- id: "imuad-linux"
main: ./cmd/imuad
binary: bin/imuad
env:
- CGO_ENABLED=1
- CC=gcc
Expand All @@ -49,10 +49,10 @@ builds:
flags:
- -tags=cgo
ldflags:
- -s -w -X github.com/cosmos/cosmos-sdk/version.Name=exocore -X github.com/cosmos/cosmos-sdk/version.AppName=exocored -X github.com/cosmos/cosmos-sdk/version.Version={{.Version}} -X github.com/cosmos/cosmos-sdk/version.Commit={{.Commit}}
- id: "exocored-linux-arm64"
main: ./cmd/exocored
binary: bin/exocored
- -s -w -X github.com/cosmos/cosmos-sdk/version.Name=imua -X github.com/cosmos/cosmos-sdk/version.AppName=imuad -X github.com/cosmos/cosmos-sdk/version.Version={{.Version}} -X github.com/cosmos/cosmos-sdk/version.Commit={{.Commit}}
- id: "imuad-linux-arm64"
main: ./cmd/imuad
binary: bin/imuad
env:
- CGO_ENABLED=1
- CC=aarch64-linux-gnu-gcc
Expand All @@ -64,10 +64,10 @@ builds:
flags:
- -tags=cgo
ldflags:
- -s -w -X github.com/cosmos/cosmos-sdk/version.Name=exocore -X github.com/cosmos/cosmos-sdk/version.AppName=exocored -X github.com/cosmos/cosmos-sdk/version.Version={{.Version}} -X github.com/cosmos/cosmos-sdk/version.Commit={{.Commit}}
- id: "exocored-windows"
main: ./cmd/exocored
binary: bin/exocored
- -s -w -X github.com/cosmos/cosmos-sdk/version.Name=imua -X github.com/cosmos/cosmos-sdk/version.AppName=imuad -X github.com/cosmos/cosmos-sdk/version.Version={{.Version}} -X github.com/cosmos/cosmos-sdk/version.Commit={{.Commit}}
- id: "imuad-windows"
main: ./cmd/imuad
binary: bin/imuad
env:
- CGO_ENABLED=1
- CC=x86_64-w64-mingw32-gcc
Expand All @@ -80,19 +80,19 @@ builds:
- -tags=cgo
- -buildmode=exe
ldflags:
- -s -w -X github.com/cosmos/cosmos-sdk/version.Name=exocore -X github.com/cosmos/cosmos-sdk/version.AppName=exocored -X github.com/cosmos/cosmos-sdk/version.Version={{.Version}} -X github.com/cosmos/cosmos-sdk/version.Commit={{.Commit}}
- -s -w -X github.com/cosmos/cosmos-sdk/version.Name=imua -X github.com/cosmos/cosmos-sdk/version.AppName=imuad -X github.com/cosmos/cosmos-sdk/version.Version={{.Version}} -X github.com/cosmos/cosmos-sdk/version.Commit={{.Commit}}

archives:
- name_template: '{{ .ProjectName }}_{{ .Version }}_{{- title .Os }}_{{ .Arch }}'
format_overrides:
- goos: windows
format: zip
builds:
- exocored-darwin
- exocored-darwin-arm64
- exocored-windows
- exocored-linux
- exocored-linux-arm64
- imuad-darwin
- imuad-darwin-arm64
- imuad-windows
- imuad-linux
- imuad-linux-arm64

checksum:
name_template: 'checksums.txt'
Expand Down
46 changes: 23 additions & 23 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Exocore Contributor Guidelines
# Imuachain Contributor Guidelines

- [Exocore Contributor Guidelines](#exocore-contributor-guidelines)
- [Imuachain Contributor Guidelines](#imuachain-contributor-guidelines)
- [General Procedure](#general-procedure)
- [Architecture Decision Records (ADR)](#architecture-decision-records-adr)
- [Forking](#forking)
Expand All @@ -19,21 +19,21 @@

## General Procedure

Thank you for considering making contributions to Exocore and related repositories!
Thank you for considering making contributions to Imuachain and related repositories!

Exocore uses [Tendermint’s coding repo](https://github.com/tendermint/coding)
Imuachain uses [Tendermint’s coding repo](https://github.com/tendermint/coding)
for overall information on repository workflow and standards.

Contributing to this repo can mean many things such as participating in discussion or proposing code changes.
To ensure a smooth workflow for all contributors,
the following general procedure for contributing has been established:

1. Either [open](https://github.com/ExocoreNetwork/exocore/issues/new/choose)
or [find](https://github.com/ExocoreNetwork/exocore/issues) an issue you have identified and would like to contribute
1. Either [open](https://github.com/imua-xyz/imuachain/issues/new/choose)
or [find](https://github.com/imua-xyz/imuachain/issues) an issue you have identified and would like to contribute
to resolving.
2. Participate in thoughtful discussion on that issue.
3. If you would like to contribute:
1. If the issue is a proposal, ensure that the proposal has been accepted by the Exocore team.
1. If the issue is a proposal, ensure that the proposal has been accepted by the Imuachain team.
2. Ensure that nobody else has already begun working on the same issue. If someone already has, please make sure to
contact the individual to collaborate.
3. If nobody has been assigned the issue and you would like to work on it,
Expand All @@ -43,7 +43,7 @@ the following general procedure for contributing has been established:
However, if you are eager and do not get a prompt response, feel free to dive on in!
4. Follow standard Github best practices:
1. Fork the repo
2. Branch from the HEAD of `development`(For core developers working within the Exocore repo, to ensure a
2. Branch from the HEAD of `development`(For core developers working within the Imuachain repo, to ensure a
clear ownership of branches, branches must be named with the convention `{moniker}/{issue#}-branch-name`).
3. Make commits
4. Submit a PR to `development`
Expand All @@ -56,7 +56,7 @@ the following general procedure for contributing has been established:
8. Please make sure to run `make format` before every commit -
the easiest way to do this is having your editor run it for you upon saving a file.
Additionally, please ensure that your code is lint compliant by running `make lint`.
There are CI tests built into the Exocore repository
There are CI tests built into the Imuachain repository
and all PR’s will require that these tests pass
before they can be merged.

Expand All @@ -68,7 +68,7 @@ that PR runs a high likelihood of being rejected.

## Architecture Decision Records (ADR)

When proposing an architecture decision for Exocore,
When proposing an architecture decision for Imuachain,
please create an ADR
so further discussions can be made.
We are following this process so all involved parties are in agreement
Expand All @@ -79,21 +79,21 @@ refer to [Tendermint ADRs](https://github.com/tendermint/tendermint/tree/master/
## Forking

Please note that Go requires code to live under absolute paths, which complicates forking.
While my fork lives at `https://github.com/ExocoreNetwork/exocore`,
the code should never exist at `$GOPATH/src/github.com/ExocoreNetwork/exocore`.
Instead, we use `git remote` to add the fork as a new remote for the original repo,`$GOPATH/src/github.com/ExocoreNetwork/exocore`,
While my fork lives at `https://github.com/imua-xyz/imuachain`,
the code should never exist at `$GOPATH/src/github.com/imua-xyz/imuachain`.
Instead, we use `git remote` to add the fork as a new remote for the original repo,`$GOPATH/src/github.com/imua-xyz/imuachain`,
and do all the work there.

For instance, to create a fork and work on a branch of it, you would:

1. Create the fork on github, using the fork button.
2. Go to the original repo checked out locally. (i.e. `$GOPATH/src/github.com/ExocoreNetwork/exocore`)
2. Go to the original repo checked out locally. (i.e. `$GOPATH/src/github.com/imua-xyz/imuachain`)
3. `git remote rename origin upstream`
4. `git remote add origin git@github.com:$USERNAME/Exocore.git`
4. `git remote add origin git@github.com:$USERNAME/Imuachain.git`

Now `origin` refers to my fork and `upstream` refers to the Exocore version.
Now `origin` refers to my fork and `upstream` refers to the Imuachain version.
So I can `git push -u origin master` to update my fork,
and make pull requests to Exocore from there.
and make pull requests to Imuachain from there.
Of course, replace `$USERNAME` with your git handle.

To pull in updates from the origin repo, run:
Expand Down Expand Up @@ -139,7 +139,7 @@ on `go mod tidy -v`.
## Protobuf

We use [Protocol Buffers](https://developers.google.com/protocol-buffers) along
with [gogoproto](https://github.com/cosmos/protobuf) to generate code for use in Exocore.
with [gogoproto](https://github.com/cosmos/protobuf) to generate code for use in Imuachain.

For deterministic behavior around Protobuf tooling, everything is containerized using Docker. Make sure to have Docker
installed on your machine, or head to [Docker's website](https://docs.docker.com/get-docker/) to install it.
Expand Down Expand Up @@ -175,17 +175,17 @@ For example, in vscode your `.vscode/settings.json` should look like:
2. `development` must never
fail `make lint, make test, make test-race, make test-rpc, make test-import`
3. No `--force` onto `development` (except when reverting a broken commit, which should seldom happen).
4. Create your feature branch from `development` either on `github.com/ExocoreNetwork/exocore`, or your fork (
4. Create your feature branch from `development` either on `github.com/imua-xyz/imuachain`, or your fork (
using `git remote add origin`).
5. Before submitting a pull request, begin `git rebase` on top of `development`.

## Testing

Exocore uses [GitHub Actions](https://github.com/features/actions) for automated testing.
Imuachain uses [GitHub Actions](https://github.com/features/actions) for automated testing.

## Updating Documentation

If you open a PR on the Exocore repo, it is mandatory to update the relevant documentation in `/docs`. Please refer to
If you open a PR on the Imuachain repo, it is mandatory to update the relevant documentation in `/docs`. Please refer to
the docs subdirectory and make changes accordingly. Prior to approval, the Code owners/approvers may request some
updates to specific docs.

Expand All @@ -195,7 +195,7 @@ User-facing repos should adhere to the [trunk based development branching model]

Libraries need not follow the model strictly, but would be wise to.

Exocore utilizes [semantic versioning](https://semver.org/).
Imuachain utilizes [semantic versioning](https://semver.org/).

### Commit messages

Expand Down Expand Up @@ -262,5 +262,5 @@ All PRs require two Reviews before merge. When reviewing PRs, please use the fol
8. Tag the release (use `git tag -a`) and create a release in Github.
9. Delete the `RC` branches.

**Note**: The Exocore team currently cuts releases on a need to have basis.
**Note**: The Imuachain team currently cuts releases on a need to have basis.
We will announce a more standardized release schedule as we near production readiness.
14 changes: 7 additions & 7 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# This is the published docker image for exocore.
# This is the published docker image for imuachain.

FROM golang:1.21.12-alpine3.19 AS build-env

WORKDIR /go/src/github.com/ExocoreNetwork/exocore
WORKDIR /go/src/github.com/imua-xyz/imuachain

COPY go.mod go.sum ./

Expand All @@ -20,7 +20,7 @@ FROM alpine:3.19

WORKDIR /root

COPY --from=build-env /go/src/github.com/ExocoreNetwork/exocore/build/exocored /usr/bin/exocored
COPY --from=build-env /go/src/github.com/imua-xyz/imuachain/build/imuad /usr/bin/imuad
COPY --from=build-env /go/bin/toml-cli /usr/bin/toml-cli

RUN apk add --no-cache \
Expand All @@ -29,15 +29,15 @@ RUN apk add --no-cache \
jq~=1.7 \
curl~=8.12 \
bash~=5.2 \
&& addgroup -g 1000 exocore \
&& adduser -S -h /home/exocore -D exocore -u 1000 -G exocore
&& addgroup -g 1000 imua \
&& adduser -S -h /home/imua -D imua -u 1000 -G imua

USER 1000
WORKDIR /home/exocore
WORKDIR /home/imua

EXPOSE 26656 26657 1317 9090 8545 8546

# Every 30s, allow 3 retries before failing, timeout after 30s.
HEALTHCHECK --interval=30s --timeout=30s --retries=3 CMD curl -f http://localhost:26657/health || exit 1

CMD ["exocored"]
CMD ["imuad"]
Loading
Loading