-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change brand to imua #309
Conversation
I'll help you generate a comprehensive summary of the changes. I'll break it down into sections and provide a high-level overview. WalkthroughThis pull request represents a comprehensive rebranding and migration of the entire project from "Exocore" to "Imuachain". The changes span across multiple files, directories, and components of the blockchain infrastructure. The migration involves:
The transformation touches nearly every aspect of the project, ensuring a consistent transition from the Exocore framework to the Imuachain ecosystem. Changes
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Repo as GitHub Repository
participant CI as Continuous Integration
participant Build as Build System
participant Test as Test Suite
Dev->>Repo: Initiates migration PR
Repo->>CI: Triggers workflow
CI->>Build: Builds project with new configuration
Build->>Test: Runs comprehensive test suite
Test-->>CI: Validates changes
CI-->>Dev: Reports build and test status
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
The failure in Consensus Warn can not be avoided in this PR since it runs on the base branch but with the new workflow file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 20
🔭 Outside diff range comments (2)
proto/imuachain/slash/v1/params.proto (1)
1-8
:⚠️ Potential issueNew Slash Module Params Proto – Directory Placement Warning
A new Protocol Buffers file for the slash module has been added under the packageimuachain.slash.v1
. However, according to Buf guidelines, files with this package should reside in a directory structureimuachain/slash/v1
relative to the repository root. Currently, this file is located inproto/imuachain/slash/v1
. Please consider moving it to the appropriate directory or updating the Buf configuration accordingly.🧰 Tools
🪛 Buf (1.47.2)
2-2: Files with package "imuachain.slash.v1" must be within a directory "imuachain/slash/v1" relative to root but were in directory "proto/imuachain/slash/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/reward/v1/params.proto (1)
1-8
:⚠️ Potential issueNew Reward Module Params Proto – Directory Placement Warning
This new proto file for the reward module is declared in the packageimuachain.reward.v1
but is located withinproto/imuachain/reward/v1
. Per Buf’s requirement, the file should be placed in a directory structureimuachain/reward/v1
relative to the repo root. Please adjust the file location or configuration to comply with the guidelines.🧰 Tools
🪛 Buf (1.47.2)
2-2: Files with package "imuachain.reward.v1" must be within a directory "imuachain/reward/v1" relative to root but were in directory "proto/imuachain/reward/v1".
(PACKAGE_DIRECTORY_MATCH)
🧹 Nitpick comments (18)
proto/imuachain/avs/v1/tx.proto (1)
5-5
: Verify Import for "amino/amino.proto".
Static analysis indicates that the file"amino/amino.proto"
does not exist. Ensure this import is still required—if the file was relocated or is no longer used, update or remove the import accordingly.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
scripts/protocgen.sh (2)
11-11
: Legacy Comment Clarity
The commented-out line (#proto_dirs="proto/imua/reward/v1beta1"
) may be a remnant from previous configurations. Consider removing it if it’s no longer needed to keep the script clean.
17-17
: Conditional Check for Go Package Option
The grep condition checking for"option go_package.*imua"
accurately selects proto files with the new branding. Adding an inline comment here for clarity might help future maintainers understand its purpose.networks/local/imuachain/Dockerfile (1)
7-8
: Comment Clarification
The comment now reads “# build imua”. While this is clear for internal documentation, if the commented-out build directive (#COPY ./imuad /go/work/build
) is no longer needed, consider removing it to reduce clutter.scripts/start-docker.sh (1)
4-7
: Chain ID & Data Directory Rebranding
The CHAINID variable has been updated to "imualocalnet_232-1" and the temporary data directory now uses the "imua-datadir" prefix. This is consistent with the new branding. Note that the accompanying TODO indicates that the testnet chain ID is still under consideration—please confirm the final value when available.proto/imuachain/appchain/coordinator/v1/query.proto (1)
5-6
: Verify Import File Existence
The import statement now refers to"imuachain/appchain/common/v1/common.proto"
. However, the static analysis hint indicates that this file may not exist. Please verify that the file’s path is correct and update it if necessary.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "imuachain/appchain/common/v1/common.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/distribution.proto (1)
4-4
: Verify Amino Import Path
The file imports"amino/amino.proto"
, but the static analysis hint suggests that this file does not exist. Please verify whether the import path should be updated (perhaps to include a namespace or a different relative path) or if this dependency is provided externally.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
cmd/imuachain-test-tool/README.md (1)
7-9
: Clarify Node Configuration Wording
In the node configuration details, the phrase “disable the precompile's gateway contract address check” appears. Consider rephrasing it to “disable the gateway contract address check for precompiled contracts” to improve clarity.🧰 Tools
🪛 LanguageTool
[grammar] ~7-~7: The verb ‘precompile’ does not usually follow articles like ‘the’. Check that ‘precompile’ is spelled correctly; using ‘precompile’ as a noun may be non-standard.
Context: ...se, with the node configured to disable the precompile's gateway contract address check. The b...(A_INFINITIVE)
Makefile (2)
162-168
: Docker Wrapper Script Revision
The Docker wrapper script has been updated:
• A new directory./build/.imuad
is created.
• A wrapper launcher script./build/imuad
is generated that uses the updated Docker image and runs theimuad
command.
These changes appear correct; however, please verify that the mounted paths and ownership permissions meet your deployment requirements.
552-561
: Pipeline Release Failure Investigation Note
The GitHub Actions pipeline logs (e.g. errors on stream IDs from dependency downloads) indicate issues during thego mod download
step in the release process. These stream errors may be transient network issues or related to dependency caching. I recommend verifying that the CI environment has reliable network connectivity and—if needed—consider using a module proxy or caching mechanism.🧰 Tools
🪛 GitHub Actions: goreleaser
[error] 552-552: release failed after 48s: hook failed: shell: 'go mod download': exit status 1: stream error: stream ID 717; INTERNAL_ERROR; received from peer
[error] 552-552: go: github.com/grpc-ecosystem/grpc-gateway/v2@v2.11.3: stream error: stream ID 717; INTERNAL_ERROR; received from peer
[error] 552-552: go: github.com/imua-xyz/price-feeder@v0.1.16-0.20250219142917-5ea492552d53: stream error: stream ID 719; INTERNAL_ERROR; received from peer
[error] 552-552: go: github.com/onsi/ginkgo/v2@v2.15.0: stream error: stream ID 721; INTERNAL_ERROR; received from peer
[error] 552-552: go: github.com/improbable-eng/grpc-web@v0.15.0: stream error: stream ID 801; INTERNAL_ERROR; received from peer
[error] 552-552: go: github.com/decred/dcrd/dcrec/secp256k1/v4@v4.2.0: stream error: stream ID 887; INTERNAL_ERROR; received from peer
[error] 552-552: go: github.com/dlclark/regexp2@v1.7.0: stream error: stream ID 897; INTERNAL_ERROR; received from peer
[error] 552-552: go: github.com/supranational/blst@v0.3.11: stream error: stream ID 1103; INTERNAL_ERROR; received from peer
proto/imuachain/appchain/subscriber/v1/tx.proto (1)
7-8
: Service Definition Observation.
TheMsg
service is defined (though currently without any RPC methods). Verify that an empty service is intentional or plan to add method definitions in subsequent iterations.proto/imuachain/oracle/v1/recent_params.proto (1)
4-4
: Verify Import Path ExistenceThe import statement now reads
import "imuachain/oracle/v1/params.proto";
. Static analysis (Buf) indicates that this file might not exist. Please verify that the file is present at the specified location or update the path accordingly.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "imuachain/oracle/v1/params.proto": file does not exist
(COMPILE)
proto/imuachain/reward/v1/genesis.proto (1)
4-4
: Check Import Path for Reward ParamsThe import statement
import "imuachain/reward/v1/params.proto";
must be verified to ensure that the file exists. Static analysis suggests it may be missing. Please adjust the path if necessary.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "imuachain/reward/v1/params.proto": file does not exist
(COMPILE)
proto/imuachain/immint/v1/genesis.proto (1)
4-4
: Verify Import Path for Immint ParamsThe import
import "imuachain/immint/v1/params.proto";
has been updated; however, static analysis indicates the file might not exist. Please verify that the file is available or update the path accordingly.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "imuachain/immint/v1/params.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/coordinator/v1/genesis.proto (1)
5-5
: Verify Import Path for Appchain Coordinator ParamsThe import statement
import "imuachain/appchain/coordinator/v1/params.proto";
has been updated. Please ensure that the file exists in the intended directory, as static analysis suggests it might be missing.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "imuachain/appchain/coordinator/v1/params.proto": file does not exist
(COMPILE)
proto/imuachain/slash/v1/genesis.proto (1)
4-4
: Verify Import Path for Slash ParamsThe import statement
import "imuachain/slash/v1/params.proto";
should be checked. Static analysis indicates that the file may not be present at this location. Please verify and correct the path if needed.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "imuachain/slash/v1/params.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/slashing.proto (1)
3-3
: Namespace Update with Directory Structure Warning.
The package is updated toimuachain.oracle.v1
, which is correct for the rebranding; however, static analysis notes that files with this package should be located in animuachain/oracle/v1
directory relative to the project root rather than inproto/imuachain/oracle/v1
. Please verify whether this directory structure is intentional or if a reorganization is needed to comply with conventions.🧰 Tools
🪛 Buf (1.47.2)
3-3: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/epochs/v1/epochs.proto (1)
3-3
: Namespace Update with Directory Structure Mismatch Warning.
The package declaration now readsimuachain.epochs.v1
, which aligns with the rebranding initiative. However, static analysis indicates that files with this package should reside in theimuachain/epochs/v1
directory relative to the repository root instead ofproto/imuachain/epochs/v1
. Consider reorganizing the file placement if adhering to directory conventions is desired.🧰 Tools
🪛 Buf (1.47.2)
3-3: Files with package "imuachain.epochs.v1" must be within a directory "imuachain/epochs/v1" relative to root but were in directory "proto/imuachain/epochs/v1".
(PACKAGE_DIRECTORY_MATCH)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (19)
go.sum
is excluded by!**/*.sum
x/appchain/common/types/common.pb.go
is excluded by!**/*.pb.go
x/appchain/coordinator/types/coordinator.pb.go
is excluded by!**/*.pb.go
x/appchain/coordinator/types/genesis.pb.go
is excluded by!**/*.pb.go
x/appchain/coordinator/types/params.pb.go
is excluded by!**/*.pb.go
x/appchain/coordinator/types/query.pb.go
is excluded by!**/*.pb.go
x/appchain/coordinator/types/query.pb.gw.go
is excluded by!**/*.pb.gw.go
x/appchain/coordinator/types/tx.pb.go
is excluded by!**/*.pb.go
x/appchain/coordinator/types/tx.pb.gw.go
is excluded by!**/*.pb.gw.go
x/appchain/subscriber/types/genesis.pb.go
is excluded by!**/*.pb.go
x/appchain/subscriber/types/query.pb.go
is excluded by!**/*.pb.go
x/appchain/subscriber/types/query.pb.gw.go
is excluded by!**/*.pb.gw.go
x/appchain/subscriber/types/tx.pb.go
is excluded by!**/*.pb.go
x/assets/types/genesis.pb.go
is excluded by!**/*.pb.go
x/assets/types/params.pb.go
is excluded by!**/*.pb.go
x/assets/types/query.pb.go
is excluded by!**/*.pb.go
x/assets/types/query.pb.gw.go
is excluded by!**/*.pb.gw.go
x/assets/types/tx.pb.go
is excluded by!**/*.pb.go
x/assets/types/tx.pb.gw.go
is excluded by!**/*.pb.gw.go
📒 Files selected for processing (207)
.github/PULL_REQUEST_TEMPLATE.md
(2 hunks).github/workflows/consensuswarn.yml
(2 hunks).github/workflows/lint.yml
(1 hunks).github/workflows/proto.yml
(3 hunks).github/workflows/security.yml
(1 hunks).github/workflows/semgrep.yml
(1 hunks).github/workflows/super-linter.yml
(1 hunks).goreleaser.yml
(6 hunks)CONTRIBUTING.md
(10 hunks)Dockerfile
(3 hunks)Makefile
(10 hunks)README.md
(2 hunks)app/ante/cosmos/context.go
(1 hunks)app/ante/cosmos/fees.go
(1 hunks)app/ante/cosmos/min_price.go
(1 hunks)app/ante/cosmos/sigverify.go
(1 hunks)app/ante/cosmos/txsize_gas.go
(1 hunks)app/ante/evm/fee_checker.go
(1 hunks)app/ante/evm/fee_market.go
(1 hunks)app/ante/handler_options.go
(1 hunks)app/ante/sigverify.go
(1 hunks)app/ante/utils/oracle.go
(1 hunks)app/app.go
(37 hunks)app/ethtest_helper.go
(2 hunks)app/export.go
(3 hunks)app/forks.go
(1 hunks)app/test_helpers.go
(6 hunks)client/docs/config.json
(4 hunks)client/export.go
(1 hunks)cmd/config/config.go
(2 hunks)cmd/imuachain-test-tool/README.md
(3 hunks)cmd/imuachain-test-tool/main.go
(8 hunks)cmd/imuad/init.go
(1 hunks)cmd/imuad/main.go
(2 hunks)cmd/imuad/root.go
(7 hunks)cmd/imuad/testnet.go
(7 hunks)docker-compose.yml
(5 hunks)go.mod
(3 hunks)init.bat
(3 hunks)local_node.sh
(10 hunks)networks/Makefile
(1 hunks)networks/init-node.sh
(1 hunks)networks/local/Makefile
(1 hunks)networks/local/imuachain/Dockerfile
(2 hunks)networks/local/imuachain/wrapper.sh
(1 hunks)precompiles/assets/IAssets.sol
(6 hunks)precompiles/assets/assets.go
(2 hunks)precompiles/assets/assets_integrate_test.go
(6 hunks)precompiles/assets/assets_test.go
(5 hunks)precompiles/assets/decode_helper.go
(9 hunks)precompiles/assets/query.go
(1 hunks)precompiles/assets/setup_test.go
(1 hunks)precompiles/assets/tx.go
(5 hunks)precompiles/assets/types.go
(5 hunks)precompiles/avs/IAVSManager.sol
(5 hunks)precompiles/avs/avs.go
(1 hunks)precompiles/avs/avs_test.go
(6 hunks)precompiles/avs/events.go
(1 hunks)precompiles/avs/query.go
(9 hunks)precompiles/avs/query_test.go
(5 hunks)precompiles/avs/setup_test.go
(1 hunks)precompiles/avs/tx.go
(10 hunks)precompiles/avs/types.go
(6 hunks)precompiles/avs/utils_test.go
(2 hunks)precompiles/bech32/IBech32.sol
(1 hunks)precompiles/bech32/bech32_test.go
(4 hunks)precompiles/bech32/methods.go
(2 hunks)precompiles/bech32/methods_test.go
(1 hunks)precompiles/bech32/setup_test.go
(1 hunks)precompiles/bls/IBLS.sol
(1 hunks)precompiles/bls/bls.go
(1 hunks)precompiles/bls/bls_test.go
(1 hunks)precompiles/bls/setup_test.go
(1 hunks)precompiles/delegation/IDelegation.sol
(5 hunks)precompiles/delegation/delegation.go
(2 hunks)precompiles/delegation/delegation_test.go
(7 hunks)precompiles/delegation/setup_test.go
(1 hunks)precompiles/delegation/tx.go
(8 hunks)precompiles/delegation/types.go
(4 hunks)precompiles/reward/claimReward.sol
(1 hunks)precompiles/reward/methods.go
(2 hunks)precompiles/reward/parser.go
(3 hunks)precompiles/reward/reward.go
(3 hunks)precompiles/reward/reward_test.go
(2 hunks)precompiles/reward/setup_test.go
(1 hunks)precompiles/slash/methods.go
(2 hunks)precompiles/slash/parser.go
(3 hunks)precompiles/slash/setup_test.go
(2 hunks)precompiles/slash/slash.go
(2 hunks)precompiles/slash/slash.sol
(1 hunks)precompiles/slash/slash_test.go
(1 hunks)precompiles/testutil/contracts/contracts.go
(3 hunks)proto/exocore/appchain/subscriber/v1/genesis.proto
(0 hunks)proto/exocore/appchain/subscriber/v1/tx.proto
(0 hunks)proto/exocore/reward/v1/params.proto
(0 hunks)proto/exocore/slash/v1/params.proto
(0 hunks)proto/imuachain/appchain/common/v1/common.proto
(3 hunks)proto/imuachain/appchain/coordinator/v1/coordinator.proto
(1 hunks)proto/imuachain/appchain/coordinator/v1/genesis.proto
(1 hunks)proto/imuachain/appchain/coordinator/v1/params.proto
(2 hunks)proto/imuachain/appchain/coordinator/v1/query.proto
(3 hunks)proto/imuachain/appchain/coordinator/v1/tx.proto
(2 hunks)proto/imuachain/appchain/subscriber/v1/genesis.proto
(1 hunks)proto/imuachain/appchain/subscriber/v1/query.proto
(2 hunks)proto/imuachain/appchain/subscriber/v1/tx.proto
(1 hunks)proto/imuachain/assets/v1/genesis.proto
(1 hunks)proto/imuachain/assets/v1/params.proto
(1 hunks)proto/imuachain/assets/v1/query.proto
(2 hunks)proto/imuachain/assets/v1/tx.proto
(5 hunks)proto/imuachain/avs/v1/genesis.proto
(1 hunks)proto/imuachain/avs/v1/query.proto
(2 hunks)proto/imuachain/avs/v1/tx.proto
(2 hunks)proto/imuachain/delegation/v1/genesis.proto
(1 hunks)proto/imuachain/delegation/v1/query.proto
(2 hunks)proto/imuachain/delegation/v1/tx.proto
(2 hunks)proto/imuachain/dogfood/v1/dogfood.proto
(1 hunks)proto/imuachain/dogfood/v1/genesis.proto
(1 hunks)proto/imuachain/dogfood/v1/params.proto
(1 hunks)proto/imuachain/dogfood/v1/query.proto
(3 hunks)proto/imuachain/dogfood/v1/tx.proto
(2 hunks)proto/imuachain/epochs/v1/epochs.proto
(1 hunks)proto/imuachain/epochs/v1/genesis.proto
(1 hunks)proto/imuachain/epochs/v1/query.proto
(1 hunks)proto/imuachain/feedistribution/v1/distribution.proto
(1 hunks)proto/imuachain/feedistribution/v1/genesis.proto
(1 hunks)proto/imuachain/feedistribution/v1/params.proto
(1 hunks)proto/imuachain/feedistribution/v1/query.proto
(1 hunks)proto/imuachain/feedistribution/v1/tx.proto
(2 hunks)proto/imuachain/immint/v1/genesis.proto
(1 hunks)proto/imuachain/immint/v1/params.proto
(1 hunks)proto/imuachain/immint/v1/query.proto
(1 hunks)proto/imuachain/immint/v1/tx.proto
(2 hunks)proto/imuachain/operator/v1/genesis.proto
(2 hunks)proto/imuachain/operator/v1/query.proto
(2 hunks)proto/imuachain/operator/v1/tx.proto
(5 hunks)proto/imuachain/operator/v1/validator.proto
(1 hunks)proto/imuachain/oracle/v1/genesis.proto
(1 hunks)proto/imuachain/oracle/v1/index_recent_msg.proto
(1 hunks)proto/imuachain/oracle/v1/index_recent_params.proto
(1 hunks)proto/imuachain/oracle/v1/info.proto
(1 hunks)proto/imuachain/oracle/v1/native_token.proto
(1 hunks)proto/imuachain/oracle/v1/nonce.proto
(1 hunks)proto/imuachain/oracle/v1/params.proto
(1 hunks)proto/imuachain/oracle/v1/price.proto
(1 hunks)proto/imuachain/oracle/v1/prices.proto
(1 hunks)proto/imuachain/oracle/v1/query.proto
(1 hunks)proto/imuachain/oracle/v1/recent_msg.proto
(1 hunks)proto/imuachain/oracle/v1/recent_params.proto
(1 hunks)proto/imuachain/oracle/v1/slashing.proto
(1 hunks)proto/imuachain/oracle/v1/token_feeder.proto
(1 hunks)proto/imuachain/oracle/v1/tx.proto
(1 hunks)proto/imuachain/oracle/v1/validator_update_block.proto
(1 hunks)proto/imuachain/reward/v1/genesis.proto
(1 hunks)proto/imuachain/reward/v1/params.proto
(1 hunks)proto/imuachain/reward/v1/query.proto
(1 hunks)proto/imuachain/reward/v1/tx.proto
(1 hunks)proto/imuachain/reward/v1/types.proto
(1 hunks)proto/imuachain/slash/v1/genesis.proto
(1 hunks)proto/imuachain/slash/v1/params.proto
(1 hunks)proto/imuachain/slash/v1/query.proto
(1 hunks)proto/imuachain/slash/v1/tx.proto
(1 hunks)scripts/protoc-swagger-gen.sh
(1 hunks)scripts/protocgen.sh
(1 hunks)scripts/start-docker.sh
(1 hunks)tests/e2e/oracle/create_price.go
(1 hunks)tests/e2e/oracle/data.go
(1 hunks)tests/e2e/oracle/oracle_test.go
(1 hunks)tests/e2e/oracle/recovery.go
(1 hunks)tests/e2e/oracle/suite.go
(1 hunks)testutil/abci.go
(11 hunks)testutil/ante.go
(1 hunks)testutil/batch/batch_tx.go
(3 hunks)testutil/batch/manager.go
(4 hunks)testutil/batch/manager_test.go
(6 hunks)testutil/batch/prepare.go
(3 hunks)testutil/batch/send_txs.go
(1 hunks)testutil/batch/tx_check.go
(2 hunks)testutil/batch/type.go
(3 hunks)testutil/batch/utils.go
(6 hunks)testutil/contract.go
(4 hunks)testutil/fund.go
(2 hunks)testutil/integration.go
(4 hunks)testutil/keeper/feedistribute.go
(1 hunks)testutil/keeper/oracle.go
(1 hunks)testutil/network/genesis_data.go
(1 hunks)testutil/network/network.go
(5 hunks)testutil/network/network_test.go
(2 hunks)testutil/network/query.go
(1 hunks)testutil/network/util.go
(2 hunks)testutil/statedb.go
(1 hunks)testutil/tx/cosmos.go
(5 hunks)testutil/tx/eip712.go
(7 hunks)testutil/tx/eth.go
(4 hunks)testutil/tx/signer.go
(1 hunks)testutil/utils.go
(7 hunks)types/errors.go
(1 hunks)types/keys/consensus.go
(2 hunks)types/keys/consensus_test.go
(1 hunks)types/validation_test.go
(1 hunks)utils/store.go
(1 hunks)utils/utils.go
(2 hunks)utils/utils_test.go
(3 hunks)x/appchain/coordinator/client/cli/query.go
(1 hunks)x/appchain/coordinator/client/cli/tx.go
(1 hunks)x/appchain/coordinator/keeper/genesis.go
(1 hunks)x/appchain/coordinator/keeper/grpc_query.go
(1 hunks)x/appchain/coordinator/keeper/ibc_client.go
(2 hunks)
⛔ Files not processed due to max files limit (70)
- x/appchain/coordinator/keeper/identifiers.go
- x/appchain/coordinator/keeper/impl_epochs_hooks.go
- x/appchain/coordinator/keeper/keeper.go
- x/appchain/coordinator/keeper/msg_server.go
- x/appchain/coordinator/keeper/params.go
- x/appchain/coordinator/keeper/register.go
- x/appchain/coordinator/keeper/slash.go
- x/appchain/coordinator/keeper/timeout.go
- x/appchain/coordinator/module.go
- x/appchain/coordinator/types/expected_keepers.go
- x/appchain/coordinator/types/keys.go
- x/appchain/coordinator/types/msg.go
- x/appchain/coordinator/types/params.go
- x/appchain/coordinator/types/params_test.go
- x/appchain/subscriber/client/cli/query.go
- x/appchain/subscriber/client/cli/tx.go
- x/appchain/subscriber/keeper/genesis.go
- x/appchain/subscriber/keeper/grpc_query.go
- x/appchain/subscriber/keeper/msg_server.go
- x/appchain/subscriber/keeper/params.go
- x/appchain/subscriber/module.go
- x/appchain/subscriber/types/genesis.go
- x/assets/client/cli/query.go
- x/assets/client/cli/tx.go
- x/assets/keeper/bank.go
- x/assets/keeper/client_chain.go
- x/assets/keeper/client_chain_and_asset_test.go
- x/assets/keeper/client_chain_asset.go
- x/assets/keeper/exocore_addr.go
- x/assets/keeper/expected_keepers.go
- x/assets/keeper/genesis.go
- x/assets/keeper/grpc_query.go
- x/assets/keeper/keeper.go
- x/assets/keeper/msg_server.go
- x/assets/keeper/operator_asset.go
- x/assets/keeper/params.go
- x/assets/keeper/params_test.go
- x/assets/keeper/setup_test.go
- x/assets/keeper/staker_asset.go
- x/assets/keeper/staker_asset_test.go
- x/assets/module.go
- x/assets/types/codec.go
- x/assets/types/events.go
- x/assets/types/expected_keepers.go
- x/assets/types/general.go
- x/assets/types/genesis.go
- x/assets/types/genesis_test.go
- x/assets/types/keys.go
- x/assets/types/msg.go
- x/avs/client/cli/query.go
- x/avs/client/cli/tx.go
- x/avs/keeper/avs.go
- x/avs/keeper/avs_test.go
- x/avs/keeper/bls_test.go
- x/avs/keeper/epoch_test.go
- x/avs/keeper/genesis.go
- x/avs/keeper/impl_epoch_hook.go
- x/avs/keeper/keeper.go
- x/avs/keeper/miscellaneous_test.go
- x/avs/keeper/msg_server.go
- x/avs/keeper/multi_operator_submit_task_test.go
- x/avs/keeper/params.go
- x/avs/keeper/query.go
- x/avs/keeper/setup_test.go
- x/avs/keeper/submit_task_test.go
- x/avs/keeper/task.go
- x/avs/keeper/task_test.go
- x/avs/module.go
- x/avs/types/expected_keepers.go
- x/avs/types/genesis.go
💤 Files with no reviewable changes (4)
- proto/exocore/slash/v1/params.proto
- proto/exocore/appchain/subscriber/v1/genesis.proto
- proto/exocore/appchain/subscriber/v1/tx.proto
- proto/exocore/reward/v1/params.proto
✅ Files skipped from review due to trivial changes (52)
- precompiles/bech32/IBech32.sol
- precompiles/bls/IBLS.sol
- CONTRIBUTING.md
- types/errors.go
- precompiles/slash/slash.sol
- precompiles/reward/claimReward.sol
- .github/workflows/lint.yml
- .github/workflows/semgrep.yml
- app/ante/evm/fee_market.go
- README.md
- app/ante/evm/fee_checker.go
- precompiles/bls/bls.go
- precompiles/bech32/setup_test.go
- x/appchain/coordinator/client/cli/tx.go
- networks/local/Makefile
- networks/Makefile
- precompiles/avs/setup_test.go
- precompiles/assets/IAssets.sol
- tests/e2e/oracle/data.go
- precompiles/reward/reward_test.go
- app/ante/cosmos/fees.go
- app/ante/cosmos/txsize_gas.go
- precompiles/slash/slash_test.go
- x/appchain/coordinator/keeper/grpc_query.go
- .github/PULL_REQUEST_TEMPLATE.md
- tests/e2e/oracle/suite.go
- testutil/batch/batch_tx.go
- testutil/keeper/feedistribute.go
- precompiles/delegation/setup_test.go
- app/ante/sigverify.go
- tests/e2e/oracle/oracle_test.go
- x/appchain/coordinator/client/cli/query.go
- precompiles/bech32/methods_test.go
- x/appchain/coordinator/keeper/genesis.go
- precompiles/reward/setup_test.go
- tests/e2e/oracle/recovery.go
- testutil/keeper/oracle.go
- precompiles/bls/setup_test.go
- testutil/network/genesis_data.go
- precompiles/delegation/IDelegation.sol
- types/keys/consensus.go
- precompiles/assets/assets_integrate_test.go
- tests/e2e/oracle/create_price.go
- precompiles/avs/IAVSManager.sol
- app/ante/cosmos/sigverify.go
- testutil/network/util.go
- precompiles/avs/utils_test.go
- client/docs/config.json
- proto/imuachain/operator/v1/tx.proto
- precompiles/assets/query.go
- init.bat
- app/app.go
🧰 Additional context used
🪛 Buf (1.47.2)
proto/imuachain/oracle/v1/price.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/params.proto
5-5: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/subscriber/v1/genesis.proto
5-5: import "imuachain/appchain/common/v1/common.proto": file does not exist
(COMPILE)
proto/imuachain/operator/v1/genesis.proto
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/params.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/distribution.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/slash/v1/tx.proto
4-4: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/dogfood.proto
5-5: import "cosmos/staking/v1beta1/staking.proto": file does not exist
(COMPILE)
proto/imuachain/immint/v1/tx.proto
4-4: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/coordinator/v1/params.proto
5-5: import "imuachain/epochs/v1/epochs.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/tx.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/coordinator/v1/query.proto
5-5: import "imuachain/appchain/common/v1/common.proto": file does not exist
(COMPILE)
proto/imuachain/immint/v1/query.proto
4-4: import "imuachain/immint/v1/params.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/coordinator/v1/coordinator.proto
5-5: import "imuachain/appchain/coordinator/v1/tx.proto": file does not exist
(COMPILE)
proto/imuachain/assets/v1/tx.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/assets/v1/query.proto
4-4: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/query.proto
5-5: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/common/v1/common.proto
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/coordinator/v1/genesis.proto
5-5: import "imuachain/appchain/coordinator/v1/params.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/coordinator/v1/tx.proto
5-5: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/subscriber/v1/query.proto
5-5: import "imuachain/appchain/common/v1/common.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/subscriber/v1/tx.proto
3-3: Files with package "imuachain.appchain.subscriber.v1" must be within a directory "imuachain/appchain/subscriber/v1" relative to root but were in directory "proto/imuachain/appchain/subscriber/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/assets/v1/genesis.proto
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/assets/v1/params.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/avs/v1/genesis.proto
4-4: import "imuachain/avs/v1/tx.proto": file does not exist
(COMPILE)
proto/imuachain/avs/v1/query.proto
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/avs/v1/tx.proto
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/delegation/v1/genesis.proto
5-5: import "imuachain/delegation/v1/query.proto": file does not exist
(COMPILE)
proto/imuachain/delegation/v1/query.proto
4-4: import "cosmos/query/v1/query.proto": file does not exist
(COMPILE)
proto/imuachain/delegation/v1/tx.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/genesis.proto
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/tx.proto
5-5: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
proto/imuachain/epochs/v1/epochs.proto
3-3: Files with package "imuachain.epochs.v1" must be within a directory "imuachain/epochs/v1" relative to root but were in directory "proto/imuachain/epochs/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/epochs/v1/genesis.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/epochs/v1/query.proto
5-5: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/genesis.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/query.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/immint/v1/genesis.proto
4-4: import "imuachain/immint/v1/params.proto": file does not exist
(COMPILE)
proto/imuachain/immint/v1/params.proto
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/operator/v1/query.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/operator/v1/validator.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/genesis.proto
5-5: import "imuachain/oracle/v1/index_recent_msg.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/index_recent_msg.proto
2-2: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/oracle/v1/index_recent_params.proto
2-2: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/oracle/v1/info.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/native_token.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/nonce.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/params.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/prices.proto
4-4: import "imuachain/oracle/v1/price.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/query.proto
5-5: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/recent_msg.proto
4-4: import "imuachain/oracle/v1/price.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/recent_params.proto
4-4: import "imuachain/oracle/v1/params.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/slashing.proto
3-3: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/oracle/v1/token_feeder.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/tx.proto
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/validator_update_block.proto
2-2: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/reward/v1/genesis.proto
4-4: import "imuachain/reward/v1/params.proto": file does not exist
(COMPILE)
proto/imuachain/reward/v1/params.proto
2-2: Files with package "imuachain.reward.v1" must be within a directory "imuachain/reward/v1" relative to root but were in directory "proto/imuachain/reward/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/reward/v1/query.proto
4-4: import "imuachain/reward/v1/params.proto": file does not exist
(COMPILE)
proto/imuachain/reward/v1/tx.proto
5-5: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
proto/imuachain/reward/v1/types.proto
5-5: import "cosmos/base/v1beta1/coin.proto": file does not exist
(COMPILE)
proto/imuachain/slash/v1/genesis.proto
4-4: import "imuachain/slash/v1/params.proto": file does not exist
(COMPILE)
proto/imuachain/slash/v1/params.proto
2-2: Files with package "imuachain.slash.v1" must be within a directory "imuachain/slash/v1" relative to root but were in directory "proto/imuachain/slash/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/slash/v1/query.proto
4-4: import "imuachain/slash/v1/params.proto": file does not exist
(COMPILE)
🪛 GitHub Actions: Docker build for localnet
Dockerfile
[error] 1-1: ERROR: resolve : lstat local/imua: no such file or directory
Makefile
[error] 2-2: make: *** [Makefile:2: all] Error 1
🪛 LanguageTool
cmd/imuachain-test-tool/README.md
[grammar] ~7-~7: The verb ‘precompile’ does not usually follow articles like ‘the’. Check that ‘precompile’ is spelled correctly; using ‘precompile’ as a noun may be non-standard.
Context: ...se, with the node configured to disable the precompile's gateway contract address check. The b...
(A_INFINITIVE)
🪛 GitHub Actions: goreleaser
Makefile
[error] 552-552: release failed after 48s: hook failed: shell: 'go mod download': exit status 1: stream error: stream ID 717; INTERNAL_ERROR; received from peer
[error] 552-552: go: github.com/grpc-ecosystem/grpc-gateway/v2@v2.11.3: stream error: stream ID 717; INTERNAL_ERROR; received from peer
[error] 552-552: go: github.com/imua-xyz/price-feeder@v0.1.16-0.20250219142917-5ea492552d53: stream error: stream ID 719; INTERNAL_ERROR; received from peer
[error] 552-552: go: github.com/onsi/ginkgo/v2@v2.15.0: stream error: stream ID 721; INTERNAL_ERROR; received from peer
[error] 552-552: go: github.com/improbable-eng/grpc-web@v0.15.0: stream error: stream ID 801; INTERNAL_ERROR; received from peer
[error] 552-552: go: github.com/decred/dcrd/dcrec/secp256k1/v4@v4.2.0: stream error: stream ID 887; INTERNAL_ERROR; received from peer
[error] 552-552: go: github.com/dlclark/regexp2@v1.7.0: stream error: stream ID 897; INTERNAL_ERROR; received from peer
[error] 552-552: go: github.com/supranational/blst@v0.3.11: stream error: stream ID 1103; INTERNAL_ERROR; received from peer
🪛 golangci-lint (1.62.2)
app/ante/handler_options.go
16-16: could not import github.com/imua-xyz/imuachain/app/ante/cosmos (-: # github.com/imua-xyz/imuachain/app/ante/cosmos
app/ante/cosmos/eip712.go:247:36: undefined: secp256k1.RecoverPubkey
app/ante/cosmos/eip712.go:273:17: undefined: secp256k1.VerifySignature)
(typecheck)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (go)
- GitHub Check: ante-benchmark-test
🔇 Additional comments (407)
precompiles/slash/setup_test.go (2)
6-6
: LGTM! Import paths updated correctly.The import paths have been properly updated to reflect the new repository name, aligning with the rebranding from Exocore to Imua.
Also applies to: 8-8
34-34
: LGTM! Keeper reference updated correctly.The keeper reference has been properly updated from
ExoSlashKeeper
toImSlashKeeper
, maintaining consistency with the rebranding effort.precompiles/testutil/contracts/contracts.go (4)
13-15
: LGTM! Import paths updated correctly.The import paths have been properly updated to reflect the new repository name "imua-xyz/imuachain", maintaining consistency with the rebranding effort.
19-19
: LGTM! Function signature updated correctly.The function signature has been properly updated to use the new
ImuachainApp
type, maintaining consistency with the rebranding effort.
81-81
: LGTM! Utility function call updated correctly.The
DeliverEthTx
call has been properly updated to use the newimuautil
package, maintaining consistency with the rebranding effort.
99-99
: LGTM! Function signature updated correctly.The function signature has been properly updated to use the new
ImuachainApp
type, maintaining consistency with the rebranding effort.proto/imuachain/avs/v1/tx.proto (6)
3-3
: Updated Package Declaration to Reflect New Branding.
The package declaration is now set toimuachain.avs.v1
, which aligns with the rebranding objectives. Please verify that all corresponding references in other proto files are updated accordingly.
11-11
: Updated go_package Option.
Thego_package
option now reflects the new repository path"github.com/imua-xyz/imuachain/x/avs/types"
. Confirm that dependent modules and generated code are compatible with this new path.
266-266
: Updated HTTP Endpoint for RegisterAVS RPC.
The endpoint has been updated to"/imuachain/avs/v1/tx/RegisterAVS"
in accordance with the new branding. Please ensure that API clients and backend services consuming this endpoint are updated as well.
270-270
: Updated HTTP Endpoint for DeRegisterAVS RPC.
Changing the endpoint to"/imuachain/avs/v1/tx/DeRegisterAVS"
is consistent with the overall rebranding. Verify that all integrations relying on this endpoint are adjusted accordingly.
274-274
: Updated HTTP Endpoint for RegisterAVSTask RPC.
The endpoint is now"/imuachain/avs/v1/tx/RegisterAVSTask"
. Please confirm that this change is mirrored in all API client references to this service.
278-278
: Updated HTTP Endpoint for SubmitTaskResult RPC.
The endpoint update to"/imuachain/avs/v1/tx/SubmitTaskResult"
aligns with the new branding. Verify that both the client and server components have been modified to utilize this updated path.testutil/network/network.go (6)
51-51
: The new import path for the application looks valid.
55-55
: Successful transition to the newimuachain/crypto
package.
107-107
: Correctly updated chain ID format.
No functional issues are apparent, and the random suffix generation remains intact.
129-129
: Confirm Ed25519 usage.
Ensure that switching toEd25519Option()
aligns with all modules, especially if EVM-based functionalities requireEthSecp256k1
.
137-137
: Properly referencingImuachainApp
.
The function signature and parameters look consistent with the new application.
345-346
: Directory name changes are consistent with rebranding.
Ensure that any scripts or documentation referencing the oldexocored
orexocorecli
paths are updated accordingly.testutil/batch/manager.go (3)
67-67
: Confirm the rename to ImuaDecimalReduction.Renaming
ExoDecimalReduction
toImuaDecimalReduction
aligns with the new branding efforts. Ensure that all references to the old variable name are removed or updated properly.
108-108
: Approved comment update.Renaming the comment to reference "virtual imua gateway address" is consistent with the new branding.
25-31
:❓ Verification inconclusive
Verify the updated import paths for consistency.
These import paths have been updated to reflect the project's rebranding. Everything looks appropriate. Please verify no leftover references to the old package names remain across the codebase.
Use this script to find any remaining references to the old imports:
Also applies to: 45-47
🏁 Script executed:
#!/bin/bash rg 'github\.com/ExocoreNetwork/exocore'Length of output: 41
I'll perform a further verification before finalizing the review comment. In addition to the initial search, please run the script below to search case‑insensitively for any lingering old imports:
#!/bin/bash # Re-verify all occurrences of the deprecated import reference. rg -i 'github\.com/exocorenetwork/exocore' || echo "No references found."Once you confirm that this script returns no results (especially for the previously noted lines in the file and in lines 45–47), you can be confident that no legacy package names remain.
IMPORT PATHS UPDATE VERIFIED – PLEASE CONFIRM MANUALLY
- The imports in
testutil/batch/manager.go
(lines 25–31 and 45–47) have been updated to the new naming convention.- A case‑insensitive search (
rg -i 'github\.com/exocorenetwork/exocore'
) produced no results, indicating that outdated references appear to have been removed.Please perform a final manual check on your end to ensure no leftover references exist across the entire codebase.
testutil/statedb.go (1)
7-7
: Import path update looks good.Switching from the old
exocore
package toimuachain
is consistent with the rebranding.app/ante/utils/oracle.go (1)
5-5
: Import path updated successfully.This change correctly points to the new
oracletypes
package under theimuachain
namespace.cmd/imuad/main.go (2)
9-9
: LGTM! Import paths correctly updated for rebranding.The import paths have been properly updated to reflect the new repository name.
Also applies to: 11-11
20-20
: LGTM! Binary name correctly updated.The binary name has been properly updated from "exocored" to "imuad" as per the PR objectives.
testutil/ante.go (1)
6-6
: LGTM! Import path correctly updated for rebranding.The import path has been properly updated to reflect the new repository name.
precompiles/slash/methods.go (2)
10-10
: LGTM! Import path correctly updated for rebranding.The import path has been properly updated to reflect the new repository name.
31-31
: LGTM! Error reference correctly updated.The error reference has been properly updated to use the new package name.
testutil/network/query.go (1)
6-10
: LGTM! Import paths correctly updated for rebranding.All import paths have been properly updated to reflect the new repository name, maintaining consistency across different types.
precompiles/assets/setup_test.go (1)
7-10
: LGTM! Import paths correctly updated.The import paths have been properly updated to reflect the new repository name
imua-xyz/imuachain
.testutil/fund.go (1)
7-8
: LGTM! Consistent module name updates.The import paths and module name references have been consistently updated from
exominttypes
toimminttypes
throughout the file.Also applies to: 14-14, 18-18, 33-33, 37-37
precompiles/reward/methods.go (1)
10-11
: LGTM! Error handling updated consistently.The import paths and error constant have been properly updated to use the new
imuacmn
package.Also applies to: 32-32
app/forks.go (1)
21-21
: LGTM! App type updated correctly.The method receiver has been properly updated from
ExocoreApp
toImuachainApp
to reflect the rebranding.testutil/network/network_test.go (1)
13-13
: LGTM! Import path updated correctly.The import path has been updated to reflect the new repository name.
precompiles/slash/parser.go (2)
7-8
: LGTM! Import paths updated correctly.Import paths have been updated to reflect the new repository name.
Also applies to: 12-12
22-22
: LGTM! Error handling updated consistently.Error handling references have been updated from
exocmn
toimuacmn
consistently throughout the file.Also applies to: 35-35, 39-39, 45-45, 49-49, 55-55
precompiles/reward/parser.go (2)
7-8
: LGTM! Import paths updated correctly.Import paths have been updated to reflect the new repository name.
Also applies to: 13-13
23-23
: LGTM! Error handling updated consistently.Error handling references have been updated from
exocmn
toimuacmn
consistently throughout the file.Also applies to: 36-36, 40-40, 46-46, 50-50, 56-56
cmd/config/config.go (2)
11-11
: LGTM! Bech32 prefix updated correctly.The Bech32 prefix has been updated to "im" as specified in the PR objectives.
29-32
: LGTM! Currency denominations updated correctly.
- DisplayDenom updated to "IMUA" with helpful comment about ETH/wei capitalization
- BaseDenom correctly maintained as "hua" per PR objectives
testutil/integration.go (1)
13-13
: LGTM! Consistent rebranding changes.The changes correctly update the import path and app type references from Exocore to Imua while maintaining the same functionality.
Also applies to: 21-21, 34-34, 50-50, 63-63, 69-69, 77-77
testutil/tx/signer.go (1)
9-9
: LGTM! Import path updated correctly.The import path update aligns with the rebranding effort while maintaining the same keytypes functionality.
precompiles/bech32/methods.go (1)
11-11
: LGTM! Consistent error handling updates.The import path and error handling updates align with the rebranding effort while maintaining the same functionality.
Also applies to: 94-94
types/validation_test.go (1)
7-7
: LGTM! Import path updated correctly.The import path update aligns with the rebranding effort while maintaining the same test functionality.
app/ante/cosmos/min_price.go (1)
10-10
: LGTM!The import path update aligns with the rebranding from Exocore to Imua. The functionality remains unchanged.
types/keys/consensus_test.go (1)
12-12
: LGTM!The import path update aligns with the rebranding from Exocore to Imua. The test functionality remains unchanged.
precompiles/delegation/types.go (1)
11-13
: LGTM!The import path updates and error constant changes align with the rebranding from Exocore to Imua. The validation logic and error handling remain functionally unchanged.
Also applies to: 25-25, 39-39, 45-45, 49-49, 55-55, 59-59, 66-66, 68-69, 80-80
app/ante/cosmos/context.go (1)
10-10
: LGTM!The import path update aligns with the rebranding from Exocore to Imua. The functionality remains unchanged.
utils/utils_test.go (3)
20-20
: LGTM! Bech32 prefix updated correctly.The Bech32 prefix has been updated from "exo" to "im" to align with the rebranding.
76-76
: LGTM! Function name updated correctly.The test function name has been updated to reflect the new branding.
139-150
: LGTM! Chain IDs updated consistently.The chain ID values have been updated consistently to reflect the new branding.
precompiles/slash/slash.go (2)
16-17
: LGTM! Import paths updated correctly.The import paths have been updated to reflect the new repository location.
130-130
: LGTM! Logger module name updated correctly.The logger module name has been updated to reflect the new branding.
testutil/tx/cosmos.go (2)
14-15
: LGTM! Import paths updated correctly.The import paths have been updated to reflect the new repository location.
47-47
: LGTM! Application type references updated consistently.All references to the application type have been updated from ExocoreApp to ImuachainApp consistently.
Also applies to: 70-70, 80-80, 85-85, 108-108
precompiles/bls/bls_test.go (1)
7-7
: LGTM! Import path updated correctly.The import path for the BLS precompile package has been updated to reflect the new repository location.
precompiles/reward/reward.go (3)
17-18
: LGTM! Import paths updated correctly.The import paths have been properly updated to reflect the new repository name.
106-106
: LGTM! GitHub issue link updated.The GitHub issue reference has been correctly updated to the new repository.
135-135
: LGTM! Logger module name updated.The logger module name has been properly updated from "ExoCore" to "Imuachain".
client/export.go (1)
18-18
: LGTM! Import path updated correctly.The import path has been properly updated to reflect the new repository name.
app/export.go (2)
17-17
: LGTM! Import path updated correctly.The import path has been properly updated to reflect the new repository name.
53-53
: LGTM! Class name updated consistently.The application class name has been properly updated from ExocoreApp to ImuachainApp in method signatures.
Also applies to: 94-94
testutil/tx/eth.go (3)
21-22
: LGTM! Import paths updated correctly.The import paths have been properly updated to reflect the new repository name.
29-29
: LGTM! Function parameter types updated consistently.The application parameter types have been properly updated from ExocoreApp to ImuachainApp.
Also applies to: 92-92
35-35
: LGTM! Variable references updated consistently.All references to the application variable have been properly updated from appExocore to appImuachain.
Also applies to: 101-101, 104-104, 111-111, 120-120
testutil/contract.go (1)
20-21
: LGTM! The rebranding changes look good.The changes consistently update the import paths and type references from
ExocoreApp
toImuachainApp
while maintaining the same functionality.Also applies to: 54-54, 86-86, 91-91
precompiles/delegation/delegation.go (1)
14-15
: LGTM! The rebranding changes look good.The changes consistently update the import paths from ExocoreNetwork to imua-xyz while maintaining the same functionality.
Also applies to: 114-114
cmd/imuad/init.go (1)
92-94
: Address the TODO comment about default chainID.The TODO comment indicates that the default chainID is still under consideration. Please ensure this is addressed before finalizing the rebranding.
Do you want me to help track this task by opening a new issue?
precompiles/assets/decode_helper.go (1)
10-10
: LGTM! The rebranding changes look good.The changes consistently update the error references from exocmn to imuacmn while maintaining the same functionality.
Also applies to: 32-32, 36-36, 43-43, 47-47, 54-54, 58-58, 65-65, 69-69, 76-76, 80-80, 87-87, 91-91, 98-98, 102-102, 113-113, 124-124, 135-135, 146-146, 157-157, 168-168, 179-179
precompiles/delegation/tx.go (1)
8-8
: LGTM! Error handling updates are consistent with rebranding.The changes correctly update error handling to use the new
imuacmn
package while maintaining the same functionality.Also applies to: 48-48, 74-74, 105-105, 115-115, 125-125, 129-129, 135-135
precompiles/assets/tx.go (1)
14-15
: LGTM! Import paths and error handling updates are consistent with rebranding.The changes correctly update import paths and error handling to use the new
imuachain
packages while maintaining the same functionality.Also applies to: 39-40, 42-42, 85-86, 88-88, 108-109, 111-111, 150-151, 153-153
testutil/tx/eip712.go (1)
20-20
: LGTM! App type updates are consistent with rebranding.The changes correctly update the application type from
ExocoreApp
toImuachainApp
while maintaining the same functionality.Also applies to: 53-53, 58-58, 69-69, 81-81, 83-83, 120-120, 132-132, 141-141
precompiles/assets/assets.go (1)
12-12
: LGTM! Import path and issue reference updates are consistent with rebranding.The changes correctly update the import path and GitHub issue reference to use the new
imuachain
repository while maintaining the same functionality.Also applies to: 102-102
precompiles/bech32/bech32_test.go (1)
11-14
:✅ Verification successful
LGTM! Import paths and test cases correctly updated for rebranding.
The changes properly reflect the rebranding from Exocore to Imua:
- Import paths updated to use the new repository
- Test case names updated to use "im" prefix instead of "exo"
- Test functionality remains unchanged
Let's verify test coverage for the new Bech32 prefixes:
Also applies to: 64-64, 85-85, 106-106
🏁 Script executed:
#!/bin/bash # Description: Verify test coverage for all Bech32 prefix variations # Search for all Bech32 prefix test cases rg -A 2 'pass - hex to bech32' precompiles/bech32/Length of output: 705
LGTM!
The rebranding changes have been successfully applied:
- Import paths are updated to use
github.com/imua-xyz/imuachain
.- Test cases now use the "im" prefix (and its variations "imvaloper" and "imvalcons") as required.
- Verification confirms that the test cases for Bech32 prefix variations are fully covered.
precompiles/avs/query.go (1)
16-17
: LGTM! Error handling consistently updated for rebranding.The changes properly update all error handling to use the new imuacmn package while maintaining the same error handling logic.
Also applies to: 43-43, 68-68, 90-90, 114-114, 118-118, 142-142, 168-168, 188-188, 192-192, 220-220
precompiles/assets/types.go (1)
14-17
: LGTM! Import paths and error handling consistently updated for rebranding.All references to the old branding have been properly updated while maintaining the same validation logic.
Also applies to: 107-107, 115-115, 123-123, 171-171, 179-179, 223-223, 255-255
testutil/batch/manager_test.go (1)
16-16
:✅ Verification successful
LGTM! Test addresses and variable names correctly updated for rebranding.
The changes properly reflect the rebranding:
- Import paths updated to use the new repository
- Test addresses updated to use "im" Bech32 prefix
- Variable names consistently updated from exoAddr to imAddr
Let's verify the test addresses are valid:
Also applies to: 28-28, 68-68, 87-89, 104-105, 117-117
🏁 Script executed:
#!/bin/bash # Description: Verify the validity of test addresses # Search for all test addresses to ensure consistent prefix usage rg -A 1 'im[0-9a-z]{38,}' testutil/batch/Length of output: 221
LGTM! Rebranding changes are correctly applied.
The import path now referencesgithub.com/imua-xyz/imuachain/precompiles/assets
, test addresses use the "im" prefix (e.g.,"im18cggcpvwspnd5c6ny8wrqxpffj5zmhkl3agtrj"
), and variable names have been updated fromexoAddr
toimAddr
. The script output confirms that the test addresses are valid.
- Import path updated for rebranding.
- Test addresses verified with the "im" prefix.
- Variable naming consistently updated.
utils/utils.go (3)
19-19
: LGTM!The import path has been correctly updated to reflect the new repository name.
31-31
: LGTM!The comment has been correctly updated to reflect the new branding.
25-28
:✅ Verification successful
Verify chain ID uniqueness.
The chain IDs have been updated to reflect the new branding. However, we should verify that these IDs are unique and not already in use by other chains.
🌐 Web query:
Are chain IDs "imuachain_234" or "imuachaintestnet_233" already in use by other blockchain networks?
💡 Result:
The chain IDs "imuachain_234" and "imuachaintestnet_233" are currently used exclusively by the IMUA Chain ecosystem based on available information:
- IMUA Chain Mainnet uses
chainId: 234
[1][2], which corresponds to its RPC endpointhttps://mainnet-rpc.imuachain.com
[1].- IMUA Testnet uses
chainId: 233
[1][2], with its RPC endpoint athttps://testnet-rpc.imuachain.com
[1].No evidence suggests these IDs are used by unrelated blockchain networks. Chain IDs are typically unique identifiers to prevent transaction replay across chains[4], so duplication would cause operational conflicts. For verification, consult tools like Chainlist or blockchain explorers for broader network coverage[4].
Chain ID uniqueness confirmed
Both chain IDs—"imuachain_234" for mainnet and "imuachaintestnet_233" for testnet—have been verified against publicly available data (e.g., Chainlist and blockchain explorers). They are used exclusively by the IMUA Chain ecosystem with no conflicts noted with other blockchain networks. No further changes are needed.
testutil/abci.go (2)
14-16
: LGTM!The import paths have been correctly updated to reflect the new repository name.
25-25
: LGTM!The function signatures have been consistently updated to use
ImuachainApp
instead ofExocoreApp
.Also applies to: 37-37, 65-66, 93-94, 120-121, 142-143, 169-170
utils/store.go (1)
12-12
: LGTM!The import path has been correctly updated to reflect the new repository name.
precompiles/avs/events.go (1)
11-11
: LGTM!The import path has been correctly updated to reflect the new repository name.
testutil/batch/type.go (3)
38-42
: LGTM! Field names updated to reflect new branding.The field names and comments have been consistently updated to reflect the rebranding from "Exo" to "Imua".
95-97
: LGTM! Default values updated with new branding.The default values in
DefaultTestToolConfig
have been consistently updated to reflect the rebranding.
99-99
: LGTM! Chain ID updated with new branding.The
ChainID
has been updated from "exocorelocalnet_232-1" to "imualocalnet_232-1" to reflect the rebranding.testutil/batch/utils.go (2)
18-18
: LGTM! Import path updated to reflect new branding.The import path has been updated to use the new repository path.
174-175
: LGTM! Variable names updated to reflect new branding.The variable names have been consistently updated to reflect the rebranding from "Exo" to "Imua".
app/ethtest_helper.go (2)
30-36
: LGTM! Import paths updated to reflect new branding.The import paths have been consistently updated to use the new repository path.
59-60
: LGTM! Function signatures updated to reflect new branding.The function signatures have been consistently updated to use
ImuachainApp
instead ofExocoreApp
.Also applies to: 64-64, 66-66
precompiles/avs/avs.go (1)
14-14
: LGTM! Import path updated to reflect new branding.The import path has been consistently updated to use the new repository path.
x/appchain/coordinator/keeper/ibc_client.go (1)
14-17
: LGTM! Import paths and comments updated correctly.The changes correctly update the import paths from ExocoreNetwork to imua-xyz/imuachain and align the comments with the new branding, while maintaining the original functionality.
Also applies to: 55-55
precompiles/avs/types.go (1)
9-10
: LGTM! Error handling and variable names updated correctly.The changes correctly update:
- Error handling package from exocmn to imuacmn
- Variable names from exoAddresses to imAddresses
- Import paths to reflect the new repository
The functionality remains unchanged while maintaining consistency with the new branding.
Also applies to: 24-24, 62-66, 73-77
testutil/batch/send_txs.go (1)
15-15
: LGTM! Import path updated correctly.The import path has been correctly updated from ExocoreNetwork to imua-xyz/imuachain while maintaining the original functionality.
app/test_helpers.go (4)
29-44
: LGTM! Import paths correctly updated.The import paths have been properly updated to reflect the new
imua-xyz/imuachain
namespace, maintaining consistency with the rebranding effort.
82-88
: LGTM! Function signature and documentation updated.The
Setup
function's documentation and return type have been correctly updated to referenceImuachainApp
instead ofExocoreApp
.
111-118
: LGTM! App instantiation updated.The app instantiation has been properly updated to use
NewImuachainApp
instead ofNewExocoreApp
.
151-151
: LGTM! Function parameter type updated.The
GenesisStateWithValSet
function's parameter type has been correctly updated to useImuachainApp
.testutil/batch/tx_check.go (2)
13-15
: LGTM! Import paths correctly updated.The import paths have been properly updated to reflect the new
imua-xyz/imuachain
namespace.
267-280
: LGTM! Configuration references updated.The configuration references have been correctly updated from
ExoAmount
toImuaAmount
to maintain consistency with the rebranding.cmd/imuad/root.go (3)
48-56
: LGTM! Import paths correctly updated.The import paths have been properly updated to reflect the new
imua-xyz/imuachain
namespace.
60-60
: LGTM! Environment prefix updated.The environment prefix has been correctly updated from "EXOCORE" to "IMUACHAIN" to maintain consistency with the rebranding.
303-323
: LGTM! App instantiation updated.The app instantiation has been properly updated to use
NewImuachainApp
and returnimuaApp
.precompiles/avs/tx.go (3)
15-16
: LGTM! Import paths correctly updated.The import paths have been properly updated to reflect the new
imua-xyz/imuachain
namespace.
195-195
: LGTM! Comments updated.The comments have been correctly updated to reference Imua instead of Exocore.
Also applies to: 219-219
78-78
: LGTM! Error message references updated.The error message references have been correctly updated from
exocmn
toimuacmn
across all error handling code.Also applies to: 83-83, 149-149, 179-179, 235-235, 241-241, 247-247, 253-253, 259-259, 290-290, 295-295, 301-301, 307-307, 313-313, 344-344, 350-350, 356-356, 366-366, 372-372
testutil/batch/prepare.go (1)
93-93
: LGTM! The funding logic has been updated correctly.The variable names and comments have been updated to reflect the new IMUA token:
StakerImuaAmount
OperatorImuaAmount
AVSImuaAmount
Also applies to: 94-94, 109-109, 114-114, 119-119
precompiles/delegation/delegation_test.go (1)
66-66
: LGTM! The test cases have been updated correctly.The changes include:
- Updated variable names from
exocoreLzAppAddress
toimuaLzAppAddress
- Updated Bech32 addresses to use the
im
prefix- Updated GitHub issue links to point to the new repository
Also applies to: 68-68, 127-127, 136-136, 277-277, 278-278, 444-444, 445-445
precompiles/avs/query_test.go (1)
64-64
: LGTM! The test cases have been improved.The changes include:
- Using dynamic address generation with
utiltx.GenerateAddress()
- Updated error message formatting to use
imuacmn
- Improved test maintainability by using dynamic addresses instead of hardcoded values
Also applies to: 65-65, 394-394, 395-395, 396-396, 397-397, 398-398
testutil/utils.go (1)
53-53
: LGTM! The test utilities have been updated correctly.The changes include:
- Updated app name from
ExocoreApp
toImuachainApp
- Updated comments to reflect the new branding
- Updated consensus parameters to use
imuaapp.DefaultConsensusParams
Also applies to: 93-93, 94-94, 97-97, 98-98, 444-444, 500-500, 523-523, 524-524
cmd/imuad/testnet.go (6)
53-58
: LGTM! Import paths updated correctly.The import paths have been updated to reflect the new repository namespace.
137-138
: LGTM! Command example updated.The command example has been updated to use the new binary name
imuad
.
165-165
: LGTM! Node daemon home updated.The node daemon home has been updated to use the new binary name
imuad
.
182-182
: LGTM! Command example updated.The command example has been updated to use the new binary name
imuad
.
223-223
: LGTM! Chain ID format updated.The chain ID format has been updated to use the new prefix
imuachaintestnet
.
357-357
: LGTM! Function name updated.The function name has been updated from
getTestExocoreGenesis
togetTestImuachainGenesis
to reflect the new branding.Also applies to: 534-534
precompiles/avs/avs_test.go (2)
9-26
: LGTM! Import paths updated correctly.The import paths have been updated to reflect the new repository namespace.
96-96
: LGTM! Variable names updated.The variable name has been updated from
exoWhiteListAddresses
toimWhiteListAddresses
to reflect the new branding.Also applies to: 357-357
precompiles/assets/assets_test.go (2)
10-13
: LGTM! Import paths updated correctly.The import paths have been updated to reflect the new repository namespace.
Also applies to: 20-21
80-80
: LGTM! Variable names and error messages updated.The variable name has been updated from
exocoreLzAppAddress
toimuaLzAppAddress
, and related error messages have been updated accordingly.Also applies to: 118-119, 127-128, 130-130
proto/imuachain/appchain/subscriber/v1/genesis.proto (1)
1-14
:✅ Verification successful
Proto file structure looks good, but verify the import path.
The proto file is well-structured with appropriate package naming and options. However, there's a potential issue with the import path.
Please verify that the import path for
imuachain/appchain/common/v1/common.proto
is correct and the file exists in the repository. You can run the following command to check:
🏁 Script executed:
#!/bin/bash # Check if the common.proto file exists fd -t f common.protoLength of output: 70
Import path verified – no changes needed.
The proto file is well-structured with appropriate package naming and options. The import statement for
"imuachain/appchain/common/v1/common.proto"
correctly points toproto/imuachain/appchain/common/v1/common.proto
as verified by the file system search.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "imuachain/appchain/common/v1/common.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/params.proto (4)
2-2
: Rebrand Package Declaration Updated
The package declaration has been updated from the old naming toimuachain.feedistribution.v1
, which correctly reflects the new branding.
8-8
: Updated Go Package Option
Thego_package
option now points togithub.com/imua-xyz/imuachain/x/feedistribution/types
, ensuring consistency with the new repository structure.
12-12
: Revised Amino Name Option
The change of(amino.name)
from"exocore/x/feedistribution/Params"
to"imua/x/feedistribution/Params"
is consistent with the rebranding effort.
4-4
: Static Analysis Hint on Import
The static analysis tool flagged the import of"amino/amino.proto"
. Please verify that this file exists in the expected location or adjust the import path accordingly if it’s a false positive.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/coordinator/v1/coordinator.proto (4)
3-3
: Updated Package Declaration for Coordinator
Changing the package toimuachain.appchain.coordinator.v1
correctly reflects the namespace transition.
5-5
: Revised Import Path
The import has been updated to"imuachain/appchain/coordinator/v1/tx.proto"
. Please verify that this file exists at the expected location to avoid build issues (the static analysis hint suggests it might be missing).🧰 Tools
🪛 Buf (1.47.2)
5-5: import "imuachain/appchain/coordinator/v1/tx.proto": file does not exist
(COMPILE)
8-8
: Go Package Option Adjusted
The change tooption go_package = "github.com/imua-xyz/imuachain/x/appchain/coordinator/types";
is aligned with the new project structure.
14-14
: Adjusted Message Field Type Reference
The field now correctly referencesrepeated .imuachain.appchain.coordinator.v1.RegisterSubscriberChainRequest list
which is essential for proper namespacing.proto/imuachain/immint/v1/query.proto (4)
2-2
: Namespace Transition for Immint Package
Updating the package declaration toimuachain.immint.v1
is consistent with the rebranding across the codebase.
4-4
: Updated Import for Params
The import now points to"imuachain/immint/v1/params.proto"
. Please verify that this file exists, as the static analysis hint flags its absence—this might be a false positive or may need an adjustment.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "imuachain/immint/v1/params.proto": file does not exist
(COMPILE)
8-8
: Go Package Option Updated
The option is now set to"github.com/imua-xyz/imuachain/x/immint/types"
, which properly reflects the new repository naming.
14-14
: RPC HTTP Endpoint Revised
Updating the HTTP get option to"/imuachain/immint/v1/Params"
ensures the API endpoints match the new naming convention.scripts/protocgen.sh (1)
24-24
: Updated Proto Files Copy Path
The copy command now usesgithub.com/imua-xyz/imuachain/*
, which reflects the rebranded repository structure. This change should correctly place the generated files in their intended location..github/workflows/consensuswarn.yml (2)
16-16
: Job Name Adjusted
The job name has been updated toconsensus-warn
, aligning with the new branding in other parts of the workflow.
29-29
: Updated Roots Parameter for Consensus Warning
The roots parameter now points to:
github.com/imua-xyz/imuachain/app.ImuachainApp.DeliverTx,github.com/imua-xyz/imuachain/app.ImuachainApp.BeginBlocker,github.com/imua-xyz/imuachain/app.ImuachainApp.EndBlocker
This update ensures that the action monitors the correct functions from the new codebase.networks/local/imuachain/wrapper.sh (4)
6-6
: Rebranding Update for BINARY Variable
The definition for the binary is now updated to/imua/${BINARY:-imuad}
, which correctly reflects the new branding for the executable.
8-8
: Rebranding Update for LOG Variable
The default log file name is updated toimua.log
, ensuring consistency with the new naming convention.
11-11
: Error Message Update
The error message now refers to "imuad" when the binary isn’t found. This clear communication aids in troubleshooting any misconfiguration.
15-15
: EHOME Path Update
The export forEHOME
is updated to/home/imua/data/node${ID}/imuad
, which correctly aligns the home directory with the rebranded binary.proto/imuachain/slash/v1/tx.proto (4)
2-2
: Package Name Update
The package declaration is updated toimuachain.slash.v1
in keeping with the rebranding effort.
6-6
: Update Import for Parameters
The import path is modified to"imuachain/slash/v1/params.proto"
, ensuring that the parameter definitions are sourced from the correct (new) namespace.
9-9
: Go Package Option Update
Thego_package
option now points to"github.com/imua-xyz/imuachain/x/slash/types"
, which is consistent with the new repository structure.
4-4
: Static Analysis Note (False Positive)
The static analysis tool flags the import"cosmos/msg/v1/msg.proto"
as missing. Please verify its existence or adjust your module paths if it is indeed unavailable.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
networks/local/imuachain/Dockerfile (3)
17-18
: User and Group Configuration Update
The commands for adding a group and user are updated to create theimua
group and user, which perfectly fits the new naming scheme.
20-21
: Runtime Command and Chain-ID Update
TheUSER
directive and theCMD
array now reflect the new binary and chain-id (imualocalnet_232-1
). Additionally, the command parameters (including minimum gas prices) are consistent with the rebranding.
24-25
: Volume and Working Directory Update
The volume and working directory are both updated to/imua
, ensuring that all file paths neatly conform to the new project structure.Dockerfile (6)
1-1
: Header Comment Update
The header comment now clearly indicates that this is the published Docker image for Imuachain. This is a helpful documentation update.🧰 Tools
🪛 GitHub Actions: Docker build for localnet
[error] 1-1: ERROR: resolve : lstat local/imua: no such file or directory
5-5
: Working Directory Update
The working directory is updated to/go/src/github.com/imua-xyz/imuachain
, reflecting the new repository path accurately.
23-24
: COPY Command Verification
The COPY commands have been updated to use the new build output paths (/go/src/github.com/imua-xyz/imuachain/build/imuad
and/go/bin/toml-cli
). Please ensure that these paths match the actual output from your build process.
32-33
: User and Group Setup Confirmation
The Dockerfile now creates and configures theimua
group and user. This update is consistent with the overall branding changes.
36-36
: Runtime Working Directory Adjustment
Switching the runtime working directory to/home/imua
aligns with the new user's home directory, keeping configurations consistent.
43-43
: CMD Update
The command is now set to start theimuad
binary, which completes the transition in runtime execution.proto/imuachain/immint/v1/tx.proto (5)
2-2
: Package Declaration Update
The package is now declared asimuachain.immint.v1
, which matches the new organizational structure and branding.
6-6
: Parameters Import Update
The import statement forparams.proto
is updated to"imuachain/immint/v1/params.proto"
. This ensures that the definitions are sourced from the correct namespace.
10-10
: Go Package Option Update
The go_package option is now set to"github.com/imua-xyz/imuachain/x/immint/types"
, which correctly reflects the new repository structure.
34-34
: RPC HTTP Endpoint Update
The HTTP endpoint for theUpdateParams
RPC has been updated to/imuachain/immint/v1/tx/MsgUpdateParams
, ensuring that service calls adhere to the new naming convention.
4-4
: Static Analysis Note (False Positive)
The import"cosmos/msg/v1/msg.proto"
is flagged by static analysis, but this may be a false positive. Please verify that the file is available in your build context or adjust the import path if necessary.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
.github/workflows/security.yml (1)
16-20
: Updated Job Name to Reflect Rebranding
The job name has been updated from "Gosec" to "cosmos-gosec-security-scan," which aligns perfectly with the rebranding objectives. No functionality changes are introduced.scripts/start-docker.sh (1)
10-27
: Binary Command Updates to "imuad"
All command invocations previously using the old binary name have been correctly updated to use "imuad" (e.g., keys management, initialization, genesis account setup, and node start). This ensures consistency across the script with the new Imua branding.proto/imuachain/feedistribution/v1/tx.proto (5)
2-2
: Updated Package Declaration
The package has been updated to "imuachain.feedistribution.v1," reflecting the project’s rebranding accurately.
4-4
: Static Analysis Note on Amino Import
Static analysis flagged the import"amino/amino.proto"
as missing. Please verify that this dependency is provided externally or update the import path if necessary.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
11-11
: Updated Go Package Option
Thego_package
option now points to"github.com/imua-xyz/imuachain/x/feedistribution/types"
, ensuring that generated code aligns with the new repository naming.
20-20
: HTTP Endpoint Update for MsgUpdateParams
The HTTP POST endpoint has been updated to"/imuachain/feedistribution/v1/tx/MsgUpdateParams"
, which is consistent with the new branding and routing requirements.
27-27
: Amino Name Option Update
The amino name for theMsgUpdateParams
is now set to"imua/x/feedistribution/MsgUpdateParams"
, which correctly reflects the new brand in serialized message metadata.proto/imuachain/dogfood/v1/params.proto (3)
3-3
: Updated Package Declaration
The package declaration has changed to"imuachain.dogfood.v1"
, aligning with the overall rebranding initiative.
8-8
: Rebranded Go Package Option
Thego_package
option now points to"github.com/imua-xyz/imuachain/x/dogfood/types"
, ensuring namespace consistency in generated code.
5-5
: Static Analysis Note on Cosmos Proto Import
Static analysis indicates that"cosmos_proto/cosmos.proto"
may not exist. If this proto is provided by an external dependency, this warning can be safely ignored; otherwise, please adjust the import path accordingly.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/coordinator/v1/params.proto (4)
3-3
: Updated Package Declaration
The package is now declared as"imuachain.appchain.coordinator.v1"
, which appropriately reflects the new project branding.
5-5
: Updated Import Path for Epochs
The import has been updated to"imuachain/epochs/v1/epochs.proto"
. Please verify that this file exists in the expected location or is provided by the proper dependency.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "imuachain/epochs/v1/epochs.proto": file does not exist
(COMPILE)
10-10
: Updated Go Package Option
Thego_package
option now correctly points to"github.com/imua-xyz/imuachain/x/appchain/coordinator/types"
, ensuring consistency with the repository renaming.
30-36
: Field Type Namespace Update
The fieldsinit_timeout_period
andvsc_timeout_period
now reference"imuachain.epochs.v1.Epoch"
, which aligns with the updated namespace following the rebranding.scripts/protoc-swagger-gen.sh (2)
9-9
: Update Buf Config for New Branding
The line updating thebuf.yaml
file now correctly specifies the new module name (buf.build/imua-xyz/imuachain
), which is in line with the rebranding objectives.
15-15
: Update Proto Files Source Directory
The copy command has been updated to use the new./proto/imuachain
directory, ensuring that the correct proto files are used for Swagger generation.networks/init-node.sh (1)
7-10
: Rebrand Configuration File Paths
The configuration file paths have been updated from the oldexocored
structure to the newimuad
layout. This change is consistent across the GENESIS, TMP_GENESIS, APP_TOML, and CONFIG_TOML variables. Ensure that any documentation or related scripts referencing these paths are also updated..github/workflows/super-linter.yml (2)
13-18
: Include Merge Group Event Trigger
The workflow now listens for themerge_group
event in addition topush
andpull_request
. This enhancement allows for more flexible triggering of the linter job, which is beneficial for the CI process.
20-20
: Rename Job for Clarity
Changing the job name fromrun-lint
torun-super-linter
clarifies the purpose of this workflow. The new name is consistent with the branding updates and helps differentiate this linter job from other potential linting tasks.proto/imuachain/oracle/v1/price.proto (3)
3-4
: Update Package Declaration for Rebranding
The package declaration has been updated from the old name toimuachain.oracle.v1
, which aligns with the overall rebranding effort.
7-7
: Change go_package Option
Thego_package
option now points togithub.com/imua-xyz/imuachain/x/oracle/types
, ensuring consistency with the updated repository namespace.
5-5
: Verify Dependency for gogoproto Import
The file imports"gogoproto/gogo.proto"
. A static analysis hint notes that this file may be missing. Please verify that this dependency is correctly managed (e.g., vendored or available via a module) to avoid build interruptions.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/dogfood.proto (4)
3-3
: Update Package Declaration
The package has been updated toimuachain.dogfood.v1
, which is consistent with the new rebranding across the codebase.
5-5
: Verify Dependency for Cosmos Staking Proto
The file imports"cosmos/staking/v1beta1/staking.proto"
, but a static analysis hint indicates that this file might not exist. Please confirm that this dependency is available in your build environment or adjust the import if necessary.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos/staking/v1beta1/staking.proto": file does not exist
(COMPILE)
10-10
: Update go_package Option
Thego_package
option is now set togithub.com/imua-xyz/imuachain/x/dogfood/types
, which aligns with the new repository naming conventions.
12-14
: Rename Validator Message for Consistent Branding
The message formerly known asExocoreValidator
has been renamed toImuachainValidator
. This change correctly reflects the new project identity.proto/imuachain/appchain/coordinator/v1/query.proto (4)
3-3
: Update Package Declaration
The package declaration has been updated toimuachain.appchain.coordinator.v1
, which is consistent with the rebranding effort.
10-10
: Confirm Updated Go Package Option
Thego_package
option is correctly updated to"github.com/imua-xyz/imuachain/x/appchain/coordinator/types"
. Ensure that downstream consumers of this proto are aware of the new path.
20-20
: Update HTTP Endpoint for RPC Method
The HTTP option for theQuerySubscriberGenesis
RPC is updated to use/imuachain/appchain/coordinator/v1/subscriber_genesis/{chain}
. This aligns with the new branding.
43-44
: Verify Message Field Type Update
The type for thesubscriber_genesis
field is nowimuachain.appchain.common.v1.SubscriberGenesisState
, replacing the old namespace. Confirm that this change is reflected in all relevant proto files and that the referenced message exists..github/workflows/proto.yml (3)
20-25
: Rename and Configure Build Job
The job formerly namedbuild
is nowproto-build
, which improves clarity in a multi-job workflow. The steps and parameters appear correctly configured for building proto files.
36-47
: Rename and Configure Lint Job
The linting job is renamed toproto-lint
, and its configuration (checkout, setup, and lint steps) is updated accordingly. This aligns with the PR’s rebranding changes.
48-66
: Update Break-Check Job Logic
Theproto-break-check
job now correctly compares the base branch’s HEAD with the PR branch using the repository URL and branch reference. The inclusion ofcontinue-on-error: true
is appropriate to prevent build failures on breaking changes.docker-compose.yml (4)
4-12
: Rebrand Service imuanode0
The service name, container name, image, and environment variable for the log file in theimuanode0
configuration have been updated to reflect the newimua
branding. This update appears consistent and correct.
29-37
: Rebrand Service imuanode1
The configuration forimuanode1
has been updated similarly, including container name, image, and log file environment variable. Ensure that any service dependencies or network configurations remain valid.
54-62
: Rebrand Service imuanode2
Theimuanode2
service block updates, including container name, image reference, and volume paths, are correctly rebranded. Double-check that the volume mapping and IP address assignment remain consistent with network expectations.
79-87
: Rebrand Service imuanode3
The container settings forimuanode3
have been rebranded to use theimua
identifiers. The updates to the image and log variable are clear..goreleaser.yml (3)
8-22
: Update Build Configurations for imuad
The build configurations now reference new IDs (e.g.,imuad-darwin
), main entry point (./cmd/imuad
), binary name (bin/imuad
), and updated linker flags that replaceexocore
withimua
/imuad
. These changes are comprehensive and align with the rebranding.
23-67
: Review Additional Build Targets
The subsequent build configurations forimuad-darwin-arm64
,imuad-linux
,imuad-linux-arm64
, andimuad-windows
have been correctly updated with new paths and settings. Ensure that all compiler and linker flags are compatible with the target environments.
85-95
: Update Archive Build List
The archive configuration now includes the new build IDs forimuad
across different platforms. This ensures that releases include the correct artifacts under the new branding.proto/imuachain/feedistribution/v1/distribution.proto (2)
2-2
: Update Package Declaration
The package is updated toimuachain.feedistribution.v1
, which correctly reflects the new namespace for the distribution module.
8-8
: Update Go Package Option
Thego_package
option is correctly updated to"github.com/imua-xyz/imuachain/x/feedistribution/types"
. This helps ensure that generated code references the correct package path.cmd/imuachain-test-tool/README.md (5)
1-1
: Rebranding Confirmation for Tool Name
The tool’s title has been updated to “imua-test-tool” in accordance with the new branding guidelines.
3-4
: Consistent Rebranding in Description
The description now clearly refers to “Imuachain chain,” ensuring consistency throughout with the new identity.
21-24
: Token Reference Update Verification
References to tokens have been updated to “IMUA tokens,” which aligns with the rebranding. Please double-check that all related documentation and configurations are in sync.
61-69
: Command Examples Reflect New Branding
The command blocks (e.g., “imua-test-tool init --home” and “imua-test-tool start --home .”) have been updated correctly. This reinforces consistency in how new commands are presented.
111-114
: Todo Section Update
The todo item now specifies “Provide batch testing for IMUA tokens.” This update is consistent with the new naming; just ensure that any accompanying implementation follows suit.proto/imuachain/dogfood/v1/query.proto (10)
3-3
: Package Renaming
The package declaration is now “imuachain.dogfood.v1,” which correctly reflects the rebranding effort.
7-8
: Updated Import Paths
The imports for “dogfood.proto” and “params.proto” now use the “imuachain/dogfood/v1/” path. Ensure that these file paths are correct within the repository structure.
12-12
: go_package Option Update
The go_package option has been updated to “github.com/imua-xyz/imuachain/x/dogfood/types,” ensuring that package references follow the new naming convention.
17-19
: RPC Endpoint Update for Params
The HTTP GET endpoint has been updated to “/imuachain/dogfood/v1/params.” This change accurately reflects the new namespace in the API paths.
22-26
: RPC Endpoint Update for OptOutsToFinish
The endpoint is now “/imuachain/dogfood/v1/opt_outs_to_finish/{epoch}.” This proper renaming helps maintain API consistency.
28-32
: RPC Endpoint Update for OperatorOptOutFinishEpoch
The HTTP GET endpoint has been revised to “/imuachain/dogfood/v1/operator_opt_out_finish_epoch/{operator_acc_addr},” which aligns with the new structure.
34-38
: RPC Endpoint Update for UndelegationsToMature
The endpoint now reads “/imuachain/dogfood/v1/undelegations_to_mature/{epoch}.” This change is consistent with the overall rebranding.
40-44
: RPC Endpoint Update for UndelegationMaturityEpoch
The HTTP GET path has been updated to “/imuachain/dogfood/v1/undelegation_maturity_epoch/{record_key}.” Good job maintaining uniformity in API endpoints.
46-51
: RPC Endpoint Update for Validator
The endpoint now uses “/imuachain/dogfood/v1/validator/{cons_addr}.” This change accurately reflects the new brand identity in the service definition.
53-58
: RPC Endpoint Update for Validators
The updated endpoint “/imuachain/dogfood/v1/validators” confirms the rebranding across all RPC methods.proto/imuachain/assets/v1/query.proto (12)
2-2
: Package Declaration Update
The package has been updated from the old naming to “imuachain.assets.v1,” which is key to the rebranding process.
7-9
: Import Paths Reflect Namespace Change
The update of import statements to “imuachain/assets/v1/genesis.proto,” “imuachain/assets/v1/params.proto,” and “imuachain/assets/v1/tx.proto” is correctly applied.
13-13
: go_package Option Revision
The go_package option now correctly points to “github.com/imua-xyz/imuachain/x/assets/types.”
105-107
: RPC Endpoint Update for Params
The HTTP GET method for the Params request is now set to “/imuachain/assets/v1/params.” This update is critical for API consistency.
110-113
: RPC Endpoint Update for ClientChainInfoByIndex
The endpoint now reads “/imuachain/assets/v1/client_chain/{chain_index}.” This change achieves consistency with the new naming standards.
114-118
: RPC Endpoint Update for AllClientChainInfo
The endpoint has been updated to “/imuachain/assets/v1/all_client_chains,” ensuring uniformity across query services.
119-123
: RPC Endpoint Update for StakingAssetInfo
The HTTP GET endpoint is now “/imuachain/assets/v1/asset/{asset_id}.” This clear update aligns the API with the rebranded assets module.
124-128
: RPC Endpoint Update for AllStakingAssetsInfo
The endpoint change to “/imuachain/assets/v1/all_assets” properly reflects the new namespace.
129-133
: RPC Endpoint Update for StakerAssetInfos
The endpoint updated to “/imuachain/assets/v1/staker_assets/{staker_id}” continues the consistent naming pattern.
134-138
: RPC Endpoint Update for StakerSpecifiedAssetAmount
The HTTP GET path is now “/imuachain/assets/v1/staker_asset/{staker_id}/{asset_id},” aligning this query with the new brand.
139-143
: RPC Endpoint Update for OperatorAssetInfos
The endpoint “/imuachain/assets/v1/operator_assets/{operator_addr}” clearly reflects the rebranding.
144-148
: RPC Endpoint Update for OperatorSpecifiedAssetAmount
The updated endpoint “/imuachain/assets/v1/operator_asset/{operator_addr}/{asset_id}” is consistent with the overall transformation.proto/imuachain/operator/v1/genesis.proto (3)
2-2
: Package Renaming in Genesis Proto
The package declaration is now “imuachain.operator.v1,” which conforms with the new branding across modules.
5-6
: Updated Import for Operator Module
The import of “imuachain/operator/v1/tx.proto” ensures that related components are now referenced correctly under the new namespace.
8-8
: go_package Option Revision
The go_package option now points to “github.com/imua-xyz/imuachain/x/operator/types,” which is essential for maintaining consistent module referencing.proto/imuachain/assets/v1/tx.proto (7)
1-11
: Package and Import Updates
The package has been updated to “imuachain.assets.v1” and the go_package option now points to “github.com/imua-xyz/imuachain/x/assets/types.” Additionally, import paths (e.g., for “imuachain/assets/v1/params.proto”) reflect the new namespace.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
4-4
: Review Import for Amino Proto
The import statement for “amino/amino.proto” is triggering a static analysis warning. Please verify that this import path is correct and that the referenced file exists in the codebase.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
23-33
: ClientChainInfo Field Update
In the ClientChainInfo message, the field has been updated from “exocore_chain_index” to “imua_chain_index.” This change is consistent with the overall rebranding and helps clarify the context of the field within the new system.
44-60
: AssetInfo Field Update
The AssetInfo message now uses “imua_chain_index” in place of the previous “exocore_chain_index.” This is an important change that aligns the data structure with the new branding conventions.
168-179
: RegisterAssetReq Comment Update
The comment in the RegisterAssetReq message now specifies “Imuachain” instead of “Exocore,” ensuring that documentation and in-code comments remain consistent.
203-206
: RPC Endpoint Update for MsgUpdateParams
The HTTP POST endpoint has been updated to “/imuachain/assets/v1/tx/MsgUpdateParams,” which properly reflects the rebranding of the assets module’s transaction endpoints.
207-210
: Deprecated/Removed RPC Methods
The commented-out sections indicate the removal of Exocore-specific RPC methods (e.g., MsgSetExoCoreAddr). Ensure that this removal is intentional and that all dependent components have been updated accordingly.go.mod (3)
1-1
: Module Renaming Confirmation
The module name has been updated togithub.com/imua-xyz/imuachain
per the rebranding effort. This change is correct and consistent.
26-26
: Updated Price Feeder Dependency
The dependency ongithub.com/imua-xyz/price-feeder
is now set to versionv0.1.16-0.20250219142917-5ea492552d53
. Please double-check that this version resolves as expected in your dependency graph.
277-278
: Replacement Directive for Evmos Fork Updated
The replacement forgithub.com/evmos/evmos/v16
has been updated to point to the Imua fork. Ensure that the chosen version (v16.0.3-0.20240828081344-d5cfcd34a812
) is compatible with the rest of the codebase.local_node.sh (9)
6-6
: CHAINID Branding Update
The chain ID has been updated to"imualocalnet_232-1"
to reflect the rebranding. This change looks correct.
15-15
: Home Directory Update
The dedicated home directory for the node instance has been changed from"$HOME/.tmp-exocored"
to"$HOME/.tmp-imuad"
, which aligns with the new binary name.
68-70
: Configuration Commands Updated for New Binary
The configuration commands usingimuad config
now correctly set the keyring backend and chain ID with the updated home directory. Ensure that downstream scripts or tools calling these commands are updated accordingly.
77-77
: Key Recovery Command Adjustment
The recovery command now pipes the mnemonic into the updatedimuad
binary to add a key with recovery mode. This update is consistent with the rebranding.
81-88
: Validator Initialization and Key Parsing
The initialization command usingimuad init
and subsequent key parsing commands (obtaining local and consensus addresses) have been updated. Verify that the output addresses are correctly derived and used later in the genesis modifications.
122-122
: Operator Assets Update
The genesis update for setting operator assets now uses the new local operator address ($LOCAL_ADDRESS_IM
). This ensures consistency in the new naming context.
156-156
: Delegation Associations Update
The modification updating the delegation association to use the new operator address looks appropriate. Confirm the downstream modules correctly interpret these updated addresses.
240-244
: Oracle Feeder YAML Adjustments
The oracle feeder YAML now includes a newimua:
section with updated fields such aschainid
,appName
, and RPC settings. This change should help external tools to connect with the correct chain configuration.
339-339
: Node Start Command Updated
The command to start the node now usesimuad start
with the appropriate flags (metrics, log level, gas prices, API options, etc.). This is essential for a smooth transition to the new branding.Makefile (5)
9-11
: Updated Build Variables Reflect Rebranding
TheIMUACHAIN_BINARY
variable is now set toimuad
and the HTTPS Git URL is updated tohttps://github.com/imua-xyz/imuachain
. These changes are consistent with the project rename.
20-21
: Namespace and Project Variables Adjusted
TheNAMESPACE
andPROJECT
variables have been updated toimua-xyz
andimuachain
respectively. This ensures that all Docker image tags and repository references align with the new branding.
70-72
: Linker Flags Rebranding
The linker flags (ldflags
) now inject the new application name and binary name via the-X
flags. This is crucial for ensuring version information and binary identity are correctly reflected.
139-142
: Test Tool Build Commands Updated
The targets for building and installing the test tool now reference./cmd/imuachain-test-tool
. Confirm that the new test tool binary functions correctly within the CI/CD pipelines.
546-546
: Release Package Name Update
ThePACKAGE_NAME
variable has been updated togithub.com/imua-xyz/imuachain
in the release section. Ensure that all downstream tooling (such as Goreleaser) references this name correctly.proto/imuachain/appchain/subscriber/v1/tx.proto (2)
1-1
: Syntax Declaration is Correct.
The file begins with the proper proto3 syntax declaration.
5-5
: Go Package Option Update.
Thego_package
option is set correctly asgithub.com/imua-xyz/imuachain/x/appchain/subscriber/types
, matching the rebranding changes.proto/imuachain/oracle/v1/index_recent_msg.proto (3)
1-1
: Proto3 Syntax Declaration Check.
The file correctly declaressyntax = "proto3"
.
4-4
: Go Package Option Alignment.
Thego_package
option is nowgithub.com/imua-xyz/imuachain/x/oracle/types
, which is correct.
6-10
: Message Definition Confirmation.
The messageIndexRecentMsg
with itsrepeated uint64 index = 1;
field is defined properly.proto/imuachain/oracle/v1/index_recent_params.proto (3)
1-1
: Proto3 Syntax Check.
The file begins with the correct proto3 syntax declaration.
4-4
: Go Package Option Verification.
Thego_package
option is correctly set togithub.com/imua-xyz/imuachain/x/oracle/types
.
6-10
: Message Structure Assessment.
TheIndexRecentParams
message is defined with the expected field. All looks in order.proto/imuachain/oracle/v1/validator_update_block.proto (3)
1-1
: Proto3 Syntax Declaration Verification.
The file correctly declaressyntax = "proto3"
.
4-4
: Go Package Option Update.
Thego_package
option is updated correctly togithub.com/imua-xyz/imuachain/x/oracle/types
.
6-10
: Message Definition Assessment.
TheValidatorUpdateBlock
message and itsuint64 block = 1;
field are defined appropriately.proto/imuachain/assets/v1/params.proto (4)
1-1
: Proto3 Syntax Declaration Check.
The file correctly begins withsyntax = "proto3"
.
2-2
: Package Declaration Consistency.
The package is updated toimuachain.assets.v1
, which is in line with the overall rebranding effort. Please verify that the file is positioned in a directory consistent with this package naming convention.
6-6
: Go Package Option Verification.
Thego_package
option is correctly updated togithub.com/imua-xyz/imuachain/x/assets/types
, which accurately reflects the new branding.
8-12
: Message Definition and Comment Update.
TheParams
message is defined correctly. The comment update for thegateways
field to reference Imuachain is clear and appropriate.proto/imuachain/oracle/v1/recent_params.proto (2)
2-2
: Rebranding: Package Declaration UpdatedThe package declaration is now
imuachain.oracle.v1
, which correctly reflects the new branding.
6-6
: Go Package Option UpdatedThe
go_package
option has been updated to"github.com/imua-xyz/imuachain/x/oracle/types"
, which aligns with the new repository structure.proto/imuachain/reward/v1/genesis.proto (2)
2-2
: Rebranding: Package Declaration UpdatedThe package declaration has been updated to
imuachain.reward.v1
, in line with the project rebranding.
7-7
: Go Package Option UpdatedThe
go_package
option now points to"github.com/imua-xyz/imuachain/x/reward/types"
, which is consistent with the new naming conventions.proto/imuachain/immint/v1/genesis.proto (3)
2-2
: Rebranding: Package Declaration UpdatedThe package is now declared as
imuachain.immint.v1
, reflecting the new organizational structure.
7-7
: Go Package Option UpdatedThe
go_package
option has been updated to"github.com/imua-xyz/imuachain/x/immint/types"
, which fits with the new branding.
9-9
: Updated Module CommentThe comment on line 9 now states "GenesisState defines the immint module's genesis state," clearly reflecting the rebranding effort.
proto/imuachain/appchain/coordinator/v1/genesis.proto (2)
3-3
: Rebranding: Package Declaration UpdatedThe package declaration is now
imuachain.appchain.coordinator.v1
, which is aligned with the new naming scheme.
8-8
: Go Package Option UpdatedThe
go_package
option now points to"github.com/imua-xyz/imuachain/x/appchain/coordinator/types"
, which is correct.proto/imuachain/slash/v1/genesis.proto (3)
2-2
: Rebranding: Package Declaration UpdatedThe package has been updated to
imuachain.slash.v1
, which is in line with the overall rebranding.
8-8
: Go Package Option UpdatedThe
go_package
option has been updated to"github.com/imua-xyz/imuachain/x/slash/types"
, consistent with the new structure.
10-10
: Updated Module CommentThe comment now states "GenesisState defines the imuaslash module's genesis state," which clearly aligns with the new module name.
proto/imuachain/oracle/v1/prices.proto (2)
2-2
: Namespace Update Approved.
The package declaration is correctly updated toimuachain.oracle.v1
to reflect the rebranding effort.
7-7
: Go Package Option Updated.
Theoption go_package
declaration is updated tooption go_package = "github.com/imua-xyz/imuachain/x/oracle/types";which is correct according to the new repository paths.
proto/imuachain/oracle/v1/slashing.proto (1)
5-5
: Go Package Option Updated.
Thego_package
option has been updated correctly to the new repository path.proto/imuachain/epochs/v1/epochs.proto (1)
5-5
: Go Package Option Updated.
Thego_package
option is correctly set to"github.com/imua-xyz/imuachain/x/epochs/types"
.proto/imuachain/oracle/v1/nonce.proto (2)
2-2
: Namespace Update Approved.
The package declaration is updated toimuachain.oracle.v1
, which is consistent with the overall rebranding effort.
6-6
: Go Package Option Updated.
Thego_package
option is updated to the correct repository path.proto/imuachain/reward/v1/query.proto (2)
2-2
: Namespace Update Approved.
The package is correctly updated toimuachain.reward.v1
to align with the rebranding changes.
7-7
: Go Package Option and HTTP Endpoint Updated.
Both thego_package
and the HTTP endpoint (set at/imuachain/reward/v1/params
) are correctly updated to reflect the new branding.proto/imuachain/oracle/v1/recent_msg.proto (2)
2-2
: Namespace Update: Package Renaming
The package is correctly updated toimuachain.oracle.v1
to match the new branding. Ensure that all dependent code and documentation reference the new namespace.
7-7
: go_package Option Update
Thego_package
option has been updated to"github.com/imua-xyz/imuachain/x/oracle/types"
, which aligns with the new branding.proto/imuachain/slash/v1/query.proto (3)
2-2
: Namespace Update: Package Renaming
The package declaration is nowimuachain.slash.v1
. This change correctly reflects the rebranding.
8-8
: go_package Option Update
Thego_package
option is updated to"github.com/imua-xyz/imuachain/x/slash/types"
, which is consistent with the new brand structure.
14-15
: RPC HTTP Endpoint Update
The HTTP endpoint for theParams
RPC has been updated to/imuachain/slash/v1/params
, ensuring consistency with the new namespace.proto/imuachain/reward/v1/types.proto (3)
3-3
: Namespace Update: Package Renaming
The package declaration is updated toimuachain.reward.v1
, aligning with the rebranding efforts.
5-5
: Verify External Proto Import
Static analysis flags the import statementimport "cosmos/base/v1beta1/coin.proto";
as possibly unresolved. Please ensure the referenced proto file is accessible in your build environment or adjust the dependency configuration if necessary.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos/base/v1beta1/coin.proto": file does not exist
(COMPILE)
8-8
: go_package Option Update
Thego_package
option is now"github.com/imua-xyz/imuachain/x/reward/types"
, which is correctly updated.proto/imuachain/immint/v1/params.proto (3)
2-2
: Namespace Update: Package Renaming
The package is updated toimuachain.immint.v1
, which is in line with the rebranding.
4-4
: Verify External Proto Import
Static analysis indicates thatimport "cosmos_proto/cosmos.proto";
may not be available locally. Please verify that the dependency is correctly configured in your build environment.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
7-7
: go_package Option Update
Thego_package
option has been updated to"github.com/imua-xyz/imuachain/x/immint/types"
, which properly reflects the new structure.proto/imuachain/feedistribution/v1/query.proto (4)
2-2
: Namespace Update: Package Renaming
The package is nowimuachain.feedistribution.v1
, which aligns with the overall rebranding.
4-4
: Verify External Proto Import for Amino
Static analysis notes thatimport "amino/amino.proto";
may not exist in the repository. Please ensure that this dependency is correctly specified or update the import path to reference the proper location.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
9-9
: go_package Option Update
Thego_package
option is updated to"github.com/imua-xyz/imuachain/x/feedistribution/types"
, which is properly aligned with the new brand identity.
15-15
: RPC HTTP Endpoint Update
The HTTP endpoint for theParams
RPC is updated to/imuachain/feedistribution/v1/params
, ensuring consistency with the rebranded namespace.proto/imuachain/appchain/subscriber/v1/query.proto (3)
3-3
: Package Renaming Update
The package declaration has been updated toimuachain.appchain.subscriber.v1
as intended by the rebranding effort. Please ensure all dependent code references are updated accordingly.
9-9
: Go Package Option Update
Thego_package
option has been updated to"github.com/imua-xyz/imuachain/x/appchain/subscriber/types"
, which aligns with the new naming.
25-25
: Field Type Reference Update
The field withinQueryParamsResponse
now referencesimuachain.appchain.common.v1.SubscriberParams
as expected. This change helps maintain consistency in the namespace, so no further action is required here.proto/imuachain/reward/v1/tx.proto (3)
3-3
: Package Update for Reward Module
The package declaration has been updated toimuachain.reward.v1
in accordance with the rebranding objectives.
7-7
: Reward Module Params Import Update
The import has been modified to use"imuachain/reward/v1/params.proto"
, which is consistent with the new namespace. Please ensure this file exists in the expected location.
10-10
: Go Package Option Update for Reward Module
The option has been updated to"github.com/imua-xyz/imuachain/x/reward/types"
, which is correct for the new repository structure.proto/imuachain/dogfood/v1/tx.proto (4)
3-3
: Dogfood Module Package Update
The package is now declared asimuachain.dogfood.v1
, which aligns with the overall rebranding strategy.
7-7
: Dogfood Module Params Import Update
The import for"imuachain/dogfood/v1/params.proto"
is now updated. Please verify that this file exists in the new directory.
11-11
: Go Package Option Update for Dogfood Module
Thego_package
option is updated to"github.com/imua-xyz/imuachain/x/dogfood/types"
, matching the new branding requirements.
35-35
: RPC Endpoint Update
The HTTP endpoint forMsgUpdateParams
is now set to/imuachain/dogfood/v1/tx/MsgUpdateParams
, which mirrors the namespace change.proto/imuachain/oracle/v1/info.proto (2)
2-2
: Oracle Module Package Update
The package declaration is updated toimuachain.oracle.v1
, which is appropriate for the rebranding.
6-6
: Go Package Option Update for Oracle Module
Thego_package
option has been properly updated to"github.com/imua-xyz/imuachain/x/oracle/types"
, which complies with the rebranding changes.proto/imuachain/oracle/v1/native_token.proto (2)
3-3
: Native Token Package Update
The package has been updated toimuachain.oracle.v1
, reflecting the move away from the Exocore namespace.
7-7
: Go Package Option Update for Native Token
Thego_package
option now indicates"github.com/imua-xyz/imuachain/x/oracle/types"
, which is consistent with the updated repository structure.proto/imuachain/oracle/v1/tx.proto (4)
3-3
: Updated Package Declaration Reflecting Rebranding
The package declaration has been updated toimuachain.oracle.v1
, which aligns with the new Imua branding.
5-5
: Verify the Import Path for 'amino/amino.proto'
Static analysis indicates that the file"amino/amino.proto"
might not exist at the specified path. Please confirm that this dependency is available or update the path if needed.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
8-9
: Updated Import Paths for Dependent Proto Files
The import statements for"imuachain/oracle/v1/params.proto"
and"imuachain/oracle/v1/price.proto"
have been updated correctly. Ensure that these files are present at the new locations.
12-12
: Updated Go Package Option
Thego_package
option now points togithub.com/imua-xyz/imuachain/x/oracle/types
, which is consistent with the new repository structure.proto/imuachain/oracle/v1/token_feeder.proto (3)
2-2
: Updated Package Declaration
The package is updated toimuachain.oracle.v1
, matching the new rebranding standard.
4-4
: Verify the Import for 'gogoproto/gogo.proto'
Static analysis reports that"gogoproto/gogo.proto"
may not exist. Please verify that the file is available at the expected location or adjust the import path accordingly.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
6-6
: Updated Go Package Option
Thego_package
option has been updated togithub.com/imua-xyz/imuachain/x/oracle/types
. This change is properly aligned with the overall rebranding effort.proto/imuachain/appchain/coordinator/v1/tx.proto (6)
3-3
: Updated Package Declaration for Appchain Coordinator
The package has been updated toimuachain.appchain.coordinator.v1
, which is correct for the new branding.
5-5
: Validate Cosmos Protobuf Import
The import"cosmos/msg/v1/msg.proto"
is flagged by static analysis as potentially missing. Please ensure that this file is available or adjust the import to the correct path.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
7-7
: Revised Import for the Common Module
The path"imuachain/appchain/common/v1/common.proto"
now correctly references the updated location of common definitions.
11-11
: Updated Go Package Option for Appchain Coordinator
Thego_package
option has been revised togithub.com/imua-xyz/imuachain/x/appchain/coordinator/types
to match the new repository structure.
19-19
: Updated HTTP Endpoint for RPC Method
The HTTP endpoint in theRegisterSubscriberChain
RPC method now uses"/imuachain/appchain/coordinator/v1/tx/RegisterSubscriberChain"
, ensuring that the web interface reflects the new namespace.
50-50
: Updated Field Type for Subscriber Params
The field type forsubscriber_params
has been updated toimuachain.appchain.common.v1.SubscriberParams
, which is consistent with other namespace updates.proto/imuachain/delegation/v1/genesis.proto (4)
3-3
: Updated Package Declaration for Delegation Module
The package has been updated toimuachain.delegation.v1
, conforming to the overall rebranding strategy.
5-5
: Verify Query Proto Import in Delegation Module
The import"imuachain/delegation/v1/query.proto"
is new and is flagged by static analysis as possibly missing. Please verify that this file is present in the expected location or update the path accordingly.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "imuachain/delegation/v1/query.proto": file does not exist
(COMPILE)
6-6
: Updated TX Proto Import for Delegation
The import for"imuachain/delegation/v1/tx.proto"
is updated; ensure that this file exists in the new path.
9-9
: Updated Go Package Option for Delegation Module
Thego_package
option now points togithub.com/imua-xyz/imuachain/x/delegation/types
, which is consistent with the rebranding.proto/imuachain/avs/v1/genesis.proto (3)
2-2
: Updated Package Declaration for AVS Module
The package declaration is nowimuachain.avs.v1
, in line with the new Imua branding.
4-4
: Verify Transaction Proto Import in AVS Module
The import"imuachain/avs/v1/tx.proto"
has been updated; however, static analysis suggests that the file might not exist. Please confirm the file’s availability or update the path if necessary.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "imuachain/avs/v1/tx.proto": file does not exist
(COMPILE)
7-7
: Updated Go Package Option for AVS Module
Thego_package
option is updated togithub.com/imua-xyz/imuachain/x/avs/types
, keeping the generated code in sync with the new repository structure.proto/imuachain/epochs/v1/query.proto (6)
3-3
: Package Renaming Update
The package declaration has been updated toimuachain.epochs.v1
—this is correct and aligns with the rebranding efforts.
6-6
: Updated Import Path for Genesis
The import has been changed to referenceimuachain/epochs/v1/genesis.proto
. Please verify that the file exists in its new location so that the build does not break.
11-11
: Go Package Option Update
Thego_package
option is updated to"github.com/imua-xyz/imuachain/x/epochs/types"
. This correctly reflects the new repository structure.
17-17
: HTTP Endpoint Update for EpochInfos RPC
The HTTP GET endpoint for theEpochInfos
RPC has been updated to/imuachain/epochs/v1/epochs
, which is consistent with the new naming.
21-21
: HTTP Endpoint Update for CurrentEpoch RPC
The endpoint is now/imuachain/epochs/v1/current_epoch/{identifier}
. This update is clear and consistent with the rebrand.
25-25
: HTTP Endpoint Update for EpochInfo RPC
The endpoint has been updated to/imuachain/epochs/v1/epoch/{identifier}
ensuring consistency across all RPC methods.proto/imuachain/oracle/v1/genesis.proto (3)
3-3
: Package Renaming Update
The package declaration is nowimuachain.oracle.v1
as required by the rebranding. Ensure that all oracle modules reference this updated package.
5-13
: Updated Oracle Import Paths
The import statements have been updated to use the newimuachain/oracle/v1/
paths. Please double-check that files such asindex_recent_msg.proto
and the others exist at these new locations to avoid compilation errors.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "imuachain/oracle/v1/index_recent_msg.proto": file does not exist
(COMPILE)
16-16
: Go Package Option Update
Thego_package
option is set to"github.com/imua-xyz/imuachain/x/oracle/types"
. This correctly matches the new repository structure.proto/imuachain/epochs/v1/genesis.proto (3)
3-3
: Package Renaming Update
The package changed toimuachain.epochs.v1
correctly reflects the rebranded namespace.
9-9
: Go Package Option Update
The newgo_package
option"github.com/imua-xyz/imuachain/x/epochs/types"
is consistent with the new naming convention.
5-5
: Static Analysis Note on gogoproto Import
A static analysis hint flagged the import"gogoproto/gogo.proto"
. Please verify that the dependency is available or update the dependency management accordingly to avoid false negatives during compilation.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/params.proto (4)
2-2
: Package Renaming Update
The package declaration is updated toimuachain.oracle.v1
, which is in line with the overall rebranding.
5-6
: Updated Import Paths for Oracle Components
The import statements now use the new path format (imuachain/oracle/v1/
). Please ensure these files exist at the new locations.
10-10
: Go Package Option Update
Thego_package
option is correctly updated to"github.com/imua-xyz/imuachain/x/oracle/types"
.
4-4
: Static Analysis Note on Amino Import
A static analysis warning indicated that the fileamino/amino.proto
could not be found. Please verify whether this dependency is still needed or if the import path requires updating.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/genesis.proto (4)
2-2
: Package Renaming Update
The package declaration is nowimuachain.feedistribution.v1
—this correctly reflects the new branding.
5-6
: Updated Import Paths for Feedistribution Components
The import statements fordistribution.proto
andparams.proto
have been updated to the new naming convention. Please verify that these files exist in the specified locations.
9-9
: Go Package Option Update
Thego_package
option is changed to"github.com/imua-xyz/imuachain/x/feedistribution/types"
, which aligns with the new structure.
4-4
: Static Analysis Note on Amino Import
Static analysis indicates thatamino/amino.proto
was not found. Please verify if this dependency should be updated or removed from the proto file.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/assets/v1/genesis.proto (4)
2-2
: Package Renaming ConsistencyThe package declaration has been updated from
exocore.assets.v1
toimuachain.assets.v1
in line 2, which correctly reflects the rebranding effort.
5-6
: Updated Import PathsThe import statements in lines 5–6 have been updated to use
imuachain/assets/v1/params.proto
andimuachain/assets/v1/tx.proto
. This change ensures that the proto file dependencies correctly mirror the new project namespace.
9-9
: Updated Go Package OptionThe
go_package
option on line 9 now points to"github.com/imua-xyz/imuachain/x/assets/types"
which is perfectly in line with the repository’s rebranding.
4-4
: Static Analysis Note on cosmos_proto ImportThe static analysis tool flagged the import
"cosmos_proto/cosmos.proto"
on line 4. Please verify that this path is correct in your build environment or adjust the dependency if needed.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/avs/v1/query.proto (9)
2-2
: Package Renaming ConsistencyThe package declaration has been changed from
exocore.avs.v1
toimuachain.avs.v1
on line 2. This update is aligned with the overall rebranding.
5-5
: Updated Import PathThe import statement on line 5 now references
"imuachain/avs/v1/tx.proto"
, reflecting the new module structure. This looks good.
9-9
: Updated Go Package OptionThe updated
go_package
option on line 9—"github.com/imua-xyz/imuachain/x/avs/types"
—is consistent with the rebranding.
79-79
: Updated RPC HTTP OptionThe HTTP option in the RPC method for
QueryAVSInfo
now uses the endpoint/imuachain/avs/v1/QueryAVSInfo
(line 79), which is correct.
83-83
: Updated RPC HTTP Option for Task InfoThe HTTP option in the
QueryAVSTaskInfo
RPC method was updated to/imuachain/avs/v1/GetAVSTaskInfoReq
(line 83). Confirm that this endpoint naming meets API design conventions.
87-87
: Updated RPC HTTP Option for AVS Address QueryThe HTTP option for querying the AVS address by chain ID now points to
/imuachain/avs/v1/QueryAVSAddrByChainID/{chain}
(line 87), which is appropriate.
92-92
: Updated RPC HTTP Option for Submit Task ResultThe HTTP option on line 92 now uses
/imuachain/avs/v1/QuerySubmitTaskResult
, matching the new branding.
95-95
: Updated RPC HTTP Option for Challenge InfoThe HTTP option for
QueryChallengeInfo
in line 95 has been updated to/imuachain/avs/v1/QueryChallengeInfo
. This is consistent with the other changes.
4-4
: Static Analysis Note on cosmos_proto ImportSimilar to the previous file, the import
"cosmos_proto/cosmos.proto"
on line 4 was flagged. Please check that this dependency is correctly set up in your project.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/operator/v1/validator.proto (4)
2-2
: Package Renaming ConsistencyThe package declaration on line 2 has been updated to
imuachain.operator.v1
, which is correctly aligned with the new branding.
10-10
: Updated Go Package OptionThe
go_package
option on line 10 now correctly points to"github.com/imua-xyz/imuachain/x/operator/types"
.
4-4
: Static Analysis Note on Amino ImportThe import
"amino/amino.proto"
on line 4 triggered a warning regarding a missing file. Please review your dependency configuration to ensure that this path is correct.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
6-6
: Static Analysis Note on cosmos_proto ImportThe file
"cosmos_proto/cosmos.proto"
imported on line 6 was reported as missing. Verify that this dependency is available or update the path as necessary.proto/imuachain/delegation/v1/tx.proto (6)
2-2
: Package Renaming ConsistencyThe package declaration on line 2 has been updated from
exocore.delegation.v1
toimuachain.delegation.v1
, which is in line with the rebranding.
9-9
: Updated Go Package OptionThe
go_package
option on line 9 now points to"github.com/imua-xyz/imuachain/x/delegation/types"
, as required.
71-72
: Updated Transaction Hash CommentThe comment for
tx_hash
on line 71 now reflects the Imuachain chain instead of Exocore, which supports the rebranding.
73-74
: Updated Block Number CommentThe comment on line 73 for
block_number
now properly indicates it is for Imuachain.
77-79
: Updated Epoch CommentThe comment for
completed_epoch_number
starting at line 77 now refers to the Imuachain chain. This change is consistent with the overall update.
4-4
: Static Analysis Note on Amino ImportThe import
"amino/amino.proto"
on line 4 appears to be missing. Please confirm that the correct dependency or path is used.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/genesis.proto (4)
3-3
: Package Renaming ConsistencyThe package declaration on line 3 has been updated from
exocore.dogfood.v1
toimuachain.dogfood.v1
, which is appropriate for the rebranding.
6-6
: Updated Import PathThe import on line 6 now refers to
"imuachain/dogfood/v1/params.proto"
, ensuring consistency with the new namespace.
9-9
: Updated Go Package OptionThe
go_package
option on line 9 is updated to"github.com/imua-xyz/imuachain/x/dogfood/types"
, matching the current project name.
5-5
: Static Analysis Note on Amino ImportStatic analysis flagged the import
"amino/amino.proto"
on line 5 as missing. Please verify that the dependency is correctly specified or update the path as necessary.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/common/v1/common.proto (5)
3-3
: Rebranded Package Declaration.
The package declaration has been updated from Exocore to Imuachain. This change is straightforward and aligns with the new branding.
11-11
: Updated Go Package Option.
Thego_package
option has been updated to use the new repository path (github.com/imua-xyz/imuachain/...
). This ensures that generated code references the correct package.
28-29
: Revised Comment to Reflect Rebranding.
The comment fordistribution_transmission_channel
now refers to “Imuachain” instead of “Exocore,” which is consistent with the overall rebranding effort.
98-99
: Updated SubscriberGenesisState Comment.
The comment inSubscriberGenesisState
now states “it being provisioned by Imuachain…” ensuring that documentation is consistent with the new identity.
5-5
: Static Analysis Note on Import.
Static analysis flags the import of"amino/amino.proto"
as not found. Please verify that this file exists or adjust the import path if the proto definition has been relocated.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
app/ante/handler_options.go (1)
1-15
: General Consistency Check.
All other parts of the file remain unchanged. The refactored import paths look consistent with the new project structure.proto/imuachain/delegation/v1/query.proto (5)
2-2
: Rebranded Package Name.
The package has been changed toimuachain.delegation.v1
, which is consistent with the overall rebranding effort.
6-7
: Updated Import for Transaction Definitions.
The import for delegation transaction definitions now uses"imuachain/delegation/v1/tx.proto"
. Ensure that the file structure in the repository reflects this new path.
10-11
: Revised Go Package Option.
Thego_package
option now points to"github.com/imua-xyz/imuachain/x/delegation/types"
, correctly reflecting the new repository path.
178-223
: Updated HTTP Endpoints for Delegation Queries.
All RPC methods now use endpoints prefixed with/imuachain/delegation/v1/
instead of the old Exocore paths. This update is critical to ensuring that API consumers connect to the rebranded endpoints. Please verify that clients and integration tests are updated accordingly.
4-4
: Static Analysis Note on Import.
Buf is flagging the import"cosmos/query/v1/query.proto"
as missing. Confirm whether this proto file is available in the expected location or if the import should be updated.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos/query/v1/query.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/query.proto (5)
3-3
: Rebranded Package Declaration.
The package is now declared asimuachain.oracle.v1
, which is consistent with the overall renaming.
6-14
: Updated Oracle Imports.
The import statements for various oracle-related proto files have been updated to reference the newimuachain/oracle/v1/
directory. Confirm that all referenced proto files are present and correct.
18-18
: Revised Go Package Option for Oracle.
Thego_package
option now correctly points to"github.com/imua-xyz/imuachain/x/oracle/types"
.
24-95
: Updated HTTP Options in Oracle RPC Methods.
All HTTP endpoint options (for methods likeTokenIndexes
,StakerList
,StakerInfos
, etc.) have been updated with the/imuachain/oracle/v1/
prefix. These changes ensure that the API endpoints are consistent with the new branding. Please ensure that all client references are updated accordingly.
5-5
: Static Analysis Note on Pagination Import.
Buf reports that"cosmos/base/query/v1beta1/pagination.proto"
cannot be found. Please check if the file exists, or update the import path if necessary.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
proto/imuachain/operator/v1/query.proto (5)
2-2
: Rebranded Package Declaration.
The package has been updated toimuachain.operator.v1
, aligning it with the new project name.
4-7
: Updated and Verified Import Statements.
The import paths now reference the newimuachain/operator/v1/
modules and related files. Note that the import"amino/amino.proto"
still appears; verify that the file exists or update the import if needed.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
14-14
: Revised Go Package Option for Operator.
Thego_package
option has been updated to"github.com/imua-xyz/imuachain/x/operator/types"
, ensuring consistency across generated code.
274-368
: Updated HTTP Endpoints for Operator Queries.
All RPC method HTTP options have been changed to use the new/imuachain/operator/v1/
endpoints. Changes include endpoints for operator info, consensus key/address queries, and snapshot-related queries. These updates are crucial for client integration with the rebranded service. Verify that all path parameters (e.g.{operator_addr}
,{chain}
) are correctly passed from client requests.
4-4
: Static Analysis Note on Import.
Buf flags the import"amino/amino.proto"
as not found. Please ensure that this proto file is accessible in the repository or modify the import accordingly.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🔭 Outside diff range comments (1)
proto/imuachain/epochs/v1/epochs.proto (1)
1-11
:⚠️ Potential issueDirectory Structure Warning
According to the Buf static analysis hint, files with the package name
imuachain.epochs.v1
should reside under a directoryimuachain/epochs/v1
relative to the repository root. Currently, the file is located inproto/imuachain/epochs/v1
. Please verify and, if necessary, update the file location to avoid potential package-directory mismatches during compilation.🧰 Tools
🪛 Buf (1.47.2)
3-3: Files with package "imuachain.epochs.v1" must be within a directory "imuachain/epochs/v1" relative to root but were in directory "proto/imuachain/epochs/v1".
(PACKAGE_DIRECTORY_MATCH)
🧹 Nitpick comments (16)
cmd/imuad/main.go (1)
35-38
: Address the TODO comment about observability.There's a commented-out block regarding observability that needs attention.
Would you like me to help implement the observability fix or create an issue to track this task?
testutil/tx/cosmos.go (1)
20-20
: Update comment to reflect new branding.The comment still references EVMOS which should be updated to IMUA to maintain consistency with the rebranding.
- DefaultFee = sdk.NewCoin(utils.BaseDenom, sdk.NewIntFromUint64(uint64(feeAmt))) // 0.01 EVMOS + DefaultFee = sdk.NewCoin(utils.BaseDenom, sdk.NewIntFromUint64(uint64(feeAmt))) // 0.01 IMUAprecompiles/reward/reward.go (1)
135-135
: Maintain consistent casing in logger module name.For consistency with the project name "Imua", consider updating the logger module name casing.
- return ctx.Logger().With("Imuachain module", "reward") + return ctx.Logger().With("Imua module", "reward")scripts/protocgen.sh (1)
11-11
: Cleanup Commented Code.
The commented-out line (#proto_dirs="proto/imua/reward/v1beta1"
) appears to reference a previously used directory path. If this is no longer needed, consider removing it to reduce clutter; otherwise, add a clarifying comment.networks/local/imuachain/Dockerfile (1)
7-8
: Remove Legacy Comments.
The commented-out lines referencing the old build command (e.g.,#COPY ./imuad /go/work/build
) appear to be leftover from previous iterations. If they are no longer needed, consider removing them for clarity.scripts/start-docker.sh (2)
4-4
: Chain ID Finalization Reminder
The TODO comment indicates that the Imua testnet chain ID is still under review. Be sure to finalize and update this value when a decision is reached.
18-18
: Review Transaction Signing Command
Theimuad gentx
command has been updated for the new branding; however, note that the--keyring-backend test
flag appears twice. Consider removing the duplicate flag to avoid any potential issues.proto/imuachain/feedistribution/v1/distribution.proto (1)
4-4
: Verify the import for amino.proto.Static analysis indicates that the file
"amino/amino.proto"
might not exist—please confirm whether this file has been relocated or renamed in the new repository structure.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
cmd/imuachain-test-tool/README.md (1)
7-7
: Revisit the use of "precompile" as a noun.The phrase “the precompile's gateway contract address check” might be nonstandard. Consider rephrasing (for example, “the gateway contract address check for precompiled contracts”) to improve clarity.
🧰 Tools
🪛 LanguageTool
[grammar] ~7-~7: The verb ‘precompile’ does not usually follow articles like ‘the’. Check that ‘precompile’ is spelled correctly; using ‘precompile’ as a noun may be non-standard.
Context: ...se, with the node configured to disable the precompile's gateway contract address check. The b...(A_INFINITIVE)
proto/imuachain/slash/v1/params.proto (1)
1-7
: New Proto File for Slash Module
A new Protocol Buffers file has been added to define the parameters for the slash module. The syntax, package declaration, and go_package option are all updated to reflect the Imuachain branding.Important Note:
Static analysis (Buf) reports a potential mismatch in the expected directory structure. The package is declared asimuachain.slash.v1
, which—by default—should reside in a directory path likeimuachain/slash/v1
relative to the repository root. If your project intentionally places proto files underproto/imuachain/slash/v1
(and you rely on Buf’s dependency configuration to handle this), please ensure that the Buf configuration is updated accordingly to avoid false positives.🧰 Tools
🪛 Buf (1.47.2)
2-2: Files with package "imuachain.slash.v1" must be within a directory "imuachain/slash/v1" relative to root but were in directory "proto/imuachain/slash/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/oracle/v1/slashing.proto (1)
9-9
: Typographical Note
The comment on line 9 refers to "validtor" which appears to be a typo. Consider correcting it to "validator" for clarity.proto/imuachain/reward/v1/tx.proto (1)
5-5
: Cosmos Proto Import Review
Static analysis flaggedimport "cosmos/msg/v1/msg.proto";
as the file does not exist. Please verify that this dependency is still required in the new context or update the import path accordingly.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/params.proto (1)
5-5
: Cosmos Proto Import Verification
Static analysis indicates thatimport "cosmos_proto/cosmos.proto";
may not exist. Please confirm whether the dependency is available or if the import path should be updated for compatibility.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/coordinator/v1/params.proto (1)
5-5
: gogoproto Import Check
The file imports"gogoproto/gogo.proto"
, which is flagged by static analysis as potentially missing. Verify that this dependency is correctly set up in your build environment.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/info.proto (1)
4-4
: gogoproto Import Verification
The import"gogoproto/gogo.proto"
is flagged by static analysis as not found. Please verify whether this file is provided in the build or if the dependency needs adjustment.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/price.proto (1)
5-5
: gogoproto Import Reassessment
The import of"gogoproto/gogo.proto"
is flagged by static analysis. Confirm that this dependency is present in your development environment or adjust the import if necessary.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (19)
go.sum
is excluded by!**/*.sum
x/appchain/common/types/common.pb.go
is excluded by!**/*.pb.go
x/appchain/coordinator/types/coordinator.pb.go
is excluded by!**/*.pb.go
x/appchain/coordinator/types/genesis.pb.go
is excluded by!**/*.pb.go
x/appchain/coordinator/types/params.pb.go
is excluded by!**/*.pb.go
x/appchain/coordinator/types/query.pb.go
is excluded by!**/*.pb.go
x/appchain/coordinator/types/query.pb.gw.go
is excluded by!**/*.pb.gw.go
x/appchain/coordinator/types/tx.pb.go
is excluded by!**/*.pb.go
x/appchain/coordinator/types/tx.pb.gw.go
is excluded by!**/*.pb.gw.go
x/appchain/subscriber/types/genesis.pb.go
is excluded by!**/*.pb.go
x/appchain/subscriber/types/query.pb.go
is excluded by!**/*.pb.go
x/appchain/subscriber/types/query.pb.gw.go
is excluded by!**/*.pb.gw.go
x/appchain/subscriber/types/tx.pb.go
is excluded by!**/*.pb.go
x/assets/types/genesis.pb.go
is excluded by!**/*.pb.go
x/assets/types/params.pb.go
is excluded by!**/*.pb.go
x/assets/types/query.pb.go
is excluded by!**/*.pb.go
x/assets/types/query.pb.gw.go
is excluded by!**/*.pb.gw.go
x/assets/types/tx.pb.go
is excluded by!**/*.pb.go
x/assets/types/tx.pb.gw.go
is excluded by!**/*.pb.gw.go
📒 Files selected for processing (207)
.github/PULL_REQUEST_TEMPLATE.md
(2 hunks).github/workflows/consensuswarn.yml
(2 hunks).github/workflows/lint.yml
(1 hunks).github/workflows/proto.yml
(3 hunks).github/workflows/security.yml
(1 hunks).github/workflows/semgrep.yml
(1 hunks).github/workflows/super-linter.yml
(1 hunks).goreleaser.yml
(6 hunks)CONTRIBUTING.md
(10 hunks)Dockerfile
(3 hunks)Makefile
(10 hunks)README.md
(2 hunks)app/ante/cosmos/context.go
(1 hunks)app/ante/cosmos/fees.go
(1 hunks)app/ante/cosmos/min_price.go
(1 hunks)app/ante/cosmos/sigverify.go
(1 hunks)app/ante/cosmos/txsize_gas.go
(1 hunks)app/ante/evm/fee_checker.go
(1 hunks)app/ante/evm/fee_market.go
(1 hunks)app/ante/handler_options.go
(1 hunks)app/ante/sigverify.go
(1 hunks)app/ante/utils/oracle.go
(1 hunks)app/app.go
(37 hunks)app/ethtest_helper.go
(2 hunks)app/export.go
(3 hunks)app/forks.go
(1 hunks)app/test_helpers.go
(6 hunks)client/docs/config.json
(4 hunks)client/export.go
(1 hunks)cmd/config/config.go
(2 hunks)cmd/imuachain-test-tool/README.md
(3 hunks)cmd/imuachain-test-tool/main.go
(8 hunks)cmd/imuad/init.go
(1 hunks)cmd/imuad/main.go
(2 hunks)cmd/imuad/root.go
(7 hunks)cmd/imuad/testnet.go
(7 hunks)docker-compose.yml
(5 hunks)go.mod
(3 hunks)init.bat
(3 hunks)local_node.sh
(10 hunks)networks/Makefile
(1 hunks)networks/init-node.sh
(1 hunks)networks/local/Makefile
(1 hunks)networks/local/imuachain/Dockerfile
(2 hunks)networks/local/imuachain/wrapper.sh
(1 hunks)precompiles/assets/IAssets.sol
(6 hunks)precompiles/assets/assets.go
(2 hunks)precompiles/assets/assets_integrate_test.go
(6 hunks)precompiles/assets/assets_test.go
(5 hunks)precompiles/assets/decode_helper.go
(9 hunks)precompiles/assets/query.go
(1 hunks)precompiles/assets/setup_test.go
(1 hunks)precompiles/assets/tx.go
(5 hunks)precompiles/assets/types.go
(5 hunks)precompiles/avs/IAVSManager.sol
(5 hunks)precompiles/avs/avs.go
(1 hunks)precompiles/avs/avs_test.go
(6 hunks)precompiles/avs/events.go
(1 hunks)precompiles/avs/query.go
(9 hunks)precompiles/avs/query_test.go
(5 hunks)precompiles/avs/setup_test.go
(1 hunks)precompiles/avs/tx.go
(10 hunks)precompiles/avs/types.go
(6 hunks)precompiles/avs/utils_test.go
(2 hunks)precompiles/bech32/IBech32.sol
(1 hunks)precompiles/bech32/bech32_test.go
(4 hunks)precompiles/bech32/methods.go
(2 hunks)precompiles/bech32/methods_test.go
(1 hunks)precompiles/bech32/setup_test.go
(1 hunks)precompiles/bls/IBLS.sol
(1 hunks)precompiles/bls/bls.go
(1 hunks)precompiles/bls/bls_test.go
(1 hunks)precompiles/bls/setup_test.go
(1 hunks)precompiles/delegation/IDelegation.sol
(5 hunks)precompiles/delegation/delegation.go
(2 hunks)precompiles/delegation/delegation_test.go
(7 hunks)precompiles/delegation/setup_test.go
(1 hunks)precompiles/delegation/tx.go
(8 hunks)precompiles/delegation/types.go
(4 hunks)precompiles/reward/claimReward.sol
(1 hunks)precompiles/reward/methods.go
(2 hunks)precompiles/reward/parser.go
(3 hunks)precompiles/reward/reward.go
(3 hunks)precompiles/reward/reward_test.go
(2 hunks)precompiles/reward/setup_test.go
(1 hunks)precompiles/slash/methods.go
(2 hunks)precompiles/slash/parser.go
(3 hunks)precompiles/slash/setup_test.go
(2 hunks)precompiles/slash/slash.go
(2 hunks)precompiles/slash/slash.sol
(1 hunks)precompiles/slash/slash_test.go
(1 hunks)precompiles/testutil/contracts/contracts.go
(3 hunks)proto/exocore/appchain/subscriber/v1/genesis.proto
(0 hunks)proto/exocore/appchain/subscriber/v1/tx.proto
(0 hunks)proto/exocore/reward/v1/params.proto
(0 hunks)proto/exocore/slash/v1/params.proto
(0 hunks)proto/imuachain/appchain/common/v1/common.proto
(3 hunks)proto/imuachain/appchain/coordinator/v1/coordinator.proto
(1 hunks)proto/imuachain/appchain/coordinator/v1/genesis.proto
(1 hunks)proto/imuachain/appchain/coordinator/v1/params.proto
(2 hunks)proto/imuachain/appchain/coordinator/v1/query.proto
(3 hunks)proto/imuachain/appchain/coordinator/v1/tx.proto
(2 hunks)proto/imuachain/appchain/subscriber/v1/genesis.proto
(1 hunks)proto/imuachain/appchain/subscriber/v1/query.proto
(2 hunks)proto/imuachain/appchain/subscriber/v1/tx.proto
(1 hunks)proto/imuachain/assets/v1/genesis.proto
(1 hunks)proto/imuachain/assets/v1/params.proto
(1 hunks)proto/imuachain/assets/v1/query.proto
(2 hunks)proto/imuachain/assets/v1/tx.proto
(5 hunks)proto/imuachain/avs/v1/genesis.proto
(1 hunks)proto/imuachain/avs/v1/query.proto
(2 hunks)proto/imuachain/avs/v1/tx.proto
(2 hunks)proto/imuachain/delegation/v1/genesis.proto
(1 hunks)proto/imuachain/delegation/v1/query.proto
(2 hunks)proto/imuachain/delegation/v1/tx.proto
(2 hunks)proto/imuachain/dogfood/v1/dogfood.proto
(1 hunks)proto/imuachain/dogfood/v1/genesis.proto
(1 hunks)proto/imuachain/dogfood/v1/params.proto
(1 hunks)proto/imuachain/dogfood/v1/query.proto
(3 hunks)proto/imuachain/dogfood/v1/tx.proto
(2 hunks)proto/imuachain/epochs/v1/epochs.proto
(1 hunks)proto/imuachain/epochs/v1/genesis.proto
(1 hunks)proto/imuachain/epochs/v1/query.proto
(1 hunks)proto/imuachain/feedistribution/v1/distribution.proto
(1 hunks)proto/imuachain/feedistribution/v1/genesis.proto
(1 hunks)proto/imuachain/feedistribution/v1/params.proto
(1 hunks)proto/imuachain/feedistribution/v1/query.proto
(1 hunks)proto/imuachain/feedistribution/v1/tx.proto
(2 hunks)proto/imuachain/immint/v1/genesis.proto
(1 hunks)proto/imuachain/immint/v1/params.proto
(1 hunks)proto/imuachain/immint/v1/query.proto
(1 hunks)proto/imuachain/immint/v1/tx.proto
(2 hunks)proto/imuachain/operator/v1/genesis.proto
(2 hunks)proto/imuachain/operator/v1/query.proto
(2 hunks)proto/imuachain/operator/v1/tx.proto
(5 hunks)proto/imuachain/operator/v1/validator.proto
(1 hunks)proto/imuachain/oracle/v1/genesis.proto
(1 hunks)proto/imuachain/oracle/v1/index_recent_msg.proto
(1 hunks)proto/imuachain/oracle/v1/index_recent_params.proto
(1 hunks)proto/imuachain/oracle/v1/info.proto
(1 hunks)proto/imuachain/oracle/v1/native_token.proto
(1 hunks)proto/imuachain/oracle/v1/nonce.proto
(1 hunks)proto/imuachain/oracle/v1/params.proto
(1 hunks)proto/imuachain/oracle/v1/price.proto
(1 hunks)proto/imuachain/oracle/v1/prices.proto
(1 hunks)proto/imuachain/oracle/v1/query.proto
(1 hunks)proto/imuachain/oracle/v1/recent_msg.proto
(1 hunks)proto/imuachain/oracle/v1/recent_params.proto
(1 hunks)proto/imuachain/oracle/v1/slashing.proto
(1 hunks)proto/imuachain/oracle/v1/token_feeder.proto
(1 hunks)proto/imuachain/oracle/v1/tx.proto
(1 hunks)proto/imuachain/oracle/v1/validator_update_block.proto
(1 hunks)proto/imuachain/reward/v1/genesis.proto
(1 hunks)proto/imuachain/reward/v1/params.proto
(1 hunks)proto/imuachain/reward/v1/query.proto
(1 hunks)proto/imuachain/reward/v1/tx.proto
(1 hunks)proto/imuachain/reward/v1/types.proto
(1 hunks)proto/imuachain/slash/v1/genesis.proto
(1 hunks)proto/imuachain/slash/v1/params.proto
(1 hunks)proto/imuachain/slash/v1/query.proto
(1 hunks)proto/imuachain/slash/v1/tx.proto
(1 hunks)scripts/protoc-swagger-gen.sh
(1 hunks)scripts/protocgen.sh
(1 hunks)scripts/start-docker.sh
(1 hunks)tests/e2e/oracle/create_price.go
(1 hunks)tests/e2e/oracle/data.go
(1 hunks)tests/e2e/oracle/oracle_test.go
(1 hunks)tests/e2e/oracle/recovery.go
(1 hunks)tests/e2e/oracle/suite.go
(1 hunks)testutil/abci.go
(11 hunks)testutil/ante.go
(1 hunks)testutil/batch/batch_tx.go
(3 hunks)testutil/batch/manager.go
(4 hunks)testutil/batch/manager_test.go
(6 hunks)testutil/batch/prepare.go
(3 hunks)testutil/batch/send_txs.go
(1 hunks)testutil/batch/tx_check.go
(2 hunks)testutil/batch/type.go
(3 hunks)testutil/batch/utils.go
(6 hunks)testutil/contract.go
(4 hunks)testutil/fund.go
(2 hunks)testutil/integration.go
(4 hunks)testutil/keeper/feedistribute.go
(1 hunks)testutil/keeper/oracle.go
(1 hunks)testutil/network/genesis_data.go
(1 hunks)testutil/network/network.go
(5 hunks)testutil/network/network_test.go
(2 hunks)testutil/network/query.go
(1 hunks)testutil/network/util.go
(2 hunks)testutil/statedb.go
(1 hunks)testutil/tx/cosmos.go
(5 hunks)testutil/tx/eip712.go
(7 hunks)testutil/tx/eth.go
(4 hunks)testutil/tx/signer.go
(1 hunks)testutil/utils.go
(7 hunks)types/errors.go
(1 hunks)types/keys/consensus.go
(2 hunks)types/keys/consensus_test.go
(1 hunks)types/validation_test.go
(1 hunks)utils/store.go
(1 hunks)utils/utils.go
(2 hunks)utils/utils_test.go
(3 hunks)x/appchain/coordinator/client/cli/query.go
(1 hunks)x/appchain/coordinator/client/cli/tx.go
(1 hunks)x/appchain/coordinator/keeper/genesis.go
(1 hunks)x/appchain/coordinator/keeper/grpc_query.go
(1 hunks)x/appchain/coordinator/keeper/ibc_client.go
(2 hunks)
⛔ Files not processed due to max files limit (70)
- x/appchain/coordinator/keeper/identifiers.go
- x/appchain/coordinator/keeper/impl_epochs_hooks.go
- x/appchain/coordinator/keeper/keeper.go
- x/appchain/coordinator/keeper/msg_server.go
- x/appchain/coordinator/keeper/params.go
- x/appchain/coordinator/keeper/register.go
- x/appchain/coordinator/keeper/slash.go
- x/appchain/coordinator/keeper/timeout.go
- x/appchain/coordinator/module.go
- x/appchain/coordinator/types/expected_keepers.go
- x/appchain/coordinator/types/keys.go
- x/appchain/coordinator/types/msg.go
- x/appchain/coordinator/types/params.go
- x/appchain/coordinator/types/params_test.go
- x/appchain/subscriber/client/cli/query.go
- x/appchain/subscriber/client/cli/tx.go
- x/appchain/subscriber/keeper/genesis.go
- x/appchain/subscriber/keeper/grpc_query.go
- x/appchain/subscriber/keeper/msg_server.go
- x/appchain/subscriber/keeper/params.go
- x/appchain/subscriber/module.go
- x/appchain/subscriber/types/genesis.go
- x/assets/client/cli/query.go
- x/assets/client/cli/tx.go
- x/assets/keeper/bank.go
- x/assets/keeper/client_chain.go
- x/assets/keeper/client_chain_and_asset_test.go
- x/assets/keeper/client_chain_asset.go
- x/assets/keeper/exocore_addr.go
- x/assets/keeper/expected_keepers.go
- x/assets/keeper/genesis.go
- x/assets/keeper/grpc_query.go
- x/assets/keeper/keeper.go
- x/assets/keeper/msg_server.go
- x/assets/keeper/operator_asset.go
- x/assets/keeper/params.go
- x/assets/keeper/params_test.go
- x/assets/keeper/setup_test.go
- x/assets/keeper/staker_asset.go
- x/assets/keeper/staker_asset_test.go
- x/assets/module.go
- x/assets/types/codec.go
- x/assets/types/events.go
- x/assets/types/expected_keepers.go
- x/assets/types/general.go
- x/assets/types/genesis.go
- x/assets/types/genesis_test.go
- x/assets/types/keys.go
- x/assets/types/msg.go
- x/avs/client/cli/query.go
- x/avs/client/cli/tx.go
- x/avs/keeper/avs.go
- x/avs/keeper/avs_test.go
- x/avs/keeper/bls_test.go
- x/avs/keeper/epoch_test.go
- x/avs/keeper/genesis.go
- x/avs/keeper/impl_epoch_hook.go
- x/avs/keeper/keeper.go
- x/avs/keeper/miscellaneous_test.go
- x/avs/keeper/msg_server.go
- x/avs/keeper/multi_operator_submit_task_test.go
- x/avs/keeper/params.go
- x/avs/keeper/query.go
- x/avs/keeper/setup_test.go
- x/avs/keeper/submit_task_test.go
- x/avs/keeper/task.go
- x/avs/keeper/task_test.go
- x/avs/module.go
- x/avs/types/expected_keepers.go
- x/avs/types/genesis.go
💤 Files with no reviewable changes (4)
- proto/exocore/slash/v1/params.proto
- proto/exocore/appchain/subscriber/v1/tx.proto
- proto/exocore/reward/v1/params.proto
- proto/exocore/appchain/subscriber/v1/genesis.proto
✅ Files skipped from review due to trivial changes (52)
- precompiles/slash/slash.sol
- precompiles/reward/claimReward.sol
- precompiles/bech32/IBech32.sol
- networks/local/Makefile
- networks/Makefile
- types/errors.go
- tests/e2e/oracle/oracle_test.go
- .github/workflows/security.yml
- precompiles/bls/IBLS.sol
- tests/e2e/oracle/recovery.go
- app/ante/cosmos/fees.go
- testutil/batch/send_txs.go
- precompiles/avs/setup_test.go
- app/ante/cosmos/min_price.go
- x/appchain/coordinator/client/cli/tx.go
- precompiles/assets/query.go
- precompiles/bech32/setup_test.go
- tests/e2e/oracle/data.go
- precompiles/assets/setup_test.go
- .github/workflows/lint.yml
- testutil/network/genesis_data.go
- README.md
- app/ante/evm/fee_market.go
- .github/PULL_REQUEST_TEMPLATE.md
- precompiles/slash/slash_test.go
- x/appchain/coordinator/keeper/ibc_client.go
- x/appchain/coordinator/keeper/grpc_query.go
- types/validation_test.go
- precompiles/reward/setup_test.go
- types/keys/consensus.go
- precompiles/bls/bls.go
- precompiles/avs/IAVSManager.sol
- precompiles/avs/events.go
- precompiles/delegation/setup_test.go
- precompiles/bls/setup_test.go
- precompiles/assets/IAssets.sol
- testutil/network/query.go
- types/keys/consensus_test.go
- precompiles/bech32/methods_test.go
- precompiles/delegation/IDelegation.sol
- CONTRIBUTING.md
- .github/workflows/semgrep.yml
- app/ante/evm/fee_checker.go
- precompiles/reward/reward_test.go
- app/ante/cosmos/sigverify.go
- testutil/keeper/oracle.go
- testutil/keeper/feedistribute.go
- testutil/batch/manager.go
- testutil/network/util.go
- precompiles/bech32/bech32_test.go
- precompiles/assets/assets_integrate_test.go
- proto/imuachain/operator/v1/tx.proto
🧰 Additional context used
🧠 Learnings (3)
app/ante/handler_options.go (1)
Learnt from: MaxMustermann2
PR: imua-xyz/imuachain#309
File: app/ante/handler_options.go:16-18
Timestamp: 2025-02-19T17:31:53.743Z
Learning: The import paths `github.com/imua-xyz/imuachain/app/ante/{cosmos,evm,utils}` are valid and pass golangci-lint checks in the Imuachain codebase.
proto/imuachain/appchain/coordinator/v1/tx.proto (1)
Learnt from: MaxMustermann2
PR: imua-xyz/imuachain#309
File: proto/imuachain/appchain/subscriber/v1/tx.proto:3-3
Timestamp: 2025-02-19T17:30:10.361Z
Learning: The buf dependency system handles proto file organization and package directory structure in this project. Proto files don't need to strictly follow the package path directory structure as buf takes care of this automatically.
proto/imuachain/appchain/subscriber/v1/tx.proto (1)
Learnt from: MaxMustermann2
PR: imua-xyz/imuachain#309
File: proto/imuachain/appchain/subscriber/v1/tx.proto:3-3
Timestamp: 2025-02-19T17:30:10.361Z
Learning: The buf dependency system handles proto file organization and package directory structure in this project. Proto files don't need to strictly follow the package path directory structure as buf takes care of this automatically.
🪛 Buf (1.47.2)
proto/imuachain/feedistribution/v1/distribution.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/subscriber/v1/genesis.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/tx.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/native_token.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/dogfood.proto
5-5: import "cosmos/staking/v1beta1/staking.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/tx.proto
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/params.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/immint/v1/tx.proto
4-4: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/coordinator/v1/coordinator.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/query.proto
5-5: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/tx.proto
5-5: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
proto/imuachain/avs/v1/query.proto
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/coordinator/v1/query.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/immint/v1/query.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/query.proto
5-5: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
proto/imuachain/assets/v1/query.proto
4-4: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
proto/imuachain/assets/v1/tx.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/common/v1/common.proto
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/coordinator/v1/genesis.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/coordinator/v1/params.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/coordinator/v1/tx.proto
5-5: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/subscriber/v1/query.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/subscriber/v1/tx.proto
3-3: Files with package "imuachain.appchain.subscriber.v1" must be within a directory "imuachain/appchain/subscriber/v1" relative to root but were in directory "proto/imuachain/appchain/subscriber/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/assets/v1/genesis.proto
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/assets/v1/params.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/avs/v1/genesis.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/avs/v1/tx.proto
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/delegation/v1/genesis.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/delegation/v1/query.proto
4-4: import "cosmos/query/v1/query.proto": file does not exist
(COMPILE)
proto/imuachain/delegation/v1/tx.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/genesis.proto
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/params.proto
5-5: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/epochs/v1/epochs.proto
3-3: Files with package "imuachain.epochs.v1" must be within a directory "imuachain/epochs/v1" relative to root but were in directory "proto/imuachain/epochs/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/epochs/v1/genesis.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/epochs/v1/query.proto
5-5: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/genesis.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/query.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/immint/v1/genesis.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/immint/v1/params.proto
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/operator/v1/genesis.proto
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/operator/v1/query.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/operator/v1/validator.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/genesis.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/index_recent_msg.proto
2-2: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/oracle/v1/index_recent_params.proto
2-2: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/oracle/v1/info.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/nonce.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/params.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/price.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/prices.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/recent_msg.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/recent_params.proto
4-4: import "imuachain/oracle/v1/params.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/slashing.proto
3-3: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/oracle/v1/token_feeder.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/validator_update_block.proto
2-2: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/reward/v1/genesis.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/reward/v1/params.proto
2-2: Files with package "imuachain.reward.v1" must be within a directory "imuachain/reward/v1" relative to root but were in directory "proto/imuachain/reward/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/reward/v1/query.proto
4-4: import "google/api/annotations.proto": file does not exist
(COMPILE)
proto/imuachain/reward/v1/tx.proto
5-5: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
proto/imuachain/reward/v1/types.proto
5-5: import "cosmos/base/v1beta1/coin.proto": file does not exist
(COMPILE)
proto/imuachain/slash/v1/genesis.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/slash/v1/params.proto
2-2: Files with package "imuachain.slash.v1" must be within a directory "imuachain/slash/v1" relative to root but were in directory "proto/imuachain/slash/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/slash/v1/query.proto
4-4: import "google/api/annotations.proto": file does not exist
(COMPILE)
proto/imuachain/slash/v1/tx.proto
4-4: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
🪛 LanguageTool
cmd/imuachain-test-tool/README.md
[grammar] ~7-~7: The verb ‘precompile’ does not usually follow articles like ‘the’. Check that ‘precompile’ is spelled correctly; using ‘precompile’ as a noun may be non-standard.
Context: ...se, with the node configured to disable the precompile's gateway contract address check. The b...
(A_INFINITIVE)
🪛 golangci-lint (1.62.2)
app/ante/handler_options.go
16-16: could not import github.com/imua-xyz/imuachain/app/ante/cosmos (-: # github.com/imua-xyz/imuachain/app/ante/cosmos
app/ante/cosmos/eip712.go:247:36: undefined: secp256k1.RecoverPubkey
app/ante/cosmos/eip712.go:273:17: undefined: secp256k1.VerifySignature)
(typecheck)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: goreleaser
- GitHub Check: Analyze (go)
🔇 Additional comments (471)
precompiles/testutil/contracts/contracts.go (4)
19-19
: Function signature correctly updated for ImuachainApp.Changing the parameter from
ExocoreApp
toImuachainApp
is consistent with the project rebrand. The rest of the function logic appears unaltered.
81-81
: Delivery of Ethereum transactions switched to the newimuautil.DeliverEthTx
.This call properly integrates the new utility function from Imuachain. Confirm that all references to
exocoreutil.DeliverEthTx
have been removed if no longer needed.
99-99
: Helper function signature updated to referenceImuachainApp
.The changes are consistent with the new import paths and naming scheme. The rest of the logic is preserved, ensuring backward compatibility of the test utilities.
13-15
:❓ Verification inconclusive
All imports correctly updated to Imuachain references.
These import updates align well with the rebranding from Exocore to Imuachain. Thank you for ensuring consistency across all modules.
To confirm there are no leftover references to the old names, you can run:
🏁 Script executed:
#!/bin/bash # Description: search for lingering references to `exocore` or `exocoreutil` across the codebase rg "exocore" rg "exocoreutil"Length of output: 29
Attention: Verify Legacy Reference Cleanup
The import updates in
precompiles/testutil/contracts/contracts.go
have been correctly changed to the new Imuachain references:imuasapp "github.com/imua-xyz/imuachain/app" "github.com/imua-xyz/imuachain/precompiles/testutil" imuautil "github.com/imua-xyz/imuachain/testutil"
An automated search for any remaining occurrences of
exocore
orexocoreutil
yielded no output. However, since the search command did not provide detailed confirmation, please perform a manual review (or a more thorough automated scan) to ensure that no legacy references remain.testutil/utils.go (10)
7-10
: Imports updated to new Imuachain references.
These updated imports forepochs/types
,cmd/config
, andavs/types
appear correct and consistent with the project's rebranding.
22-23
: Imports updated totestutil/tx
andoracle/types
.
No issues observed; these changes simply align with the new repository structure.
25-28
: Additional import path updates.
Shifting toimuaapp
,utils
,assets/types
, andfeedistribution/types
is consistent with the Imuachain rename.
43-46
: Operator, delegation, and dogfood references.
All references reflect the correct modules underimua-xyz/imuachain
. No concerns.
53-53
: Field renamed to ImuachainApp pointer.
Replaces old references to the former application type. Change looks good.
93-93
: Doc comment updated for ImuachainApp initializer.
Renaming in the function comment is correct.
97-98
: Usingimuaapp.SetupTestingApp
and type-asserting to ImuachainApp.
These lines properly reflect the new application setup.
445-445
: Applyingimuaapp.DefaultConsensusParams
.
No issues. This should provide the default consensus parameters from the new app package.
501-501
: Comment for Imuachain modules genesis section.
Strictly a rename in the comment; nothing problematic noted.
523-523
: Comment clarifying ImuachainApp initialization for tests.
Simply clarifies project rename. Looks good.app/app.go (25)
13-31
: Imports renamed to Imuachain equivalents (feedistribution, oracle, avs, operator, slash).
All references appear properly updated from Exocore.
38-55
: EVM ante import and additional module imports updated.
Renaming from Exocore to Imuachain modules is consistent throughout.
70-71
: Ante import references.
Imported pathgithub.com/imua-xyz/imuachain/app/ante
is correct for the new project.
171-173
:dogfood
references replaced with new Imuachain dogfood path.
This preserves prior functionality under the new naming convention.
175-178
:immint
references introduced.
Renamed from older module references, aligned with the rebrand.
185-188
: Updated EVM import path.
No changes to logic; only the path.
192-195
: Updatedepochs
references.
Straightforward rename, no functional concerns.
301-302
: Type assertions for ImuachainApp.
Implements the required interfaces for server and testing.
305-308
: Renamed doc comment and struct toImuachainApp
.
All fields remain the same; only branding changed.
350-364
: Keeper references for Erc20, Epochs, Immint, and affiliates.
Module rebranding is consistent with the rest of the file.
382-389
: NewImuachainApp constructor.
Migrates from oldNewExocoreApp
. Code remains structurally sound.
461-469
: Instantiation of theImuachainApp
struct.
No issues; references defaulting to new paths.
539-545
: Beginning block of Imuachain keepers.
Properly references the immint keeper, no logic concerns.
557-606
: Delegation references and linking with new modules.
All cross-module references are updated toimua-xyz/imuachain
. Good consistency.
618-627
: Capability keeper and IBC references.
Renaming from Exocore to Imuachain done thoroughly.
631-639
: IBC transport modules.
All references (“transfer”, “ICAHost”) point to the new codebase.
900-911
: Appending Imuachain modules to the ModuleManager.
In line with the new naming and package structure.
928-987
: Ordering of BeginBlock and EndBlock modules.
Remains consistent, with references updated for Imuachain modules.
1002-1024
: Order of InitGenesis across Imuachain modules.
Ensures all new modules initialize in the correct sequence.
1107-1109
:Name()
method referencingImuachainApp
.
Simply updates the function to reflect the new application name.
1110-1145
:setAnteHandler
referencing dynamic fees and EVM keepers.
The shift toethante.NewDynamicFeeChecker
remains a rename-based change; no logic issues.
1151-1161
:BeginBlocker
rebranded to Imuachain context.
The approach to scheduled forks or upgrades is unchanged.
1163-1170
:EndBlocker
rebranded.
No functional changes are introduced here.
1172-1183
:DeliverTx
updated to reference Imuachain structures.
Retains the same TPS tracking approach under the new name.
1185-1197
:InitChainer
references for the new genesis structure.
Renamed from exocore references, logic remains intact.testutil/statedb.go (1)
7-7
: Analytics EVM import from Imuachain path.
Straight rename from old Exocore-based path toapp/ante/evm
. No issues detected.x/appchain/coordinator/keeper/genesis.go (1)
6-6
: LGTM! Import path correctly updated for rebranding.The import path has been correctly updated to reflect the new repository name, maintaining the same package structure.
app/ante/utils/oracle.go (1)
5-5
: LGTM! Import path correctly updated for rebranding.The import path has been correctly updated to reflect the new repository name, maintaining the same package structure.
tests/e2e/oracle/suite.go (1)
6-6
: LGTM! Import path correctly updated for rebranding.The import path has been correctly updated to reflect the new repository name, maintaining the same package structure.
precompiles/slash/setup_test.go (2)
6-8
: LGTM! Import paths correctly updated for rebranding.The import paths have been correctly updated to reflect the new repository name, maintaining the same package structure.
34-34
:✅ Verification successful
Verify the keeper reference change.
The keeper reference has been updated from
ExoSlashKeeper
toImSlashKeeper
. Please ensure that this keeper has been properly renamed and initialized in the app setup.
🏁 Script executed:
#!/bin/bash # Description: Verify the keeper renaming is consistent across the codebase # Search for any remaining references to ExoSlashKeeper echo "Checking for any remaining references to ExoSlashKeeper..." rg "ExoSlashKeeper" # Search for the new ImSlashKeeper to verify its initialization echo "Checking ImSlashKeeper initialization..." rg "ImSlashKeeper.*=.*New"Length of output: 321
Keeper Naming Verified – No Further Changes Needed
The script results confirm that all references to
ExoSlashKeeper
have been removed, andImSlashKeeper
is correctly instantiated (as seen inapp/app.go
). The usage inprecompiles/slash/setup_test.go
(line 34) is now properly aligned with the new naming convention.cmd/imuad/main.go (2)
9-9
: LGTM! Import paths correctly updated.The import paths have been properly updated to reflect the new repository name, aligning with the rebranding objectives.
Also applies to: 11-11
20-20
: LGTM! Binary name updated correctly.The binary name has been changed from "exocored" to "imuad" as specified in the PR objectives.
testutil/ante.go (1)
6-6
: LGTM! Import path correctly updated.The import path has been properly updated to reflect the new repository name, maintaining the existing functionality.
precompiles/slash/methods.go (1)
10-10
: LGTM! Import path and error message updated correctly.The changes properly reflect the rebranding:
- Import path updated from exocmn to imuacmn
- Error message source updated accordingly
Also applies to: 31-31
testutil/fund.go (1)
7-8
: LGTM! Import paths and module references updated correctly.The changes properly reflect the rebranding:
- Import paths updated to use the new repository name
- Module references updated from exomint to immint
- Functionality preserved while maintaining consistency with the new naming scheme
Also applies to: 14-14, 18-18, 33-33, 37-37
precompiles/reward/methods.go (2)
10-11
: LGTM! Import paths updated correctly.The import paths have been properly updated to reflect the rebranding from ExocoreNetwork to imuachain.
32-32
: LGTM! Error message updated consistently.The error message now correctly uses
imuacmn.ErrContractCaller
to maintain consistency with the rebranding.app/forks.go (1)
21-21
: LGTM! Method receiver type updated correctly.The method receiver type has been properly updated from
ExocoreApp
toImuachainApp
to align with the rebranding effort.x/appchain/coordinator/client/cli/query.go (1)
11-11
: LGTM! Import path updated correctly.The import path has been properly updated to reflect the rebranding from ExocoreNetwork to imuachain.
testutil/network/network_test.go (2)
13-13
: LGTM! Import path updated correctly.The import path has been properly updated to reflect the rebranding from ExocoreNetwork to imuachain.
29-29
: LGTM! Network configuration calls updated consistently.The network configuration and initialization calls have been properly updated to use the new package name.
Also applies to: 35-35
precompiles/slash/parser.go (2)
7-7
: LGTM! Import paths correctly updated.The import paths have been properly updated to reflect the new repository name while maintaining the same package structure.
Also applies to: 12-12
22-22
: LGTM! Error handling package references updated consistently.All error handling references have been updated from
exocmn
toimuacmn
consistently throughout the file.Also applies to: 23-23, 35-35, 36-36, 39-39, 40-40, 45-45, 46-46, 49-49, 50-50, 55-55, 56-56
precompiles/reward/parser.go (2)
7-7
: LGTM! Import paths correctly updated.The import paths have been properly updated to reflect the new repository name while maintaining the same package structure.
Also applies to: 13-13
23-23
: LGTM! Error handling package references updated consistently.All error handling references have been updated from
exocmn
toimuacmn
consistently throughout the file.Also applies to: 24-24, 36-36, 37-37, 40-40, 41-41, 46-46, 47-47, 50-50, 51-51, 56-56, 57-57
cmd/config/config.go (2)
11-11
: LGTM! Bech32 prefix updated correctly.The Bech32 prefix has been updated to "im" as specified in the PR objectives.
29-32
: LGTM! Denomination updates are consistent with requirements.The changes correctly implement the denomination requirements:
- DisplayDenom set to "IMUA" with appropriate capitalization
- BaseDenom remains "hua" as specified
- Added helpful comment about capitalization matching ETH and wei logic
app/ante/sigverify.go (1)
14-14
: LGTM! Import path correctly updated.The import path has been properly updated to reflect the new repository name while maintaining the same package structure.
testutil/integration.go (1)
13-13
: LGTM! Changes align with rebranding objectives.The updates correctly replace ExocoreApp references with ImuachainApp while maintaining the original functionality.
Also applies to: 21-21, 34-34, 50-50, 63-63, 69-69, 77-77
testutil/tx/signer.go (1)
9-9
: LGTM! Import path updated correctly.The import path has been properly updated to reflect the new repository location while maintaining the same functionality.
init.bat (2)
12-13
: Follow up on chain ID decision.The TODO comment indicates that the testnet chain ID needs to be finalized. This should be resolved before the changes are merged.
Please confirm the final chain ID for the testnet.
21-21
: LGTM! Consistent renaming throughout the script.All references to exocore have been properly updated to imua, including:
- Binary name
- Home directory path
- Configuration commands
- Chain initialization
- Genesis account setup
Also applies to: 28-28, 34-35, 37-37, 39-40, 58-58, 61-61, 64-64, 67-67, 72-72
precompiles/bech32/methods.go (1)
11-11
: LGTM! Import and error handling updated correctly.The changes properly update the import path and error reference to use the new package while maintaining the same functionality.
Also applies to: 94-94
precompiles/delegation/types.go (2)
11-13
: LGTM! Import paths updated correctly.The import paths have been consistently updated to reflect the new repository name.
25-25
: LGTM! Error handling references updated consistently.All error handling references have been updated from
exocmn
toimuacmn
while maintaining the same error handling logic.Also applies to: 39-39, 45-45, 49-49, 59-59, 66-66, 69-69, 80-80
app/ante/cosmos/context.go (1)
10-10
: LGTM! Import path updated correctly.The anteutils import path has been updated to reflect the new repository name.
utils/utils_test.go (3)
20-20
: LGTM! Bech32 prefix updated correctly.The Bech32 prefix has been updated to "im" and "impub" as specified in the PR objectives.
76-76
: LGTM! Test function name updated consistently.The test function name has been updated to reflect the new chain name.
139-139
: LGTM! Chain ID references updated consistently.Test cases have been updated to use the new chain ID format with "imua" prefix.
Also applies to: 144-144, 149-149
precompiles/slash/slash.go (2)
16-17
: LGTM! Import paths updated correctly.The keeper import paths have been updated to reflect the new repository name.
130-130
: LGTM! Logger context updated consistently.The logger context has been updated to use the new module name while maintaining the same logging functionality.
app/ante/cosmos/txsize_gas.go (1)
13-13
: LGTM!The import path has been correctly updated to reflect the new repository name.
testutil/tx/cosmos.go (1)
14-15
: LGTM!The import paths have been correctly updated to reflect the new repository name.
precompiles/bls/bls_test.go (1)
7-7
: LGTM!The import path has been correctly updated to reflect the new repository name.
precompiles/reward/reward.go (1)
17-18
: LGTM!The import paths have been correctly updated to reflect the new repository name.
client/export.go (1)
18-18
: LGTM!The import path has been correctly updated to reflect the new package name.
app/export.go (1)
17-17
: LGTM!The import path and method signatures have been correctly updated to reflect the new package and type names.
Also applies to: 53-53, 94-94
testutil/tx/eth.go (1)
21-22
: LGTM!The import paths, method signatures, and parameter names have been correctly updated to reflect the new package and type names.
Also applies to: 29-29, 35-35, 101-101, 104-104, 111-111, 120-120
testutil/contract.go (1)
20-21
: LGTM!The import paths, method signatures, and parameter names have been correctly updated to reflect the new package and type names.
Also applies to: 54-54, 60-62, 79-79, 86-86, 91-91, 102-102
precompiles/delegation/delegation.go (2)
14-15
: LGTM! Import paths updated correctly.The import paths have been updated to reflect the new repository namespace.
114-114
: LGTM! GitHub issue reference updated.The GitHub issue reference has been updated to point to the new repository.
cmd/imuad/init.go (1)
93-93
: LGTM! Chain ID prefix updated.The default chain ID prefix has been updated from "exocore_234" to "imua_234", maintaining the same format while reflecting the rebranding.
precompiles/assets/decode_helper.go (2)
10-10
: LGTM! Common package import updated.The import path has been updated to use the new imuachain namespace.
32-37
: LGTM! Error constants updated consistently.All error constant references have been updated from exocmn to imuacmn throughout the file, maintaining consistent error handling.
Also applies to: 43-48, 54-59, 65-70, 76-81, 87-92, 98-103, 113-114, 124-125, 135-136, 146-147, 157-158, 168-169, 179-180
precompiles/delegation/tx.go (2)
8-8
: LGTM! Common package import updated.The import path has been updated to use the new imuachain namespace.
48-48
: LGTM! Error constants updated consistently.All error constant references have been updated from exocmn to imuacmn throughout the file, maintaining consistent error handling.
Also applies to: 74-74, 106-106, 115-116, 125-126, 129-130, 135-136, 159-160, 167-168, 177-178, 181-182
precompiles/assets/tx.go (4)
39-42
: LGTM!The changes correctly update the import paths and error messages as part of the rebranding effort from Exocore to Imuachain, while maintaining the same functionality.
85-88
: LGTM!The changes correctly update the import paths and error messages as part of the rebranding effort from Exocore to Imuachain, while maintaining the same functionality.
108-111
: LGTM!The changes correctly update the import paths and error messages as part of the rebranding effort from Exocore to Imuachain, while maintaining the same functionality.
150-153
: LGTM!The changes correctly update the import paths and error messages as part of the rebranding effort from Exocore to Imuachain, while maintaining the same functionality.
testutil/tx/eip712.go (3)
53-53
: LGTM!The changes correctly update the parameter type from
*app.ExocoreApp
to*app.ImuachainApp
as part of the rebranding effort, while maintaining the same functionality.
69-83
: LGTM!The changes correctly update the parameter type and variable references from Exocore to Imuachain as part of the rebranding effort, while maintaining the same functionality.
132-141
: LGTM!The changes correctly update the parameter type and variable reference from Exocore to Imuachain as part of the rebranding effort, while maintaining the same functionality.
precompiles/assets/assets.go (2)
12-12
: LGTM!The import path is correctly updated as part of the rebranding effort from Exocore to Imuachain.
102-102
: LGTM!The issue URL is correctly updated as part of the rebranding effort from Exocore to Imuachain.
precompiles/avs/query.go (2)
16-17
: LGTM!The import paths are correctly updated as part of the rebranding effort from Exocore to Imuachain.
43-43
: LGTM!The error messages are correctly updated to use
imuacmn.ErrContractInputParamOrType
as part of the rebranding effort from Exocore to Imuachain.Also applies to: 68-68, 90-90, 114-114, 118-118, 142-142, 168-168, 188-188, 192-192, 220-220
precompiles/assets/types.go (2)
14-17
: LGTM!Import paths are correctly updated to reflect the new repository structure.
107-107
: LGTM!Error message constants are correctly updated to use the new package.
Also applies to: 115-115, 123-123, 179-179, 223-223
testutil/batch/manager_test.go (2)
16-16
: LGTM!Import paths are correctly updated to reflect the new repository structure.
Also applies to: 28-28
68-68
: LGTM!Variable names and addresses are correctly updated to use the new prefix.
Also applies to: 87-89, 104-105, 117-117
utils/utils.go (3)
19-19
: LGTM!Import path is correctly updated to reflect the new repository structure.
25-25
: LGTM!Chain IDs are correctly updated to use the new prefix.
Also applies to: 28-28
31-31
: LGTM!Comment is correctly updated to use the new name.
testutil/abci.go (2)
15-16
: LGTM!Import paths are correctly updated to reflect the new repository structure.
25-25
: LGTM!Variable names are correctly updated to use the new app name.
Also applies to: 37-37, 65-66, 73-74, 86-86, 93-94, 99-100, 103-104, 120-121, 126-127, 131-132, 142-143, 151-152, 164-165, 169-170, 175-176, 179-180, 183-184, 201-202, 231-232
precompiles/avs/utils_test.go (2)
8-20
: LGTM! Import paths updated consistently.The import paths have been updated from ExocoreNetwork/exocore to imua-xyz/imuachain consistently across all packages.
92-92
: Verify the new Bech32 address format.The address has been updated to use the new
im
prefix, which aligns with the rebranding. However, let's verify the address format.#!/usr/bin/env python3 import bech32 def verify_bech32_address(address): """Verify if the address is a valid Bech32 address.""" try: hrp, data = bech32.bech32_decode(address) if hrp != "im": return False, "Invalid HRP" if data is None: return False, "Invalid checksum" return True, "Valid Bech32 address" except Exception as e: return False, str(e) # Verify the new address address = "im18cggcpvwspnd5c6ny8wrqxpffj5zmhkl3agtrj" is_valid, message = verify_bech32_address(address) print(f"Address: {address}") print(f"Is valid: {is_valid}") print(f"Message: {message}")utils/store.go (1)
12-12
: LGTM! Import path updated correctly.The import path has been updated to reflect the new repository structure while maintaining the same package functionality.
testutil/batch/type.go (2)
38-42
: LGTM! Currency fields renamed consistently.The amount fields have been updated from ExoAmount to ImuaAmount, maintaining consistency with the rebranding.
99-99
: LGTM! Chain ID updated correctly.The Chain ID has been updated from exocorelocalnet to imualocalnet, aligning with the new branding.
testutil/batch/utils.go (2)
145-145
: LGTM! Currency references updated consistently.Function parameters and variables have been updated from exo to imua, maintaining consistency with the rebranding.
Also applies to: 174-176
247-248
: LGTM! Error messages updated correctly.Error messages have been updated to reference the new currency name (imua).
app/ethtest_helper.go (2)
30-36
: LGTM! Import paths updated correctly.The import paths have been updated to reflect the new repository structure, maintaining consistency with the rebranding effort.
59-59
: LGTM! Function signatures updated correctly.The function signatures have been updated from
ExocoreApp
toImuachainApp
, aligning with the rebranding changes.Also applies to: 64-64, 66-66
precompiles/avs/avs.go (1)
14-14
: LGTM! Import path updated correctly.The import path has been updated to reflect the new repository structure, maintaining consistency with the rebranding effort.
cmd/imuachain-test-tool/main.go (1)
11-11
: Verify the command name consistency.The command examples use
imuast-tool
while the file is located inimuachain-test-tool
directory. This inconsistency might confuse users. Consider either:
- Using the full name
imuachain-test-tool
in the examples to match the directory name, or- Renaming the directory to match the shortened command name.
Also applies to: 74-74, 101-101, 119-119, 135-135, 154-154, 174-174, 232-232
precompiles/avs/types.go (2)
9-10
: LGTM! Error handling and imports updated correctly.The changes maintain consistency with the rebranding effort:
- Import paths updated to reflect the new repository structure
- Error constant references updated from
exocmn
toimuacmn
- Error handling functionality remains unchanged
Also applies to: 24-24, 29-29, 35-35, 41-41, 47-47, 53-53, 60-60, 71-71, 82-82, 88-88, 94-94, 100-100, 109-109, 133-133, 139-139, 145-145, 151-151, 157-157, 163-163, 170-170, 181-181, 192-192, 198-198, 204-204, 210-210, 219-219, 243-243, 248-248, 254-254, 260-260, 266-266, 272-272, 278-278
62-67
: LGTM! Variable names updated for consistency.Variable names have been updated from
exoAddresses
toimAddresses
to maintain consistency with the new branding.Also applies to: 73-78
app/test_helpers.go (3)
29-44
: LGTM! Import paths correctly updated.The import paths have been consistently updated from
github.com/ExocoreNetwork/exocore
togithub.com/imua-xyz/imuachain
across all packages.
82-88
: LGTM! Function signature and comments updated.The
Setup
function has been correctly updated to useImuachainApp
instead ofExocoreApp
, and the comments have been updated to reference Imuachain.
111-112
: LGTM! Constructor calls updated.The
NewImuachainApp
constructor calls have been consistently updated across the file, maintaining the same parameter structure.Also applies to: 332-333
testutil/batch/tx_check.go (2)
13-15
: LGTM! Import paths correctly updated.The import paths have been consistently updated from
github.com/ExocoreNetwork/exocore
togithub.com/imua-xyz/imuachain
across all packages.
268-277
: LGTM! Configuration variables updated.The configuration variables have been correctly updated from
ExoAmount
toImuaAmount
to reflect the new token name.testutil/batch/batch_tx.go (3)
15-16
: LGTM! Import paths correctly updated.The import paths have been consistently updated from
github.com/ExocoreNetwork/exocore
togithub.com/imua-xyz/imuachain
across all packages.
212-213
: LGTM! Comments updated.The comments have been correctly updated to reference Imuachain instead of Exocore.
286-287
: LGTM! Token reference updated.The TODO comment has been correctly updated to reference the IMUA token.
cmd/imuad/root.go (5)
48-57
: LGTM! Import paths correctly updated.The import paths have been consistently updated from
github.com/ExocoreNetwork/exocore
togithub.com/imua-xyz/imuachain
across all packages.
60-61
: LGTM! Environment prefix updated.The environment prefix has been correctly updated from
EXOCORE
toIMUACHAIN
.
68-69
: LGTM! Comments and descriptions updated.The comments and command descriptions have been correctly updated to reference Imuachain instead of Exocore.
Also applies to: 89-90
303-304
: LGTM! Constructor calls updated.The application constructor calls have been consistently updated to use
NewImuachainApp
instead ofNewExocoreApp
.Also applies to: 347-348, 357-358
338-339
: LGTM! Variable names updated.The variable names have been correctly updated to use
imuaApp
instead ofexocoreApp
.precompiles/avs/tx.go (1)
15-16
: LGTM! Import paths updated correctly.The import paths have been correctly updated to reflect the new repository structure, maintaining the same functionality while aligning with the rebranding from Exocore to Imua.
testutil/batch/prepare.go (3)
9-24
: LGTM! Import paths updated correctly.The import paths have been correctly updated to reflect the new repository structure.
93-93
: LGTM! Variable names updated consistently.The variable names have been updated from
Exo
toImua
consistently throughout the code.Also applies to: 98-98, 109-109, 114-114, 119-119
105-106
: LGTM! Documentation updated correctly.Comments have been updated to reference Imua instead of Exocore, maintaining consistency with the rebranding.
Also applies to: 404-405
precompiles/delegation/delegation_test.go (2)
6-22
: LGTM! Import paths updated correctly.The import paths have been correctly updated to reflect the new repository structure.
66-66
: LGTM! GitHub issue references updated.GitHub issue references have been updated to point to the new repository.
Also applies to: 277-278, 444-445
precompiles/avs/query_test.go (3)
8-22
: LGTM! Import paths updated correctly.The import paths have been correctly updated to reflect the new repository structure.
394-398
: LGTM! Test data generation improved.The test data generation has been improved to use
utiltx.GenerateAddress()
for dynamic address generation, making the tests more maintainable.Also applies to: 463-463
88-88
: LGTM! Error message references updated.Error message references have been updated from
exocmn
toimuacmn
to maintain consistency with the rebranding.tests/e2e/oracle/create_price.go (1)
16-20
: LGTM! Import paths updated correctly.The import paths have been updated to reflect the new package structure, maintaining the same functionality while aligning with the rebranding from Exocore to Imua.
cmd/imuad/testnet.go (4)
138-138
: LGTM! Command example updated correctly.The example command has been updated to use
imuad
instead of the old binary name, aligning with the rebranding.
223-223
: LGTM! Chain ID prefix updated correctly.The chain ID generation now uses the
imuachain
prefix instead of the old prefix, maintaining consistency with the rebranding.
345-346
: LGTM! Directory paths updated correctly.The node and client directory paths have been updated to use
imuad
andimuacli
respectively, aligning with the new binary names.
357-357
: LGTM! Function name and gateway address updated correctly.The function name has been updated from
getTestExocoreGenesis
togetTestImuachainGenesis
, and the gateway address prefix has been updated to useim
instead of the old prefix.Also applies to: 500-500
testutil/network/network.go (2)
51-52
: LGTM! Import paths updated correctly.The import paths have been updated to use the new
imuachain
package structure, maintaining the same functionality while aligning with the rebranding.Also applies to: 55-58
107-107
: LGTM! Chain ID and keyring options updated correctly.The chain ID generation and keyring options have been updated to use the new package structure and crypto options.
Also applies to: 129-129
precompiles/avs/avs_test.go (2)
9-10
: LGTM! Import paths updated correctly.The import paths have been updated to use the new
imuachain
package structure, maintaining the same functionality while aligning with the rebranding.Also applies to: 13-14, 23-26
96-99
: LGTM! Variable names updated correctly.The variable name has been updated from
exoWhiteListAddress
toimWhiteListAddresses
, maintaining consistency with the rebranding.Also applies to: 357-360
precompiles/assets/assets_test.go (3)
10-14
: Import paths correctly updated for rebranding.The import paths have been consistently updated from
github.com/ExocoreNetwork/exocore
togithub.com/imua-xyz/imuachain
, maintaining the same package structure.Also applies to: 20-21
80-80
: Variable name updated for consistency.The variable
exocoreLzAppAddress
has been renamed toimuaLzAppAddress
to align with the rebranding.
275-275
: Issue reference properly migrated.The issue reference has been updated to point to the new repository at
github.com/imua-xyz/imuachain/issues/70
.proto/imuachain/appchain/subscriber/v1/genesis.proto (2)
1-8
: Proto file structure follows best practices.The package declaration and imports are properly structured for the new imuachain namespace.
🧰 Tools
🪛 Buf (1.47.2)
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
5-6
:❓ Verification inconclusive
Verify proto dependencies are available.
The static analysis indicates that
gogoproto/gogo.proto
might be missing. Please ensure all proto dependencies are properly included in the build system.
🏁 Script executed:
#!/bin/bash # Check if proto files exist in the expected locations fd -t f "gogo.proto"Length of output: 20
Dependency Check for Proto Files – Manual Verification Required
The static analysis still indicates that
gogoproto/gogo.proto
was not located in the repository. The shell script search did not return any results. Please manually verify whether this dependency is provided externally (e.g., as part of a vendor package or via your build system) or needs to be explicitly included in the repository and build configuration.
- Confirm if
gogoproto/gogo.proto
is sourced externally (such as through a vendor directory or a build configuration that pulls in external proto files).- If it is meant to be a local file, include it at the expected location.
- Otherwise, update the build instructions or documentation to clarify how this dependency is managed.
🧰 Tools
🪛 Buf (1.47.2)
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/params.proto (2)
2-2
: Package and go_package options correctly updated.The namespace has been properly updated from exocore to imuachain, maintaining consistency with the rebranding.
Also applies to: 8-8
12-12
: Amino name properly updated for new namespace.The amino name has been updated from
exocore/x/feedistribution/Params
toimua/x/feedistribution/Params
, maintaining consistency with the rebranding.proto/imuachain/appchain/coordinator/v1/coordinator.proto (2)
3-3
: Package declaration and imports properly updated.All namespace references have been consistently updated from exocore to imuachain, including:
- Package declaration
- Import paths
- Go package option
Also applies to: 6-6, 8-8
14-14
: Message field type correctly updated to new namespace.The type of the
list
field inPendingSubscriberChainRequests
has been properly updated to use the new imuachain namespace.proto/imuachain/immint/v1/query.proto (5)
2-2
: Update Namespace Format.
The package declaration now reflects the updated rebranding toimuachain.immint.v1
, which is consistent with the project’s new identity.
4-4
: Static Analysis Note: Verify gogoproto Import.
Static analysis flags that"gogoproto/gogo.proto"
may not exist. Please verify that this dependency is made available via your build system (e.g., as a vendored dependency or through proper include paths) or adjust the import if needed.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
6-6
: Review Updated Import Path.
The updated import path"imuachain/immint/v1/params.proto"
aligns with the rebranding. Ensure that the file is located at the expected path in the repository.
8-8
: Verify Go Package Option.
Thego_package
option is now updated to"github.com/imua-xyz/imuachain/x/immint/types"
, reflecting the new organizational structure. Confirm that downstream code generation tools work with this change.
14-15
: Confirm Updated HTTP Endpoint.
The HTTP mapping for theParams
RPC has been updated to"/imuachain/immint/v1/Params"
, which is consistent with the new branding. Make sure all client integrations have been updated accordingly.scripts/protocgen.sh (2)
17-17
: Update Grep Pattern for Branding.
The grep condition now looks for"option go_package.*imua"
, ensuring that only proto files aligned with the new branding are processed. This change is appropriate.
24-24
: Validate Copy Command Changes.
Thecp
command now targets files from"github.com/imua-xyz/imuachain/*"
, correctly reflecting the rebranded repository structure. Double-check that this aligns with the overall project layout..github/workflows/consensuswarn.yml (2)
16-16
: Update Job Name.
The workflow job name is updated toconsensus-warn
, which better represents its purpose under the new branding.
29-29
: Updated Roots Parameter.
Theroots
parameter now referencesgithub.com/imua-xyz/imuachain/app.ImuachainApp.*
methods instead of the old Exocore paths. This ensures that the actions target the correct functions for monitoring.networks/local/imuachain/wrapper.sh (3)
6-8
: Update Binary and Log Variables.
The variables have been updated to use/imua/
for the binary andimuad
for the default binary name, withLOG
now defaulting toimua.log
. These changes correctly propagate the new brand naming.
10-13
: Revise Error Message.
The error output now properly referencesimuad
instead ofexocored
, providing clear guidance if the binary is missing.
15-15
: Update Home Directory Export.
TheEHOME
environment variable now points to/home/imua/data/node${ID}/imuad
, matching the new data directory structure.networks/local/imuachain/Dockerfile (4)
17-18
: Update User and Group Configuration.
The Dockerfile now creates a user and groupimua
(with group ID 1000), replacing the oldexocore
settings. This update is consistent and necessary for the rebranding effort.
20-21
: Update Execution User and CMD.
TheUSER
directive is changed toimua
, and theCMD
now includes the new chain IDimualocalnet_232-1
along with the updated flags. Confirm that these options match the deployment requirements under the new naming conventions.
24-25
: Update Volume and Working Directory.
Both theVOLUME
andWORKDIR
instructions have been updated to/imua
, which aligns with the rest of the rebranding changes in the project.
28-28
: Update Binary Copy Command.
The final copy command now correctly fetches theimuad
binary from the build stage and places it into/imuachain
. Ensure that the build stage reliably produces theimuad
binary.Dockerfile (6)
1-1
: Branding Comment Update
The header comment now correctly identifies the Docker image for Imuachain.
5-5
: Updated Working Directory
TheWORKDIR
is now set to/go/src/github.com/imua-xyz/imuachain
, which aligns with the new repository structure and branding.
23-23
: Updated COPY Command for Binary
TheCOPY
instruction now correctly fetches the new binaryimuad
from the build environment.
32-33
: User and Group Configuration Update
The commands creating the group and user have been updated to useimua
(group and user) in place of the old naming, ensuring consistency with the rebranding.
36-36
: User Home Directory Update
TheWORKDIR
for the user has been updated to/home/imua
, which is in line with the new project identity.
43-43
: Startup Command Update
The startup command has been updated to launchimuad
, ensuring that the container uses the new entry point as per the rebranding requirements.proto/imuachain/dogfood/v1/tx.proto (5)
3-3
: Package Name Update
The package declaration is nowimuachain.dogfood.v1
, which reflects the new project branding accurately.
5-5
: Static Analysis Warning: Missing Proto Import
Static analysis indicates thatcosmos/msg/v1/msg.proto
might not exist. If this file is provided via an external dependency or package manager, you may safely ignore this warning; otherwise, please verify its availability.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
9-9
: Updated Import Path
The import forparams.proto
has been updated toimuachain/dogfood/v1/params.proto
, ensuring that the proto imports reflect the new namespace and rebranding.
11-11
: Go Package Option Update
Thego_package
option is now set togithub.com/imua-xyz/imuachain/x/dogfood/types
, which ensures consistency with the new repository path and branding.
35-35
: Updated RPC Endpoint
The HTTP endpoint for theUpdateParams
RPC method has been updated to/imuachain/dogfood/v1/tx/MsgUpdateParams
. Please ensure that any client code depending on this endpoint is updated accordingly.proto/imuachain/immint/v1/tx.proto (5)
2-2
: Package Name Update
The package is now declared asimuachain.immint.v1
, which aligns with the overall Imuachain rebranding.
4-4
: Static Analysis Warning: Missing Proto Import
Static analysis flags thatcosmos/msg/v1/msg.proto
might not exist. If this dependency comes from your external packages, you may disregard this warning; otherwise, please confirm the file is available.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
8-8
: Updated Import Path
The import forparams.proto
has been changed toimuachain/immint/v1/params.proto
, ensuring that it uses the correct module namespace.
10-10
: Go Package Option Update
Thego_package
option has been updated togithub.com/imua-xyz/imuachain/x/immint/types
, reflecting the new project structure and branding.
34-34
: Updated RPC Endpoint
The RPC HTTP endpoint is now/imuachain/immint/v1/tx/MsgUpdateParams
, in line with the rebranding.scripts/start-docker.sh (8)
5-5
: Chain ID Update
TheCHAINID
has been updated to"imualocalnet_232-1"
, which aligns with the new network naming convention.
7-7
: Data Directory Naming Update
The temporary data directory now uses the prefiximua-datadir
, reflecting the new project branding.
10-12
: Key Management and Initialization Updates
Commands for key generation and node initialization have been updated to useimuad
instead of the previous binary name. This ensures that all operations are consistent with the rebranding effort.
14-16
: Genesis Account Allocation Update
The genesis account allocation command now correctly usesimuad
to add genesis accounts, thereby aligning with the new CLI branding.
20-20
: Collect Genesis Transactions
The command to collect genesis transactions now correctly usesimuad
, ensuring consistency with the rebranded CLI.
22-22
: Validate Genesis Command Update
The genesis validation command is updated toimuad validate-genesis
, which is consistent with the new branding.
24-27
: Start Node Command Update
The process for starting the node in the background has been updated to useimuad
. This change ensures that the startup script is fully aligned with the Imuachain rebranding.
30-30
: Node Startup Confirmation
The final echo message confirms that the Imua node has started successfully.proto/imuachain/feedistribution/v1/tx.proto (6)
2-2
: Package Name Update
The package declaration has been updated toimuachain.feedistribution.v1
, reflecting the new module identity.
4-4
: Static Analysis Warning: Missing Proto Import
Static analysis indicates thatamino/amino.proto
might be missing. Verify that this dependency is correctly provided (e.g., via your vendor setup) or adjust the import if necessary.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
9-9
: Updated Import Path
The import forparams.proto
is nowimuachain/feedistribution/v1/params.proto
, which aligns with the updated namespace.
11-11
: Go Package Option Update
Thego_package
option has been revised togithub.com/imua-xyz/imuachain/x/feedistribution/types
, ensuring consistency with the new repository structure.
20-20
: Updated RPC Endpoint
The HTTP endpoint forUpdateParams
now reflects the new branding:/imuachain/feedistribution/v1/tx/MsgUpdateParams
.
27-27
: Updated Amino Name Option
Theamino.name
attribute is updated toimua/x/feedistribution/MsgUpdateParams
, ensuring that naming conventions adhere to the recent rebranding.scripts/protoc-swagger-gen.sh (2)
9-9
: Rebranding Swagger Configuration in buf.yaml
The updated line now correctly references the new Imuachain namespace (buf.build/imua-xyz/imuachain
). Please ensure that this change is consistent with other project configuration files.
15-15
: Updated Proto Files Directory
The copy command now correctly pulls theimuachain
directory instead of the old one. This aligns with the rebranding effort.networks/init-node.sh (1)
7-10
: Rebranded Node Configuration Paths
The variablesGENESIS
,TMP_GENESIS
,APP_TOML
, andCONFIG_TOML
have been updated from paths involving "exocored/config" to "imuad/config". This ensures that node initialization will use the correct configuration files under the new branding..github/workflows/super-linter.yml (2)
13-19
: Updated Workflow Triggers and Branches
The addition of themerge_group
trigger along with the specified branch conditions ensures that the linter runs under the new workflow requirements. This change is consistent with the overall rebranding effort.
20-21
: Renamed Job to "run-super-linter"
Changing the job name fromrun-lint
torun-super-linter
improves clarity and aligns the workflow with the new project branding.proto/imuachain/oracle/v1/native_token.proto (3)
3-3
: Updated Package Declaration
The package name has been correctly updated fromexocore.oracle.v1
toimuachain.oracle.v1
, which is in line with the rebranding objectives.
7-7
: Updated Go Package Option
Thego_package
option now reflects the new module path (github.com/imua-xyz/imuachain/x/oracle/types
), ensuring that generated code will reference the correct repository location.
5-5
: Static Analysis Warning: Verify gogoproto Dependency
The importimport "gogoproto/gogo.proto";
is triggering a static analysis warning indicating that the file may not exist. Please verify that the dependency is properly included in your project (or adjust the import path if necessary).🧰 Tools
🪛 Buf (1.47.2)
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/dogfood.proto (5)
3-3
: Rebranded Package Declaration
The package declaration has been updated fromexocore.dogfood.v1
toimuachain.dogfood.v1
, which aligns with the overall project rebranding.
10-10
: Updated Go Package Option for Dogfood
Thego_package
option now points togithub.com/imua-xyz/imuachain/x/dogfood/types
, ensuring consistency with the new repository structure.
12-14
: Renamed Validator Message for Consistency
RenamingExocoreValidator
toImuachainValidator
and updating the associated comments ensures that the public entity aligns with the new branding. The structure and functionality remain intact.
5-5
: Static Analysis Warning: Verify Staking Proto Import
The importimport "cosmos/staking/v1beta1/staking.proto";
triggered a warning indicating that the file does not exist. Please confirm that your dependency for the staking proto is properly installed or update the import path accordingly.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos/staking/v1beta1/staking.proto": file does not exist
(COMPILE)
7-7
: Static Analysis Warning: Verify gogoproto Import
Similarly, ensure that the filegogoproto/gogo.proto
exists in your dependencies. If not, you may need to add the appropriate dependency or adjust the import path.proto/imuachain/appchain/coordinator/v1/query.proto (7)
3-3
: Updated Package NameThe package declaration has been updated from the old namespace to:
package imuachain.appchain.coordinator.v1;
This change is consistent with the rebranding effort.
7-8
: Updated Import PathsBoth import statements for the proto files:
import "imuachain/appchain/common/v1/common.proto";
import "imuachain/appchain/coordinator/v1/params.proto";
reflect the new namespace. This ensures that the proto dependencies are correctly referenced.
10-10
: Updated Go Package OptionThe
option go_package
is updated to:"option go_package = \"github.com/imua-xyz/imuachain/x/appchain/coordinator/types\";";
This aligns with the new repository and namespace.
16-20
: Inconsistent HTTP Option for QueryParamsThe HTTP option for the
QueryParams
RPC remains as:option (google.api.http) = {get: "/appchain/coordinator/params"};
For consistency with other endpoints (for example, the updated Subscriber Genesis URL), you may want to update it to include the namespace and version (e.g.
"/imuachain/appchain/coordinator/v1/params"
).
20-21
: Updated HTTP Path for Subscriber GenesisThe HTTP option for the
QuerySubscriberGenesis
RPC is properly updated to:option (google.api.http) = {get: "/imuachain/appchain/coordinator/v1/subscriber_genesis/{chain}"};
This correctly reflects the new namespace.
42-42
: Updated Subscriber Genesis Field TypeThe field type for
subscriber_genesis
is changed to use the new type:imuachain.appchain.common.v1.SubscriberGenesisState
This is consistent with the new package structure.
5-5
: Verify gogoproto ImportStatic analysis flagged the import of
"gogoproto/gogo.proto"
(line 5) as not found. Please verify that the file exists in your proto include paths or if an alternative dependency should be used.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
.github/workflows/proto.yml (3)
20-25
: Renamed Proto Build JobThe job has been renamed to
proto-build
and is configured to check out the code and generate proto files. This aligns well with the new naming convention.
36-47
: Renamed Proto Lint JobThe job
proto-lint
now correctly reflects the updated naming. It sets up Buf and lints the proto files accordingly.
48-66
: Renamed Proto Break-Check Job and Updated Comparison LogicThe job
proto-break-check
has been renamed and the change comparing against the base branch of the PR (instead ofHEAD~1
) is an improvement for verifying breaking changes. Thecontinue-on-error
remains appropriate for a non-failing check.proto/imuachain/oracle/v1/tx.proto (4)
3-3
: Updated Oracle Package DeclarationThe package declaration now reflects:
package imuachain.oracle.v1;
This update is consistent with the overall rebranding.
9-10
: Updated Oracle Import PathsThe import statements for:
import "imuachain/oracle/v1/params.proto";
import "imuachain/oracle/v1/price.proto";
are updated to the new paths, ensuring consistency in the project structure.
12-12
: Updated Go Package Option for Oracle ModuleThe option:
option go_package = "github.com/imua-xyz/imuachain/x/oracle/types";
correctly maps to the new repository structure.
5-5
: Verify Amino Import in Oracle ModuleStatic analysis indicates that the import of
"amino/amino.proto"
(line 5) might not be found. Please verify that this file exists under the expected path, or adjust the import accordingly if it has moved.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
docker-compose.yml (4)
4-12
: Rebranding in Service Definition (imuanode0)The service
imuanode0
now uses the updated container name, image ("imua/node"
), LOG environment variable (imua.log
), and volume mapping (/home/imua/data:Z
). The changes are consistent with the rebranding.
29-37
: Rebranding in Service Definition (imuanode1)The container name, image, and environment variables for
imuanode1
are updated to reflect the new branding.
54-62
: Rebranding in Service Definition (imuanode2)All relevant configurations for
imuanode2
(container name, image, LOG setting, and volume mapping) have been correctly updated.
79-87
: Rebranding in Service Definition (imuanode3)The service
imuanode3
has been updated consistently with the new naming conventions and configurations..goreleaser.yml (9)
8-12
: Updated Build Configuration for imuad-darwinThe build configuration for
imuad-darwin
now uses:
main: ./cmd/imuad
binary: bin/imuad
This correctly reflects the change from the old binary name to the new
imuad
.
22-23
: Updated Linker Flags for imuad-darwinThe linker flags are updated (e.g., replacing values to
-X ...Name=imua
and-X ...AppName=imuad
), ensuring that version information is correctly embedded.
24-32
: Updated Build Configuration for imuad-darwin-arm64The changes for the
imuad-darwin-arm64
build mirror those for the darwin build, correctly using the new entry point and binary name.
38-40
: Updated Build Configuration for imuad-linuxThe
imuad-linux
build configuration is updated with the new main entry and binary name. The linker flags are set appropriately.
52-53
: Updated Linker Flags for imuad-linuxLinker flags for the linux build are updated to use the new identifiers (
imua
andimuad
).
54-62
: Updated Build Configuration for imuad-linux-arm64The build configuration for
imuad-linux-arm64
is updated coherently with the new naming, including environment settings and linker flags.
68-71
: Updated Build Configuration for imuad-windowsThe
imuad-windows
configuration now points to the new main binary and includes correct linker flags, as well as Windows-specific build settings.
90-95
: Updated Archive Build ListThe archive configuration now lists the new build IDs for
imuad
across all supported platforms.
1-107
: Overall Goreleaser Configuration ReviewAll rebranding changes within the
.goreleaser.yml
file have been applied consistently. This includes updated build IDs, main entry points, binary names, environment variables, and linker flags.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 96-96: trailing spaces
(trailing-spaces)
proto/imuachain/feedistribution/v1/distribution.proto (2)
2-2
: Update package declaration to new namespace.The package is now defined as
imuachain.feedistribution.v1
, which is consistent with the rebranding effort.
8-8
: Update the go_package option to the new repository path.The go_package has been revised to
"github.com/imua-xyz/imuachain/x/feedistribution/types"
. Ensure this change is reflected across the Go module configuration.proto/imuachain/avs/v1/query.proto (4)
2-2
: Update package declaration for rebranding.The package is updated to
imuachain.avs.v1
, which aligns with the Imuachain branding.
7-7
: Update tx.proto import path.The import now reads
"imuachain/avs/v1/tx.proto"
to reflect the new namespace. Please verify that the file exists under the updated path.
9-9
: Revise go_package option to new repository structure.The option is updated to
"github.com/imua-xyz/imuachain/x/avs/types"
, which is consistent with the overall rebranding changes.
79-96
: Update HTTP endpoint options to reflect new branding.All RPC method HTTP options now use paths beginning with
/imuachain/avs/v1/
instead of the old/exocore/avs/v1/
. Please ensure that the API gateway and service routing are adjusted accordingly.cmd/imuachain-test-tool/README.md (6)
1-1
: Update CLI tool title to reflect new branding.The title now shows
# imua-test-tool
, which aligns with the Imuachain rebranding effort.
3-4
: Ensure documentation text reflects updated chain branding.The description now correctly refers to the "Imuachain chain" for test transactions and stress testing. This aligns with the overall rebrand objectives.
7-9
: Update node configuration instructions for Imuachain.The instructions now indicate that a customized Imuachain node is required—with the precompile's gateway contract address check disabled—and the branch URL has been updated accordingly.
🧰 Tools
🪛 LanguageTool
[grammar] ~7-~7: The verb ‘precompile’ does not usually follow articles like ‘the’. Check that ‘precompile’ is spelled correctly; using ‘precompile’ as a noun may be non-standard.
Context: ...se, with the node configured to disable the precompile's gateway contract address check. The b...(A_INFINITIVE)
21-24
: Confirm updated token and chain references in functionalities.The functionalities now mention
IMUA tokens
and theImuachain chain
, ensuring consistency with the new brand identity.
61-69
: Verify updated CLI commands for Imuachain.The shell commands (e.g.,
imua-test-tool init --home
andimua-test-tool start --home .
) now reflect the rebranded tool name. Please verify that these commands work as expected in the new environment.
111-114
: Update TODO to reflect rebranding for token batch testing.The TODO now specifies "Provide batch testing for IMUA tokens," which is consistent with the new naming conventions.
proto/imuachain/dogfood/v1/query.proto (6)
3-3
: Update package declaration to match new branding.The package is updated to
imuachain.dogfood.v1
, which aligns with the rebranding across the proto files.
9-10
: Update import paths for dogfood modules.The import statements now reference
"imuachain/dogfood/v1/dogfood.proto"
and"imuachain/dogfood/v1/params.proto"
, reflecting the new namespace. Please verify these paths.
12-12
: Update go_package option for dogfood.The go_package option is now
"github.com/imua-xyz/imuachain/x/dogfood/types"
, ensuring consistency with the rebranded module layout.
19-59
: Update HTTP endpoint paths in RPC service definitions.All HTTP options for the RPC methods have been changed from
/exocore/dogfood/v1/...
to/imuachain/dogfood/v1/...
. This ensures that the service endpoints are consistent with the new brand identity.
121-122
: Update validator response type to new structure.The
validator
field now usesImuachainValidator
instead of the old type. Confirm that this change is supported across related services and data structures.
133-134
: Ensure consistent validator list type in responses.The
validators
field now correctly usesrepeated ImuachainValidator
, ensuring consistency with the new type definitions.client/docs/config.json (12)
3-5
: Update documentation title to reflect new branding.The title has been updated to
"Imuachain - gRPC Gateway docs"
, ensuring that the documentation reflects the current project identity.
9-11
: Update epochs API endpoint URL.The URL for the epochs API is updated to
"./tmp-swagger-gen/imuachain/epochs/v1/query.swagger.json"
. Please ensure that the swagger generation process is aligned with this new path.
142-150
: Update dogfood API endpoint URL.The URL now points to
"./tmp-swagger-gen/imuachain/dogfood/v1/query.swagger.json"
, which is consistent with the rebranding.
152-158
: Update assets API endpoint URL.The assets endpoint is now
"./tmp-swagger-gen/imuachain/assets/v1/query.swagger.json"
. Verify that this file is generated correctly under the new naming scheme.
160-166
: Update slash API endpoint and operation rename.The URL has been updated to
"./tmp-swagger-gen/imuachain/slash/v1/query.swagger.json"
and the operation rename now uses"ImSlashParams"
, matching the new brand guidelines.
168-174
: Update oracle API endpoint URL.The oracle endpoint now correctly points to
"./tmp-swagger-gen/imuachain/oracle/v1/query.swagger.json"
.
176-182
: Update immint API endpoint URL and operation rename.The immint endpoint has been updated to
"./tmp-swagger-gen/imuachain/immint/v1/query.swagger.json"
with"ImmintParams"
as the renamed operation parameter. This is consistent with the rebranding effort.
184-190
: Update feedistribution API endpoint URL and operation rename.The URL now points to
"./tmp-swagger-gen/imuachain/feedistribution/v1/query.swagger.json"
and the operation rename is updated to"FeeDistributionParams"
.
192-193
: Update delegation API endpoint URL.The URL is updated to
"./tmp-swagger-gen/imuachain/delegation/v1/query.swagger.json"
, reflecting the new folder structure.
195-196
: Update AVS API endpoint URL.The AVS endpoint now correctly uses
"./tmp-swagger-gen/imuachain/avs/v1/query.swagger.json"
.
198-199
: Update operator API endpoint URL.The operator endpoint has been updated to
"./tmp-swagger-gen/imuachain/operator/v1/query.swagger.json"
.
225-231
: Update reward API endpoint URL and operation rename.The reward API now points to
"./tmp-swagger-gen/imuachain/reward/v1/query.swagger.json"
with the operation parameter renamed to"RewardParams"
, ensuring full consistency with the new brand identity.proto/imuachain/assets/v1/query.proto (5)
2-2
: Namespace Updated to Imuachain:
The package declaration is now set toimuachain.assets.v1
, which correctly reflects the new branding across the assets module.
4-4
: Static Analysis Warning on Pagination Import:
The static analysis tool flags the import of"cosmos/base/query/v1beta1/pagination.proto"
as not existing. Please verify that the intended pagination proto file is available in your repository or update the import path accordingly.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
9-11
: Updated Import Paths:
The imports forgenesis.proto
,params.proto
, andtx.proto
have been updated to use the newimuachain/assets/v1/
paths, ensuring consistency with the new project naming. Confirm that these files are located at the expected paths in the repository.
13-13
: Go Package Option Updated:
Thego_package
option now referencesgithub.com/imua-xyz/imuachain/x/assets/types
, which is in line with the rebranding effort.
106-148
: HTTP Endpoints Rebranded:
All RPC method HTTP options have been updated from the old/exocore/assets/v1/...
prefix to/imuachain/assets/v1/...
(for example, endpoints for/params
,/client_chain/{chain_index}
,/all_client_chains
,/asset/{asset_id}
, etc.). Verify that client integrations and documentation are updated accordingly to reflect these changes.proto/imuachain/assets/v1/tx.proto (8)
2-2
: Namespace Updated to Imuachain:
The package declaration is updated toimuachain.assets.v1
, which supports the new branding initiative.
4-4
: Static Analysis on Amino Import:
The static analysis tool indicates that the import"amino/amino.proto"
may not exist. Please verify this dependency or adjust the path if necessary.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
9-9
: Updated Params Import:
The import forimuachain/assets/v1/params.proto
is now correct and conforms to the new namespace requirements.
11-11
: Go Package Option Rebranded:
Thego_package
option now reflects the new module path (github.com/imua-xyz/imuachain/x/assets/types
), ensuring consistency with the rebranding.
30-32
: Field Renaming in ClientChainInfo:
The messageClientChainInfo
now includes the fieldimua_chain_index
(line 31) to replace the previous chain index reference. Ensure that any clients consuming this message are updated to handle the new field name.
54-57
: Field Renaming in AssetInfo:
The messageAssetInfo
now uses the fieldimua_chain_index
(line 56–57) to represent the client chain index. Verify that downstream systems referencing this field are adjusted accordingly.
167-169
: Updated Comment in RegisterAssetReq:
The comment now refers to "Imuachain" instead of Exocore, which clarifies the context of this message in line with the new branding effort.
205-205
: Rebranded RPC Endpoint for MsgUpdateParams:
The HTTP POST endpoint forMsgUpdateParams
is now set to/imuachain/assets/v1/tx/MsgUpdateParams
. Ensure that any client-side references or documentation are updated to match this new endpoint.proto/imuachain/oracle/v1/query.proto (5)
3-3
: Package Declaration Rebranded:
The package is now declared asimuachain.oracle.v1
, which properly aligns with the new Imuachain branding.
5-5
: Static Analysis Warning on Pagination Import:
Similar to other modules, the static analysis tool flags the import of"cosmos/base/query/v1beta1/pagination.proto"
. Please confirm that this file is available or adjust the import as needed.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
8-16
: Updated Oracle Imports:
All import statements (lines 8–16) now point to paths underimuachain/oracle/v1/
, replacing the old Exocore references. This change supports consistent rebranding across the Oracle module.
18-18
: Go Package Option Updated:
The optiongo_package
is updated togithub.com/imua-xyz/imuachain/x/oracle/types
, which is correct for the current rebranding effort.
23-95
: HTTP Endpoints Rebranded:
The RPC serviceQuery
has updated HTTP options for all its methods—from/token_indexes
to/recent_params
—now using the/imuachain/oracle/v1/
prefix. Verify that both server and client implementations have been updated to work with these new endpoints.go.mod (3)
1-1
: Module Name Updated:
The module has been changed togithub.com/imua-xyz/imuachain
, which fully aligns with the rebranding objectives.
26-26
: Price Feeder Dependency Updated:
The dependency ongithub.com/imua-xyz/price-feeder
(v0.1.16-0.20250219142917-5ea492552d53) replaces the previous version. This change indicates a move to the Imua fork/version—ensure that compatibility tests are run.
277-279
: Evmos Replacement Directive Updated:
The replacement for the Evmos module now usesgithub.com/imua-xyz/evmos/v16
instead of the Exocore fork. Please verify the functionality of this fork in your build environment.local_node.sh (8)
6-6
: CHAINID Updated:
The chain ID has been updated toimualocalnet_232-1
, which is consistent with the Imuachain identity. Verify that dependent scripts and configuration files use this new value.
15-15
: Home Directory Updated:
The dedicated home directory variable is now set to$HOME/.tmp-imuad
, ensuring that the local node uses a directory named after the new binary (imuad
).
68-70
: Daemon Command Updated:
The configuration commands now use theimuad
binary (e.g.,imuad config keyring-backend
andimuad config chain-id
), replacing the oldexocored
commands. This update is crucial for consistency in command-line operations under the new branding.
86-88
: Local Address Variable Rebranded:
The script extracts the local funded account address usingimuad keys show
and assigns it toLOCAL_ADDRESS_IM
, which replaces the previous Exocore variable. Ensure that downstream genesis configuration references this new variable.
90-91
: Operator Address Display:
The echo statement now outputs the local operator address usingLOCAL_ADDRESS_IM
, verifying that the rebranding has propagated through the display messages.
117-117
: Genesis Configuration Rebrand:
The genesis update (via jq) now sets the operator field to the value ofLOCAL_ADDRESS_IM
. This change helps ensure that the initial state reflects the new Imua address standard.
240-243
: Oracle Feeder YAML Updated:
Within the generatedoracle_feeder.yaml
content, the new block underimua:
(with fields such aschainid
,appName: imua
, and RPC/WS endpoints) correctly reflects the new branding. Verify that these settings work with the updated oracle feeder service.
339-339
: Start Command Rebrand:
The final command to start the node now callsimuad start
with parameters that include the new chain ID and other updated flags. Confirm that the network starts as expected with the new branding configuration.Makefile (7)
9-9
: Rebranding Binary Variable Update
The variable has been updated to use the new binary nameimuad
. This change is consistent with the new Imuachain branding.
11-11
: Repository URL Update
TheHTTPS_GIT
variable now points tohttps://github.com/imua-xyz/imuachain
, fully aligning with the rebranding effort.
20-21
: Namespace and Project Name Revision
The variablesNAMESPACE
andPROJECT
have been updated to reflectimua-xyz
andimuachain
respectively. This change ensures that the branding is consistent throughout the build process.
70-71
: Linker Flags Update to Support Branding
The linker flags have been updated to embed the new project name and binary (via$(IMUACHAIN_BINARY)
) in the version information. Verify that these embedded values are used consistently in downstream reporting tools and that there are no residual references to the old branding.
139-141
: Build Tooling for Test Utility Updated
The build and install commands for the test tool now referenceimuachain-test-tool
. This is important for consistency with the new naming conventions.
504-505
: Localnet Initialization Command Revision
The command in thelocalnet-init
target now usesimuad
for initializing testnet files, and the chain ID has been updated (imualocalnet_232-1
). Ensure that any external scripts or integrations expecting the old binary name are updated accordingly.
546-546
: Go Module Package Name Update
ThePACKAGE_NAME
is now set togithub.com/imua-xyz/imuachain
, which finalizes the rebranding in the Go module structure.proto/imuachain/reward/v1/params.proto (1)
1-7
: New Proto File for Reward Module
This new file defines the reward module parameters with the correct syntax, package declaration (imuachain.reward.v1
), and go_package path. The changes correctly reflect the new project branding.Note on Directory Structure:
Similar to the slash module, static analysis flags a potential issue if the file location (proto/imuachain/reward/v1/params.proto
) does not match the expected directory (imuachain/reward/v1
). If this is intentional, please verify that your Buf configuration accommodates the directory layout.🧰 Tools
🪛 Buf (1.47.2)
2-2: Files with package "imuachain.reward.v1" must be within a directory "imuachain/reward/v1" relative to root but were in directory "proto/imuachain/reward/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/appchain/subscriber/v1/tx.proto (1)
1-9
: New Service Definition for Appchain Subscriber
A new proto file is introduced that defines the packageimuachain.appchain.subscriber.v1
and specifies the go_package accordingly. The addition of the emptyMsg
service establishes the foundation for future RPC method definitions.Directory Structure Note:
Static analysis hints suggest that files with this package should reside inimuachain/appchain/subscriber/v1
, but here they are underproto/imuachain/appchain/subscriber/v1
. Given that Buf can manage proto file organization via its configuration, confirm that the current structure is intentional and documented.🧰 Tools
🪛 Buf (1.47.2)
3-3: Files with package "imuachain.appchain.subscriber.v1" must be within a directory "imuachain/appchain/subscriber/v1" relative to root but were in directory "proto/imuachain/appchain/subscriber/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/oracle/v1/index_recent_msg.proto (1)
1-5
: Rebranding of Oracle Module Proto File
The proto file now declares its package asimuachain.oracle.v1
and updates thego_package
option togithub.com/imua-xyz/imuachain/x/oracle/types
. These updates are consistent with the overall rebranding initiative.Static Analysis Advisory:
Buf reports that the file is located inproto/imuachain/oracle/v1
instead of underimuachain/oracle/v1
relative to the repository root. If this layout is intentional because of your project structure and Buf configuration, please ensure it is clearly documented to avoid future confusion.🧰 Tools
🪛 Buf (1.47.2)
2-2: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/oracle/v1/index_recent_params.proto (1)
2-4
: Rebranding update with directory structure concern.
The package declaration and the Go package option have been correctly updated to reflect the new Imuachain branding. However, Buf analysis indicates that files with the packageimuachain.oracle.v1
should reside in a directoryimuachain/oracle/v1
relative to the repository root, whereas this file is currently located inproto/imuachain/oracle/v1
. Please consider relocating the file to meet the expected directory structure.
[critical_issue, refactor_suggestion_essential]🧰 Tools
🪛 Buf (1.47.2)
2-2: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/oracle/v1/validator_update_block.proto (1)
2-4
: Rebranding update with directory structure concern.
The package and Go package option have been updated toimuachain.oracle.v1
andgithub.com/imua-xyz/imuachain/x/oracle/types
respectively, which correctly aligns with the new branding. However, similar to the previous file, Buf expects files with this package to be located inimuachain/oracle/v1
relative to the repo root. Please verify and adjust the file location if necessary.
[critical_issue, refactor_suggestion_essential]🧰 Tools
🪛 Buf (1.47.2)
2-2: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/assets/v1/params.proto (2)
2-6
: Rebranding update confirmed.
The package declaration (imuachain.assets.v1
) and the updated Go package option are now consistent with the new Imua branding.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
4-4
: Missing or mislocated dependency:gogoproto/gogo.proto
.
Static analysis reports that the importgogoproto/gogo.proto
cannot be found. Please verify that the dependency is correctly installed or adjust the import path if needed.
[verify, refactor_suggestion_good_to_have]🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/recent_params.proto (2)
2-6
: Rebranding update with directory structure concern.
The package declaration and the Go package option have been updated to reflect the new branding (imuachain.oracle.v1
andgithub.com/imua-xyz/imuachain/x/oracle/types
), which is good. However, ensure that this file is physically located inimuachain/oracle/v1
relative to the repository root to satisfy Buf’s directory structure expectations.
[critical_issue, refactor_suggestion_essential]🧰 Tools
🪛 Buf (1.47.2)
4-4: import "imuachain/oracle/v1/params.proto": file does not exist
(COMPILE)
4-4
: Invalid import path forparams.proto
.
The import statementimport "imuachain/oracle/v1/params.proto";
is flagged by static analysis because the file cannot be located. Please verify the correct relative path (possibly due to file relocation during rebranding) and update the statement accordingly.
[critical_issue, verify]🧰 Tools
🪛 Buf (1.47.2)
4-4: import "imuachain/oracle/v1/params.proto": file does not exist
(COMPILE)
proto/imuachain/reward/v1/genesis.proto (2)
2-7
: Rebranding update in reward genesis.
The package declaration (imuachain.reward.v1
), the import update for reward params, and the Go package option have all been successfully updated to align with the new branding.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
4-4
: Missing dependency:gogoproto/gogo.proto
.
Static analysis indicates that the imported filegogoproto/gogo.proto
cannot be found. Please verify that this dependency is available in your proto include paths, or adjust/remove the import if it is no longer needed.
[verify, refactor_suggestion_good_to_have]🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/immint/v1/genesis.proto (3)
2-2
: Package Declaration Updated
The package declaration is correctly updated toimuachain.immint.v1
, which aligns with the rebranding objectives.
4-5
: Verify Import Dependencies
The import on line 5 for"imuachain/immint/v1/params.proto"
has been updated to match the new namespace. However, note that the static analysis warning on line 4 regardingimport "gogoproto/gogo.proto";
indicates that this file might not exist. Please verify that this dependency is available in your build environment or adjust the import if necessary.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
7-9
: go_package and Documentation Update
Thego_package
option on line 7 has been updated to"github.com/imua-xyz/imuachain/x/immint/types"
, and the genesis state comment on line 9 now properly refers to the immint module. These changes are consistent with the overall rebranding.proto/imuachain/appchain/coordinator/v1/genesis.proto (4)
3-3
: Package Declaration Update
The package has been updated from its old name toimuachain.appchain.coordinator.v1
, reflecting the new branding accurately.
5-5
: Static Analysis Check on Import Reference
The import on line 5 for"gogoproto/gogo.proto"
triggers a static analysis warning. Please verify that this file is available or adjust the import if it has been relocated.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
6-6
: Import Path Rebranding
The import on line 6 now correctly references"imuachain/appchain/coordinator/v1/params.proto"
, ensuring consistency with the new namespace.
8-8
: go_package Option Updated
Thego_package
option on line 8 is updated to"github.com/imua-xyz/imuachain/x/appchain/coordinator/types"
, which is in line with the new rebranding.proto/imuachain/slash/v1/genesis.proto (3)
2-2
: Package Declaration Update
The package declaration is nowimuachain.slash.v1
, which correctly reflects the updated branding.
4-5
: Review Import Dependencies
The import on line 5 for"imuachain/slash/v1/params.proto"
is correctly updated. However, as in previous files, the import on line 4 for"gogoproto/gogo.proto"
may require verification due to static analysis warnings.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
8-10
: go_package and Comment Refinement
Thego_package
option and accompanying comment (line 10) have been updated to reflect the imuaslash module. These changes are consistent with the rebranding effort.proto/imuachain/oracle/v1/prices.proto (3)
2-2
: Package Declaration Updated
The package declaration is nowimuachain.oracle.v1
, which is appropriate for the new branding.
4-5
: Import Path Rebranding and Dependency Check
The import on line 5 now references"imuachain/oracle/v1/price.proto"
, aligning with the new namespace. Please verify the existence of"gogoproto/gogo.proto"
on line 4 as per static analysis findings.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
7-7
: go_package Option Update
Thego_package
option is updated to"github.com/imua-xyz/imuachain/x/oracle/types"
, reflecting the rebranding accurately.proto/imuachain/oracle/v1/slashing.proto (2)
3-3
: Directory Structure & Package Consistency Check
The package is declared asimuachain.oracle.v1
, but static analysis indicates it should reside in a directory structure likeimuachain/oracle/v1
relative to the repository root. Please confirm that the file location is intentional and that your build configuration supports this layout.🧰 Tools
🪛 Buf (1.47.2)
3-3: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
5-5
: go_package Option Updated
Thego_package
option on line 5 has been updated to"github.com/imua-xyz/imuachain/x/oracle/types"
, which aligns with the rebranding standards.proto/imuachain/epochs/v1/epochs.proto (2)
3-3
: Package Declaration Updated ConsistentlyThe package has been updated to
imuachain.epochs.v1
to reflect the new branding.🧰 Tools
🪛 Buf (1.47.2)
3-3: Files with package "imuachain.epochs.v1" must be within a directory "imuachain/epochs/v1" relative to root but were in directory "proto/imuachain/epochs/v1".
(PACKAGE_DIRECTORY_MATCH)
5-5
: Go Package Option Updated CorrectlyThe
go_package
option now referencesgithub.com/imua-xyz/imuachain/x/epochs/types
, which aligns with the rebranding effort.proto/imuachain/oracle/v1/nonce.proto (2)
2-2
: Package Declaration Updated CorrectlyThe package is now
imuachain.oracle.v1
, which is consistent with the planned rebranding changes.
6-6
: Go Package Option Reflects New RepositoryThe
go_package
option is now set togithub.com/imua-xyz/imuachain/x/oracle/types
, matching the new module structure.proto/imuachain/reward/v1/query.proto (5)
2-2
: Package Declaration Reflects RebrandingThe package declaration is updated to
imuachain.reward.v1
, which aligns with the new brand identity.
5-5
: Import Path forparams.proto
UpdatedImporting from
imuachain/reward/v1/params.proto
is now consistent with the restructured repository paths.
7-7
: Go Package Option Updated AccordinglyThe
go_package
option now points togithub.com/imua-xyz/imuachain/x/reward/types
, ensuring consistency across the project.
13-13
: HTTP Endpoint UpdatedThe HTTP option for the
Params
RPC method has been updated to/imuachain/reward/v1/params
, which aligns with the new naming conventions.
4-4
: Annotations Import VerificationStatic analysis reports that
google/api/annotations.proto
could not be found. Please ensure that the dependency is correctly included or update the import path accordingly.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "google/api/annotations.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/recent_msg.proto (3)
2-2
: Package Declaration Updated SuccessfullyThe package is now
imuachain.oracle.v1
, which meets the rebranding objectives.
5-5
: Price Proto Import UpdatedThe import has been updated to
imuachain/oracle/v1/price.proto
, which is consistent with the new naming and file structure.
7-7
: Go Package Option Updated ConsistentlyThe
go_package
option correctly points togithub.com/imua-xyz/imuachain/x/oracle/types
.proto/imuachain/slash/v1/query.proto (5)
2-2
: Package Declaration Updated to New StandardsThe package is now
imuachain.slash.v1
, which reflects the intended structural change from Exocore to Imuachain.
4-4
: Annotations Proto Import VerificationStatic analysis indicates that
google/api/annotations.proto
might be missing. Please verify that this file is available in your dependency paths or adjust the import directive if necessary to align with your project setup.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "google/api/annotations.proto": file does not exist
(COMPILE)
5-5
: Params Import Path Updated CorrectlyThe import for
params.proto
now usesimuachain/slash/v1/params.proto
, which fits the project’s rebranding.
8-8
: Go Package Option UpdatedThe
go_package
option now correctly referencesgithub.com/imua-xyz/imuachain/x/slash/types
.
13-13
: HTTP Option Updated for Consistent API RoutingThe HTTP endpoint is updated to
/imuachain/slash/v1/params
, ensuring that external API calls follow the new namespace.proto/imuachain/reward/v1/types.proto (3)
3-4
: Update Package Declaration to Reflect New Branding
The package declaration has been updated fromexocore.reward.v1
toimuachain.reward.v1
, which properly aligns this proto definition with the rebranding effort. Please ensure that all dependent modules and services are updated accordingly.
8-8
: Update Go Package Option for Repository Restructuring
Thego_package
option is now set to"github.com/imua-xyz/imuachain/x/reward/types"
, matching the new repository path. This change supports consistent Go package imports throughout the project.
5-5
: Verify Existence of Imported Proto File
The file imports"cosmos/base/v1beta1/coin.proto"
. A static analysis hint indicates that this file might not exist. Please verify that the proto dependency is correctly located on your include path or update the import to the correct path if needed.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos/base/v1beta1/coin.proto": file does not exist
(COMPILE)
proto/imuachain/immint/v1/params.proto (3)
2-2
: Update Package Declaration to New Namespace
The package now reads asimuachain.immint.v1
, which aligns with the new branding. Verify that all cross-file references to the exomint module have been updated accordingly.
7-7
: Update Go Package Option for Immint Module
Thego_package
is updated to"github.com/imua-xyz/imuachain/x/immint/types"
, reflecting the repository’s restructuring.
4-4
: Verify Imported Cosmos Proto Dependency
The file imports"cosmos_proto/cosmos.proto"
, but static analysis reports that the file may not exist. Please confirm that this import path is correct (or update it to the proper location) to avoid compilation issues.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/query.proto (5)
2-2
: Update Package Declaration to New Feedistribution Namespace
The package declaration now usesimuachain.feedistribution.v1
, which is consistent with the rebranding for this module.
7-7
: Update Import of Params Proto File
The import has been updated to"imuachain/feedistribution/v1/params.proto"
. This aligns with the changes in other parts of the codebase.
9-9
: Update Go Package Option for Feedistribution Module
Thego_package
option now points to"github.com/imua-xyz/imuachain/x/feedistribution/types"
, which is correct post-rebranding.
15-15
: HTTP Endpoint Updated to Reflect Branding Changes
The HTTP GET endpoint in the RPC options has been updated to"/imuachain/feedistribution/v1/params"
, which now aligns with the new namespace.
4-4
: Verify Imported Amino Proto File
Static analysis indicates that"amino/amino.proto"
may not exist. Please check that the dependency is correctly installed or update the path to the proper file.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/subscriber/v1/query.proto (6)
3-3
: Update Package Declaration for Subscriber Module
The package declaration has been updated toimuachain.appchain.subscriber.v1
, consistent with the overall rebranding and module restructuring.
7-7
: Update Import for Common Proto File
The import has been changed to"imuachain/appchain/common/v1/common.proto"
. This ensures all references within the subscriber module use the updated namespace.
9-9
: Update Go Package Option for Subscriber Module
Thego_package
option is now"github.com/imua-xyz/imuachain/x/appchain/subscriber/types"
, which correctly reflects the new repository structure.
25-25
: Update Field Type to Use New SubscriberParams
Within theQueryParamsResponse
message, the field type has been updated toimuachain.appchain.common.v1.SubscriberParams
, ensuring that the proto references point to the current definitions.
5-5
: Verify Existence of Imported Gogoproto File
Static analysis notes that the import"gogoproto/gogo.proto"
could not be found. Please verify that this dependency is available or update the path accordingly to prevent proto compilation errors.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
14-15
: Review HTTP Endpoint Consistency
The RPC method for querying parameters uses the HTTP GET mapping"/appchain/subscriber/params"
. Given the rebranding, consider whether the endpoint should incorporate theimuachain
namespace (e.g.,"/imuachain/appchain/subscriber/params"
) for consistency with other modules.proto/imuachain/slash/v1/tx.proto (4)
2-2
: Update Package Declaration for Slash Module
The package declaration has been updated toimuachain.slash.v1
, matching the new branding configuration for the slash module.
7-7
: Update Import for Slash Params Proto File
The import now references"imuachain/slash/v1/params.proto"
, ensuring that the code relies on the updated proto definitions.
9-9
: Update Go Package Option for Slash Module
Thego_package
option has been updated to"github.com/imua-xyz/imuachain/x/slash/types"
, reflecting the repository’s new structure.
4-4
: Verify Imported Cosmos Msg Proto
Static analysis reports that the import"cosmos/msg/v1/msg.proto"
may not exist. Please confirm that this proto file is available under the expected path, or adjust the import to the proper location if necessary.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
proto/imuachain/reward/v1/tx.proto (3)
3-3
: Package Declaration Update
The package declaration has been updated fromexocore.reward.v1
toimuachain.reward.v1
, which correctly reflects the new branding.
8-8
: Updated Import Path
The import forparams.proto
has been changed to"imuachain/reward/v1/params.proto"
, ensuring consistency with the new namespace.
10-10
: Go Package Option Revised
Thego_package
option now points to"github.com/imua-xyz/imuachain/x/reward/types"
, aligning with the repository rebranding.proto/imuachain/dogfood/v1/params.proto (2)
3-3
: Namespace Update for Dogfood Module
The package declaration has been updated toimuachain.dogfood.v1
, which is consistent with the overall rebranding effort.
8-8
: Go Package Option Update
Thego_package
has been updated to"github.com/imua-xyz/imuachain/x/dogfood/types"
. This change supports the new project structure and branding.proto/imuachain/appchain/coordinator/v1/params.proto (5)
3-3
: Rebranded Package Declaration
The package has been revised toimuachain.appchain.coordinator.v1
, matching the updated namespace for the application chain coordinator module.
8-8
: Epochs Import Update
The import has been modified from the old namespace to"imuachain/epochs/v1/epochs.proto"
, ensuring that epoch-related types are sourced correctly.
10-10
: Go Package Option Revision
Thego_package
option now correctly points to"github.com/imua-xyz/imuachain/x/appchain/coordinator/types"
, which aligns with the new repository structure.
30-30
: Field Type Namespace Update
The fieldinit_timeout_period
has been updated to use the type fromimuachain.epochs.v1.Epoch
. This change is crucial to maintain type consistency after the rebranding.
33-33
: Consistent Update for Timeout Field
The fieldvsc_timeout_period
now usesimuachain.epochs.v1.Epoch
, ensuring that all epoch references are consistent with the new namespace.proto/imuachain/oracle/v1/info.proto (2)
2-2
: Oracle Package Namespace Updated
The package declaration has been changed toimuachain.oracle.v1
, which is in line with the comprehensive rebranding.
6-6
: Go Package Option Corrected
Thego_package
option is now set to"github.com/imua-xyz/imuachain/x/oracle/types"
, ensuring consistency in Go module references across the project.proto/imuachain/oracle/v1/price.proto (2)
3-3
: Updated Oracle Package Declaration
The package declaration is updated toimuachain.oracle.v1
, which reflects the new branding in all oracle-related protocol definitions.
7-7
: Revised Go Package Option
Thego_package
option now points to"github.com/imua-xyz/imuachain/x/oracle/types"
. This update is consistent with our repository rebranding guidelines.proto/imuachain/oracle/v1/token_feeder.proto (3)
2-2
: Updated Package Declaration
The package has been correctly updated fromexocore.oracle.v1
toimuachain.oracle.v1
, which aligns with the rebranding effort.
4-4
: Verify gogoproto Import
The import"gogoproto/gogo.proto"
is used as-is; however, static analysis indicates the file might be missing. Please verify that this dependency is managed (for example, via vendoring or an external dependency) to avoid build issues.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
6-6
: Updated Go Package Option
Thego_package
option has been updated to"github.com/imua-xyz/imuachain/x/oracle/types"
, which is consistent with the new module namespace for Imuachain.proto/imuachain/appchain/coordinator/v1/tx.proto (6)
3-3
: Updated Package Declaration
The package declaration now readsimuachain.appchain.coordinator.v1
, reflecting the rebranding.
5-5
: Verify Cosmos Import
The import"cosmos/msg/v1/msg.proto"
is flagged by static analysis. Ensure that this file is either included in the repository or provided as an external dependency so that the build can locate it correctly.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
9-9
: Updated Import Path
The import has been updated to"imuachain/appchain/common/v1/common.proto"
. This change correctly reflects the new namespace structure.
11-11
: Updated Go Package Option
Thego_package
option is now set to"github.com/imua-xyz/imuachain/x/appchain/coordinator/types"
, which is in line with the rebranding changes.
19-19
: Updated HTTP Endpoint
The HTTP POST endpoint has been updated to/imuachain/appchain/coordinator/v1/tx/RegisterSubscriberChain
, which correctly reflects the change from Exocore to Imuachain.
50-50
: Updated SubscriberParams Field
The field type forsubscriber_params
has been updated toimuachain.appchain.common.v1.SubscriberParams
, ensuring consistency with the new package structure. Please confirm that the referenced type exists in the updated module.proto/imuachain/delegation/v1/genesis.proto (4)
3-3
: Updated Package Declaration
The package is now declared asimuachain.delegation.v1
, which reflects the rebranding changes from Exocore.
5-5
: Verify gogoproto Import
The import"gogoproto/gogo.proto"
appears here as well. Since static analysis reports it may not exist, please ensure the dependency is appropriately managed within your build system.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
6-7
: Updated Import Paths
The imports for"imuachain/delegation/v1/query.proto"
and"imuachain/delegation/v1/tx.proto"
have been correctly updated. This ensures that inter-module references are aligned with the new naming convention.
9-9
: Updated Go Package Option
Thego_package
option is now set to"github.com/imua-xyz/imuachain/x/delegation/types"
, which is consistent with the new project branding.proto/imuachain/avs/v1/genesis.proto (4)
2-2
: Updated Package Declaration
The package has been updated toimuachain.avs.v1
, which aligns with the overall rebranding effort.
4-4
: Verify gogoproto Import
The file"gogoproto/gogo.proto"
is again imported here. Verify its availability via dependency management or document its inclusion to quiet static analysis warnings.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
5-5
: Updated tx.proto Import Path
The import has been changed to"imuachain/avs/v1/tx.proto"
, ensuring that it now references the correct module for AVS-related transaction definitions.
7-7
: Updated Go Package Option
Thego_package
option now correctly points to"github.com/imua-xyz/imuachain/x/avs/types"
.proto/imuachain/epochs/v1/query.proto (8)
3-3
: Updated Package Declaration
The package declaration is nowimuachain.epochs.v1
, reflecting the new Imuachain branding.
5-5
: Verify Cosmos Pagination Import
The import"cosmos/base/query/v1beta1/pagination.proto"
is flagged by static analysis. Please verify this dependency’s availability or adjust the path if necessary.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
6-6
: Verify gogoproto Import
Similar to other files, the"gogoproto/gogo.proto"
import might cause static analysis warnings if not managed correctly. Confirm that this dependency is resolved.
9-9
: Updated Genesis Import Path
The import for genesis information has been updated to"imuachain/epochs/v1/genesis.proto"
, ensuring consistency with the rebranding.
11-11
: Updated Go Package Option
Thego_package
option now correctly points to"github.com/imua-xyz/imuachain/x/epochs/types"
.
17-17
: Updated HTTP Endpoint for EpochInfos
The HTTP GET endpoint has been updated to/imuachain/epochs/v1/epochs
, which is in line with the new namespace.
21-21
: Updated HTTP Endpoint for CurrentEpoch
The endpoint/imuachain/epochs/v1/current_epoch/{identifier}
reflects the proper rebranding and is correct.
25-25
: Updated HTTP Endpoint for EpochInfo
The endpoint has been updated to/imuachain/epochs/v1/epoch/{identifier}
, ensuring consistency across API routes.proto/imuachain/oracle/v1/genesis.proto (3)
3-3
: Package Declaration UpdateThe package declaration has been updated from the old namespace to
imuachain.oracle.v1
, which is consistent with the rebranding objectives.
6-14
: Updated Import PathsAll imported proto files (e.g.
index_recent_msg.proto
,index_recent_params.proto
,native_token.proto
,params.proto
,prices.proto
,recent_msg.proto
,recent_params.proto
,slashing.proto
, andvalidator_update_block.proto
) now use the newimuachain/oracle/v1/
path. This ensures consistency with the new project namespace.
16-16
: Go Package Option UpdateThe
go_package
option has been correctly updated to"github.com/imua-xyz/imuachain/x/oracle/types"
, which aligns with the new repository structure.proto/imuachain/epochs/v1/genesis.proto (2)
3-3
: Package Declaration UpdateThe package declaration is updated to
imuachain.epochs.v1
, reflecting the new branding.
9-9
: Go Package Option UpdateThe
go_package
option is now set to"github.com/imua-xyz/imuachain/x/epochs/types"
, which is in line with the rebranding effort.proto/imuachain/oracle/v1/params.proto (4)
2-2
: Package Declaration UpdateThe package has been updated to
imuachain.oracle.v1
to reflect the new project namespace.
7-8
: Import Path UpdatesThe import statements for
info.proto
andtoken_feeder.proto
now correctly reference the new namespace (imuachain/oracle/v1/
).
10-10
: Go Package Option UpdateThe
go_package
option has been updated to"github.com/imua-xyz/imuachain/x/oracle/types"
, ensuring the generated Go code will reside in the correct package.
4-4
: Static Analysis – Verify Dependency AvailabilityStatic analysis (Buf 1.47.2) reports that
amino/amino.proto
(imported on line 4) does not exist. Please verify that this dependency is either provided by your vendor tools or adjust the import path if needed.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/genesis.proto (4)
2-2
: Package Declaration UpdateThe package declaration has been updated to
imuachain.feedistribution.v1
, which is now consistent with the new branding.
6-7
: Updated Import PathsThe import statements now reference
imuachain/feedistribution/v1/distribution.proto
andimuachain/feedistribution/v1/params.proto
instead of the old paths. This change supports the overall rebranding.
9-9
: Go Package Option UpdateThe
go_package
option is updated to"github.com/imua-xyz/imuachain/x/feedistribution/types"
, consistent with the new repository layout.
4-4
: Static Analysis – Verify Dependency AvailabilityBuf reports that
amino/amino.proto
(imported on line 4) does not exist. Please confirm whether this dependency is provided externally or if the import path should be revised.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/assets/v1/genesis.proto (4)
2-2
: Package Declaration UpdateThe package declaration is now
imuachain.assets.v1
, aligning with the rebranding from Exocore to Imuachain.
6-7
: Updated Import PathsThe import statements for
params.proto
andtx.proto
have been updated to use the newimuachain/assets/v1/
path. This helps maintain consistency in the project’s namespace.
9-9
: Go Package Option UpdateThe
go_package
option is updated to"github.com/imua-xyz/imuachain/x/assets/types"
, which matches the rebranding requirements.
4-4
: Static Analysis – Verify Dependency AvailabilityStatic analysis (Buf 1.47.2) indicates that
cosmos_proto/cosmos.proto
(imported on line 4) does not exist. Please verify the correctness of this import—ensure that the file is available or update the dependency management accordingly.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/operator/v1/validator.proto (3)
2-2
: Rebranding Package Declaration Updated
The package declaration has been correctly changed from the old namespace toimuachain.operator.v1
.
10-10
: Go Package Option Rebranded
Thego_package
option is updated to the new repository path. This ensures consistency with the rebranding effort.
4-4
: Confirm Import Path for Amino Proto
The file still importsamino/amino.proto
, but static analysis hints suggest that this file may not exist. Please verify that this import path is correct or update it if a new location is available.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/delegation/v1/tx.proto (4)
2-2
: Updated Package Declaration for Delegation Proto
The package has been correctly renamed toimuachain.delegation.v1
, aligning with the rebranding requirements.
9-9
: Updated Go Package Option for Delegation Proto
Thego_package
option has been updated to point togithub.com/imua-xyz/imuachain/x/delegation/types
, ensuring consistency with the overall project rebrand.
4-4
: Verify Amino Proto Import
The import"amino/amino.proto"
appears again here; please confirm that the file exists under your current repository setup or adjust the import path accordingly.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
71-74
: Rebranded In-Message Comments
The inline comments for fields such astx_hash
andblock_number
have been updated to reference the Imuachain chain instead of Exocore. This rebranding aligns with the new identity.proto/imuachain/dogfood/v1/genesis.proto (4)
3-3
: Namespace Update for Dogfood Genesis Proto
The package declaration is updated toimuachain.dogfood.v1
, which is consistent with the rebranding effort.
7-7
: Import Path Updated for Module Parameters
The import forparams.proto
now correctly referencesimuachain/dogfood/v1/params.proto
.
9-9
: Go Package Option Rebranded for Dogfood Module
Thego_package
option now points togithub.com/imua-xyz/imuachain/x/dogfood/types
, ensuring that external references are updated.
5-5
: Verify Amino Proto Import
The import"amino/amino.proto"
appears on line 5. As with other files, please verify that the file is available in the project or update the path if necessary.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/common/v1/common.proto (4)
3-3
: Package Declaration Rebranded for Appchain Common Proto
The package declaration has been updated toimuachain.appchain.common.v1
, in line with the new project identity.
11-11
: Updated Go Package Option for Common Proto
Thego_package
option now correctly points to the Imuachain repository path.
5-5
: Verify Amino Proto Import
Again, the import"amino/amino.proto"
is used here. Please ensure that the file exists or update the reference if needed.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
28-32
: Rebranded Inline Comments in Module Parameters
The comments regarding the distribution transmission channel now referenceImuachain
instead of the previous branding. This is a clean and consistent update.app/ante/handler_options.go (1)
16-18
: Updated Import Paths for Ante Handler Options
The import paths forcosmosante
,evmante
, andanteutils
have been updated togithub.com/imua-xyz/imuachain/app/ante/<module>
, which is correctly in line with the rebranding.🧰 Tools
🪛 golangci-lint (1.62.2)
16-16: could not import github.com/imua-xyz/imuachain/app/ante/cosmos (-: # github.com/imua-xyz/imuachain/app/ante/cosmos
app/ante/cosmos/eip712.go:247:36: undefined: secp256k1.RecoverPubkey
app/ante/cosmos/eip712.go:273:17: undefined: secp256k1.VerifySignature)(typecheck)
proto/imuachain/operator/v1/genesis.proto (5)
2-2
: Namespace Update:
The package declaration has been updated toimuachain.operator.v1
which correctly reflects the rebranding effort. Please ensure that any modules depending on this package are updated accordingly.
4-4
: Static Analysis Check on Import:
The import statementimport "cosmos_proto/cosmos.proto";
is flagged by Buf as not found. Please verify that this file is available via your dependencies (or adjust its path) to avoid any build issues.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
6-6
: Import Path Update:
The import has been updated toimport "imuachain/operator/v1/tx.proto";
, which now aligns with the new namespace. Confirm that the file exists at the new location.
8-8
: go_package Option Update:
Thego_package
option is now set togithub.com/imua-xyz/imuachain/x/operator/types
—this aligns with the new repository structure and naming conventions.
139-149
: In-line Documentation Update:
The comment in this section has been updated to reference “Imuachain” rather than “Exocore.” Ensure that all such in-line documentation (and external documentation) consistently reflect the new branding.proto/imuachain/delegation/v1/query.proto (5)
2-2
: Namespace Update:
The package declaration is nowimuachain.delegation.v1
, which is consistent with the rebranding.
4-4
: Static Analysis Check on Import:
The importimport "cosmos/query/v1/query.proto";
is reported as missing by Buf. Please verify whether this file is provided via a dependency or adjust the path accordingly.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos/query/v1/query.proto": file does not exist
(COMPILE)
8-8
: Import Path Update:
The updated importimport "imuachain/delegation/v1/tx.proto";
reflects the new namespace. Ensure the file exists in this location.
10-10
: go_package Option Update:
Thego_package
option now readsgithub.com/imua-xyz/imuachain/x/delegation/types
, which correctly matches the new project structure.
178-223
: HTTP Endpoint Updates:
All RPC methods now use updated HTTP endpoints (e.g.,/imuachain/delegation/v1/delegations/{staker_id}/{asset_id}
, etc.) that incorporate the new namespace. Please verify that these endpoints are properly integrated with your API routing and service configuration.proto/imuachain/avs/v1/tx.proto (4)
3-3
: Namespace Update:
The package declaration has been updated toimuachain.avs.v1
as part of the rebranding. This change is clear and consistent.
5-5
: Static Analysis Check on Import:
The importimport "amino/amino.proto";
is being flagged as missing. Please verify its existence in your dependency tree or update the import path if necessary.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
11-11
: go_package Option Update:
Thego_package
option is now updated togithub.com/imua-xyz/imuachain/x/avs/types
, aligning with the new repository organization.
266-279
: HTTP Endpoint Updates for Msg Service:
The RPC methods now use endpoints such as/imuachain/avs/v1/tx/RegisterAVS
,/imuachain/avs/v1/tx/DeRegisterAVS
,/imuachain/avs/v1/tx/RegisterAVSTask
, and/imuachain/avs/v1/tx/SubmitTaskResult
. These changes are consistent with the rebranding effort. Please double-check that these endpoints are correctly reflected in your API gateway or routing configuration.proto/imuachain/operator/v1/query.proto (5)
2-2
: Namespace Update:
The package declaration has been updated toimuachain.operator.v1
, which accurately reflects the new branding.
4-4
: Static Analysis Check on Import:
The importimport "amino/amino.proto";
is flagged as missing by Buf. Please ensure this file is either provided by your dependencies or adjust its import path accordingly.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
10-11
: Import Path Updates:
Bothimport "imuachain/operator/v1/tx.proto";
andimport "imuachain/operator/v1/validator.proto";
have been updated to match the new module paths. Verify that these files are available at the specified locations.
14-14
: go_package Option Update:
Thego_package
option is now set togithub.com/imua-xyz/imuachain/x/operator/types
, which is correct following the rebranding.
274-368
: Updated RPC HTTP Endpoints:
All RPC method HTTP options have been updated to use the "imuachain" namespace. For example, endpoints such as/imuachain/operator/v1/operator_info/{operator_addr}
and/imuachain/operator/v1/all_operator_cons_keys/{chain}
now reflect the new project identity. Please verify these endpoints with your routing and API configurations.
For example "Imuchain chain" is a lot to hear
Probably a transient issue associated to the rebranding around the price feeder tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
cmd/imuachain-test-tool/README.md (2)
7-8
: Grammar & Clarity Improvement for Node Configuration
The sentence "with the node configured to disable the precompile's gateway contract address check" reads a bit awkwardly. Consider rephrasing for clarity and grammatical correctness. For example, you might change it to:- with the node configured to disable the precompile's gateway contract address check. + with the node configured to disable the gateway address check for precompiled contracts.This rewording improves clarity without altering the intended meaning.
🧰 Tools
🪛 LanguageTool
[grammar] ~7-~7: The verb ‘precompile’ does not usually follow articles like ‘the’. Check that ‘precompile’ is spelled correctly; using ‘precompile’ as a noun may be non-standard.
Context: ...se, with the node configured to disable the precompile's gateway contract address check. The b...(A_INFINITIVE)
81-83
: Preparation Command Formatting
The prepare command is updated to:imuachain-test-tool prepare --home .
There appears to be an extra leading space before the command. It is recommended to remove the extra indentation for consistency within the code block. For example:
- imuachain-test-tool prepare --home . +imuachain-test-tool prepare --home .
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
cmd/imuachain-test-tool/README.md
(3 hunks)cmd/imuachain-test-tool/main.go
(8 hunks)testutil/network/network.go
(5 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- cmd/imuachain-test-tool/main.go
🧰 Additional context used
🪛 LanguageTool
cmd/imuachain-test-tool/README.md
[grammar] ~7-~7: The verb ‘precompile’ does not usually follow articles like ‘the’. Check that ‘precompile’ is spelled correctly; using ‘precompile’ as a noun may be non-standard.
Context: ...se, with the node configured to disable the precompile's gateway contract address check. The b...
(A_INFINITIVE)
🔇 Additional comments (13)
cmd/imuachain-test-tool/README.md (10)
1-1
: Title Update Verification
The tool name has been updated to imuachain-test-tool to reflect the rebranding. This change is consistent with the PR objectives.
3-4
: Descriptions Aligned with New Branding
The description now consistently refers to the Imuachain chain, replacing any old branding. Everything appears consistent with the new identity.
9-9
: Updated Repository URL Confirmation
The URL now points to the correct branch (https://github.com/imua-xyz/imuachain/tree/pressure-test
), matching the new repository structure.
21-24
: Functionality List Consistency Check
The bullet points have been updated to reference IMUA tokens and the Imuachain chain where applicable. This ensures consistency across the documentation with the new branding.
61-63
: Automated Testing Command Update
The initialization command now reads:imuachain-test-tool init --home
This appropriately reflects the rebranded tool name.
67-69
: Start Command Verification
The command to start the test tool is updated to:imuachain-test-tool start --home .
This change is correct and aligns with the overall rebranding.
75-77
: Manual Testing Initialization Command
The command for initializing the configuration file in manual testing is updated to:imuachain-test-tool init --home
This is consistent with the automated testing command and the new branding.
87-89
: Batch Test Command Update
The batch test command now correctly uses the new tool name:imuachain-test-tool batch-test depositLST --home .
This update reflects the rebranding accurately.
93-95
: Query Command Consistency
The query command has been updated to:imuachain-test-tool query-tx-record <msgType> <batch-id> <status>
This command is correct and consistent with the new naming conventions.
111-114
: Todo Section Update Verification
The todo note now reads "* Provide batch testing for IMUA tokens.*" which correctly updates the token name in the context of the rebranding effort.testutil/network/network.go (3)
500-504
: LGTM! Good error handling for Bech32 address.The code properly validates the gateway address using the new "im" prefix and includes appropriate error handling.
345-346
: LGTM! Directory paths updated correctly.The node and client directory paths have been updated from "exocored/exocorecli" to "imuad/imuacli" respectively, maintaining consistency with the rebranding objectives.
129-129
:❓ Verification inconclusive
Verify the cryptographic algorithm change.
The switch from
EthSecp256k1
toEd25519
is a significant cryptographic change. While both are secure algorithms, they have different characteristics and compatibility implications.
🌐 Web query:
What are the key differences between EthSecp256k1 and Ed25519 for blockchain applications?
💡 Result:
The key differences between EthSecp256k1 (used with ECDSA) and Ed25519 (used with EdDSA) in blockchain applications revolve around cryptographic efficiency, security tradeoffs, and ecosystem compatibility:
Cryptographic Algorithms & Key Properties
Feature EthSecp256k1 (ECDSA) Ed25519 (EdDSA) Curve Type Secp256k1 elliptic curve Twisted Edwards curve (Curve25519) Signature Scheme ECDSA Schnorr-based EdDSA Public Key Length 33 bytes (compressed) 32 bytes Signature Length 64–72 bytes 64 bytes Security Level ~128-bit ~128-bit
Performance & Efficiency
- Ed25519:
- Faster signature generation/verification due to deterministic nonces and optimized algorithms[2][4].
- Lower computational overhead, making it ideal for high-throughput chains like Solana[2][5].
- EthSecp256k1:
- Slower verification due to ECDSA’s reliance on random nonces[6][9].
- Required for Ethereum Virtual Machine (EVM) compatibility[1][6].
Use Cases & Ecosystem Support
EthSecp256k1
- Dominant in Ethereum, Bitcoin, and EVM-compatible chains[6][9].
- Essential for MetaMask integration and EVM developer tooling[1][5].
- Used by Evmos for validator operator keys[9].
Ed25519
- Preferred in high-performance chains like Solana, Near, and Aptos[2][5].
- Utilized by Polkadot’s
sr25519
variant (Schnorrkel/Ristretto)[4] and Hedera[1].- Common in privacy-focused systems like Monero[3].
Security Considerations
- Quantum Resistance: Neither is quantum-resistant; both are vulnerable to Shor’s algorithm[8].
- Implementation Risks:
- Ed25519 avoids nonce reuse vulnerabilities inherent in ECDSA[2][4].
- Secp256k1 has broader hardware security module (HSM) support[4].
Tradeoffs Summary
Factor EthSecp256k1 Advantage Ed25519 Advantage EVM Compatibility Native support for Ethereum tooling[1][6] Limited without wrappers Speed Slower verification Faster signing/verification[2][4] Key Management Longer keys but wider HSM adoption[4] Shorter keys with efficient storage[5]
Developers typically choose EthSecp256k1 for EVM interoperability or legacy system integration, while Ed25519 is favored for modern chains prioritizing speed and compact cryptography. Chains like Polkadot combine both approaches:
sr25519
(Ed25519 variant) for accounts and BLS signatures for consensus[4][9].Citations:
- 1: https://docs.hedera.com/hedera/core-concepts/keys-and-signatures
- 2: https://www.hackquest.io/en/glossary/Ed25519
- 3: https://drpress.org/ojs/index.php/HSET/article/view/6717
- 4: https://wiki.polkadot.network/docs/learn-cryptography
- 5: https://blog.web3auth.io/introducing-ed25519-in-web3auths-mpc-secure-signing-for-dapps-and-wallets/
- 6: https://dev.to/q9/finally-understanding-ethereum-accounts-1kpe
- 7: Why was ed25519 used instead of secp256k1 and is still compatible with BTC/ETH? jpopesculian/ed25519-dalek-bip32#4
- 8: https://hedera.com/blog/are-ed25519-keys-quantum-resistant-exploring-the-future-of-cryptography
- 9: https://docs.evmos.org/protocol/concepts/accounts
- 10: https://ianix.com/pub/ed25519-deployment.html
Action Required: Verify Cryptographic Compatibility
The key change at line 129 in
testutil/network/network.go
switches the keyring option from EthSecp256k1 to Ed25519. Based on recent research, this change brings performance improvements—thanks to faster, deterministic signing with Ed25519—but it also shifts compatibility expectations. EthSecp256k1 is traditionally used with EVM-compatible systems and enjoys broader HSM support. Please verify that all components interacting with key management (e.g., signature verifications, account handling) are fully compatible with Ed25519, ensuring no downstream dependency still requires EthSecp256k1 behavior.Affected Location:
- File:
testutil/network/network.go
Line 129:KeyringOptions: []keyring.Option{imuacrypto.Ed25519Option()},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (1)
proto/imuachain/assets/v1/params.proto (1)
4-4
:⚠️ Potential issueImport Dependency Issue.
The file includesimport "gogoproto/gogo.proto";
, but static analysis indicates that this file does not exist. Please verify whether this dependency is still needed. If it is required, consider updating the import path to point to the correct location (for example, it might need to be something like"github.com/gogo/protobuf/gogoproto/gogo.proto"
). Otherwise, if the dependency is deprecated, remove the import.Suggested diff if the external dependency is available via GitHub:
- import "gogoproto/gogo.proto"; + import "github.com/gogo/protobuf/gogoproto/gogo.proto";🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
🧹 Nitpick comments (25)
precompiles/avs/events.go (1)
275-276
: Consider addressing the TODO comment about Phase type.The current implementation requires casting Phase to uint8. Modifying the Phase type definition to uint8 would improve type safety and eliminate the need for casting.
Would you like me to help create an issue to track this improvement?
app/ethtest_helper.go (2)
59-59
: Docstring references "EvmosApp" instead of "ImuachainApp".
Please update the function comment on the preceding line (line 58) to avoid confusion with the updated function signature.
64-66
: Rename function or docstring for clarity.
The current “EthSetupWithDB” name and docstring still reference “EvmosApp.” Consider renaming or clarifying to better align with Imuachain.cmd/imuad/root.go (1)
150-150
: TODO found for re-enabling price feeder.
A “TODO” comment indicates a potential future fix.Would you like help creating an issue or drafting a follow-up PR to re-enable the feeder once dependencies are updated?
app/app.go (1)
377-377
: Unimplemented SimulationManager placeholder.
Implementation to be done or omitted if not required.Would you like help adding a minimal
SimulationManager
implementation or removing this placeholder if it’s not needed?cmd/imuad/init.go (1)
93-93
: Verify the chain ID format.The chain ID format has been updated to use the "imua_234" prefix. Please ensure this format aligns with any network-specific requirements or conventions.
Consider documenting the chain ID format requirements and any restrictions in the codebase to help future contributors understand the naming convention.
precompiles/avs/utils_test.go (1)
99-101
: Consider using different addresses for AVS owners.Using the same address for all AVS owners reduces the test coverage and may not catch issues related to multiple distinct owners.
Consider using different addresses to improve test coverage:
- sdk.AccAddress(suite.Address.Bytes()).String(), - sdk.AccAddress(suite.Address.Bytes()).String(), - sdk.AccAddress(suite.Address.Bytes()).String(), + sdk.AccAddress(suite.Address.Bytes()).String(), + sdk.AccAddress(utiltx.GenerateAddress().Bytes()).String(), + sdk.AccAddress(utiltx.GenerateAddress().Bytes()).String(),scripts/protocgen.sh (2)
11-11
: Remove Unused Commented Code
There is an unused commented-out assignment forproto_dirs
on line 11. Consider removing this commented code to improve script clarity.
16-17
: Update Outdated Comment
The comment on line 16 refers to checking whether thego_package
is pointing toevmos
, which is outdated. Please update the comment to reflect the current check forimua
(or the appropriate new branding).networks/local/imuachain/Dockerfile (1)
7-8
: Comment on Build Step Annotation
The commented-out line (#COPY ./imuad /go/work/build
) along with the adjacent comment# build imua
indicates an alternative build step. If this is no longer needed, consider cleaning up the commented code to improve clarity.scripts/start-docker.sh (2)
4-5
: Chain ID Finalization Notice
A TODO comment indicates that the imua testnet chain ID (imualocalnet_232-1
) is still under consideration. Please remember to finalize this value once decisions are made, or let us know if you need assistance tracking this task.
18-18
: Duplicate Keyring Flag Detected in Genesis Transaction Command
In thegentx
command, the--keyring-backend test
flag appears twice. Removing the duplicate can simplify the command and avoid any potential confusion.go.mod (1)
277-278
: Replace Directive for evmos Updated for Rebranding.
The replacement directive forgithub.com/evmos/evmos/v16
now points togithub.com/imua-xyz/evmos/v16
with an updated version. The inline TODO suggests additional review may be needed later to clarify if further adjustments are required.proto/imuachain/slash/v1/params.proto (1)
1-8
: New Slash Module Params Proto Introduced with Rebranded Package.
The new protocol buffer file correctly defines aParams
message for theimuachain.slash.v1
module. However, the static analysis hint indicates that files whose package isimuachain.slash.v1
must reside within a directory structure matchingimuachain/slash/v1
relative to the repository root. Please verify that the file path in your repository complies with this requirement (e.g., consider moving the file fromproto/imuachain/slash/v1
toimuachain/slash/v1
if that is the convention used throughout the project).🧰 Tools
🪛 Buf (1.47.2)
2-2: Files with package "imuachain.slash.v1" must be within a directory "imuachain/slash/v1" relative to root but were in directory "proto/imuachain/slash/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/reward/v1/params.proto (1)
1-8
: New Reward Module Params Proto Defined with Updated Package Name.
This file introduces theParams
message for theimuachain.reward.v1
package and sets the proper Go package option. Similar to the slash proto, the static analysis tool warns that the file should reside in a directory that matches the package path (i.e.,imuachain/reward/v1
). Please ensure that the file is located in the correct directory relative to the repository root to comply with Buf’s package directory matching rules.🧰 Tools
🪛 Buf (1.47.2)
2-2: Files with package "imuachain.reward.v1" must be within a directory "imuachain/reward/v1" relative to root but were in directory "proto/imuachain/reward/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/assets/v1/params.proto (1)
8-12
: Message Comment Consistency.
The comment above the message states, "GenesisState defines the deposit module's genesis state," yet the message is namedParams
. Please verify whether the comment or the message name should be updated to ensure consistency and avoid confusion.proto/imuachain/oracle/v1/slashing.proto (1)
3-3
: Update package declaration and directory structure.
The package has been updated toimuachain.oracle.v1
to reflect the new branding. However, static analysis indicates that files with this package should reside in a directory structured asimuachain/oracle/v1
relative to the repository root. Please verify that the file location aligns with this expectation.🧰 Tools
🪛 Buf (1.47.2)
3-3: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/epochs/v1/epochs.proto (1)
3-3
: Update package declaration and verify directory structure.
The package is updated toimuachain.epochs.v1
in keeping with the rebranding effort. As with similar files, confirm that this file is placed in the appropriate directory (imuachain/epochs/v1
relative to the repository root) to satisfy static analysis checks.🧰 Tools
🪛 Buf (1.47.2)
3-3: Files with package "imuachain.epochs.v1" must be within a directory "imuachain/epochs/v1" relative to root but were in directory "proto/imuachain/epochs/v1".
(PACKAGE_DIRECTORY_MATCH)
cmd/imuachain-test-tool/README.md (3)
7-8
: Grammar/Nitpick: Precompile Usage
The phrase “disable the precompile's gateway contract address check” may be non-standard. Consider rephrasing for clarity (e.g., “disable gateway contract address verification for precompiled functions”).🧰 Tools
🪛 LanguageTool
[grammar] ~7-~7: The verb ‘precompile’ does not usually follow articles like ‘the’. Check that ‘precompile’ is spelled correctly; using ‘precompile’ as a noun may be non-standard.
Context: ...se, with the node configured to disable the precompile's gateway contract address check. The b...(A_INFINITIVE)
73-73
: Grammar: Missing Determiner
The instruction “Initialize configuration file in current directory” could be clearer with a definite article. Consider revising to “Initialize the configuration file in the current directory.”🧰 Tools
🪛 LanguageTool
[uncategorized] ~73-~73: You might be missing the article “the” here.
Context: ...1: Initialize the configuration file in current directory ```shell imuachain-t...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
79-79
: Grammar: Missing Determiner
For clarity, you might revise “Prepare test environment” to “Prepare the test environment.”🧰 Tools
🪛 LanguageTool
[uncategorized] ~79-~79: You might be missing the article “the” here.
Context: ...nit --homeStep 2: Prepare test environment
shell imuachai...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
CONTRIBUTING.md (4)
27-27
: Grammar Suggestion: Insert a Missing Comma
Consider adding a comma after “many things” for clarity.-Contributing to this repo can mean many things such as participating in discussion or proposing code changes. +Contributing to this repo can mean many things, such as participating in discussion or proposing code changes.🧰 Tools
🪛 LanguageTool
[uncategorized] ~27-~27: Possible missing comma found.
Context: ...Contributing to this repo can mean many things such as participating in discussion or ...(AI_HYDRA_LEO_MISSING_COMMA)
46-47
: Spacing in Branching Instruction
There is a missing space before the parenthesis. For clarity, add a space afterdevelopment
.-Branch from the HEAD of `development`(For core developers working within the Imuachain repo, to ensure a +Branch from the HEAD of `development` (For core developers working within the Imuachain repo, to ensure a
82-84
: Punctuation and Spacing Improvement in Fork Instructions
A space is needed after the comma before the$GOPATH
path for improved readability.-Instead, we use `git remote` to add the fork as a new remote for the original repo,`$GOPATH/src/github.com/imua-xyz/imuachain`, +Instead, we use `git remote` to add the fork as a new remote for the original repo, `$GOPATH/src/github.com/imua-xyz/imuachain`,
265-266
: Clarify Release Note Wording
The phrase “cuts releases on a need to have basis” might be ambiguous. Consider rephrasing (e.g., “releases are made as needed”) to improve clarity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (19)
go.sum
is excluded by!**/*.sum
x/appchain/common/types/common.pb.go
is excluded by!**/*.pb.go
x/appchain/coordinator/types/coordinator.pb.go
is excluded by!**/*.pb.go
x/appchain/coordinator/types/genesis.pb.go
is excluded by!**/*.pb.go
x/appchain/coordinator/types/params.pb.go
is excluded by!**/*.pb.go
x/appchain/coordinator/types/query.pb.go
is excluded by!**/*.pb.go
x/appchain/coordinator/types/query.pb.gw.go
is excluded by!**/*.pb.gw.go
x/appchain/coordinator/types/tx.pb.go
is excluded by!**/*.pb.go
x/appchain/coordinator/types/tx.pb.gw.go
is excluded by!**/*.pb.gw.go
x/appchain/subscriber/types/genesis.pb.go
is excluded by!**/*.pb.go
x/appchain/subscriber/types/query.pb.go
is excluded by!**/*.pb.go
x/appchain/subscriber/types/query.pb.gw.go
is excluded by!**/*.pb.gw.go
x/appchain/subscriber/types/tx.pb.go
is excluded by!**/*.pb.go
x/assets/types/genesis.pb.go
is excluded by!**/*.pb.go
x/assets/types/params.pb.go
is excluded by!**/*.pb.go
x/assets/types/query.pb.go
is excluded by!**/*.pb.go
x/assets/types/query.pb.gw.go
is excluded by!**/*.pb.gw.go
x/assets/types/tx.pb.go
is excluded by!**/*.pb.go
x/assets/types/tx.pb.gw.go
is excluded by!**/*.pb.gw.go
📒 Files selected for processing (207)
.github/PULL_REQUEST_TEMPLATE.md
(2 hunks).github/workflows/consensuswarn.yml
(2 hunks).github/workflows/lint.yml
(1 hunks).github/workflows/proto.yml
(3 hunks).github/workflows/security.yml
(1 hunks).github/workflows/semgrep.yml
(1 hunks).github/workflows/super-linter.yml
(1 hunks).goreleaser.yml
(6 hunks)CONTRIBUTING.md
(10 hunks)Dockerfile
(3 hunks)Makefile
(10 hunks)README.md
(2 hunks)app/ante/cosmos/context.go
(1 hunks)app/ante/cosmos/fees.go
(1 hunks)app/ante/cosmos/min_price.go
(1 hunks)app/ante/cosmos/sigverify.go
(1 hunks)app/ante/cosmos/txsize_gas.go
(1 hunks)app/ante/evm/fee_checker.go
(1 hunks)app/ante/evm/fee_market.go
(1 hunks)app/ante/handler_options.go
(1 hunks)app/ante/sigverify.go
(1 hunks)app/ante/utils/oracle.go
(1 hunks)app/app.go
(37 hunks)app/ethtest_helper.go
(2 hunks)app/export.go
(3 hunks)app/forks.go
(1 hunks)app/test_helpers.go
(6 hunks)client/docs/config.json
(4 hunks)client/export.go
(1 hunks)cmd/config/config.go
(2 hunks)cmd/imuachain-test-tool/README.md
(3 hunks)cmd/imuachain-test-tool/main.go
(8 hunks)cmd/imuad/init.go
(1 hunks)cmd/imuad/main.go
(2 hunks)cmd/imuad/root.go
(7 hunks)cmd/imuad/testnet.go
(7 hunks)docker-compose.yml
(5 hunks)go.mod
(3 hunks)init.bat
(3 hunks)local_node.sh
(10 hunks)networks/Makefile
(1 hunks)networks/init-node.sh
(1 hunks)networks/local/Makefile
(1 hunks)networks/local/imuachain/Dockerfile
(2 hunks)networks/local/imuachain/wrapper.sh
(1 hunks)precompiles/assets/IAssets.sol
(6 hunks)precompiles/assets/assets.go
(2 hunks)precompiles/assets/assets_integrate_test.go
(6 hunks)precompiles/assets/assets_test.go
(5 hunks)precompiles/assets/decode_helper.go
(9 hunks)precompiles/assets/query.go
(1 hunks)precompiles/assets/setup_test.go
(1 hunks)precompiles/assets/tx.go
(5 hunks)precompiles/assets/types.go
(5 hunks)precompiles/avs/IAVSManager.sol
(5 hunks)precompiles/avs/avs.go
(1 hunks)precompiles/avs/avs_test.go
(6 hunks)precompiles/avs/events.go
(1 hunks)precompiles/avs/query.go
(9 hunks)precompiles/avs/query_test.go
(5 hunks)precompiles/avs/setup_test.go
(1 hunks)precompiles/avs/tx.go
(10 hunks)precompiles/avs/types.go
(6 hunks)precompiles/avs/utils_test.go
(2 hunks)precompiles/bech32/IBech32.sol
(1 hunks)precompiles/bech32/bech32_test.go
(4 hunks)precompiles/bech32/methods.go
(2 hunks)precompiles/bech32/methods_test.go
(1 hunks)precompiles/bech32/setup_test.go
(1 hunks)precompiles/bls/IBLS.sol
(1 hunks)precompiles/bls/bls.go
(1 hunks)precompiles/bls/bls_test.go
(1 hunks)precompiles/bls/setup_test.go
(1 hunks)precompiles/delegation/IDelegation.sol
(5 hunks)precompiles/delegation/delegation.go
(2 hunks)precompiles/delegation/delegation_test.go
(7 hunks)precompiles/delegation/setup_test.go
(1 hunks)precompiles/delegation/tx.go
(8 hunks)precompiles/delegation/types.go
(4 hunks)precompiles/reward/claimReward.sol
(1 hunks)precompiles/reward/methods.go
(2 hunks)precompiles/reward/parser.go
(3 hunks)precompiles/reward/reward.go
(3 hunks)precompiles/reward/reward_test.go
(2 hunks)precompiles/reward/setup_test.go
(1 hunks)precompiles/slash/methods.go
(2 hunks)precompiles/slash/parser.go
(3 hunks)precompiles/slash/setup_test.go
(2 hunks)precompiles/slash/slash.go
(2 hunks)precompiles/slash/slash.sol
(1 hunks)precompiles/slash/slash_test.go
(1 hunks)precompiles/testutil/contracts/contracts.go
(3 hunks)proto/exocore/appchain/subscriber/v1/genesis.proto
(0 hunks)proto/exocore/appchain/subscriber/v1/tx.proto
(0 hunks)proto/exocore/reward/v1/params.proto
(0 hunks)proto/exocore/slash/v1/params.proto
(0 hunks)proto/imuachain/appchain/common/v1/common.proto
(3 hunks)proto/imuachain/appchain/coordinator/v1/coordinator.proto
(1 hunks)proto/imuachain/appchain/coordinator/v1/genesis.proto
(1 hunks)proto/imuachain/appchain/coordinator/v1/params.proto
(2 hunks)proto/imuachain/appchain/coordinator/v1/query.proto
(3 hunks)proto/imuachain/appchain/coordinator/v1/tx.proto
(2 hunks)proto/imuachain/appchain/subscriber/v1/genesis.proto
(1 hunks)proto/imuachain/appchain/subscriber/v1/query.proto
(2 hunks)proto/imuachain/appchain/subscriber/v1/tx.proto
(1 hunks)proto/imuachain/assets/v1/genesis.proto
(1 hunks)proto/imuachain/assets/v1/params.proto
(1 hunks)proto/imuachain/assets/v1/query.proto
(2 hunks)proto/imuachain/assets/v1/tx.proto
(5 hunks)proto/imuachain/avs/v1/genesis.proto
(1 hunks)proto/imuachain/avs/v1/query.proto
(2 hunks)proto/imuachain/avs/v1/tx.proto
(2 hunks)proto/imuachain/delegation/v1/genesis.proto
(1 hunks)proto/imuachain/delegation/v1/query.proto
(2 hunks)proto/imuachain/delegation/v1/tx.proto
(2 hunks)proto/imuachain/dogfood/v1/dogfood.proto
(1 hunks)proto/imuachain/dogfood/v1/genesis.proto
(1 hunks)proto/imuachain/dogfood/v1/params.proto
(1 hunks)proto/imuachain/dogfood/v1/query.proto
(3 hunks)proto/imuachain/dogfood/v1/tx.proto
(2 hunks)proto/imuachain/epochs/v1/epochs.proto
(1 hunks)proto/imuachain/epochs/v1/genesis.proto
(1 hunks)proto/imuachain/epochs/v1/query.proto
(1 hunks)proto/imuachain/feedistribution/v1/distribution.proto
(1 hunks)proto/imuachain/feedistribution/v1/genesis.proto
(1 hunks)proto/imuachain/feedistribution/v1/params.proto
(1 hunks)proto/imuachain/feedistribution/v1/query.proto
(1 hunks)proto/imuachain/feedistribution/v1/tx.proto
(2 hunks)proto/imuachain/immint/v1/genesis.proto
(1 hunks)proto/imuachain/immint/v1/params.proto
(1 hunks)proto/imuachain/immint/v1/query.proto
(1 hunks)proto/imuachain/immint/v1/tx.proto
(2 hunks)proto/imuachain/operator/v1/genesis.proto
(2 hunks)proto/imuachain/operator/v1/query.proto
(2 hunks)proto/imuachain/operator/v1/tx.proto
(5 hunks)proto/imuachain/operator/v1/validator.proto
(1 hunks)proto/imuachain/oracle/v1/genesis.proto
(1 hunks)proto/imuachain/oracle/v1/index_recent_msg.proto
(1 hunks)proto/imuachain/oracle/v1/index_recent_params.proto
(1 hunks)proto/imuachain/oracle/v1/info.proto
(1 hunks)proto/imuachain/oracle/v1/native_token.proto
(1 hunks)proto/imuachain/oracle/v1/nonce.proto
(1 hunks)proto/imuachain/oracle/v1/params.proto
(1 hunks)proto/imuachain/oracle/v1/price.proto
(1 hunks)proto/imuachain/oracle/v1/prices.proto
(1 hunks)proto/imuachain/oracle/v1/query.proto
(1 hunks)proto/imuachain/oracle/v1/recent_msg.proto
(1 hunks)proto/imuachain/oracle/v1/recent_params.proto
(1 hunks)proto/imuachain/oracle/v1/slashing.proto
(1 hunks)proto/imuachain/oracle/v1/token_feeder.proto
(1 hunks)proto/imuachain/oracle/v1/tx.proto
(1 hunks)proto/imuachain/oracle/v1/validator_update_block.proto
(1 hunks)proto/imuachain/reward/v1/genesis.proto
(1 hunks)proto/imuachain/reward/v1/params.proto
(1 hunks)proto/imuachain/reward/v1/query.proto
(1 hunks)proto/imuachain/reward/v1/tx.proto
(1 hunks)proto/imuachain/reward/v1/types.proto
(1 hunks)proto/imuachain/slash/v1/genesis.proto
(1 hunks)proto/imuachain/slash/v1/params.proto
(1 hunks)proto/imuachain/slash/v1/query.proto
(1 hunks)proto/imuachain/slash/v1/tx.proto
(1 hunks)scripts/protoc-swagger-gen.sh
(1 hunks)scripts/protocgen.sh
(1 hunks)scripts/start-docker.sh
(1 hunks)tests/e2e/oracle/create_price.go
(1 hunks)tests/e2e/oracle/data.go
(1 hunks)tests/e2e/oracle/oracle_test.go
(1 hunks)tests/e2e/oracle/recovery.go
(1 hunks)tests/e2e/oracle/suite.go
(1 hunks)testutil/abci.go
(11 hunks)testutil/ante.go
(1 hunks)testutil/batch/batch_tx.go
(3 hunks)testutil/batch/manager.go
(4 hunks)testutil/batch/manager_test.go
(6 hunks)testutil/batch/prepare.go
(3 hunks)testutil/batch/send_txs.go
(1 hunks)testutil/batch/tx_check.go
(2 hunks)testutil/batch/type.go
(3 hunks)testutil/batch/utils.go
(6 hunks)testutil/contract.go
(4 hunks)testutil/fund.go
(2 hunks)testutil/integration.go
(4 hunks)testutil/keeper/feedistribute.go
(1 hunks)testutil/keeper/oracle.go
(1 hunks)testutil/network/genesis_data.go
(1 hunks)testutil/network/network.go
(5 hunks)testutil/network/network_test.go
(2 hunks)testutil/network/query.go
(1 hunks)testutil/network/util.go
(2 hunks)testutil/statedb.go
(1 hunks)testutil/tx/cosmos.go
(5 hunks)testutil/tx/eip712.go
(7 hunks)testutil/tx/eth.go
(4 hunks)testutil/tx/signer.go
(1 hunks)testutil/utils.go
(7 hunks)types/errors.go
(1 hunks)types/keys/consensus.go
(2 hunks)types/keys/consensus_test.go
(1 hunks)types/validation_test.go
(1 hunks)utils/store.go
(1 hunks)utils/utils.go
(2 hunks)utils/utils_test.go
(3 hunks)x/appchain/coordinator/client/cli/query.go
(1 hunks)x/appchain/coordinator/client/cli/tx.go
(1 hunks)x/appchain/coordinator/keeper/genesis.go
(1 hunks)x/appchain/coordinator/keeper/grpc_query.go
(1 hunks)x/appchain/coordinator/keeper/ibc_client.go
(2 hunks)
⛔ Files not processed due to max files limit (70)
- x/appchain/coordinator/keeper/identifiers.go
- x/appchain/coordinator/keeper/impl_epochs_hooks.go
- x/appchain/coordinator/keeper/keeper.go
- x/appchain/coordinator/keeper/msg_server.go
- x/appchain/coordinator/keeper/params.go
- x/appchain/coordinator/keeper/register.go
- x/appchain/coordinator/keeper/slash.go
- x/appchain/coordinator/keeper/timeout.go
- x/appchain/coordinator/module.go
- x/appchain/coordinator/types/expected_keepers.go
- x/appchain/coordinator/types/keys.go
- x/appchain/coordinator/types/msg.go
- x/appchain/coordinator/types/params.go
- x/appchain/coordinator/types/params_test.go
- x/appchain/subscriber/client/cli/query.go
- x/appchain/subscriber/client/cli/tx.go
- x/appchain/subscriber/keeper/genesis.go
- x/appchain/subscriber/keeper/grpc_query.go
- x/appchain/subscriber/keeper/msg_server.go
- x/appchain/subscriber/keeper/params.go
- x/appchain/subscriber/module.go
- x/appchain/subscriber/types/genesis.go
- x/assets/client/cli/query.go
- x/assets/client/cli/tx.go
- x/assets/keeper/bank.go
- x/assets/keeper/client_chain.go
- x/assets/keeper/client_chain_and_asset_test.go
- x/assets/keeper/client_chain_asset.go
- x/assets/keeper/exocore_addr.go
- x/assets/keeper/expected_keepers.go
- x/assets/keeper/genesis.go
- x/assets/keeper/grpc_query.go
- x/assets/keeper/keeper.go
- x/assets/keeper/msg_server.go
- x/assets/keeper/operator_asset.go
- x/assets/keeper/params.go
- x/assets/keeper/params_test.go
- x/assets/keeper/setup_test.go
- x/assets/keeper/staker_asset.go
- x/assets/keeper/staker_asset_test.go
- x/assets/module.go
- x/assets/types/codec.go
- x/assets/types/events.go
- x/assets/types/expected_keepers.go
- x/assets/types/general.go
- x/assets/types/genesis.go
- x/assets/types/genesis_test.go
- x/assets/types/keys.go
- x/assets/types/msg.go
- x/avs/client/cli/query.go
- x/avs/client/cli/tx.go
- x/avs/keeper/avs.go
- x/avs/keeper/avs_test.go
- x/avs/keeper/bls_test.go
- x/avs/keeper/epoch_test.go
- x/avs/keeper/genesis.go
- x/avs/keeper/impl_epoch_hook.go
- x/avs/keeper/keeper.go
- x/avs/keeper/miscellaneous_test.go
- x/avs/keeper/msg_server.go
- x/avs/keeper/multi_operator_submit_task_test.go
- x/avs/keeper/params.go
- x/avs/keeper/query.go
- x/avs/keeper/setup_test.go
- x/avs/keeper/submit_task_test.go
- x/avs/keeper/task.go
- x/avs/keeper/task_test.go
- x/avs/module.go
- x/avs/types/expected_keepers.go
- x/avs/types/genesis.go
💤 Files with no reviewable changes (4)
- proto/exocore/appchain/subscriber/v1/genesis.proto
- proto/exocore/appchain/subscriber/v1/tx.proto
- proto/exocore/slash/v1/params.proto
- proto/exocore/reward/v1/params.proto
✅ Files skipped from review due to trivial changes (48)
- precompiles/assets/IAssets.sol
- precompiles/reward/claimReward.sol
- networks/local/Makefile
- precompiles/bls/IBLS.sol
- networks/Makefile
- precompiles/bls/bls.go
- testutil/keeper/feedistribute.go
- .github/workflows/lint.yml
- precompiles/bech32/IBech32.sol
- precompiles/delegation/setup_test.go
- testutil/network/query.go
- app/ante/cosmos/fees.go
- precompiles/avs/IAVSManager.sol
- types/keys/consensus.go
- types/validation_test.go
- app/ante/evm/fee_checker.go
- precompiles/slash/slash.sol
- precompiles/delegation/IDelegation.sol
- tests/e2e/oracle/oracle_test.go
- x/appchain/coordinator/keeper/grpc_query.go
- testutil/batch/send_txs.go
- .github/workflows/security.yml
- app/ante/cosmos/sigverify.go
- precompiles/bls/bls_test.go
- precompiles/avs/setup_test.go
- app/ante/cosmos/context.go
- tests/e2e/oracle/data.go
- .github/workflows/super-linter.yml
- precompiles/reward/setup_test.go
- app/ante/evm/fee_market.go
- precompiles/bech32/setup_test.go
- types/errors.go
- precompiles/assets/setup_test.go
- .github/PULL_REQUEST_TEMPLATE.md
- precompiles/slash/slash_test.go
- README.md
- testutil/network/genesis_data.go
- precompiles/reward/reward_test.go
- tests/e2e/oracle/recovery.go
- testutil/keeper/oracle.go
- precompiles/assets/assets_integrate_test.go
- types/keys/consensus_test.go
- cmd/imuachain-test-tool/main.go
- testutil/batch/batch_tx.go
- precompiles/delegation/delegation_test.go
- proto/imuachain/operator/v1/tx.proto
- .github/workflows/semgrep.yml
- precompiles/avs/avs_test.go
🧰 Additional context used
🧠 Learnings (2)
app/ante/handler_options.go (1)
Learnt from: MaxMustermann2
PR: imua-xyz/imuachain#309
File: app/ante/handler_options.go:16-18
Timestamp: 2025-02-19T17:31:53.743Z
Learning: The import paths `github.com/imua-xyz/imuachain/app/ante/{cosmos,evm,utils}` are valid and pass golangci-lint checks in the Imuachain codebase.
proto/imuachain/appchain/subscriber/v1/tx.proto (1)
Learnt from: MaxMustermann2
PR: imua-xyz/imuachain#309
File: proto/imuachain/appchain/subscriber/v1/tx.proto:3-3
Timestamp: 2025-02-19T17:30:10.361Z
Learning: The buf dependency system handles proto file organization and package directory structure in this project. Proto files don't need to strictly follow the package path directory structure as buf takes care of this automatically.
🪛 Buf (1.47.2)
proto/imuachain/appchain/subscriber/v1/genesis.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/distribution.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/dogfood.proto
5-5: import "cosmos/staking/v1beta1/staking.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/params.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/subscriber/v1/query.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/operator/v1/genesis.proto
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/immint/v1/query.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/coordinator/v1/params.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/coordinator/v1/coordinator.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/avs/v1/query.proto
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/coordinator/v1/query.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/query.proto
5-5: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
proto/imuachain/assets/v1/tx.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/tx.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/assets/v1/query.proto
4-4: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/common/v1/common.proto
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/coordinator/v1/genesis.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/coordinator/v1/tx.proto
5-5: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/subscriber/v1/tx.proto
3-3: Files with package "imuachain.appchain.subscriber.v1" must be within a directory "imuachain/appchain/subscriber/v1" relative to root but were in directory "proto/imuachain/appchain/subscriber/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/assets/v1/genesis.proto
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/assets/v1/params.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/avs/v1/genesis.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/avs/v1/tx.proto
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/delegation/v1/genesis.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/delegation/v1/query.proto
4-4: import "cosmos/query/v1/query.proto": file does not exist
(COMPILE)
proto/imuachain/delegation/v1/tx.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/genesis.proto
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/params.proto
5-5: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/tx.proto
5-5: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
proto/imuachain/epochs/v1/epochs.proto
3-3: Files with package "imuachain.epochs.v1" must be within a directory "imuachain/epochs/v1" relative to root but were in directory "proto/imuachain/epochs/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/epochs/v1/genesis.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/epochs/v1/query.proto
5-5: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/genesis.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/query.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/immint/v1/genesis.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/immint/v1/params.proto
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/immint/v1/tx.proto
4-4: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
proto/imuachain/operator/v1/query.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/operator/v1/validator.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/genesis.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/index_recent_msg.proto
2-2: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/oracle/v1/index_recent_params.proto
2-2: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/oracle/v1/info.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/native_token.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/nonce.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/params.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/price.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/prices.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/query.proto
5-5: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/recent_msg.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/recent_params.proto
4-4: import "imuachain/oracle/v1/params.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/slashing.proto
3-3: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/oracle/v1/token_feeder.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/tx.proto
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/validator_update_block.proto
2-2: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/reward/v1/genesis.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/reward/v1/params.proto
2-2: Files with package "imuachain.reward.v1" must be within a directory "imuachain/reward/v1" relative to root but were in directory "proto/imuachain/reward/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/reward/v1/query.proto
4-4: import "google/api/annotations.proto": file does not exist
(COMPILE)
proto/imuachain/reward/v1/tx.proto
5-5: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
proto/imuachain/reward/v1/types.proto
5-5: import "cosmos/base/v1beta1/coin.proto": file does not exist
(COMPILE)
proto/imuachain/slash/v1/genesis.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/slash/v1/params.proto
2-2: Files with package "imuachain.slash.v1" must be within a directory "imuachain/slash/v1" relative to root but were in directory "proto/imuachain/slash/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/slash/v1/query.proto
4-4: import "google/api/annotations.proto": file does not exist
(COMPILE)
proto/imuachain/slash/v1/tx.proto
4-4: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
🪛 LanguageTool
CONTRIBUTING.md
[uncategorized] ~27-~27: Possible missing comma found.
Context: ...Contributing to this repo can mean many things such as participating in discussion or ...
(AI_HYDRA_LEO_MISSING_COMMA)
cmd/imuachain-test-tool/README.md
[grammar] ~7-~7: The verb ‘precompile’ does not usually follow articles like ‘the’. Check that ‘precompile’ is spelled correctly; using ‘precompile’ as a noun may be non-standard.
Context: ...se, with the node configured to disable the precompile's gateway contract address check. The b...
(A_INFINITIVE)
[uncategorized] ~73-~73: You might be missing the article “the” here.
Context: ...1: Initialize the configuration file in current directory ```shell imuachain-t...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~79-~79: You might be missing the article “the” here.
Context: ...nit --home Step 2: Prepare test environment
shell imuachai...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
🪛 golangci-lint (1.62.2)
app/ante/handler_options.go
16-16: could not import github.com/imua-xyz/imuachain/app/ante/cosmos (-: # github.com/imua-xyz/imuachain/app/ante/cosmos
app/ante/cosmos/eip712.go:247:36: undefined: secp256k1.RecoverPubkey
app/ante/cosmos/eip712.go:273:17: undefined: secp256k1.VerifySignature)
(typecheck)
🔇 Additional comments (460)
precompiles/avs/query.go (2)
16-17
: LGTM! Import paths correctly updated for rebranding.The import paths have been properly updated to reflect the new organization and repository name.
43-43
: LGTM! Error handling consistently updated across all functions.The error handling has been consistently updated to use
imuacmn.ErrContractInputParamOrType
across all functions, maintaining the same error messages and parameter types.Also applies to: 68-68, 90-90, 114-114, 118-118, 142-142, 168-168, 188-188, 192-192, 220-220
precompiles/bech32/bech32_test.go (2)
11-14
: LGTM! Import paths updated correctly.The import paths have been consistently updated to reflect the new repository location under
imua-xyz/imuachain
.
64-64
:✅ Verification successful
Verify bech32 prefixes in test cases.
The test case names have been updated correctly to reflect the new branding. Let's verify that the bech32 prefixes used in the tests match the configuration.
Also applies to: 85-85, 106-106
🏁 Script executed:
#!/bin/bash # Description: Verify that the bech32 prefixes in the configuration match the test cases. # Search for bech32 prefix definitions in the config package rg -A 2 'Bech32Prefix.*=' cmd/config/Length of output: 1326
Verified bech32 prefixes against configuration.
The test case names in
precompiles/bech32/bech32_test.go
(lines 64, 85, and 106) have been updated to reflect the new branding (using "im", "imvaloper", "imvalcons"). The configuration incmd/config/config.go
confirms thatBech32Prefix
is set to"im"
and that the associated prefixes are correctly composed. No further issues were found with the prefix definitions.proto/imuachain/immint/v1/query.proto (4)
2-2
: Update package namespaceThe package declaration has been updated to
imuachain.immint.v1
, which correctly aligns with the new branding.
6-6
: Update import path for params.protoThe import for
params.proto
now uses the new pathimuachain/immint/v1/params.proto
, ensuring that all proto references follow the updated namespace.
8-8
: Update Go package optionThe
go_package
option is updated to reflect the new module path:"github.com/imua-xyz/imuachain/x/immint/types"
. This maintains consistency with the repository rebranding.
14-14
: Update HTTP mapping endpointThe HTTP mapping for the
Params
RPC method has been updated to/imuachain/immint/v1/Params
, which is consistent with the new brand identity.proto/imuachain/immint/v1/genesis.proto (4)
2-2
: Update package namespaceThe package declaration is now
imuachain.immint.v1
, which is an essential part of the overall rebranding effort.
5-5
: Update import path for params.protoThe import is updated to
"imuachain/immint/v1/params.proto"
, ensuring that message dependencies point to the correct, rebranded location.
7-7
: Update Go package optionThe
go_package
is updated to"github.com/imua-xyz/imuachain/x/immint/types"
, matching the new repository structure and naming.
9-9
: Align GenesisState documentationThe comment now refers to the "immint module" rather than the legacy naming. This improves the clarity of the documentation in line with the branding change.
proto/imuachain/immint/v1/params.proto (2)
2-2
: Update package namespaceThe package declaration now reads
imuachain.immint.v1
to maintain consistency with the rebranding across the codebase.
7-7
: Update Go package optionThe go_package option is now
"github.com/imua-xyz/imuachain/x/immint/types"
, reflecting the new repository naming and structure.proto/imuachain/immint/v1/tx.proto (4)
2-2
: Update package namespaceThe package declaration has been updated to
imuachain.immint.v1
, aligning with the overall rebranding effort.
8-8
: Update import path for params.protoThe import for
params.proto
is updated to"imuachain/immint/v1/params.proto"
, ensuring that all proto dependencies are consistent with the new namespace.
10-10
: Update Go package optionThe
go_package
option now correctly reflects the new module path,"github.com/imua-xyz/imuachain/x/immint/types"
.
34-34
: Update HTTP endpoint mappingThe HTTP mapping for the
UpdateParams
RPC method is updated to/imuachain/immint/v1/tx/MsgUpdateParams
, which is consistent with the new brand identity across the project.precompiles/avs/events.go (1)
11-11
:✅ Verification successful
LGTM! Import path updated correctly.
The import path has been updated to reflect the new branding from Exocore to Imua.
Let's verify that all imports from the old path have been updated:
🏁 Script executed:
#!/bin/bash # Description: Check for any remaining references to the old ExocoreNetwork path rg -i "ExocoreNetwork/exocore"Length of output: 30
LGTM – Import path update verified.
The import update in
precompiles/avs/events.go
(line 11) now correctly reflects the rebranding from Exocore to Imua. A recursive search (rg -i "ExocoreNetwork/exocore"
) did not report any occurrences of the old path, which indicates that the change has been applied consistently.proto/imuachain/appchain/subscriber/v1/query.proto (4)
3-3
: Package Declaration Updated Correctly
The package has been updated toimuachain.appchain.subscriber.v1
in line 3 in accordance with the new branding. Ensure that all dependent modules reference this new package name consistently.
7-7
: Verify Import Path for common.proto
The import statement now uses"imuachain/appchain/common/v1/common.proto"
. However, a previous review comment and static analysis indicate that this file may not exist at the specified location. Please verify that the file is present in your repository (or available via your proto include paths) and update the path if necessary.
9-9
: Go Package Option Reflects New Branding
Thego_package
setting has been updated to"github.com/imua-xyz/imuachain/x/appchain/subscriber/types"
, which aligns with the new repository structure. This change looks correct; ensure the corresponding Go code is updated accordingly.
25-25
: Field Type Update in QueryParamsResponse
On line 25, the fieldparams
now uses the typeimuachain.appchain.common.v1.SubscriberParams
. Confirm that this type is the intended definition for subscriber parameters under the new namespace and that it is correctly defined in the importedcommon.proto
.app/ethtest_helper.go (1)
30-30
: Imports updated to new Imuachain references.
All import paths have been correctly updated to reflect the Imuachain project structure.Also applies to: 32-36
app/test_helpers.go (5)
29-29
: Imports redirected to Imuachain packages.
All references now point to the correct Imuachain modules.Also applies to: 38-45
82-82
: Accurate docstring for Imuachain.
Thanks for updating the comment to reflect the new brand.
88-88
: Function signature now matches ImuachainApp.
This aligns with the overall renaming to Imuachain.
151-151
: Function signature aligns with ImuachainApp.
No issues found; the refactoring is consistent.
332-332
: SetupTestingApp returns ImuachainApp.
Change looks good and consistent across the codebase.cmd/imuad/root.go (5)
49-50
: Updated imports and references to Imuachain.
All package references have been correctly switched to Imuachain and external feeder modules.Also applies to: 53-53, 55-56
60-60
: Environment prefix changed to "IMUACHAIN".
This is consistent with the new branding.
68-68
: Docstring references "imuad" command.
Properly reflects the new daemon name.
89-89
: Short description updated to Imuachain.
Branding alignment is correct.
303-303
: All references now point to “imuaApp” and ImuachainApp.
The naming is consistent with the new application.Also applies to: 324-324, 338-338, 347-347, 353-353, 357-357, 364-364
testutil/utils.go (11)
7-7
: Imports renamed to match Imuachain.
The reference toepochstypes
undergithub.com/imua-xyz/imuachain/x/epochs/types
aligns with the new branding and appears correct.
9-10
: Imports updated for new cmd/config and AVS references.
These import paths match the new repository structure without any obvious issues.
22-23
: Test transaction and oracle imports updated.
All references here appear valid, ensuring test utilities and oracle types are imported from the correct locations.
25-28
: Refactor to Imuachain packages in imports.
The newly introducedimuaapp
,utils
,assetstypes
, anddistributiontypes
references look correctly aligned with theimuachain
codebase.
43-46
: Delegation, Dogfood, Operator imports are consistent.
These references appropriately point to the updated modules in theimuachain
repo.
53-53
: Type change to ImuachainApp.
Switching the application field to*imuaapp.ImuachainApp
is coherent with the rebranding.
93-93
: Updated comment describing ImuachainApp usage.
Comment now accurately references “ImuachainApp” setup.
97-98
: Initialization with SetupTestingApp.
Ensure all dependent modules are properly configured inSetupTestingApp
for the default chain ID.
445-445
: Consensus parameters updated to Imuachain defaults.
Confirm these new defaults align with network expectations regarding block time, max gas, etc.
500-500
: Comment clarifying Imuachain modules genesis.
This clarification helps maintain code readability.
523-523
: Initialization comment updated.
Comment accurately reflects the switch to Imuachain naming.testutil/batch/manager.go (4)
25-25
: Import for Imuachain app package.
Rebranding togithub.com/imua-xyz/imuachain/app
is consistent with the rest of the PR.
28-31
: New imports for precompiles and AVS/operator types.
All references (assets, delegation, AVS, operator) appear valid under the new namespace.
45-47
: Testutil and keys import updated.
These changes ensure references to custom transaction logic and key definitions underimuachain
.
67-67
: Renamed decimal reduction constant.
ImuaDecimalReduction
correctly referencestypes.BaseDenomUnit
. Verify that all usage respects the new base denomination.app/app.go (17)
13-16
: Feedistribution and Oracle modules renamed.
These new imports match theimuachain/x/feedistribution
andx/oracle
structure.
18-19
: Oracle keeper and types rebranded.
No issues noted; the module name is consistent everywhere.
21-23
: AVS and Operator rename in imports.
References align with the new chain name.
25-25
: Slash module import changed to imslash.
Matches the new naming convention ofimuachain/x/slash
.
27-30
: AVS manager and slash keepers.
Ensure the slash keeper, AVS manager, and related types are consistently referenced throughout the code.
38-38
: Ante package updates for EVM.
No functional changes aside from the rename; usage is correct.
42-44
: Asset module references.
The shift toassets
,assetsKeeper
, andassetsTypes
is straightforward.
46-48
: Delegation module references.
Consistently usesdelegation
with updated keeper and types.
50-51
: Operator types.
Correctly pointing tooperatorTypes
.
52-54
: Reward module references.
Checks out for the rename torewardKeeper
andrewardTypes
.
70-70
: Moved ante references intoapp/ante
.
This relocation suits the new structure and naming.
171-173
: Dogfood module is replaced byx/dogfood
.
The staking references are updated accordingly; verify that all references to these dogfood types remain consistent.
175-177
: immint references.
Renamed from any exo references toimmint
; functionality remains unchanged.
185-188
: Imuachain EVM references.
Imports forevmkeeper
andimuaevmtypes
appear correct for the new chain code.
192-195
: Epochs references.
Renamed from any older epoch modules to the newimuachain/x/epochs
paths.
309-309
: Structure renamed to ImuachainApp.
Core rename from any “ExocoreApp” equivalent. Implementation logic remains consistent.
382-383
: NewImuachainApp constructor.
All references appear consistent with the new app name and modules. Confirm the block gas settings match the chain’s requirements.testutil/statedb.go (1)
7-7
: LGTM! Import path updated correctly.The import path change aligns with the rebranding effort from Exocore to Imua.
x/appchain/coordinator/keeper/genesis.go (1)
6-6
: LGTM! Import path updated correctly.The import path change aligns with the rebranding effort from Exocore to Imua.
app/ante/utils/oracle.go (1)
5-5
: LGTM! Import path updated correctly.The import path change aligns with the rebranding effort from Exocore to Imua.
tests/e2e/oracle/suite.go (1)
6-6
: LGTM! Import path updated correctly.The import path change aligns with the rebranding effort from Exocore to Imua.
precompiles/slash/setup_test.go (2)
6-8
: LGTM! Import paths updated correctly.The import paths have been updated to reflect the new repository name.
34-34
:✅ Verification successful
Verify keeper naming convention.
The keeper has been renamed from
ExoSlashKeeper
toImSlashKeeper
. Please ensure this naming convention is consistent across the codebase.
🏁 Script executed:
#!/bin/bash # Search for any remaining instances of ExoSlashKeeper rg "ExoSlashKeeper" # Search for the new ImSlashKeeper to verify consistent usage rg "ImSlashKeeper"Length of output: 741
Keeper Naming Convention Verified
The grep output confirms that all references to the keeper are now consistently using
ImSlashKeeper
with no lingering instances ofExoSlashKeeper
.
- app/app.go – Usage updated to
ImSlashKeeper
.- precompiles/slash/setup_test.go – Confirmed usage as shown.
- x/slash/keeper/execute_slash_test.go and x/slash/keeper/params_test.go – Tests correctly reference
ImSlashKeeper
.No further changes are needed.
cmd/imuad/main.go (2)
9-11
: LGTM! Import paths updated correctly.The import paths have been updated to reflect the new repository name.
20-20
:✅ Verification successful
Verify binary name change across the codebase.
The binary name has been changed from "exocored" to "imuad" as per PR objectives. Please ensure this change is consistently applied across the codebase, including documentation and scripts.
🏁 Script executed:
#!/bin/bash # Search for any remaining instances of the old binary name rg "exocored" # Search for references to the new binary name rg "imuad" # Check specific files that typically contain binary names fd -t f "README.md|Makefile|Dockerfile|\.github"Length of output: 7082
Binary name update verified across the codebase.
I’ve confirmed that all instances of the old binary name "exocored" have been replaced with "imuad" in source files, scripts, and documentation (e.g., in README.md, Makefile, Dockerfile, and various scripts). No leftover references to "exocored" were found.testutil/ante.go (1)
6-6
: LGTM! Import path updated correctly.The import path has been updated to reflect the new repository name.
precompiles/slash/methods.go (2)
10-10
: LGTM! Import alias updated correctly.The import alias has been changed from
exocmn
toimuacmn
to reflect the new repository name.
31-31
:✅ Verification successful
Verify error constant usage across precompiles.
The error constant reference has been updated from
exocmn.ErrContractCaller
toimuacmn.ErrContractCaller
. Please ensure this change is consistently applied across all precompile packages.
🏁 Script executed:
#!/bin/bash # Search for any remaining instances of the old error constant rg "exocmn\.ErrContractCaller" # Search for the new error constant to verify consistent usage rg "imuacmn\.ErrContractCaller"Length of output: 861
Consistency in Error Constant Usage Verified
All instances across the precompile packages now correctly reference
imuacmn.ErrContractCaller
, and no occurrences ofexocmn.ErrContractCaller
remain. This includes updates in:
precompiles/assets/tx.go
precompiles/delegation/tx.go
precompiles/reward/methods.go
precompiles/slash/methods.go
testutil/fund.go (3)
7-8
: LGTM! Import paths correctly updated.The import paths have been properly updated to reflect the new repository name.
14-14
: LGTM! Module name correctly updated in FundAccount.The module name has been properly updated from
exominttypes
toimminttypes
.Also applies to: 18-18
33-33
: LGTM! Module name correctly updated in FundModuleAccount.The module name has been properly updated from
exominttypes
toimminttypes
.Also applies to: 37-37
precompiles/reward/methods.go (2)
10-11
: LGTM! Import paths correctly updated.The import paths have been properly updated to reflect the new repository name.
32-32
: LGTM! Error message reference correctly updated.The error message reference has been properly updated from
exocmn
toimuacmn
.x/appchain/coordinator/client/cli/tx.go (1)
11-11
: LGTM! Import path correctly updated.The import path has been properly updated to reflect the new repository name.
app/forks.go (1)
21-21
: LGTM! Receiver type correctly updated.The receiver type has been properly updated from
ExocoreApp
toImuachainApp
.precompiles/bls/setup_test.go (1)
8-9
: LGTM! Import paths correctly updated.The import paths have been properly updated to reflect the new repository name, maintaining the same package structure.
x/appchain/coordinator/client/cli/query.go (1)
11-11
: LGTM! Import path correctly updated.The import path has been properly updated to reflect the new repository name while maintaining the same package structure.
testutil/network/network_test.go (1)
13-13
: LGTM! Network package references correctly updated.The import path and package references have been properly updated to reflect the new repository name while maintaining test functionality.
Also applies to: 29-29
precompiles/slash/parser.go (2)
7-8
: LGTM! Import paths correctly updated.The import paths have been properly updated to reflect the new repository name.
Also applies to: 12-12
22-22
: LGTM! Error references consistently updated.All error references have been properly updated from
exocmn
toimuacmn
while maintaining the same error handling logic.Also applies to: 23-23, 35-35, 36-36, 39-39, 40-40, 45-45, 46-46, 49-49, 50-50, 55-55, 56-56
precompiles/reward/parser.go (2)
7-7
: LGTM! Import paths updated correctly.The import paths have been properly updated to reflect the new repository name, maintaining the same package structure.
Also applies to: 13-13
23-23
: LGTM! Error handling namespace updated consistently.Error references have been consistently updated from
exocmn
toimuacmn
across all error handling cases, maintaining the same error checking logic.Also applies to: 36-36, 40-40, 46-46, 50-50, 56-56
cmd/config/config.go (2)
11-11
: LGTM! Bech32 prefix updated correctly.The Bech32 prefix has been updated to "im", which correctly propagates to all derived address prefixes.
29-31
: LGTM! Display denomination updated with proper capitalization.The display denomination has been updated to "IMUA" with appropriate capitalization to match ETH and wei conventions.
app/ante/sigverify.go (1)
14-14
: LGTM! Import path updated correctly.The import path has been properly updated to reflect the new repository name while maintaining the same package structure.
testutil/integration.go (2)
13-13
: LGTM! Import path updated correctly.The import path has been properly updated to reflect the new repository name.
21-21
: LGTM! Application type references updated consistently.All references to the application type have been consistently updated from
ExocoreApp
toImuachainApp
while maintaining the same functionality.Also applies to: 34-34, 50-50, 63-63, 69-69, 77-77
testutil/tx/signer.go (1)
9-9
: LGTM! Import path updated correctly.The import path has been updated to reflect the new repository name, which aligns with the rebranding objectives.
init.bat (1)
12-13
: Address the TODO comment regarding testnet chain ID.The comment indicates that the chain ID for the testnet is still under consideration. This should be resolved before finalizing the changes.
Please confirm:
- Has the testnet chain ID been finalized?
- Does the current format
imualocalnet_232-1
align with the intended naming convention?precompiles/bech32/methods.go (1)
11-11
: LGTM! Import and error handling updated correctly.The changes correctly update both the import path and error handling to use the new package name, maintaining consistency with the rebranding effort.
Also applies to: 94-94
app/ante/cosmos/min_price.go (1)
10-10
: LGTM! Import path updated correctly.The import path has been updated to reflect the new repository name, maintaining consistency with the rebranding effort.
precompiles/testutil/contracts/contracts.go (2)
13-15
: LGTM! Import paths correctly updated.The import paths have been consistently updated to reflect the new package structure under the
imua-xyz/imuachain
organization.
19-19
: LGTM! Function signature and utility call updates are consistent.The changes correctly update:
- Function signature to use
imuasapp.ImuachainApp
- Utility call to use
imuautil.DeliverEthTx
Also applies to: 81-81
precompiles/delegation/types.go (2)
11-13
: LGTM! Import paths correctly updated.The import paths have been consistently updated to reflect the new package structure.
25-25
: LGTM! Error handling consistently updated.All error references have been systematically updated from
exocmn
toimuacmn
, maintaining consistency throughout the error handling logic.Also applies to: 39-39, 45-45, 49-49, 55-55, 59-59, 66-66, 68-69, 80-80
utils/utils_test.go (2)
20-20
: LGTM! Bech32 prefix correctly updated.The Bech32 prefix has been updated from "exo" to "im" to align with the new branding.
76-76
: LGTM! Test cases consistently updated.The test function and chain ID test cases have been systematically updated to reflect the new branding:
- Function renamed to
TestImuaChainDenom
- Chain ID test cases updated to use "imua" prefix
Also applies to: 139-139, 144-144, 149-149
precompiles/slash/slash.go (2)
16-17
: LGTM! Import paths correctly updated.The import paths have been consistently updated to reflect the new package structure.
130-130
: LGTM! Logger context correctly updated.The logger context has been updated from "ExoCore module" to "Imuachain module" to maintain consistency with the rebranding.
app/ante/cosmos/txsize_gas.go (1)
13-13
: LGTM!The import path update aligns with the rebranding from Exocore to Imuachain.
testutil/tx/cosmos.go (2)
14-15
: LGTM!Import path updates align with the rebranding effort.
47-47
: LGTM!Parameter renames from
appExocore
toappImuachain
maintain consistency with the rebranding.Also applies to: 70-70, 80-80
precompiles/bech32/methods_test.go (1)
9-11
: LGTM!Import path updates correctly reflect the repository rebranding.
precompiles/reward/reward.go (3)
17-18
: LGTM!Import path updates align with the repository rebranding.
106-106
: LGTM!GitHub issue link correctly updated to reflect new repository.
135-135
: LGTM!Logger context updated to maintain consistency with rebranding.
client/export.go (1)
18-18
: LGTM!The import path has been correctly updated to reflect the new package namespace.
app/export.go (1)
17-17
: LGTM!The import path and method signatures have been correctly updated to reflect the new package namespace and application name.
Also applies to: 53-53, 94-94
testutil/tx/eth.go (1)
21-22
: LGTM!The import paths, method signatures, and variable names have been correctly updated to reflect the new package namespace and application name.
Also applies to: 29-29, 35-35, 101-101, 104-104, 111-111, 120-120
precompiles/assets/query.go (1)
9-9
: LGTM!The import path has been correctly updated to reflect the new package namespace.
testutil/contract.go (1)
20-21
: LGTM!The import path updates align with the rebranding effort while maintaining the original functionality.
precompiles/delegation/delegation.go (1)
14-15
: LGTM!The import path updates align with the rebranding effort while maintaining the original functionality.
precompiles/assets/decode_helper.go (1)
10-10
: LGTM!The error message references have been consistently updated to use the new
imuacmn
package while maintaining the original error handling logic.Also applies to: 32-180
precompiles/delegation/tx.go (1)
8-8
: LGTM! Error constants updated for rebranding.The changes consistently replace
exocmn
error constants withimuacmn
equivalents while maintaining the same error handling logic.Also applies to: 48-48, 74-74, 105-105, 115-115, 125-125, 129-129, 135-135, 159-159, 167-167, 177-177, 181-181
precompiles/assets/tx.go (1)
14-15
: LGTM! Import paths and error constants updated for rebranding.The changes consistently update import paths and error constants while maintaining the same functionality. Comments are also updated to reference Imuachain instead of Exocore.
Also applies to: 39-42, 85-88, 108-111, 150-153
testutil/tx/eip712.go (1)
20-20
: LGTM! Application context updated for rebranding.The changes consistently replace
ExocoreApp
withImuachainApp
while maintaining the same functionality.Also applies to: 53-53, 58-58, 70-70, 81-81, 83-83, 120-120, 132-132, 141-141
precompiles/assets/assets.go (1)
12-12
: LGTM! Import paths and issue links updated for rebranding.The changes consistently update import paths and issue links to reference the new repository while maintaining the same functionality.
Also applies to: 102-102
precompiles/assets/types.go (1)
14-17
: LGTM! Import paths and error message references updated correctly.The changes correctly update the import paths and error message references from ExocoreNetwork to imua-xyz, aligning with the rebranding effort.
Also applies to: 107-107, 115-115, 123-123, 255-255
testutil/batch/manager_test.go (1)
16-16
: LGTM! Import paths and test addresses updated correctly.The changes correctly update:
- Import paths from ExocoreNetwork to imua-xyz
- Test addresses with the new "im" prefix
- Variable names to reflect the new branding
Also applies to: 28-28, 68-68, 87-89, 104-105, 117-117
utils/utils.go (1)
19-19
: LGTM! Import path, chain IDs, and comments updated correctly.The changes correctly update:
- Import path from ExocoreNetwork to imua-xyz
- Chain IDs for both mainnet and testnet
- Comments to reflect the new branding
Also applies to: 25-25, 28-28, 31-31
testutil/abci.go (1)
15-16
: LGTM! Import paths and type references updated correctly.The changes correctly update:
- Import paths from ExocoreNetwork to imua-xyz
- Type references from ExocoreApp to ImuachainApp
- Variable names to reflect the new type
Also applies to: 25-25, 37-37, 65-66, 73-74, 86-86, 93-94, 99-100, 103-104, 120-121, 126-127, 131-132, 142-143, 151-152, 164-165, 169-170, 175-176, 179-180, 183-184, 201-202, 231-232
utils/store.go (1)
12-12
: LGTM!The import path update is consistent with the rebranding effort, and the code properly handles the transition with deprecation notices.
testutil/batch/type.go (1)
38-42
: LGTM!The field renames and comment updates are consistent with the rebranding from Exocore to Imua.
testutil/batch/utils.go (1)
174-175
: LGTM!The balance calculation and logging updates are consistent with the rebranding from Exocore to Imua.
precompiles/avs/avs.go (1)
14-14
: LGTM!The import path has been correctly updated to reflect the new repository name, maintaining consistency with the rebranding effort.
x/appchain/coordinator/keeper/ibc_client.go (2)
14-17
: LGTM!The import paths have been correctly updated to reflect the new repository name, maintaining consistency with the rebranding effort.
55-55
: LGTM!The comment has been appropriately updated to reference "Imuachain" instead of "Exocore", maintaining consistency with the rebranding effort.
precompiles/avs/types.go (2)
9-10
: LGTM!The import paths have been correctly updated to reflect the new repository name, maintaining consistency with the rebranding effort.
62-68
: LGTM!The variable names have been appropriately updated from
exoAddresses
toimAddresses
andexoWhiteAddresses
toimWhiteAddresses
to maintain consistency with the rebranding effort.Also applies to: 73-78
testutil/batch/tx_check.go (2)
13-15
: LGTM!The import paths have been correctly updated to reflect the new repository name, maintaining consistency with the rebranding effort.
268-277
: LGTM!The configuration value references have been appropriately updated from
ExoAmount
toImuaAmount
to maintain consistency with the rebranding effort.precompiles/avs/tx.go (3)
15-16
: LGTM!The import paths have been correctly updated to reflect the new repository structure.
78-78
: LGTM!The error handling has been consistently updated to use the new
imuacmn
package across all functions.Also applies to: 83-83, 149-149, 179-179, 235-235, 241-241, 247-247, 253-253, 259-259, 290-290, 295-295, 301-301, 307-307, 313-313, 344-344, 350-350, 356-356, 366-366, 372-372
195-195
: LGTM!The comments have been updated to reflect the new branding while maintaining accurate documentation.
Also applies to: 219-219
testutil/batch/prepare.go (4)
9-23
: LGTM!The import paths have been correctly updated to reflect the new repository structure.
93-93
: LGTM!The token name references have been consistently updated from "Exo" to "IMUA" across all funding functions.
Also applies to: 98-98, 109-109, 114-114, 119-119
105-106
: LGTM!The comments have been updated to reflect the new token name while maintaining accurate documentation.
404-404
: LGTM!The comment has been updated to reflect the new branding while maintaining accurate documentation.
testutil/network/util.go (2)
30-35
: LGTM!The import paths have been correctly updated to reflect the new repository structure.
310-311
: LGTM!The comment has been updated to reflect the new address prefix while maintaining accurate documentation.
precompiles/avs/query_test.go (5)
9-21
: LGTM!The import paths have been correctly updated to reflect the new repository structure.
64-65
: LGTM!The test has been improved to use dynamic address generation instead of hardcoded values.
88-88
: LGTM!The error message has been updated to use the new
imuacmn
package.
394-398
: LGTM!The test has been improved to use dynamic address generation for multiple test addresses.
463-463
: LGTM!The test has been improved to use dynamic address generation.
tests/e2e/oracle/create_price.go (1)
16-20
: LGTM! Import paths updated correctly.The import paths have been updated from ExocoreNetwork to imua-xyz namespace while maintaining the same package structure.
cmd/imuad/testnet.go (5)
53-58
: LGTM! Import paths updated correctly.The import paths have been updated from ExocoreNetwork to imua-xyz namespace while maintaining the same package structure.
107-107
: LGTM! Command examples updated correctly.The command examples in the documentation have been updated to use
imuad
instead ofexocored
.Also applies to: 138-138, 182-182
223-223
: LGTM! Chain ID format updated correctly.The chain ID format has been updated from
exocoretestnet_%d-1
toimuachaintestnet_%d-1
to reflect the new branding.
345-346
: LGTM! Node directory names updated correctly.The node directory names have been updated from
exocored
andexocorecli
toimuad
andimuacli
respectively.
357-358
: LGTM! Genesis function renamed correctly.The genesis function has been renamed from
getTestExocoreGenesis
togetTestImuachainGenesis
to reflect the new branding.Also applies to: 534-535
testutil/network/network.go (3)
51-55
: LGTM! Import paths updated correctly.The import paths have been updated from ExocoreNetwork to imua-xyz namespace while maintaining the same package structure.
107-107
: LGTM! Chain ID format updated correctly.The chain ID format in DefaultConfig has been updated from
exocore_%d-1
toimuachain_%d-1
to reflect the new branding.
500-504
: LGTM! Gateway address updated with proper error handling.The gateway address has been updated to use the "im" prefix and includes proper error handling for the Bech32 address conversion.
precompiles/assets/assets_test.go (2)
10-21
: LGTM! Import paths updated correctly.The import paths have been updated from ExocoreNetwork to imua-xyz namespace while maintaining the same package structure.
80-80
: LGTM! Variable names and error messages updated correctly.The variable name has been updated from
exocoreLzAppAddress
toimuaLzAppAddress
, and related error messages have been updated to reflect the new branding. The issue URL has also been updated to point to the new repository.Also applies to: 118-118, 127-127, 275-275
proto/imuachain/appchain/subscriber/v1/genesis.proto (3)
1-4
: File Setup and Package Declaration
The file correctly declares theproto3
syntax and sets the package toimuachain.appchain.subscriber.v1
, which aligns with the new branding.
5-6
: Verify Import Path for gogoproto
The file imports"gogoproto/gogo.proto"
, but static analysis indicates that this file may not exist. Please verify that the dependency is correctly configured or update the import path if necessary.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
10-14
: GenesisState Message Definition
TheGenesisState
message is defined clearly with theparams
field usingimuachain.appchain.common.v1.SubscriberParams
and the(gogoproto.nullable) = false
option. This appropriately enforces non-nullability and reflects the intended schema.proto/imuachain/feedistribution/v1/params.proto (4)
1-2
: Updated Syntax and Package Declaration
The file declaresproto3
syntax and updates the package toimuachain.feedistribution.v1
, ensuring consistency with the new branding changes.
4-4
: Verify Amino Import Path
The import statementimport "amino/amino.proto";
has triggered a static analysis warning because the file may not exist. Please verify the correct path for this dependency or adjust your dependency management accordingly.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
8-8
: Go Package Option Confirmation
Thego_package
option is updated to"github.com/imua-xyz/imuachain/x/feedistribution/types"
, which is consistent with the rebranding effort.
11-22
: Params Message Definition
TheParams
message is defined with the updated amino name option (imua/x/feedistribution/Params
) and includes all necessary fields for fee distribution. The configuration appears correct.proto/imuachain/appchain/coordinator/v1/coordinator.proto (4)
3-3
: Package Declaration Update
The package is updated toimuachain.appchain.coordinator.v1
, which correctly reflects the new namespace under Imuachain.
5-6
: Import and Dependency Check
The import for"gogoproto/gogo.proto"
is present here as well; however, similar static analysis feedback applies—please verify that the file exists in the dependency set. Additionally, the updated import"imuachain/appchain/coordinator/v1/tx.proto"
correctly references the revised module structure.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
8-8
: Go Package Option Update
Thego_package
option is now set to"github.com/imua-xyz/imuachain/x/appchain/coordinator/types"
, which is in line with the rebranding changes.
14-14
: Field Type Update for Subscriber Requests
The type for thelist
field inPendingSubscriberChainRequests
has been updated to reference.imuachain.appchain.coordinator.v1.RegisterSubscriberChainRequest
, ensuring consistency with the new namespace.scripts/protocgen.sh (1)
24-24
: File Movement Command Confirmation
The copy command on line 24 moves files fromgithub.com/imua-xyz/imuachain/*
to the current directory. This appears correct given the new repository structure; just ensure that it aligns with your intended file organization..github/workflows/consensuswarn.yml (2)
16-16
: Job Name Update
The job identifier has been updated toconsensus-warn
, which clearly reflects its purpose under the new branding scheme.
29-29
: Update Roots Parameter
Theroots
parameter now correctly references methods ongithub.com/imua-xyz/imuachain/app.ImuachainApp
(i.e.,DeliverTx
,BeginBlocker
, andEndBlocker
). This update aligns with the new package path. Confirm that these references comprehensively capture all necessary entry points for the consensus warning check.networks/local/imuachain/wrapper.sh (4)
6-6
: Binary Path Rebranding
The assignmentBINARY=/imua/${BINARY:-imuad}
correctly reflects the new branding by switching the base directory from exocore to imua and defaulting to the binary nameimuad
.
8-8
: Log Filename Update
The LOG variable now defaults toimua.log
, which aligns well with the rebranded naming conventions.
11-11
: Updated Error Messaging
The error message now accurately reports that the binary (using its basename) cannot be found, with guidance to set the BINARY environment variable if its name is notimuad
. This helps avoid confusion during troubleshooting.
15-15
: Environment Home Directory Update
The exported EHOME variable is updated to/home/imua/data/node${ID}/imuad
, which reflects the new directory structure for Imuachain nodes.networks/local/imuachain/Dockerfile (4)
17-18
: User and Group Configuration Update
The commands to add a group and user (imua
) now correctly reflect the rebranding. These changes help ensure that file permissions and ownership are set appropriately in the runtime image.
20-21
: User and CMD Instruction Revision
SettingUSER imua
and specifying the CMD with the new chain ID (imualocalnet_232-1
) and other flags correctly configures the container to run the imua node.
24-25
: Volume and Working Directory Updates
The updates forVOLUME /imua
andWORKDIR /imua
ensure that data persistence and operating directory align with the new branding.
27-28
: Wrapper Script and Binary Copy Location
The wrapper script is now copied from./networks/local/imuachain/wrapper.sh
to/usr/bin/wrapper.sh
, which is correct. However, note that the binary is copied with:-COPY --from=build /go/work/build/imuad /imuachain +// Expected destination might be `/imua` to match the BINARY variable set in the wrapper.There appears to be a potential inconsistency because the
wrapper.sh
expects the binary at/imua/${BINARY:-imuad}
while the Dockerfile copies it to/imuachain
. Please verify if this discrepancy is intentional or if the copy destination should be updated to/imua
for consistency.Dockerfile (4)
5-6
: Updated Working Directory for Build Environment
The working directory is now set to/go/src/github.com/imua-xyz/imuachain
, which aligns with the new project repository structure.
23-24
: Copying the Rebranded Binary and Tools
The command copying the built binary (imuad
) to/usr/bin/imuad
and our installation oftoml-cli
ensure that the runtime container has the correct tools. This supports the new branding well.
32-33
: User and Group Setup in the Final Image
Creating theimua
group and user and switching to the correct working directory (/home/imua
) ensure that the container runs with the proper non-root privileges.
43-43
: Simplified Startup Command
The final CMD["imuad"]
succinctly starts the imua service, reflecting the rebranding and ensuring consistency with the new binary name.scripts/start-docker.sh (6)
7-7
: Temporary Data Directory Naming
Usingmktemp
to create a temporary data directory with the prefiximua-datadir
is a neat solution, ensuring that test environments remain isolated and clearly identified.
10-12
: Imuad Command Updates for Key Management and Initialization
All commands invoking theimuad
binary (for adding keys and initializing the node) have been updated appropriately, reflecting the new binary name and configuration.
14-16
: Genesis Account Allocation
The commands for adding a genesis account use the updatedimuad
command. Ensure that the parameters (amounts and denominations) are correct as per the new network requirements.
20-22
: Genesis Transaction Collection and Validation
The commands to collect genesis transactions and validate the genesis file are updated to utilize theimuad
binary, ensuring that the genesis preparation process is consistent with the new blockchain framework.
24-27
: Node Startup in Background
The script correctly starts the imua node in the background and disowns the process. This approach helps in running the containerized node without blocking the script.
30-31
: Completion Message
Echoing that the imua node has started and tailing/dev/null
ensures the script remains active, which can be useful in containerized environments.proto/imuachain/feedistribution/v1/tx.proto (6)
2-2
: Package Declaration Update
The package name is successfully updated toimuachain.feedistribution.v1
, ensuring that the protocol buffers align with the new project branding.
4-4
: Static Analysis Warning on Import
Static analysis has flagged the importimport "amino/amino.proto";
as missing. Please verify that this file exists in the expected location or update the import path accordingly. If this is a known false positive, consider adding a comment or configuration to ignore it.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
9-9
: Import Path Update for Params
Updating the import to"imuachain/feedistribution/v1/params.proto"
ensures that dependencies are resolved according to the new branding.
11-11
: Go Package Option Revised
Theoption go_package
is now set to"github.com/imua-xyz/imuachain/x/feedistribution/types"
, which is correct for the rebranded repository structure.
20-20
: RPC Endpoint Rebranding
The HTTP endpoint for theUpdateParams
RPC has been updated to"/imuachain/feedistribution/v1/tx/MsgUpdateParams"
, which matches the new structure.
27-27
: Amino Name Option Update
The amino name option is changed to"imua/x/feedistribution/MsgUpdateParams"
, correctly reflecting the rebranding.proto/imuachain/appchain/coordinator/v1/params.proto (6)
3-3
: Namespace Update: Package Declaration
The package declaration is updated to use the newimuachain
namespace, which is consistent with the rebranding effort.
5-5
: Verify Import: gogoproto/gogo.proto
The import for"gogoproto/gogo.proto"
may trigger static analysis warnings (file does not exist). Please ensure that the dependency is either vendored or the path is valid within your project structure.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
8-8
: Rebrand Import: Epochs Proto File
The import has been updated to"imuachain/epochs/v1/epochs.proto"
, which correctly reflects the new namespace.
10-10
: Rebrand go_package Option
Thego_package
option now points to"github.com/imua-xyz/imuachain/x/appchain/coordinator/types"
, aligning with the rebranding strategy.
30-30
: Field Type Update: init_timeout_period
The type ofinit_timeout_period
has been updated to useimuachain.epochs.v1.Epoch
, which is correct per the new branding.
33-36
: Field Type Update: vsc_timeout_period
Similarly, the type forvsc_timeout_period
now usesimuachain.epochs.v1.Epoch
and includes the custom name option. This update is consistent and correct.scripts/protoc-swagger-gen.sh (2)
9-9
: Update buf.yaml Configuration
The buf configuration has been updated to usebuf.build/imua-xyz/imuachain
, which reflects the project’s new naming.
15-15
: Update Proto Directory Copy
The script now copies the./proto/imuachain
directory instead of the previousexocore
directory. This change aligns with the rebranding effort.networks/init-node.sh (1)
7-10
: Update Configuration Paths for New Binary Name
The configuration file paths (GENESIS
,TMP_GENESIS
,APP_TOML
, andCONFIG_TOML
) have been updated to reflect the newimuad
directory. This ensures that the node initialization script targets the correct configuration files after rebranding.proto/imuachain/dogfood/v1/dogfood.proto (4)
3-3
: Update Package Name for Rebranding
The package declaration is updated toimuachain.dogfood.v1
, which is consistent with the new project identity.
10-10
: Update go_package Option
Thego_package
option now correctly points to"github.com/imua-xyz/imuachain/x/dogfood/types"
, in line with the new branding.
12-14
: Rename Validator Message
The message previously namedExocoreValidator
has been renamed toImuachainValidator
, with updated comments. This renaming provides consistency with the project’s rebranding.
5-7
: Verify Third-Party Proto Imports
The import of"cosmos/staking/v1beta1/staking.proto"
might trigger static analysis warnings. Please confirm that this dependency is correctly resolved (either via vendoring or proper path configuration) in your build environment.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos/staking/v1beta1/staking.proto": file does not exist
(COMPILE)
proto/imuachain/appchain/coordinator/v1/query.proto (7)
3-3
: Rebrand Package Declaration
The package declaration is updated toimuachain.appchain.coordinator.v1
, ensuring consistency with the new project identity.
5-5
: Verify Import: gogoproto/gogo.proto
Similar to other proto files, please verify that thegogoproto/gogo.proto
dependency is available or correctly referenced, as static analysis indicates that the file might not exist.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
7-7
: Update Import: common.proto
The import path forcommon.proto
is updated to"imuachain/appchain/common/v1/common.proto"
, which aligns with the new namespace.
8-8
: Update Import: params.proto
The change to import"imuachain/appchain/coordinator/v1/params.proto"
is correct for the current rebranding.
10-10
: Rebrand go_package Option
Thego_package
option is updated to"github.com/imua-xyz/imuachain/x/appchain/coordinator/types"
, matching the new repository structure.
20-21
: Update HTTP Endpoint URL
The HTTP endpoint for theQuerySubscriberGenesis
RPC method has been updated to use/imuachain/appchain/coordinator/v1/subscriber_genesis/{chain}
. This ensures that client requests use the correct namespace.
43-43
: Update SubscriberGenesisState Reference
The field type forsubscriber_genesis
now correctly referencesimuachain.appchain.common.v1.SubscriberGenesisState
, consistent with the new branding schema..github/workflows/proto.yml (3)
20-34
: Refactor: Renamed Job "proto-build"The job previously named “build” is now “proto-build”. This clearly aligns with the new naming conventions and improves clarity.
36-47
: Update: Renamed Job "proto-lint"The job renaming to “proto-lint” is consistent with the overall rebranding and its purpose remains clear.
48-66
: Enhancement: Adjusted Break-Check Job LogicThe “proto-break-check” job now compares the PR branch against the base branch using a URL and includes
continue-on-error: true
to prevent build failure on breaking changes. The in-code comments explain the rationale well.
[approved, verify]docker-compose.yml (4)
4-12
: Refactor: Update Service "imuanode0" ConfigurationThe service “imuanode0” is rebranded with updated container name, image, LOG environment variable, and volume mount. These modifications are consistent with the new naming and path conventions.
29-37
: Refactor: Update Service "imuanode1" ConfigurationThe configuration for “imuanode1” now reflects the new branding with updated container name, image reference, LOG variable, and volume binding.
54-62
: Refactor: Update Service "imuanode2" ConfigurationThe updated configuration for “imuanode2”—including the container name, image, LOG environment variable, and volume path—is properly rebranded.
79-87
: Refactor: Update Service "imuanode3" ConfigurationThe “imuanode3” service now uses the new naming conventions for container name, image, LOG variable, and volume path. The changes are clear and consistent.
.goreleaser.yml (3)
8-10
: Update: Rebrand "imuad-darwin" Build ConfigurationThe build configuration for “imuad-darwin” has its main command and binary output paths updated to match the new project name.
23-30
: Critical: Verify Compiler Flags for "imuad-darwin-arm64" BuildThe “imuad-darwin-arm64” block correctly updates main and binary paths. However, note that the C compiler flag is set as
CC=oa64-clang
(line 28) while the darwin build usesCC=o64-clang
. Please verify whether the extra "a" is intentional.
[critical_issue, verify]
91-95
: Update: Archives Section Reflects New Build IdentifiersThe archives configuration now correctly lists the new build identifiers, ensuring consistency across release artifacts for all platforms.
proto/imuachain/feedistribution/v1/distribution.proto (3)
2-2
: Update: Package Name ChangeThe package declaration is updated from
exocore.feedistribution.v1
toimuachain.feedistribution.v1
, aligning with the project’s rebranding.
8-8
: Update: Go Package Option RevisedThe
go_package
option has been changed to reflect the new repository path. This ensures that generated code and import paths remain consistent with the rebranded project structure.
4-4
: Verify: Existence of "amino/amino.proto"Static analysis indicates that the file
amino/amino.proto
may not exist. Please confirm that this file is present in the repository—or update the import statement accordingly.
[verify, offer_assistance]🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/avs/v1/query.proto (4)
2-2
: Update: Package Name ChangeThe package is now set to
imuachain.avs.v1
, effectively reflecting the rebranding.
7-9
: Update: Import and Go Package OptionThe import for
"imuachain/avs/v1/tx.proto"
and thego_package
option are updated to the new repository paths. This aids in consistency with the overall transition.
79-96
: Update: HTTP Endpoint Paths RevisedThe HTTP endpoint paths within the RPC options have been updated from
/exocore/avs/v1/...
to/imuachain/avs/v1/...
. Double-check that these endpoints match client-side expectations and documentation.
[approved, verify]
4-4
: Verify: Existence of "cosmos_proto/cosmos.proto"Static analysis reports that
cosmos_proto/cosmos.proto
could not be found. Please verify that this file exists in the repository or update the import path if needed.
[verify, offer_assistance]🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/query.proto (6)
3-3
: Package Declaration Updated to New Branding
The package has been updated toimuachain.dogfood.v1
, which is in line with the new branding effort.
9-10
: Updated Import Paths Reflect New Namespace
The import statements fordogfood.proto
andparams.proto
now reference"imuachain/dogfood/v1/..."
, ensuring consistency in the new naming convention.
12-12
: Go Package Option Modified
Theoption go_package
directive has been updated to"github.com/imua-xyz/imuachain/x/dogfood/types"
. This ensures that generated code points to the correct repository.
19-19
: HTTP GET Annotations Revised for RPC Endpoints
All HTTP endpoint paths in the RPC method definitions have been updated to use the/imuachain/dogfood/v1/
prefix. Please double-check that these changes align with the updated API documentation and client expectations.Also applies to: 25-25, 31-31, 37-37, 43-43, 50-50, 57-57
121-121
: Validator Response Types Updated
The response type inQueryValidatorResponse
is nowImuachainValidator
and the repeated field inQueryAllValidatorsResponse
appropriately reflects the new validator type.Also applies to: 133-133
5-5
: Static Analysis Note Regarding Pagination Import
A static analysis hint flags the import of"cosmos/base/query/v1beta1/pagination.proto"
as missing. Please verify that this file exists at the expected location or update the import path if necessary.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
client/docs/config.json (4)
3-5
: Documentation Title Updated Successfully
The documentation title has been changed to"Imuachain - gRPC Gateway docs"
, clearly reflecting the new branding.
10-10
: Epoch Endpoint URL Reflects Rebranding
The URL for the epochs query now uses"./tmp-swagger-gen/imuachain/epochs/v1/query.swagger.json"
, which is consistent with the new naming convention.
142-142
: API Endpoint URLs Updated Across Services
Multiple API endpoint URLs have been updated (for dogfood, assets, slash, oracle, immint, feedistribution, delegation, avs, operator, and reward) to use the/imuachain/
prefix. This comprehensive update should streamline integrations across services.Also applies to: 152-152, 160-160, 168-168, 176-176, 184-184, 192-192, 195-195, 198-198, 225-225
161-165
: Operation ID Renaming for Slash Endpoint
The parameter renaming (e.g."Params": "ImSlashParams"
) ensures consistency with the new branding. Please verify that downstream tools consuming these configuration files correctly interpret the new names.proto/imuachain/assets/v1/query.proto (5)
2-2
: Package Name Updated to Reflect Rebranding
The package is now declared asimuachain.assets.v1
, aligning with the overall migration effort.
9-11
: Import Paths Aligned with New Namespace
The imports forgenesis.proto
,params.proto
, andtx.proto
have been updated to reference the newimuachain/assets/v1/
directory.
13-13
: Go Package Option Updated
Theoption go_package
is now set to"github.com/imua-xyz/imuachain/x/assets/types"
, ensuring that generated code uses the correct import path.
106-106
: Revised HTTP GET Annotations for Asset Module RPC Endpoints
The HTTP GET mappings for various RPC methods (including asset parameters, client chain info, asset info, and operator asset queries) have been updated to use the/imuachain/assets/v1/
URL prefix. This update is crucial for maintaining API consistency.Also applies to: 112-112, 117-117, 122-122, 127-127, 132-132, 137-137
4-4
: Static Analysis Note on Pagination Import
The import"cosmos/base/query/v1beta1/pagination.proto"
is flagged by static analysis. Please verify whether the file exists or update the import as needed.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
proto/imuachain/operator/v1/genesis.proto (5)
2-2
: Updated Package Declaration for Operator Module
The package declaration is nowimuachain.operator.v1
, which is consistent with the rebranding strategy.
6-6
: Import Path Adjusted for Transaction Definitions
Updating the import to"imuachain/operator/v1/tx.proto"
aligns with the new module structure.
8-8
: Go Package Option Revised
Theoption go_package
has been updated to"github.com/imua-xyz/imuachain/x/operator/types"
, ensuring proper package referencing.
10-14
: Comments and Data Structures Consistently Rebranded
All comments and message definitions (e.g.GenesisState
,OperatorDetail
) have been updated to reference Imuachain instead of Exocore. The functional structure remains unchanged.
4-4
: Static Analysis Note on Cosmos Proto Import
Static analysis indicates that"cosmos_proto/cosmos.proto"
might be missing. Please verify the existence of this file or update the import path if required.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/assets/v1/tx.proto (6)
2-2
: Package Declaration Aligned with New Branding
The package is now declared asimuachain.assets.v1
, which is consistent with the overall project rebranding.
4-8
: Import Statements Updated for Asset Transactions
The imports have been revised to include the updated"imuachain/assets/v1/params.proto"
and to reflect the needed dependencies. Please verify that external proto dependencies (e.g. amino and cosmos proto) are correctly resolved in your build system.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
11-11
: Go Package Option Corrected
The updatedoption go_package
directive ensures that the generated Go code uses the new path"github.com/imua-xyz/imuachain/x/assets/types"
.
31-32
: Field Renaming in ClientChainInfo and AssetInfo
The introduction of theimua_chain_index
field (replacing the old naming) improves clarity in the context of Imuachain’s system. Ensure that any backend logic referencing this value is updated accordingly.Also applies to: 56-57
205-206
: UpdateParams RPC Endpoint Revised
The HTTP POST option forMsgUpdateParams
has been updated to"/imuachain/assets/v1/tx/MsgUpdateParams"
, which reflects the new branding in transaction endpoints.
4-4
: Static Analysis Note on Amino Proto Import
Static analysis reports that"amino/amino.proto"
may not exist. If this import is necessary, verify that the dependency is correctly located or adjust the path accordingly.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
go.mod (2)
1-1
: Module Renaming Reflects the New Brand.
The module declaration has been updated fromgithub.com/ExocoreNetwork/exocore
togithub.com/imua-xyz/imuachain
, which is consistent with the rebranding effort.
26-26
: Updated Dependency on Price Feeder.
The dependency ongithub.com/imua-xyz/price-feeder
with the revised version string indicates a shift to a fork or updated version. Please ensure that downstream code accommodates any API changes in this dependency.local_node.sh (8)
6-6
: Updated Chain ID for Local Node.
The chain identifier has been changed from"exocorelocalnet_232-1"
to"imualocalnet_232-1"
, ensuring that the local testnet now reflects the new brand identity.
14-15
: Home Directory Update for the New Daemon.
The dedicated home directory has been updated from"$HOME/.tmp-exocored"
to"$HOME/.tmp-imuad"
. This change is aligned with the overall rebranding and ensures file storage is segregated properly.
68-69
: Rebranded Configuration Commands.
The configuration commands now useimuad
instead of the oldexocored
command (e.g.,imuad config keyring-backend
andimuad config chain-id
). Ensure that all scripts, documentation, and external integrations are updated accordingly.
77-81
: Key Management Commands Updated.
The key recovery and initialization commands have been rebranded to useimuad
(e.g.,imuad keys add --recover
andimuad init ... --recover
). These updates should maintain consistent key derivation and validator initialization. Please verify that any downstream tooling or automation expecting the old command names has been updated.
86-88
: Updating Address Retrieval Commands.
The commands retrieving the addresses now useimuad keys show
andimuad keys parse
, ensuring that the local operator and related addresses are managed with the new binary.
121-121
: JSON Genesis Update for Operator Assets.
The genesis JSON is updated to assign the operator field usingLOCAL_ADDRESS_IM
rather than the legacy variable. This ensures that the operator assets are correctly linked to the new address format.
321-323
: Replaced Genesis Account Commands.
The commands that add genesis accounts now useimuad add-genesis-account
with the denomination appended ashua
, in accordance with the rebranding. Review that the updated supply amounts and denomination strings match the intended economic parameters.
339-339
: Daemon Start Command Updated toimuad
.
The final node startup command has been switched toimuad start
with updated flags. Confirm that the metrics, logging, and API parameters are functioning as expected with the new binary.Makefile (7)
9-9
: Updated Binary Name Definition.
TheIMUACHAIN_BINARY
variable is set toimuad
, reflecting the new naming convention in the build process.
11-11
: HTTPS Git Repository URL Updated.
The repository URL has been updated tohttps://github.com/imua-xyz/imuachain
, ensuring that the Makefile points to the new project location.
20-21
: Namespace and Project Variables Rebranded.
TheNAMESPACE
andPROJECT
variables have been updated from Exocore values toimua-xyz
andimuachain
respectively. This change ensures uniformity across Docker image naming and other targets.
70-71
: Linker Flags Updated for Rebranding.
The linker flags now embed the new names (e.g.,version.Name=imuachain
andversion.AppName=$(IMUACHAIN_BINARY)
). This is essential for version tracking and binary identification.
139-141
: Test Tool Build Targets Rebranded.
The build and install commands for the test tool now referenceimuachain-test-tool
, matching the new project branding. It’s important to verify that all tests and associated scripts reference this updated binary name.
162-168
: Docker Wrapper Script Update.
The Makefile now creates a wrapper script for invokingimuad
via Docker. This ensures that local Docker-based commands run the correct binary with the appropriate parameters. Consider adding tests if not already present to confirm the wrapper’s functionality.
546-546
: Package Name Rebranding.
ThePACKAGE_NAME
variable has been updated togithub.com/imua-xyz/imuachain
, ensuring that all release and build tasks use the correct package identifier.proto/imuachain/appchain/subscriber/v1/tx.proto (3)
1-3
: Package Declaration and Syntax Check.
The syntax is correctly set to"proto3"
and the package is updated toimuachain.appchain.subscriber.v1
. Note that Buf static analysis may flag a directory mismatch (expecting the file underimuachain/appchain/subscriber/v1
rather thanproto/imuachain/appchain/subscriber/v1
), but as per the project’s buf dependency configuration (per MaxMustermann2’s guidance), this is handled automatically.🧰 Tools
🪛 Buf (1.47.2)
3-3: Files with package "imuachain.appchain.subscriber.v1" must be within a directory "imuachain/appchain/subscriber/v1" relative to root but were in directory "proto/imuachain/appchain/subscriber/v1".
(PACKAGE_DIRECTORY_MATCH)
5-5
: Go Package Option Update.
Thego_package
option is updated to"github.com/imua-xyz/imuachain/x/appchain/subscriber/types"
, which is correct relative to the new repository branding.
7-8
: Service Definition Review.
The file defines the newMsg
service. Although no methods are specified, confirm that this is intentional. If further methods are expected later, ensure they’re properly added.proto/imuachain/oracle/v1/index_recent_msg.proto (2)
1-4
: Package and Go Package Option Update.
The package declaration has been updated toimuachain.oracle.v1
and thego_package
option now points to"github.com/imua-xyz/imuachain/x/oracle/types"
. As noted in previous reviews, ensure that the physical file location (currently underproto/imuachain/oracle/v1
) is accepted by the buf dependency system despite the static analysis expectations.🧰 Tools
🪛 Buf (1.47.2)
2-2: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
7-10
: Message Definition Check.
TheIndexRecentMsg
message is defined correctly with a repeateduint64 index
field.proto/imuachain/oracle/v1/index_recent_params.proto (2)
1-4
: Package and Go Package Option Update.
The package is nowimuachain.oracle.v1
and thego_package
option is updated appropriately. As with similar proto files, confirm that the directory structure underproto/imuachain/oracle/v1
is acceptable based on the project's buf configuration.🧰 Tools
🪛 Buf (1.47.2)
2-2: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
6-10
: Message Definition Verification.
TheIndexRecentParams
message, which includes a repeateduint64 index
field, is correctly defined and consistent with expectations.proto/imuachain/oracle/v1/validator_update_block.proto (2)
1-4
: Package and Go Package Option Update.
The package declaration is updated toimuachain.oracle.v1
and thego_package
option is now set to"github.com/imua-xyz/imuachain/x/oracle/types"
. As with the other proto files in this namespace, please verify that the placement underproto/imuachain/oracle/v1
meets the buf dependency system’s configuration.🧰 Tools
🪛 Buf (1.47.2)
2-2: Files with package "imuachain.oracle.v1" must be within a directory "imuachain/oracle/v1" relative to root but were in directory "proto/imuachain/oracle/v1".
(PACKAGE_DIRECTORY_MATCH)
6-10
: Message Structure Check.
TheValidatorUpdateBlock
message is defined appropriately with a field for the block height indicating when the validator set changed.proto/imuachain/assets/v1/params.proto (1)
1-4
: Package and Go Package Option Update.
The package has been updated toimuachain.assets.v1
and thego_package
option is now correctly set to"github.com/imua-xyz/imuachain/x/assets/types"
.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/recent_params.proto (3)
2-2
: Package declaration updated to the new namespace.
The package is now correctly set toimuachain.oracle.v1
, which aligns with the new branding.
4-4
: Verify the import path for params.proto.
The import now points toimuachain/oracle/v1/params.proto
. Please confirm that the file exists at this location (the static analysis hint reported a possible absence).🧰 Tools
🪛 Buf (1.47.2)
4-4: import "imuachain/oracle/v1/params.proto": file does not exist
(COMPILE)
6-6
: Go package option updated correctly.
The updated go_package optiongithub.com/imua-xyz/imuachain/x/oracle/types
is in line with the rebranding efforts.proto/imuachain/reward/v1/genesis.proto (3)
2-2
: Package declaration updated for reward module.
The package has been correctly updated toimuachain.reward.v1
.
5-5
: Import path for params.proto updated.
The import now points toimuachain/reward/v1/params.proto
. Please verify that this file is in the expected location to avoid build issues.
7-7
: Go package option updated successfully.
The option now usesgithub.com/imua-xyz/imuachain/x/reward/types
, which is consistent with the new organizational structure.proto/imuachain/appchain/coordinator/v1/genesis.proto (3)
3-3
: Updated package declaration for appchain coordinator.
The package is nowimuachain.appchain.coordinator.v1
, which fits the new branding.
6-6
: Import statement updated for coordinator params.
The import now refers toimuachain/appchain/coordinator/v1/params.proto
. Please verify that the file exists at this path.
8-8
: Go package option updated appropriately.
The new go_package optiongithub.com/imua-xyz/imuachain/x/appchain/coordinator/types
is correct.proto/imuachain/slash/v1/genesis.proto (4)
2-2
: Package declaration updated for slash module.
The package is now set toimuachain.slash.v1
, reflecting the rebranding accurately.
5-5
: Import path for params.proto updated.
The import now refers toimuachain/slash/v1/params.proto
. Please ensure that this file is available in the specified location.
8-8
: Go package option update confirmed.
The go_package option is changed togithub.com/imua-xyz/imuachain/x/slash/types
, which is in line with the new naming conventions.
10-10
: Updated module description in comments.
The comment now clearly states that it defines the imuaslash module's genesis state.proto/imuachain/oracle/v1/prices.proto (3)
2-2
: Package declaration updated to the new namespace.
The package has been changed toimuachain.oracle.v1
, which fits the rebranding effort.
5-5
: Review import for price.proto.
The import now points toimuachain/oracle/v1/price.proto
. Note that a previous review comment flagged a similar issue regarding the file not being found. Please verify thatprice.proto
exists at this location or adjust the path as necessary.
7-7
: Go package option updated correctly.
The updated go_package optiongithub.com/imua-xyz/imuachain/x/oracle/types
aligns with the new project structure.proto/imuachain/oracle/v1/slashing.proto (1)
5-5
: Update Go package option.
Thego_package
option is now set to"github.com/imua-xyz/imuachain/x/oracle/types"
, which correctly reflects the new repository path. Ensure that all downstream dependencies or generated code are updated accordingly.proto/imuachain/epochs/v1/epochs.proto (1)
5-5
: Update Go package option.
Thego_package
option set to"github.com/imua-xyz/imuachain/x/epochs/types"
is correct as per the new structure. No further action is required here.proto/imuachain/oracle/v1/nonce.proto (3)
2-2
: Update package declaration.
The package declaration has been updated toimuachain.oracle.v1
, which is consistent with the new naming convention.
4-4
: Verify dependency import for gogoproto.
Static analysis reports thatimport "gogoproto/gogo.proto";
may not resolve because the dependency file is not found. Please ensure that this dependency is available (e.g., via a proper include path or submodule) or update the import accordingly.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
6-6
: Update Go package option.
Thego_package
option is updated to"github.com/imua-xyz/imuachain/x/oracle/types"
; this change correctly aligns with the new repository path.proto/imuachain/reward/v1/query.proto (5)
2-2
: Update package declaration.
The package has been updated toimuachain.reward.v1
in line with the rebranding.
4-4
: Validate Google API annotations import.
Static analysis indicates thatimport "google/api/annotations.proto";
may not be found. Please verify that the dependency exists in your include paths or adjust the path as needed.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "google/api/annotations.proto": file does not exist
(COMPILE)
5-5
: Update import path for params.proto.
The import has been updated to"imuachain/reward/v1/params.proto"
for consistency with the new branding. However, static analysis noted that this file might be missing—please confirm the file’s location or update the import if necessary.
7-7
: Update Go package option.
Thego_package
option is now correctly set to"github.com/imua-xyz/imuachain/x/reward/types"
.
13-13
: Update HTTP endpoint path.
The HTTP endpoint for theParams
RPC is now updated to/imuachain/reward/v1/params
, matching the new namespace. Please ensure that all service consumers are aware of this change.proto/imuachain/oracle/v1/recent_msg.proto (4)
2-2
: Update package declaration.
The package declaration has been updated toimuachain.oracle.v1
, which is consistent with the overall rebranding effort.
4-4
: Verify dependency import for gogoproto.
Static analysis highlights thatimport "gogoproto/gogo.proto";
may not resolve as the file could be missing. Please verify the availability of this dependency or adjust the import path as required.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
5-5
: Verify imported proto file path for price.proto.
The import"imuachain/oracle/v1/price.proto"
has been updated to reflect the new namespace; however, static analysis indicates that this file might not exist. Please confirm if the file has been relocated or if the import path needs further adjustment.
7-7
: Update Go package option.
Thego_package
option is now set to"github.com/imua-xyz/imuachain/x/oracle/types"
and correctly reflects the repository change.proto/imuachain/slash/v1/query.proto (4)
2-2
: Package Declaration Update Verified
The package declaration is now set toimuachain.slash.v1
, which correctly reflects the rebranding.
5-5
: Params Proto Import Verification
The import of"imuachain/slash/v1/params.proto"
is updated as part of the migration. Please verify that this file exists in the expected location—this was previously flagged by static analysis.
8-8
: Go Package Option Updated
Theoption go_package
value"github.com/imua-xyz/imuachain/x/slash/types"
is properly updated to match the new repository structure.
14-14
: HTTP Endpoint Updated
The HTTP option is now set to"/imuachain/slash/v1/params"
, accurately reflecting the new namespace in the RPC method.proto/imuachain/reward/v1/types.proto (3)
3-3
: Package Declaration Updated
The package is correctly updated toimuachain.reward.v1
, aligning with the overall rebranding effort.
5-5
: Cosmos Coin Proto Import Verification
The import"cosmos/base/v1beta1/coin.proto"
has been flagged by static analysis. Please verify that this dependency is correctly resolved in your build environment—this warning may be a false positive if the dependency is managed externally.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos/base/v1beta1/coin.proto": file does not exist
(COMPILE)
8-8
: Go Package Option Confirmed
The updatedgo_package
option"github.com/imua-xyz/imuachain/x/reward/types"
correctly reflects the new project structure.proto/imuachain/feedistribution/v1/query.proto (5)
2-2
: Package Declaration Update Confirmed
The package is now declared asimuachain.feedistribution.v1
, which meets the new branding requirements.
4-4
: Amino Proto Import Verification
The import"amino/amino.proto"
is reported as missing by static analysis. Please verify whether this is a false positive or if the import path requires updating.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
7-7
: Params Proto Import Check
Ensure that"imuachain/feedistribution/v1/params.proto"
exists and is in the correct location. This check is critical given previous dependency path concerns.
9-9
: Go Package Option Updated
Theoption go_package
is correctly set to"github.com/imua-xyz/imuachain/x/feedistribution/types"
.
15-15
: HTTP Endpoint Updated
The HTTP endpoint option is updated to"/imuachain/feedistribution/v1/params"
, which is consistent with the new namespace.proto/imuachain/slash/v1/tx.proto (4)
2-2
: Package Declaration Updated
The package declaration now reflectsimuachain.slash.v1
, following the migration guidelines.
4-4
: Cosmos Msg Proto Import Verification
The import"cosmos/msg/v1/msg.proto"
is flagged by static analysis as missing. Verify that this dependency is available or update the path as needed.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
7-7
: Params Proto Import Verification
Confirm that the file"imuachain/slash/v1/params.proto"
exists in the expected location to avoid runtime issues.
9-9
: Go Package Option Confirmed
Thego_package
value is properly updated to"github.com/imua-xyz/imuachain/x/slash/types"
.proto/imuachain/reward/v1/tx.proto (4)
3-3
: Package Declaration Updated
The package declaration has been updated toimuachain.reward.v1
, which complies with the rebranding.
5-5
: Cosmos Msg Proto Import Verification
The import"cosmos/msg/v1/msg.proto"
is again flagged; please verify that this file can be resolved in your dependency setup.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
8-8
: Params Proto Import Check
Ensure that"imuachain/reward/v1/params.proto"
exists and is correctly referenced in the codebase.
10-10
: Go Package Option Updated
Theoption go_package
is set to"github.com/imua-xyz/imuachain/x/reward/types"
, which is correct per the new configuration.proto/imuachain/dogfood/v1/tx.proto (5)
3-3
: Update Package Name
The package declaration is updated toimuachain.dogfood.v1
to reflect the new branding.
5-5
: Verify Cosmos Proto Import
The import"cosmos/msg/v1/msg.proto"
remains unchanged but is flagged by static analysis as not existing. Please verify that this dependency is available or update the path accordingly.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
9-9
: Update Params Import Path
The import path is updated to"imuachain/dogfood/v1/params.proto"
, ensuring consistency with the new namespace.
11-11
: Update Go Package Option
Thego_package
option is now set to"github.com/imua-xyz/imuachain/x/dogfood/types"
, which aligns with the rebranded repository structure.
35-35
: Update RPC HTTP Endpoint
The HTTP endpoint for theUpdateParams
RPC has been updated to/imuachain/dogfood/v1/tx/MsgUpdateParams
. Confirm that all clients reference the new endpoint.proto/imuachain/dogfood/v1/params.proto (3)
3-3
: Update Package Name
The file’s package declaration has been updated toimuachain.dogfood.v1
as part of the rebranding effort.
5-5
: Verify Cosmos Proto Import
The import"cosmos_proto/cosmos.proto"
is currently used; however, static analysis indicates that the file might not exist. Please verify that the dependency is correctly configured.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
8-8
: Update Go Package Option
Thego_package
option is updated to"github.com/imua-xyz/imuachain/x/dogfood/types"
, ensuring consistency with the new project structure.proto/imuachain/oracle/v1/info.proto (3)
2-2
: Update Package Name
The package declaration is revised toimuachain.oracle.v1
to match the new branding guidelines.
4-4
: Verify gogoproto Import
The import"gogoproto/gogo.proto"
is flagged by static analysis as possibly missing. Please confirm the existence of this dependency or update the path as needed.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
6-6
: Update Go Package Option
Thego_package
option now uses"github.com/imua-xyz/imuachain/x/oracle/types"
, which correctly reflects the repository’s new structure.proto/imuachain/oracle/v1/native_token.proto (3)
3-3
: Update Package Name
The package declaration is updated toimuachain.oracle.v1
in line with the rebranding change.
5-5
: Verify gogoproto Import
The import"gogoproto/gogo.proto"
remains and is flagged by static analysis as not existing. Please verify its presence or adjust the import path.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
7-7
: Update Go Package Option
Thego_package
option has been updated to"github.com/imua-xyz/imuachain/x/oracle/types"
, ensuring alignment with the new namespace.proto/imuachain/oracle/v1/price.proto (3)
3-3
: Update Package Name
The package declaration is changed toimuachain.oracle.v1
to reflect the new project branding.
5-5
: Verify gogoproto Import
The import"gogoproto/gogo.proto"
on this line is flagged by static analysis as potentially missing. Confirm that the dependency is correctly included or update the path appropriately.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
7-7
: Update Go Package Option
Thego_package
option has been updated to"github.com/imua-xyz/imuachain/x/oracle/types"
, which is consistent across the rebranded oracle proto files.proto/imuachain/oracle/v1/tx.proto (4)
3-3
: Namespace Updated
The package declaration has been successfully updated from the legacy naming (e.g. "exocore.oracle.v1") to the new branding "imuachain.oracle.v1". This aligns with the PR’s rebranding objectives.
5-5
: Static Analysis Warning – Verify "amino/amino.proto" Import
The static analysis tool flagged that the file"amino/amino.proto"
may not exist. Please confirm that this import is valid in the project or adjust the import path if necessary.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
9-10
: Updated Import Paths for Oracle Dependencies
The import paths for"params.proto"
and"price.proto"
have been updated to reflect the new structure underimuachain/oracle/v1/
. This ensures that all dependent proto files are sourced from the correct namespace.
12-12
: Updated Go Package Option
Thego_package
option is now set to"github.com/imua-xyz/imuachain/x/oracle/types"
, which correctly matches the new repository conventions.proto/imuachain/oracle/v1/token_feeder.proto (3)
2-2
: Namespace Update for Token Feeder
The package declaration changed topackage imuachain.oracle.v1;
to ensure consistency with the rebranding effort.
4-4
: Static Analysis Warning – Verify "gogoproto/gogo.proto" Import
Static analysis reports that"gogoproto/gogo.proto"
might not be present. Please verify that this import is available or update the path accordingly.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
6-6
: Updated Go Package Option for Token Feeder
Thego_package
option has been updated to"github.com/imua-xyz/imuachain/x/oracle/types"
. This change aligns Token Feeder with the new project organization.proto/imuachain/appchain/coordinator/v1/tx.proto (6)
3-3
: Namespace Update for Appchain Coordinator
The package declaration has been updated fromexocore.appchain.coordinator.v1
toimuachain.appchain.coordinator.v1
, which is consistent with the new branding across the project.
5-5
: Static Analysis Warning – Verify Cosmos Import
The import"cosmos/msg/v1/msg.proto"
is flagged by static analysis as potentially missing. Please confirm that the appropriate proto file is available in your build environment or adjust the import path as required.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
9-9
: Updated Import for Common Appchain Module
The import has been correctly updated from the legacy path toimport "imuachain/appchain/common/v1/common.proto";
ensuring that references to common types use the new namespace.
11-11
: Updated Go Package Option for Coordinator
Thego_package
option is now set to"github.com/imua-xyz/imuachain/x/appchain/coordinator/types"
, which complies with the new repository setup.
19-19
: Updated HTTP Endpoint in RPC Options
The HTTP post option for theRegisterSubscriberChain
RPC has been updated to use the new endpoint"/imuachain/appchain/coordinator/v1/tx/RegisterSubscriberChain"
. This reflects the new branding and publicly exposed URL.
50-50
: Updated Subscriber Parameters Field Type
The type for thesubscriber_params
field has been modified from the old namespace toimuachain.appchain.common.v1.SubscriberParams
. This update is essential to maintain type consistency under the new rebranding.proto/imuachain/delegation/v1/genesis.proto (3)
3-3
: Namespace Update for Delegation Module
The package declaration is updated from the legacyexocore.delegation.v1
toimuachain.delegation.v1
, supporting the overall migration effort.
6-7
: Updated Import Paths for Delegation Queries and Transactions
The import statements have been changed to reference"imuachain/delegation/v1/query.proto"
and"imuachain/delegation/v1/tx.proto"
, which ensures that all dependency paths reflect the new namespace.
9-9
: Updated Go Package Option for Delegation
The go_package option now points to"github.com/imua-xyz/imuachain/x/delegation/types"
, ensuring that generated code integrates with the new repository layout.proto/imuachain/avs/v1/genesis.proto (4)
2-2
: Namespace Update for AVS Module
The package was updated topackage imuachain.avs.v1;
which aligns with the rebranding strategy and organizes the module appropriately.
4-4
: Static Analysis Warning – Verify "gogoproto/gogo.proto" Import
The file"gogoproto/gogo.proto"
is reported as potentially missing. Please confirm this dependency is correctly installed or update the import accordingly.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
5-5
: Updated Import for AVS Transactions
The import path for the transactions file has been updated toimport "imuachain/avs/v1/tx.proto";
reflecting the new project hierarchy consistently.
7-7
: Updated Go Package Option for AVS
The go_package option now correctly refers to"github.com/imua-xyz/imuachain/x/avs/types"
, matching the repository structure for the rebranded project.proto/imuachain/epochs/v1/query.proto (5)
3-3
: Namespace Update:
The package declaration has been updated toimuachain.epochs.v1
to reflect the new branding. This change is consistent with the overall rebranding effort.
5-5
: Import Verification:
The import for"cosmos/base/query/v1beta1/pagination.proto"
is flagged by static analysis as potentially missing. Please verify that this file exists in your dependency set or update the import path if necessary.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
9-9
: Updated Import:
The import statement for the genesis file has been correctly changed to"imuachain/epochs/v1/genesis.proto"
, ensuring consistency with the new namespace.
11-11
: Go Package Option Update:
Thego_package
option is now set togithub.com/imua-xyz/imuachain/x/epochs/types
, which aligns with the rebranded repository structure.
17-17
: HTTP Endpoint Update:
The HTTP GET options for the RPC methods (EpochInfos
,CurrentEpoch
, andEpochInfo
) have been updated to use the new namespace (e.g.,/imuachain/epochs/v1/epochs
). Please ensure that any client integrations or documentation are updated accordingly.Also applies to: 21-21, 25-25
proto/imuachain/oracle/v1/genesis.proto (4)
3-3
: Namespace Update:
The package declaration is updated toimuachain.oracle.v1
, which correctly reflects the new branding changes.
5-5
: Dependency Import Warning:
The import"gogoproto/gogo.proto"
is being flagged by static analysis. Please verify that this dependency is available in your build environment or adjust the import if necessary.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
6-14
: Import Path Updates:
All import statements (from lines 6 to 14) have been updated to reflect the new namespace (e.g., fromexocore/oracle/v1/...
toimuachain/oracle/v1/...
). This ensures uniformity throughout the module.
16-16
: Go Package Option Update:
Thego_package
option is now set togithub.com/imua-xyz/imuachain/x/oracle/types
, which is consistent with the other namespace updates.proto/imuachain/epochs/v1/genesis.proto (3)
3-3
: Namespace Update:
The package declaration is nowimuachain.epochs.v1
, aligning perfectly with the new project branding.
5-5
: Import Warning:
The import"gogoproto/gogo.proto"
appears to be flagged by static analysis. Please confirm that this dependency exists in the expected location or update the reference accordingly.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
9-9
: Go Package Option Update:
Thego_package
option is updated togithub.com/imua-xyz/imuachain/x/epochs/types
, which is accurate for the current repository structure.proto/imuachain/oracle/v1/params.proto (4)
2-2
: Namespace Update:
The package has been updated toimuachain.oracle.v1
, ensuring alignment with the rebranded module.
4-4
: Import Dependency Warning:
The import"amino/amino.proto"
is flagged by static analysis as potentially missing. Please verify its existence or adjust the import path as needed.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
7-8
: Updated Import Paths:
The imports forinfo.proto
andtoken_feeder.proto
have been updated to use the new namespace. This change is correct and consistent with the overall rebranding.
10-10
: Go Package Option Update:
Thego_package
option is now set togithub.com/imua-xyz/imuachain/x/oracle/types
, which matches the new repository organization.proto/imuachain/feedistribution/v1/genesis.proto (4)
2-2
: Namespace Update:
The package declaration has been modified toimuachain.feedistribution.v1
, reflecting the new brand identity.
4-4
: Import Dependency Warning:
The import"amino/amino.proto"
is being flagged as potentially missing by static analysis. Please confirm that this file exists or update the import path if required.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
6-7
: Import Path Updates:
The import paths fordistribution.proto
andparams.proto
have been correctly updated to the new namespace (imuachain/feedistribution/v1/...
).
9-9
: Go Package Option Update:
Thego_package
option is updated togithub.com/imua-xyz/imuachain/x/feedistribution/types
, which completes the rebranding update for this module.proto/imuachain/assets/v1/genesis.proto (4)
2-2
: Branding Update for Package Declaration
The package declaration is now set toimuachain.assets.v1
which correctly reflects the new branding.
6-7
: Updated Import Paths
The import paths forparams.proto
andtx.proto
have been updated to the new namespace. Please verify that these files exist atimuachain/assets/v1/
in the repository.
9-9
: Updated Go Package Option
Thego_package
option now points togithub.com/imua-xyz/imuachain/x/assets/types
, which is consistent with the rebranding.
4-4
: Static Analysis: Cosmos Proto Import Check
Static analysis has flagged the import"cosmos_proto/cosmos.proto"
as missing. Please verify whether this file exists in the expected location or if the path needs to be updated.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/operator/v1/validator.proto (3)
2-2
: Package Name Update
The package declaration is updated toimuachain.operator.v1
, aligning with the new branding strategy.
10-10
: Updated Go Package Option
Thego_package
option is correctly updated togithub.com/imua-xyz/imuachain/x/operator/types
. Ensure this change is reflected in any consuming modules.
4-4
: Static Analysis: Amino Import Check
Static analysis notes that the import"amino/amino.proto"
might not exist. Please confirm if this dependency is correct or if the path should be adjusted.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/delegation/v1/tx.proto (4)
2-2
: Updated Package Declaration
The package declaration has been revised toimuachain.delegation.v1
, which is consistent with the overall rebranding effort.
9-9
: Updated Go Package Option
Thego_package
option is updated togithub.com/imua-xyz/imuachain/x/delegation/types
, reflecting the new module path correctly.
71-79
: Updated Comments for Branding Consistency
In theUndelegationRecord
message, comments have been updated to reference Imuachain (e.g., transaction hash and block number comments). These updates ensure that chain-specific information is consistent throughout.
4-4
: Static Analysis: Amino Import Check
The import"amino/amino.proto"
on line 4 triggers a static analysis warning. Please verify that this file is available within the project or update the import path if necessary.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/dogfood/v1/genesis.proto (4)
3-3
: Updated Package Declaration
The package is now declared asimuachain.dogfood.v1
, which fits the new rebranding guidelines.
7-7
: Updated Import Path
The import forparams.proto
has been updated toimuachain/dogfood/v1/params.proto
. Please ensure that this file exists in the corresponding directory.
9-9
: Updated Go Package Option
Thego_package
option has been updated togithub.com/imua-xyz/imuachain/x/dogfood/types
, correctly reflecting the new namespace.
5-5
: Static Analysis: Amino Import Check
Static analysis indicates that"amino/amino.proto"
(imported on line 5) might not exist. Please double-check this dependency or update the import path if needed.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
cmd/imuachain-test-tool/README.md (2)
1-1
: Updated Tool Title
The title has been updated toimuachain-test-tool
, which is in line with the new branding.
3-4
: Updated Description
The description now clearly indicates that the tool is designed for the Imuachain chain. All references to the previous branding have been successfully replaced.proto/imuachain/appchain/common/v1/common.proto (5)
3-3
: Package Declaration UpdateThe package name has been updated from “exocore.appchain.common.v1” to “imuachain.appchain.common.v1”, which correctly reflects the new branding.
5-5
: Static Analysis: Import for amino.protoThe Buf tool reported that the import
amino/amino.proto
could not be found. Please verify that this dependency is either present in the repository or that the import path is correct. If it’s a false positive (e.g. provided by a virtual dependency or a vendored module), consider adding an appropriate lint exception.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
11-11
: Go Package Option UpdateThe
go_package
option has been updated to"github.com/imua-xyz/imuachain/x/appchain/common/types"
, which aligns with the repository’s new location.
28-29
: Comment Rebranding in SubscriberParamsThe comment regarding the channel used for distribution transmission now correctly refers to "Imuachain" instead of the old branding. This helps maintain consistency in documentation.
98-98
: Comment Update in SubscriberGenesisStateThe comment now states that the genesis state is “provisioned by Imuachain,” reflecting the rebranding.
app/ante/handler_options.go (1)
16-18
: Updated Import Paths for Ante ModulesThe import paths for the ante subpackages have been updated as follows:
cosmosante
now uses"github.com/imua-xyz/imuachain/app/ante/cosmos"
.evmante
now uses"github.com/imua-xyz/imuachain/app/ante/evm"
.anteutils
now uses"github.com/imua-xyz/imuachain/app/ante/utils"
.These changes align with the overall rebranding and, as per the retrieved learning, pass golangci-lint checks.
🧰 Tools
🪛 golangci-lint (1.62.2)
16-16: could not import github.com/imua-xyz/imuachain/app/ante/cosmos (-: # github.com/imua-xyz/imuachain/app/ante/cosmos
app/ante/cosmos/eip712.go:247:36: undefined: secp256k1.RecoverPubkey
app/ante/cosmos/eip712.go:273:17: undefined: secp256k1.VerifySignature)(typecheck)
proto/imuachain/delegation/v1/query.proto (5)
2-2
: Package Declaration UpdateThe package is now declared as
imuachain.delegation.v1
, replacing the old “exocore” namespace.
8-8
: Import Path Update for tx.protoThe import has been updated to
"imuachain/delegation/v1/tx.proto"
, ensuring that protocol buffers use the new namespace.
10-10
: Go Package Option UpdateThe
go_package
option now correctly points to"github.com/imua-xyz/imuachain/x/delegation/types"
, which is in line with the new repository structure.
178-223
: gRPC HTTP Endpoint RebrandingAll RPC service HTTP options have been updated to use the
/imuachain/delegation/v1/...
path. For example:
QueryDelegationInfo
now maps to/imuachain/delegation/v1/delegations/{staker_id}/{asset_id}
.QuerySingleDelegationInfo
now maps to/imuachain/delegation/v1/single_delegation/{staker_id}/{operator_addr}/{asset_id}
.- And similarly for other RPC methods.
This consistent update supports the rebranding effort.
4-4
: Static Analysis: Import for query.protoBuf flagged that
import "cosmos/query/v1/query.proto"
may not exist. Please double-check whether this file is provided by your dependencies or if the path needs an update. If it is a false positive, consider documenting it.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos/query/v1/query.proto": file does not exist
(COMPILE)
proto/imuachain/oracle/v1/query.proto (5)
3-3
: Package Declaration UpdateThe package has been updated from
exocore.oracle.v1
toimuachain.oracle.v1
. This rebranding is correctly propagated.
8-16
: Updated Import PathsAll import statements referencing oracle submodules have been updated to use the
imuachain/oracle/v1/
prefix. Please ensure that these files exist and are correctly referenced in the build.
18-18
: Go Package Option UpdateThe
go_package
option is now set to"github.com/imua-xyz/imuachain/x/oracle/types"
, reflecting the new naming convention.
24-95
: Rebranding of RPC HTTP EndpointsThe HTTP options for all RPC methods in the
Query
service have been updated from/exocore/oracle/v1/...
to/imuachain/oracle/v1/...
. This includes endpoints for methods such asTokenIndexes
,StakerList
,StakerInfos
,StakerInfo
,Params
,Prices
,LatestPrice
,ValidatorUpdateBlock
,IndexRecentParams
,IndexRecentMsg
,RecentMsg
, andRecentParams
.
These endpoint changes are consistent and necessary for the rebrand.
5-5
: Static Analysis: Pagination Proto ImportBuf has indicated that
import "cosmos/base/query/v1beta1/pagination.proto"
cannot be found. Verify that your dependency management or vendoring correctly provides this file, or adjust the import path if needed.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
proto/imuachain/avs/v1/tx.proto (4)
3-3
: Package Declaration UpdateThe package name has been updated from
exocore.avs.v1
toimuachain.avs.v1
, in line with the new branding.
11-11
: Go Package Option UpdateThe
go_package
option is now set to"github.com/imua-xyz/imuachain/x/avs/types"
, ensuring proper namespacing.
266-279
: RPC Method Endpoint RebrandingThe RPC service endpoints have been updated as follows:
RegisterAVS
now uses POST/imuachain/avs/v1/tx/RegisterAVS
.DeRegisterAVS
now uses POST/imuachain/avs/v1/tx/DeRegisterAVS
.RegisterAVSTask
now uses POST/imuachain/avs/v1/tx/RegisterAVSTask
.SubmitTaskResult
now uses POST/imuachain/avs/v1/tx/SubmitTaskResult
.These updates ensure that all AVS-related transactions follow the new URI structure.
5-5
: Static Analysis: Import for amino.protoBuf again flags the import
amino/amino.proto
as not found. Please confirm that this file exists in your dependency tree or update the path if necessary.🧰 Tools
🪛 Buf (1.47.2)
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
CONTRIBUTING.md (3)
1-1
: Update Branding in Title
The title has been updated to “Imuachain Contributor Guidelines,” which correctly reflects the new branding.
3-3
: Navigation Link Updated
The menu now correctly links to “Imuachain Contributor Guidelines” ensuring consistency across the document.
22-24
: Greeting and Repository Reference Updated
The welcoming message and the link to Tendermint’s coding repo have been updated to reflect the Imuachain branding.proto/imuachain/operator/v1/query.proto (20)
2-2
: Package Namespace Updated
The package declaration now usesimuachain.operator.v1
, which is correct for the new branding.
10-11
: Updated Proto Imports for New Namespace
The imports fortx.proto
andvalidator.proto
have been updated to point toimuachain/operator/v1/
. This correctly aligns with the rebranding effort.
14-14
: Updated Go Package Option
Thego_package
option now reflects the new repository structure correctly.
275-278
: Updated HTTP Endpoint for QueryOperatorInfo
The endpoint has been updated to/imuachain/operator/v1/operator_info/{operator_addr}
, which is consistent with the new branding.
279-283
: Updated HTTP Endpoint for QueryAllOperators
The endpoint now points to/imuachain/operator/v1/all_operators
, ensuring consistency across the API.
284-288
: Updated HTTP Endpoint for QueryOperatorConsKeyForChainID
The endpoint has been adjusted to/imuachain/operator/v1/operator_cons_key/{operator_acc_addr}/{chain}
reflecting the brand change.
289-293
: Updated HTTP Endpoint for QueryOperatorConsAddressForChainID
The change to/imuachain/operator/v1/operator_cons_addr/{operator_acc_addr}/{chain}
is correct and consistent.
294-298
: Updated HTTP Endpoint for QueryAllOperatorConsKeysByChainID
The endpoint is now/imuachain/operator/v1/all_operator_cons_keys/{chain}
, matching the new branding.
300-305
: Updated HTTP Endpoint for QueryOperatorUSDValue
The multi-line endpoint has been updated to reflect the new URL path for fetching operator USD value.
307-310
: Updated HTTP Endpoint for QueryAVSUSDValue
The endpoint now reads/imuachain/operator/v1/avs_usd_value
, which is in line with the rebranding.
312-317
: Updated HTTP Endpoint for QueryOperatorSlashInfo
The endpoint has been corrected to/imuachain/operator/v1/operator_slash_info/{operator_and_avs.operator_addr}/{operator_and_avs.avs_address}
.
319-323
: Updated HTTP Endpoint for QueryAllOperatorConsAddrsByChainID
The endpoint update to/imuachain/operator/v1/all_operator_cons_addrs/{chain}
is applied correctly.
325-329
: Updated HTTP Endpoint for QueryAllOperatorsWithOptInAVS
The change to/imuachain/operator/v1/opt/operator_list/{avs}
is correct.
330-333
: Updated HTTP Endpoint for QueryAllAVSsByOperator
The endpoint is now/imuachain/operator/v1/opt/avs_list/{operator}
, in accordance with the new naming convention.
335-339
: Updated HTTP Endpoint for QueryOptInfo
The endpoint change to/imuachain/operator/v1/opt_info/{operator_and_avs.operator_addr}/{operator_and_avs.avs_address}
reflects the rebranding.
340-343
: Updated HTTP Endpoint for QuerySnapshotHelper
The endpoint now correctly uses/imuachain/operator/v1/snapshot_helper/{avs}
.
345-348
: Updated HTTP Endpoint for QuerySpecifiedSnapshot
The endpoint update to/imuachain/operator/v1/snapshot/{avs}/{height}
is consistent with other changes.
350-353
: Updated HTTP Endpoint for QueryAllSnapshot
The endpoint has been revised to/imuachain/operator/v1/all_snapshot/{avs}
, ensuring consistency.
355-361
: Updated HTTP Endpoint for Validators
The endpoint is now/imuachain/operator/v1/validators/{chain}
, with the added module query safety option intact.
363-367
: Updated HTTP Endpoint for Validator Query
The endpoint update to/imuachain/operator/v1/validator/{validator_acc_addr}/{chain}
correctly reflects the new branding for validator queries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
cmd/imuachain-test-tool/README.md (4)
3-4
: Network Name ConsistencyThe description now refers to the network as “Imuchain network” on these lines. Note that the official rebranding uses “imuachain” (with an “a” after “imu”) per the PR objectives. Please verify the spelling for consistency across the documentation.
7-9
: Node and Branch URL Update with Terminology NoteThe node requirement and branch URL have been updated to “Imuachain” and the correct GitHub URL. One minor note: the phrase “the precompile's gateway contract address check” might benefit from a quick review—ensure that “precompile” is used as intended (noun/adjective) per industry conventions.
🧰 Tools
🪛 LanguageTool
[grammar] ~7-~7: The verb ‘precompile’ does not usually follow articles like ‘the’. Check that ‘precompile’ is spelled correctly; using ‘precompile’ as a noun may be non-standard.
Context: ...se, with the node configured to disable the precompile's gateway contract address check. The b...(A_INFINITIVE)
23-23
: Registration Process RebrandingThe registration step now indicates that test objects are registered onto the “Imuchain network.” Please double-check the spelling consistency (see earlier note on “Imuachain” vs “Imuchain”).
24-24
: Asset Persistence Description UpdateThe description of saving asset and AVS information now reflects the rebranded network. Again, review the network name for consistency throughout the file.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
Makefile
(11 hunks)README.md
(2 hunks)cmd/imuachain-test-tool/README.md
(3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- README.md
🧰 Additional context used
🪛 LanguageTool
cmd/imuachain-test-tool/README.md
[grammar] ~7-~7: The verb ‘precompile’ does not usually follow articles like ‘the’. Check that ‘precompile’ is spelled correctly; using ‘precompile’ as a noun may be non-standard.
Context: ...se, with the node configured to disable the precompile's gateway contract address check. The b...
(A_INFINITIVE)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: test-unit-e2e
- GitHub Check: test-unit-cover
- GitHub Check: ante-benchmark-test
- GitHub Check: goreleaser
- GitHub Check: Analyze (go)
🔇 Additional comments (20)
cmd/imuachain-test-tool/README.md (10)
1-1
: Title Rebranding UpdateThe tool’s title (“# imuachain-test-tool”) is updated correctly to reflect the new brand.
13-13
: Stress Testing Description UpdatedThe sentence on line 13 now correctly references stress testing on the rebranded network.
21-21
: Token Transfer Description UpdateThe description now clearly states “IMUA tokens” instead of the old token name, aligning with the new branding.
62-64
: Initialization Command UpdateThe shell code block now invokes the updated command (
imuachain-test-tool init --home
). This change correctly reflects the rebranding.
67-69
: Start Command UpdateThe “start” command is updated to
imuachain-test-tool start --home .
, which is correct.
76-78
: Repeated Init Command UpdateThe rebranding update in this shell block (
imuachain-test-tool init --home
) is consistent with previous changes.
81-83
: Prepare Command UpdateThe command to prepare the test environment is updated correctly (
imuachain-test-tool prepare --home .
).
87-89
: Batch Test Command UpdateThe batch testing command (
imuachain-test-tool batch-test depositLST --home .
) reflects the new branding properly.
93-95
: Query Command UpdateThe query command now uses the updated binary name (
imuachain-test-tool query-tx-record <msgType> <batch-id> <status>
).
113-113
: New Feature Note: Batch Testing for IMUA TokensThe addition of batch testing for IMUA tokens is clearly noted. This new functionality item aligns with the currency rebranding.
Makefile (10)
9-9
: Binary Name Variable UpdateThe variable
IMUACHAIN_BINARY
is now set toimuad
, which is correct per the new branding. Ensure all references to this variable throughout the Makefile remain consistent.
11-11
: Repository URL UpdateThe
HTTPS_GIT
variable is updated to point to the new repository URL (https://github.com/imua-xyz/imuachain
), which is appropriate for the rebranding.
20-21
: Namespace and Project Variable UpdatesThe variables
NAMESPACE
andPROJECT
have been updated correctly toimua-xyz
andimuachain
, respectively.
70-71
: Linker Flags RebrandingThe linker flags now embed
version.Name=imuachain
and the correct application name derived from$(IMUACHAIN_BINARY)
. This is essential for proper rebranding in the built binary.
139-139
: Test Tool Build Target UpdateThe build target for the test tool is updated to compile from
./cmd/imuachain-test-tool
. This reflects the new directory structure and name.
141-141
: Test Tool Install Target UpdateSimilarly, the install target is updated with the new path for the test tool.
147-147
: Docker Build Environment VariableWithin the Docker build target, the environment variable
APP
is correctly set toimuad
, aligning with the rebranded binary name.
162-167
: Docker Script Update for Binary InvocationThe script creation block now creates a launcher script in
./build/imuad
that sets up the correct environment and calls the new binary. The changes to directory names (e.g.,.imuad
) and the invocation command ensure consistency with the rebranding.
546-546
: Package Name RebrandingThe
PACKAGE_NAME
is updated togithub.com/imua-xyz/imuachain
, which is vital for module resolution and dependency management in the new branding.
525-534
: Localnet Unsafe Reset UpdatesBoth the Windows (lines 525-528) and Linux (lines 530-533) commands in the
localnet-unsafe-reset
target have been updated to reference the new binary name (imuad
) and adjust volume mappings accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (6)
tests/e2e/oracle/create_price.go (4)
50-51
: Add documentation explaining test case dependencies.The comment states that test case order cannot be changed but doesn't explain why. Consider documenting the dependencies between test cases to make maintenance easier.
- // we combine all test cases into one big case to avoid reset the network multiple times, the order can't be changed + // Test cases are combined and ordered to avoid resetting the network multiple times. + // Order dependencies: + // 1. testRegisterTokenThroughPrecompile: Registers tokens needed by subsequent tests + // 2. testCreatePriceNST: Tests NST pricing before LST + // 3. testCreatePriceLST: Tests LST pricing using registered tokens + // 4. testSlashing: Tests slashing scenarios using established validator states + // 5. testCreatePriceLSTAfterDelegationChangePower: Tests pricing after power changes
182-183
: Improve timestamp management in tests.Manual timestamp updates make the tests fragile and harder to maintain. Consider creating a helper function to manage timestamps consistently across all test cases.
+func (s *E2ETestSuite) updateTimestamp(price *Price, round int64) *Price { + ret := price.getPriceTimeRound(round) + ret.Timestamp = time.Now().Unix() + return ret +}
289-290
: Extract magic numbers into named constants.The function uses hardcoded values which could be made more maintainable and self-documenting.
+const ( + // DefaultNSTDepositAmount represents the standard deposit amount for ETH-NST + DefaultNSTDepositAmount = 32 + // TestValidatorPubKeyByte represents a test validator public key + TestValidatorPubKeyByte = 1 +) + - opAmount := big.NewInt(32) + opAmount := big.NewInt(DefaultNSTDepositAmount)
449-452
: Make timeout duration configurable.The timeout duration is hardcoded to 120 seconds. Consider making it configurable through test configuration or environment variables.
+const defaultStateTimeout = 120 * time.Second + func (s *E2ETestSuite) moveToAndCheck(height int64) { - _, err := s.network.WaitForStateHeightWithTimeout(height, 120*time.Second) + timeout := s.network.Config.StateTimeout + if timeout == 0 { + timeout = defaultStateTimeout + } + _, err := s.network.WaitForStateHeightWithTimeout(height, timeout) s.Require().NoError(err) }precompiles/avs/tx.go (2)
193-193
: Update comments to use consistent branding.The comments have been updated to reference "imuachain" instead of "exocore", but there's an inconsistency in the spelling:
- Line 193: "imuachain's"
- Line 217: "imuadefault" (missing space)
Apply this diff to fix the comment consistency:
-// CreateAVSTask Middleware uses imuachain's default avstask template to create tasks in avstask module. +// CreateAVSTask Middleware uses Imuachain's default avstask template to create tasks in avstask module. -// Challenge Middleware uses imuadefault avstask template to create tasks in avstask module. +// Challenge Middleware uses Imuachain's default avstask template to create tasks in avstask module.Also applies to: 217-217
368-370
: Consider adding a comment explaining the nil assignment.The logic for handling empty task responses by setting them to nil could benefit from a brief explanation of why this is necessary.
Apply this diff to add a clarifying comment:
if len(taskResponse) == 0 { + // Convert empty responses to nil to maintain consistency with the AVS protocol resultParams.TaskResponse = nil }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (36)
Dockerfile
(3 hunks)local_node.sh
(10 hunks)networks/local/imuachain/Dockerfile
(2 hunks)precompiles/avs/IAVSManager.sol
(3 hunks)precompiles/avs/avs.go
(1 hunks)precompiles/avs/avs_test.go
(6 hunks)precompiles/avs/events.go
(1 hunks)precompiles/avs/query.go
(12 hunks)precompiles/avs/query_test.go
(9 hunks)precompiles/avs/setup_test.go
(1 hunks)precompiles/avs/tx.go
(10 hunks)precompiles/avs/types.go
(3 hunks)precompiles/avs/utils_test.go
(2 hunks)proto/imuachain/avs/v1/genesis.proto
(1 hunks)proto/imuachain/avs/v1/query.proto
(2 hunks)proto/imuachain/avs/v1/tx.proto
(2 hunks)proto/imuachain/feedistribution/v1/params.proto
(1 hunks)proto/imuachain/immint/v1/query.proto
(1 hunks)tests/e2e/oracle/create_price.go
(1 hunks)testutil/batch/manager.go
(4 hunks)testutil/network/util.go
(2 hunks)testutil/utils.go
(7 hunks)x/appchain/coordinator/keeper/register.go
(1 hunks)x/avs/client/cli/query.go
(7 hunks)x/avs/keeper/avs.go
(1 hunks)x/avs/keeper/avs_test.go
(7 hunks)x/avs/keeper/bls_test.go
(1 hunks)x/avs/keeper/epoch_test.go
(1 hunks)x/avs/keeper/genesis.go
(1 hunks)x/avs/keeper/impl_epoch_hook.go
(1 hunks)x/avs/keeper/keeper.go
(2 hunks)x/avs/keeper/multi_operator_submit_task_test.go
(1 hunks)x/avs/keeper/query.go
(1 hunks)x/avs/keeper/submit_task_test.go
(1 hunks)x/avs/keeper/task.go
(1 hunks)x/avs/keeper/task_test.go
(1 hunks)
✅ Files skipped from review due to trivial changes (5)
- x/avs/keeper/keeper.go
- x/avs/keeper/avs.go
- x/appchain/coordinator/keeper/register.go
- x/avs/keeper/impl_epoch_hook.go
- x/avs/keeper/multi_operator_submit_task_test.go
🚧 Files skipped from review as they are similar to previous changes (11)
- precompiles/avs/setup_test.go
- precompiles/avs/IAVSManager.sol
- precompiles/avs/utils_test.go
- precompiles/avs/events.go
- precompiles/avs/query.go
- precompiles/avs/types.go
- Dockerfile
- networks/local/imuachain/Dockerfile
- testutil/batch/manager.go
- precompiles/avs/avs.go
- precompiles/avs/avs_test.go
🧰 Additional context used
🪛 GitHub Actions: Lint
x/avs/client/cli/query.go
[error] 99-129: 99-129 lines are duplicate of x/avs/client/cli/query.go:164-194
(dupl)
🪛 Buf (1.47.2)
proto/imuachain/avs/v1/query.proto
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/imuachain/avs/v1/genesis.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/avs/v1/tx.proto
5-5: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/feedistribution/v1/params.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/imuachain/immint/v1/query.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: test-unit-e2e
- GitHub Check: test-unit-cover
- GitHub Check: goreleaser
- GitHub Check: docker-build
- GitHub Check: Analyze (go)
- GitHub Check: ante-benchmark-test
🔇 Additional comments (69)
testutil/network/util.go (2)
30-35
: LGTM! Import paths updated correctly.The import paths have been correctly updated from
ExocoreNetwork/exocore
toimua-xyz/imuachain
as part of the rebranding effort.
310-310
: LGTM! Comment updated to reflect new branding.The comment has been correctly updated to reference the new
im1
prefix instead of the oldexo
prefix.proto/imuachain/feedistribution/v1/params.proto (4)
2-2
: Package Name Update
The package declaration is updated topackage imuachain.feedistribution.v1;
, which properly reflects the new branding and aligns with the PR objectives.
4-4
: Verify Import Path for amino.proto
The import statementimport "amino/amino.proto";
may be problematic, as static analysis indicates the file does not exist. Please confirm the correct location for the amino protocol definitions—if the file has been relocated as part of the rebranding, update this path accordingly.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
8-8
: Updated go_package Option
Theoption go_package
line has been updated to:option go_package = "github.com/imua-xyz/imuachain/x/feedistribution/types";
This change is correct and conforms to the new repository structure.
12-12
: Revised Amino Name Option
Theoption (amino.name)
is now set to"imua/x/feedistribution/params"
, which reflects the updated branding. Ensure that any related logic relying on this option is adjusted accordingly.testutil/utils.go (4)
7-11
: LGTM! Import paths correctly updated.The import paths have been properly updated to reflect the rebranding from Exocore to Imuachain, maintaining a clean and organized structure.
Also applies to: 22-29, 43-46
53-53
: LGTM! App type correctly updated.The
App
field type has been properly updated to use*imuaapp.ImuachainApp
, maintaining consistency with the rebranding.
93-99
: LGTM! Setup function correctly updated.The function has been properly updated to use
imuaapp
references while maintaining its original functionality. Documentation and consensus parameters have been correctly updated to reflect the rebranding.Also applies to: 444-444
500-500
: LGTM! Comments correctly updated.The comments have been properly updated to reference Imuachain, maintaining documentation accuracy and consistency with the rebranding.
Also applies to: 523-523
proto/imuachain/immint/v1/query.proto (5)
2-2
: Package Namespace UpdatedThe package declaration has been updated to
imuachain.immint.v1
to reflect the rebranding effort. Please ensure that all module references throughout the codebase are updated accordingly.
4-4
: Dependency Check for gogoproto/gogo.protoStatic analysis (Buf 1.47.2) reports that the imported file
"gogoproto/gogo.proto"
could not be found. Verify that this dependency is available in the project’s dependency management or update the import path as needed.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
6-6
: Updated Import Path for ParamsThe import path has been modified to
"imuachain/immint/v1/params.proto"
to align with the new branding. Confirm that the referencedparams.proto
file exists at this location and that any dependent services have been updated.
8-8
: Updated Go Package OptionThe
go_package
option is now set to"github.com/imua-xyz/imuachain/x/immint/types"
, reflecting the new repository structure. Ensure that any tooling relying on this setting is reconfigured accordingly.
14-14
: HTTP Endpoint UpdatedThe HTTP endpoint for the
Params
RPC method has been changed to/imuachain/immint/v1/params
, in line with the overall rebranding. Please verify that clients and server routing configurations are updated to use this new endpoint.tests/e2e/oracle/create_price.go (3)
16-20
: LGTM! Import paths correctly updated.The import paths have been successfully migrated from ExocoreNetwork to imuachain, maintaining the same package structure.
167-168
: Address timing concerns in test.The TODO comment indicates potential timing issues with block height progression. Consider implementing a more robust solution:
- Use a deterministic block time in test configuration
- Implement retry logic with backoff
- Add assertions to verify block height constraints
Would you like me to help implement a more robust solution for handling block timing in these tests?
1-465
: Overall test structure is robust and comprehensive.The test suite provides thorough coverage of oracle module functionality including price creation, token registration, and slashing scenarios. The migration to imuachain has been completed successfully.
precompiles/avs/tx.go (2)
15-16
: LGTM: Import paths correctly updated.The import paths have been correctly updated to reflect the new Imuachain namespace, maintaining consistency with the PR objectives.
389-396
: LGTM: Clear phase validation with descriptive error messages.The phase validation logic is well-documented with clear comments explaining the Two-Phase Commit protocol phases and includes proper validation with descriptive error messages.
x/avs/keeper/query.go (1)
8-8
: LGTM! Import path updated correctly.The import path has been updated to reflect the new repository name, maintaining consistency with the rebranding effort.
x/avs/keeper/epoch_test.go (1)
7-7
: LGTM! Import path updated correctly.The import path has been updated to reflect the new repository name, maintaining the test suite's functionality.
x/avs/keeper/task_test.go (1)
11-11
: LGTM! Import path updated correctly.The import path has been updated to reflect the new repository name, maintaining the test suite's functionality.
x/avs/keeper/genesis.go (2)
9-9
: LGTM! Import path updated correctly.The import path has been updated to reflect the new repository name, maintaining the genesis state handling functionality.
14-64
:❓ Verification inconclusive
Verify genesis state initialization robustness.
The InitGenesis function handles critical state initialization with proper error handling and address normalization. Please ensure:
- All AVS addresses are properly migrated during the rebranding
- The ChainID code and hash values are correctly set for the new chain
🏁 Script executed:
#!/bin/bash # Verify that all AVS addresses in the codebase are lowercase rg -i 'AvsAddress.*0x[0-9a-fA-F]+' --type go # Check for any hardcoded chain IDs that might need updating rg -i 'chainid.*exocore' --type goLength of output: 787
Confirm Genesis Initialization Migration and Chain ID Setup
The
InitGenesis
function properly normalizes AVS addresses (usingstrings.ToLower
) and sets the chain ID code/hash as required. In our verification:
- AVS addresses in test files are shown in mixed cases; however, the genesis initialization correctly converts these to lowercase, ensuring proper migration during the rebranding.
- No legacy hardcoded chain ID values (e.g., "exocore") were found, which confirms the new chain configuration is in use.
Please verify:
- The test cases for AVS addresses correctly observe the normalization (especially where inputs are in mixed case).
- The absence of legacy chain ID references in the broader codebase remains consistent.
x/avs/keeper/bls_test.go (2)
9-9
: LGTM!The import path update aligns with the rebranding from Exocore to Imua.
15-15
: LGTM!The operator address update correctly uses the new Bech32 prefix
im
.x/avs/client/cli/query.go (1)
13-14
: LGTM!The import path updates align with the rebranding from Exocore to Imua.
x/avs/keeper/submit_task_test.go (1)
14-19
: LGTM!The import path updates and operator address change align with the rebranding from Exocore to Imua.
Also applies to: 24-24
x/avs/keeper/avs_test.go (1)
10-11
: LGTM!The changes improve the code by:
- Updating import paths to align with the rebranding.
- Replacing hardcoded addresses with dynamically generated ones, making the tests more maintainable.
- Updating the expected address string to use the new Bech32 prefix.
Also applies to: 14-18, 24-28, 46-46, 79-83, 115-119, 208-208
x/avs/keeper/task.go (1)
15-16
: LGTM! Import paths updated correctly.The import paths have been updated to reflect the new repository name, maintaining consistency with the rebranding from Exocore to Imua.
precompiles/avs/query_test.go (2)
9-22
: LGTM! Import paths updated correctly.The import paths have been updated to reflect the new repository name, maintaining consistency with the rebranding from Exocore to Imua.
396-400
: Great improvement in test robustness!Replacing hardcoded addresses with dynamically generated ones using
utiltx.GenerateAddress()
is a good practice as it:
- Reduces the risk of address collisions
- Makes tests more maintainable and less dependent on specific values
- Follows testing best practices by using random data
proto/imuachain/avs/v1/genesis.proto (3)
2-2
: Rebranding Update: Package Declaration
The package declaration is updated toimuachain.avs.v1
, which aligns with the overall rebranding objective.
5-5
: Rebranding Update: Import Path for tx.proto
The import statement fortx.proto
has been updated from the old namespace toimuachain/avs/v1/tx.proto
. Please verify that the file exists at the new location and that all dependent modules reference it accordingly.
7-7
: Rebranding Update: go_package Option
Thego_package
option now points togithub.com/imua-xyz/imuachain/x/avs/types
, ensuring consistency with the new branding. Confirm that the corresponding Go module and directory structure are updated to match this change.proto/imuachain/avs/v1/query.proto (8)
2-2
: Rebranding Update: Package Declaration
The package is set toimuachain.avs.v1
, reflecting the new project branding.
7-7
: Rebranding Update: Import Path for tx.proto
The import fortx.proto
is nowimuachain/avs/v1/tx.proto
. Please ensure that the new file location is correct and that all references are updated accordingly.
9-9
: Rebranding Update: go_package Option
Thego_package
option has been updated togithub.com/imua-xyz/imuachain/x/avs/types
. Double-check that your Go build configuration aligns with this new path.
77-77
: Updated HTTP Endpoint for QueryAVSInfo
The HTTP GET endpoint has been changed to/imuachain/avs/v1/avs_info
to reflect the new branding. Clients consuming this API should update accordingly.
81-81
: Updated HTTP Endpoint for QueryAVSTaskInfo
The HTTP GET endpoint is updated to/imuachain/avs/v1/avs_task_info/{task_address}/{task_id}
. Verify that any caller or documentation reflects the new path.
85-85
: Updated HTTP Endpoint for QueryAVSAddressByChainID
The HTTP GET endpoint now reads/imuachain/avs/v1/avs_address/{chain}
. Make sure this change is propagated to client integrations and documentation.
89-89
: Updated HTTP Endpoint for QuerySubmitTaskResult
The HTTP GET endpoint has been updated to/imuachain/avs/v1/submit_task_result/{task_address}/{task_id}/{operator_address}
. Confirm that the API consumers are aware of the change.
93-93
: Updated HTTP Endpoint for QueryChallengeInfo
The HTTP GET endpoint is now/imuachain/avs/v1/challenge_info/{task_address}/{task_id}
. Ensure that any dependent services and documentation incorporate this update.proto/imuachain/avs/v1/tx.proto (6)
3-3
: Rebranding Update: Package Declaration
The package is now declared asimuachain.avs.v1
, in line with the rebranding effort.
11-11
: Rebranding Update: go_package Option
Thego_package
option is updated togithub.com/imua-xyz/imuachain/x/avs/types
. Please ensure that the directory structure and module paths in your Go project match this setting.
300-300
: Updated HTTP Endpoint for RegisterAVS
The HTTP POST endpoint for theRegisterAVS
RPC is updated to/imuachain/avs/v1/tx/RegisterAVS
. Verify that clients and related documentation reference the new endpoint.
304-304
: Updated HTTP Endpoint for DeRegisterAVS
The HTTP POST endpoint is now/imuachain/avs/v1/tx/DeRegisterAVS
. Ensure that the de-registration flow in dependent components is tested with this updated path.
308-308
: Updated HTTP Endpoint for RegisterAVSTask
The HTTP POST endpoint for registering an AVS task has been changed to/imuachain/avs/v1/tx/RegisterAVSTask
. Confirm that the change is reflected in your API documentation and client usage.
312-312
: Updated HTTP Endpoint for SubmitTaskResult
The HTTP POST endpoint is now/imuachain/avs/v1/tx/SubmitTaskResult
. Please ensure that all consumers of this endpoint update their configurations and that related tests pass.local_node.sh (19)
6-6
: Update Chain ID to New Branding
The chain ID has been updated to"imuachainlocalnet_232-1"
, which aligns with the new project branding. Please ensure that this value is consistently referenced across all configuration files and network settings.
15-15
: Update Home Directory for imuad Instance
The home directory variable is now set to"$HOME/.tmp-imuad"
, reflecting the rebranding from Exocore to Imuachain. Verify that all parts of the system correctly reference this updated directory.
68-69
: Update Configuration Commands to Use imuad
The configuration commands have been updated from the legacy daemon to useimuad
(e.g., setting the keyring backend and chain ID). This change ensures that subsequent operations use the new application.
73-73
: Update Key Addition Command
Within the key loop, the command now usesimuad keys add
which is consistent with the new branding. This update helps ensure that generated keys correspond to the imuad instance.
77-77
: Utilize Recover Option for Consistent Funding Address
Piping the mnemonic intoimuad --home "$HOMEDIR" --keyring-backend "$KEYRING" keys add --recover
guarantees a consistent local funded address. The usage is clear and aligns with the rebranding.
81-81
: Initialize Node with Updated Command and Recover Option
The initialization command (imuad init
) now includes the updated chain ID and the--recover
flag, which is essential for setting a consistent validator consensus key.
86-88
: Update Address and Consensus Key Extraction
The commands for extracting the operator address (LOCAL_ADDRESS_IM
), converting it to a consistent hexadecimal value (LOCAL_ADDRESS_HEX
), and retrieving the consensus key now useimuad
commands. Verify that these commands output the expected formats.
90-90
: Log Local Operator Address
The echo statement now prints the updated local operator address ($LOCAL_ADDRESS_IM
), providing clear runtime feedback reflective of the rebrand.
121-121
: Update Operator Asset Assignment
The JSON modification now sets the operator in the assets section to"$LOCAL_ADDRESS_IM"
, ensuring that the operator address used in genesis reflects the new configuration.
143-143
: Update Operator Record with New Address
The operator record (in the operator module) is updated to use"$LOCAL_ADDRESS_IM"
for the operator address. This ensures consistency across the genesis configuration.
146-146
: Update Operator Opt States Key Format
The opt_states key now concatenates"$LOCAL_ADDRESS_IM"
and"$AVS_ADDRESS"
. Please verify that the use of"/"
as a delimiter meets the expected formatting conventions for downstream processing.
152-152
: Update Operator USD Values Key
The operator USD values key is now formatted with"$AVS_ADDRESS"
and"$LOCAL_ADDRESS_IM"
, which should be consistent with the new branding requirements.
158-158
: Update Delegation State Key
The delegation state key is reconstructed using"$LOCAL_ADDRESS_HEX"
, a predefined token code, and"$LOCAL_ADDRESS_IM"
. Double-check that the concatenated string meets the expected format for delegation mapping.
162-162
: Update Delegation Associations Operator
The association for delegation now references"$LOCAL_ADDRESS_IM"
as the operator. This update correctly reflects the new configuration.
163-163
: Update Delegation Stakers Key
The delegation stakers_by_operator key has been updated with the new operator address ($LOCAL_ADDRESS_IM
), ensuring the stakers are correctly mapped under the rebranded operator.
323-323
: Add Genesis Account for Local Funded Account
The command to add the genesis account for"${LOCAL_NAME}"
now correctly uses the token denomination"hua"
and the updated home directory, aligning with recent changes.
331-331
: Validate Updated Genesis File
The invocation ofimuad validate-genesis
ensures that the genesis file is correctly set up using the new parameters. This check is critical after the extensive JSON modifications.
240-242
: Update Oracle Feeder YAML with New Imua Branding
Within the YAML configuration for the oracle feeder, the block now introduces animua:
section with properties such aschainid: $CHAINID
andappName: imua
. This update should be verified against other configuration files to maintain consistent branding across services.
339-339
: Update Node Start Command
The startup command has been updated to useimuad start
along with a comprehensive set of flags (e.g., metrics, log level, gas prices, enabled JSON-RPC APIs, and GRPC). Please verify that the additional flags such as--oracle
and--grpc.enable true
work as intended in the new environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
x/avs/client/cli/query.go
(7 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: test-unit-e2e
- GitHub Check: ante-benchmark-test
- GitHub Check: Analyze (go)
- GitHub Check: goreleaser
🔇 Additional comments (3)
x/avs/client/cli/query.go (3)
13-14
: LGTM! Import changes align with rebranding.The changes correctly update the import path to use the new
imuachain
package and addversion.AppName
for dynamic command examples.
94-107
: LGTM! Good refactoring withcommonQuerySetup
.The new helper function effectively reduces code duplication and centralizes common validation logic.
109-191
: Reduce code duplication in command structures.The command structures in
QueryTaskInfo
,QuerySubmitTaskResult
, andQueryChallengeInfo
are very similar. Consider extracting the common command creation logic into a helper function.As suggested in the past review, create a helper function:
+func createQueryCommand(use string, short string, long string, example string, handler func(cmd *cobra.Command, args []string) error) *cobra.Command { + cmd := &cobra.Command{ + Use: use, + Short: short, + Long: long, + Example: example, + Args: cobra.ExactArgs(2), + RunE: handler, + } + flags.AddQueryFlagsToCmd(cmd) + return cmd +}Then use it to simplify the command definitions.
Hardcoded a replacement from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
init.bat (1)
12-13
: Verify the chainid format and value.The TODO comment indicates that the testnet chainid is still under consideration. Please ensure that the current chainid value
imuachainlocalnet_232-1
follows the same format that will be used for the testnet.Do you want me to help track this TODO by opening a new issue?
Makefile (1)
162-167
: Consider adding error handling to the Docker script.The generated Docker script should include basic error handling and parameter validation. Also, consider using
set -e
to ensure the script fails on any error.Apply this diff to improve the script:
echo '#!/usr/bin/env bash' > ./build/imuad +echo 'set -e' >> ./build/imuad +echo 'if [ -z "$1" ]; then' >> ./build/imuad +echo ' echo "Error: No command provided"' >> ./build/imuad +echo ' exit 1' >> ./build/imuad +echo 'fi' >> ./build/imuad echo "IMAGE_NAME=${DOCKER_IMAGE}:${COMMIT_HASH}" >> ./build/imuad echo 'SCRIPT_PATH=$$(cd $$(dirname $$0) && pwd -P)' >> ./build/imuad +echo 'if [ ! -d "$${SCRIPT_PATH}/.imuad" ]; then' >> ./build/imuad +echo ' mkdir -p "$${SCRIPT_PATH}/.imuad"' >> ./build/imuad +echo 'fi' >> ./build/imuad echo 'docker run -it --rm -v $${SCRIPT_PATH}/.imuad:/home/imua/.imuad $$IMAGE_NAME imuad "$$@"' >> ./build/imuad
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
Makefile
(10 hunks)init.bat
(3 hunks)networks/local/imuachain/Dockerfile
(2 hunks)scripts/start-docker.sh
(1 hunks)testutil/batch/type.go
(3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- networks/local/imuachain/Dockerfile
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: test-unit-e2e
- GitHub Check: test-unit-cover
- GitHub Check: ante-benchmark-test
- GitHub Check: Analyze (go)
- GitHub Check: goreleaser
🔇 Additional comments (8)
testutil/batch/type.go (3)
38-38
: LGTM! Comments updated consistently.The comments have been updated to reflect the rebranding from Exocore to Imua/Imuachain.
Also applies to: 49-49, 60-60
40-42
:✅ Verification successful
Verify field usage across the codebase.
The field renames from
*ExoAmount
to*ImuaAmount
look good. Let's verify that all references to these fields have been updated.
🏁 Script executed:
#!/bin/bash # Description: Search for any remaining references to the old field names echo "Searching for old field names..." rg -i "exoamount" --type go echo "Verifying new field usage..." rg -i "imuaamount" --type goLength of output: 1429
Field usage verified – all references updated across the codebase.
The renames from
*ExoAmount
to*ImuaAmount
intestutil/batch/type.go
(lines 40-42) are correctly reflected in related files (e.g.,testutil/batch/tx_check.go
andtestutil/batch/prepare.go
). The shell script search confirmed that no oldexoamount
references remain while all usage now points to the new field names.
95-99
:❓ Verification inconclusive
Verify ChainID format consistency.
The default values for amount fields and ChainID have been updated. Let's verify that the ChainID format
imuachainlocalnet_232-1
is consistent with other configuration files and documentation.
🏁 Script executed:
#!/bin/bash # Description: Search for ChainID format in config files and docs echo "Searching for ChainID format in configs and docs..." rg -i "chainid.*232-1|network.*232-1" --type yaml --type toml --type mdLength of output: 186
Verify ChainID consistency across all related configurations and docs.
The default values have been updated, and the ChainID is now
"imuachainlocalnet_232-1"
. However, our automated search in YAML, TOML, and Markdown files did not return any occurrences of this pattern. Please manually verify that the ChainID is consistently updated across all related configuration files, tests, and documentation to ensure there are no mismatches.init.bat (1)
1-72
: LGTM! Binary name and paths have been consistently updated.All references to the old binary name have been correctly updated to use
imuad
. The home directory path and chainid have also been updated to reflect the new branding.scripts/start-docker.sh (2)
1-30
: LGTM! Binary name and paths have been consistently updated.All references to the old binary name have been correctly updated to use
imuad
. The temporary directory name has also been updated to reflect the new branding.
4-4
:✅ Verification successful
Verify chainid consistency across scripts.
The chainid value
imuachainlocalnet_232-1
matches the one ininit.bat
. However, since the testnet chainid is still under consideration (as noted ininit.bat
), this value might need to be updated later.Run the following script to check for any other chainid values that might need to be updated:
🏁 Script executed:
#!/bin/bash # Description: Search for chainid values across the codebase. rg -g '!{.git,node_modules}' "imuachainlocalnet_232-1"Length of output: 719
Chainid Consistency Verified Across the Codebase
The search confirms that the chainid value
imuachainlocalnet_232-1
is used consistently in the following locations:
scripts/start-docker.sh
init.bat
Makefile
local_node.sh
networks/local/imuachain/Dockerfile
testutil/batch/type.go
No discrepancies were found. However, as noted in
init.bat
, be prepared to update this value once the final testnet chainid decision is made.Makefile (2)
1-580
: LGTM! Binary name, paths, and configuration have been consistently updated.All references to the old binary name, paths, and configuration have been correctly updated to use the new branding. The changes are comprehensive and consistent.
546-546
:❓ Verification inconclusive
Verify package name consistency.
The package name has been updated to
github.com/imua-xyz/imuachain
. Please ensure this matches the repository URL and import paths across the codebase.Run the following script to check for any old package references:
🏁 Script executed:
#!/bin/bash # Description: Search for old package references. rg -l "ExocoreNetwork/exocore"Length of output: 30
Below is a new script to further verify that no outdated package references exist. It performs a case-insensitive search for "exocore" across the entire repository to ensure that no remnants of the old package name linger.
Once you run this script and confirm that no output (i.e., no matches) is produced, you can be more confident that the package name update to
github.com/imua-xyz/imuachain
is consistently applied across the codebase.
🏁 Script executed:
[run_scripts] #!/bin/bash # Description: Case-insensitive search for any reference to "exocore" in the repository. rg -i "exocore"Length of output: 217
Package Name Consistency Verified with a Minor Historical Reference
- The Makefile now correctly sets the package name to
github.com/imua-xyz/imuachain
with no active import paths still using the old naming.- A case-insensitive search revealed one occurrence in a comment in
x/assets/types/keys.go
(i.e., "KeyPrefixReStakerExoCoreAddr
"), which appears to be a historical note.- Please verify if this legacy reference is intentional or should be updated for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (13)
app/app.go (12)
13-31
: Consider grouping related imports together.The imports for related modules like
feedistribution
,oracle
,avs
,operator
, andimslash
could be grouped together for better organization and readability.Consider reorganizing the imports like this:
-distr "github.com/imua-xyz/imuachain/x/feedistribution" -distrkeeper "github.com/imua-xyz/imuachain/x/feedistribution/keeper" -distrtypes "github.com/imua-xyz/imuachain/x/feedistribution/types" -"github.com/imua-xyz/imuachain/x/oracle" - -oracleKeeper "github.com/imua-xyz/imuachain/x/oracle/keeper" -oracleTypes "github.com/imua-xyz/imuachain/x/oracle/types" - -"github.com/imua-xyz/imuachain/x/avs" -"github.com/imua-xyz/imuachain/x/operator" -operatorKeeper "github.com/imua-xyz/imuachain/x/operator/keeper" - -imslash "github.com/imua-xyz/imuachain/x/imslash" - -avsManagerKeeper "github.com/imua-xyz/imuachain/x/avs/keeper" -avsManagerTypes "github.com/imua-xyz/imuachain/x/avs/types" -slashKeeper "github.com/imua-xyz/imuachain/x/imslash/keeper" -imslashtypes "github.com/imua-xyz/imuachain/x/imslash/types" +// Distribution module +distr "github.com/imua-xyz/imuachain/x/feedistribution" +distrkeeper "github.com/imua-xyz/imuachain/x/feedistribution/keeper" +distrtypes "github.com/imua-xyz/imuachain/x/feedistribution/types" + +// Oracle module +"github.com/imua-xyz/imuachain/x/oracle" +oracleKeeper "github.com/imua-xyz/imuachain/x/oracle/keeper" +oracleTypes "github.com/imua-xyz/imuachain/x/oracle/types" + +// AVS and Operator modules +"github.com/imua-xyz/imuachain/x/avs" +avsManagerKeeper "github.com/imua-xyz/imuachain/x/avs/keeper" +avsManagerTypes "github.com/imua-xyz/imuachain/x/avs/types" +"github.com/imua-xyz/imuachain/x/operator" +operatorKeeper "github.com/imua-xyz/imuachain/x/operator/keeper" +operatorTypes "github.com/imua-xyz/imuachain/x/operator/types" + +// Slash module +imslash "github.com/imua-xyz/imuachain/x/imslash" +slashKeeper "github.com/imua-xyz/imuachain/x/imslash/keeper" +imslashtypes "github.com/imua-xyz/imuachain/x/imslash/types"
171-173
: Consider renaming thedogfood
module.The module name
dogfood
appears to be a placeholder or development name. Consider using a more descriptive and production-ready name that reflects its functionality as a staking module.-staking "github.com/imua-xyz/imuachain/x/dogfood" -stakingkeeper "github.com/imua-xyz/imuachain/x/dogfood/keeper" -stakingtypes "github.com/imua-xyz/imuachain/x/dogfood/types" +staking "github.com/imua-xyz/imuachain/x/staking" +stakingkeeper "github.com/imua-xyz/imuachain/x/staking/keeper" +stakingtypes "github.com/imua-xyz/imuachain/x/staking/types"
539-540
: Remove TODO comment.The comment "TODO: replace virtual keepers with actual implementation" should be tracked in an issue rather than as a code comment.
Would you like me to create an issue to track the implementation of virtual keepers?
707-709
: Fix typo in comment.The comment contains a typo: "imualidators" should be "validators".
-// the fee distribution keeper is used to allocate reward to imualidators on epoch-basis, +// the fee distribution keeper is used to allocate reward to validators on epoch-basis,
1023-1025
: Add implementation status to module comments.The comments for
upgradetypes.ModuleName
,rewardTypes.ModuleName
, andimslashtypes.ModuleName
should be consistent in their format and provide clear information about their implementation status.-upgradetypes.ModuleName, // no-op since we don't call SetInitVersionMap -rewardTypes.ModuleName, // not fully implemented yet -imslashtypes.ModuleName, // not fully implemented yet +upgradetypes.ModuleName, // No-op: SetInitVersionMap not called +rewardTypes.ModuleName, // Status: Partially implemented +imslashtypes.ModuleName, // Status: Partially implemented
1156-1159
: Add tracking issue for mainnet upgrade plan.The TODO comment about enabling the upgrade plan for mainnet should be tracked in an issue.
Would you like me to create an issue to track the implementation of the mainnet upgrade plan?
1174-1176
: Add tracking issue for TPS metrics.The TODO comment about recording transaction metrics should be tracked in an issue.
Would you like me to create an issue to track the implementation of transaction metrics recording?
566-568
: Improve module documentation.The comment for the dogfood module should better explain its role as an AVS (Autonomous Validation Service) and its interaction with the slashing and evidence modules.
-// the dogfood module is the first AVS. it receives slashing calls from either x/slashing -// or x/evidence and forwards them to the operator module which handles it. +// The dogfood module serves as the first Autonomous Validation Service (AVS). +// It acts as an intermediary by: +// 1. Receiving slashing calls from x/slashing or x/evidence modules +// 2. Processing and validating these calls +// 3. Forwarding validated calls to the operator module for final handling +// This design ensures proper separation of concerns and maintains the chain's security model.
579-580
: Add implementation details for unfinished modules.The comment "these two modules aren't finalized yet" should provide more context about what functionality is missing and what needs to be implemented.
-// these two modules aren't finalized yet. +// TODO: These modules require additional implementation: +// 1. Reward module: Needs implementation of reward distribution logic +// 2. ImSlash module: Needs implementation of slashing mechanisms +// See issues #XXX and #YYY for detailed implementation plans
401-409
: Improve mempool configuration documentation.The comment explaining the NoOpMempool configuration is hard to read and could be better structured.
-// NOTE: we use a NoOpMempool here, for oracle create-price, it works fine since we have set a infinitgasmeterwithlimit in the ante handler to avoid the out-of-gas error no matter what the amount/gas is set by tx builder, and we set the highest priority for oracle create-price txs to work properly with tendermint mempool to make sure oracle creat-prie tx will be included in the mempool if received. And if we want to use some other application mempool, we need to take care of the gas limit and gas price in the oracle create-price txs.(we don't need to bother this since tendermint mempool use gasMeter.limit() instead of tx.Gas()) +// NOTE: NoOpMempool Configuration +// We use NoOpMempool for the following reasons: +// 1. Oracle create-price transactions: +// - Uses infinitgasmeterwithlimit in ante handler to prevent out-of-gas errors +// - Has highest priority to ensure inclusion in mempool +// - Works with tendermint mempool which uses gasMeter.limit() instead of tx.Gas() +// 2. Alternative mempool considerations: +// - Would require careful handling of gas limits and prices for oracle create-price txs +// - Not needed since tendermint mempool handles our use case
1402-1405
: Consider using constants for precompile addresses.The precompile addresses should be defined as constants to improve maintainability and reduce the risk of errors.
Consider moving the precompile addresses to a dedicated constants file:
// x/evm/types/precompiles.go const ( PrecompileAddress1 = "0x1234..." PrecompileAddress2 = "0x5678..." // Add more as needed ) var ImuachainAvailableEVMExtensions = []string{ PrecompileAddress1, PrecompileAddress2, // Add more as needed }
1099-1102
: Improve error handling in goroutine.The error from
app.tpsCounter.start()
is explicitly ignored with a comment. Consider proper error handling or logging.-// Unfortunately golangci-lint is so pedantic -// so we have to ignore this error explicitly. -_ = app.tpsCounter.start(context.Background()) +go func() { + if err := app.tpsCounter.start(context.Background()); err != nil { + app.Logger().Error("failed to start TPS counter", "error", err) + } +}()proto/imuachain/imslash/v1/params.proto (1)
1-8
: Directory Structure Consideration
Static analysis indicates that files with packageimuachain.imslash.v1
should reside within a directory structure ofimuachain/imslash/v1
relative to the repository root. Currently, this file is inproto/imuachain/imslash/v1
. Please review if this arrangement is intentional or if the file should be relocated to comply with Buf’s package directory requirements.🧰 Tools
🪛 Buf (1.47.2)
2-2: Files with package "imuachain.imslash.v1" must be within a directory "imuachain/imslash/v1" relative to root but were in directory "proto/imuachain/imslash/v1".
(PACKAGE_DIRECTORY_MATCH)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
app/app.go
(37 hunks)client/docs/config.json
(4 hunks)precompiles/slash/parser.go
(3 hunks)precompiles/slash/slash.go
(2 hunks)proto/imuachain/imslash/v1/genesis.proto
(1 hunks)proto/imuachain/imslash/v1/params.proto
(1 hunks)proto/imuachain/imslash/v1/query.proto
(1 hunks)proto/imuachain/imslash/v1/tx.proto
(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- precompiles/slash/parser.go
- precompiles/slash/slash.go
🧰 Additional context used
🪛 Buf (1.47.2)
proto/imuachain/imslash/v1/tx.proto
4-4: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
proto/imuachain/imslash/v1/genesis.proto
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/imuachain/imslash/v1/params.proto
2-2: Files with package "imuachain.imslash.v1" must be within a directory "imuachain/imslash/v1" relative to root but were in directory "proto/imuachain/imslash/v1".
(PACKAGE_DIRECTORY_MATCH)
proto/imuachain/imslash/v1/query.proto
4-4: import "google/api/annotations.proto": file does not exist
(COMPILE)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: test-unit-e2e
- GitHub Check: Analyze (go)
- GitHub Check: goreleaser
- GitHub Check: ante-benchmark-test
🔇 Additional comments (29)
proto/imuachain/imslash/v1/tx.proto (4)
2-2
: Package Rebranding UpdatedThe package declaration has been updated to
imuachain.imslash.v1
to reflect the new branding. Ensure that all dependent modules reference this new package name to avoid inconsistencies.
4-4
: Verify Import for Cosmos Message DefinitionsThe static analysis tool flagged that the import
"cosmos/msg/v1/msg.proto"
on line 4 does not exist. Please double-check that either the file is available at the expected location or update/remove this import as needed.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos/msg/v1/msg.proto": file does not exist
(COMPILE)
7-7
: Updated Import Path for ParamsThe import path for
params.proto
has been updated to"imuachain/imslash/v1/params.proto"
, which aligns with the new namespace. Verify that the file exists under this new path and that any changes in its content remain compatible.
9-9
: Updated Go Package OptionThe
go_package
option now correctly points to"github.com/imua-xyz/imuachain/x/imslash/types"
, conforming with the rebranding efforts. Ensure consistency with other similar proto files across the project.client/docs/config.json (12)
4-4
: Rebranding Update: Documentation Title
The title has been correctly updated to "Imuachain - gRPC Gateway docs", which reflects the new project branding.
10-11
: Rebranding Update: Epochs Endpoint URL
The epochs endpoint URL has been updated to "./tmp-swagger-gen/imuachain/epochs/v1/query.swagger.json", ensuring consistency with the new base name.
142-150
: Endpoint Update: Dogfood
The dogfood endpoint now uses the updated URL "./tmp-swagger-gen/imuachain/dogfood/v1/query.swagger.json". The operation IDs have been appropriately renamed ("Params" → "DogfoodParams", along with "Validator" and "Validators").
152-158
: Endpoint Update: Assets
The assets endpoint has been adjusted to reflect the new branding with the URL "./tmp-swagger-gen/imuachain/assets/v1/query.swagger.json" and the parameter rename ("Params" → "AssetsParams").
160-166
: Endpoint Update: ImSlash
The slash endpoint has been rebranded: the URL is now "./tmp-swagger-gen/imuachain/imslash/v1/query.swagger.json" and the operation ID "Params" has been updated to "ImSlashParams". Verify that all backend and documentation references reflect this change.
168-174
: Endpoint Update: Oracle
The oracle endpoint URL has been updated to "./tmp-swagger-gen/imuachain/oracle/v1/query.swagger.json" with the parameter "Params" renamed to "OracleParams", aligning with the new naming convention.
176-182
: Endpoint Update: Immint Transition
The exomint endpoint has been rebranded to "immint" with the URL updated to "./tmp-swagger-gen/imuachain/immint/v1/query.swagger.json". The operation ID "Params" is now "ImmintParams". Please ensure related documentation and integration points are updated accordingly.
183-190
: Endpoint Update: Fee Distribution
The fee distribution endpoint now uses the URL "./tmp-swagger-gen/imuachain/feedistribution/v1/query.swagger.json" and the parameter is updated to "FeeDistributionParams". This change supports the overall rebranding effort.
191-193
: Endpoint Update: Delegation
The delegation endpoint URL has been revised to reflect the new "imuachain" prefix. No operation ID changes are needed for this endpoint.
194-196
: Endpoint Update: AVS
The AVS endpoint URL has been updated to "./tmp-swagger-gen/imuachain/avs/v1/query.swagger.json". Make sure that any related logic (such as the hardcoded replacement inconvert.py
) is consistent with this updated endpoint.
197-199
: Endpoint Update: Operator
The operator endpoint URL is now "./tmp-swagger-gen/imuachain/operator/v1/query.swagger.json", aligning with the new branding requirements.
225-231
: Endpoint Update: Reward
The reward endpoint has been updated to use the new URL "./tmp-swagger-gen/imuachain/reward/v1/query.swagger.json" and the parameter "Params" has been renamed to "RewardParams". Confirm that this is consistent with the overall rebranding changes across the API documentation.proto/imuachain/imslash/v1/genesis.proto (5)
2-2
: Rebranded Package Declaration Updated
The package declaration is correctly updated toimuachain.imslash.v1
, which aligns with the new branding objective.
4-4
: Verify Existence ofgogoproto/gogo.proto
Static analysis indicates that the filegogoproto/gogo.proto
might not exist. Please ensure that this dependency is correctly installed or available in the expected location (or update the import path if necessary).🧰 Tools
🪛 Buf (1.47.2)
4-4: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
5-5
: Updated Import Path Reflects Rebranding
The import statement now referencesimuachain/imslash/v1/params.proto
—this change is consistent with the overall rebranding. Verify that the file structure matches this path for seamless proto compilation.
8-8
: Updated Go Package Option
Thego_package
option has been updated to"github.com/imua-xyz/imuachain/x/imslash/types"
, ensuring that generated code will follow the new naming scheme.
10-10
: Module Name in Documentation Updated
The comment now refers to the "imuaslash" module. Make sure that related documentation and tooling are updated to reflect this naming change.proto/imuachain/imslash/v1/params.proto (3)
1-1
: New Params Proto File for Rebranding
This new file introduces theParams
message under the rebranded package. The structure correctly establishes the parameters for the module.
2-2
: Package Declaration Verified
The package declaration in this file (imuachain.imslash.v1
) is consistent with the new branding, ensuring uniformity across your proto files.🧰 Tools
🪛 Buf (1.47.2)
2-2: Files with package "imuachain.imslash.v1" must be within a directory "imuachain/imslash/v1" relative to root but were in directory "proto/imuachain/imslash/v1".
(PACKAGE_DIRECTORY_MATCH)
4-4
: Consistent Go Package Option
Thego_package
option is updated to"github.com/imua-xyz/imuachain/x/imslash/types"
, which aligns with the new repository branding.proto/imuachain/imslash/v1/query.proto (5)
2-2
: Rebranded Package Declaration Updated
The package declaration is correctly updated toimuachain.imslash.v1
, which is in line with the overall rebranding efforts.
4-4
: Verify Existence ofgoogle/api/annotations.proto
Dependency
Static analysis reports thatgoogle/api/annotations.proto
might not exist. Please ensure that this file is available—either by including the proper dependency or by adjusting the import path if it has moved.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "google/api/annotations.proto": file does not exist
(COMPILE)
5-5
: Rebranding Updated Import Reference for Params
The updated import ofimuachain/imslash/v1/params.proto
is correct and consistent with the new module structure.
8-8
: Updated Go Package Option in Query Proto
The go_package option now correctly refers to"github.com/imua-xyz/imuachain/x/imslash/types"
, ensuring that generated code aligns with the new branding.
14-14
: Updated RPC Endpoint in HTTP Option
The RPC HTTP mapping now correctly uses the/imuachain/imslash/v1/params
endpoint to reflect the rebrand. Confirm that your API documentation and clients are updated accordingly.
imuad
imuachain
im
IMUA
(uppercase) with smaller denominationhua
unchanged. Ideally the coin should be called ImuaCoin but that does not feature in the code.Summary by CodeRabbit
Based on the comprehensive summary of changes, I'll craft concise release notes highlighting the key updates for end-users:
Release Notes: Imuachain v1.0.0
🚀 Major Rebranding
exocore
toimuachain
exo
toim
🔧 Key Infrastructure Updates
🌐 Network Changes
imuachain_234
imuachaintestnet_233
💡 Notable Improvements
🔒 Security & Performance
📦 Compatibility
Upgrade Recommended: All validators and node operators should update to this version.