-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: ensure campaign cover block does not render unless an image is selected #7732
Conversation
@JoshuaHungDinh this is not meant to be for the block preview, but for the actual front-end rendering to avoid a broken image src being rendered: ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoshuaHungDinh Since this task is related to the frontend view, I think we should roll back the placeholder on the block editor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoshuaHungDinh Thanks for the changes. This is ready to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed QA tests
Resolves GIVE-2148
Description
The Campaign Cover Image should render blank when an image URL is not set.
Affects
Campaign Cover Block
Visuals
Screen.Recording.2025-02-17.at.3.46.14.PM.mov
Testing Instructions
Pre-review Checklist
@unreleased
tags included in DocBlocks