Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: ensure campaign cover block does not render unless an image is selected #7732

Merged
merged 7 commits into from
Feb 20, 2025

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Feb 14, 2025

Resolves GIVE-2148

Description

The Campaign Cover Image should render blank when an image URL is not set.

Affects

Campaign Cover Block

Visuals

Screen.Recording.2025-02-17.at.3.46.14.PM.mov

Testing Instructions

  • Create a campaign
  • Add the Campaign Cover block
  • If an image has NOT been uploaded -> the frontend should NOT render anything a broken image tag.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh changed the title refactor: remove placeholder refactor: remove campaign cover block empty placeholder Feb 14, 2025
@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review February 17, 2025 06:50
@JoshuaHungDinh JoshuaHungDinh changed the title refactor: remove campaign cover block empty placeholder refactor: campaign cover block should render empty when no image is selected Feb 17, 2025
@JoshuaHungDinh JoshuaHungDinh changed the title refactor: campaign cover block should render empty when no image is selected Refactor: campaign cover block should render empty when no image is selected Feb 17, 2025
@glaubersilva glaubersilva self-requested a review February 17, 2025 13:36
@jonwaldstein
Copy link
Contributor

@JoshuaHungDinh this is not meant to be for the block preview, but for the actual front-end rendering to avoid a broken image src being rendered:

Screenshot 2025-02-17 at 9 45 11 AM

Copy link
Contributor

@glaubersilva glaubersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshuaHungDinh Since this task is related to the frontend view, I think we should roll back the placeholder on the block editor.

@JoshuaHungDinh JoshuaHungDinh changed the title Refactor: campaign cover block should render empty when no image is selected Refactor: ensure campaign cover block does not render unless an image is selected Feb 19, 2025
Copy link
Contributor

@glaubersilva glaubersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshuaHungDinh Thanks for the changes. This is ready to go!

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed QA tests

@jonwaldstein jonwaldstein merged commit 706f15c into epic/campaigns Feb 20, 2025
20 checks passed
@jonwaldstein jonwaldstein deleted the refactor/campaign-cover-updates branch February 20, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants