Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: ensure campaign cover block does not render unless an image is selected #7732

Merged
merged 7 commits into from
Feb 20, 2025
Merged

Refactor: ensure campaign cover block does not render unless an image is selected #7732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5a046ed
refactor: remove placeholder
JoshuaHungDinh Feb 14, 2025
1d4294d
Merge branch 'epic/campaigns' into refactor/campaign-cover-updates
JoshuaHungDinh Feb 17, 2025
ffa3b46
refactor: return early if image has not been set
JoshuaHungDinh Feb 18, 2025
b21e426
Merge branch 'epic/campaigns' into refactor/campaign-cover-updates
JoshuaHungDinh Feb 18, 2025
e4d53ea
Merge branch 'epic/campaigns' into refactor/campaign-cover-updates
JoshuaHungDinh Feb 19, 2025
e002879
refactor: reinclude placeholder
JoshuaHungDinh Feb 19, 2025
4921f1b
Merge branch 'epic/campaigns' into refactor/campaign-cover-updates
JoshuaHungDinh Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Campaigns/Blocks/CampaignCover/edit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export default function Edit({attributes, setAttributes, toggleSelection}: EditP
/>

)}

{hasResolved && campaign?.image &&
(!isSizeAligned ? (
<ResizableBox
Expand Down
4 changes: 2 additions & 2 deletions src/Campaigns/Blocks/CampaignCover/render.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
use Give\Campaigns\Models\Campaign;
use Give\Campaigns\Repositories\CampaignRepository;

if ( ! isset($attributes['campaignId'])) {
if (!isset($attributes['campaignId'])) {
return;
}

/** @var Campaign $campaign */
$campaign = give(CampaignRepository::class)->getById($attributes['campaignId']);

if ( ! $campaign) {
if (!$campaign || !$campaign->image) {
return;
}

Expand Down
Loading