-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename fields in Strapi data (RPB-160) #81
Merged
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
36f3d7d
Rename `f00_` to `rpbId` in Strapi title data (RPB-160)
fsteeg be36408
Rename `f14_` to `doNotIndex` in Strapi title data (RPB-160)
fsteeg 887d5c5
Rename `f20_` to `title` in Strapi title data (RPB-160)
fsteeg a188237
Rename `f39_` to `responsibilityStatement` in title data (RPB-160)
fsteeg 273f837
Rename `f77_` to `extent` in title data (RPB-160)
fsteeg 60934d4
Map `f21_` to `preferredTitle` in Strapi title data (RPB-160)
fsteeg c99cb45
Update URL label for current Strapi data model
fsteeg e347134
Map `f28_` to `alternativeSpelling` in Strapi title data (RPB-160)
fsteeg 8966362
Rename fields f70b, f70h, f70j, f70s, f70z (RPB-160)
fsteeg f847db1
Rename f76a, f76b to publicationDate, publicationYear (RPB-160)
fsteeg 7440079
Rename `f18_` to `inCollection` in Strapi title data (RPB-160)
fsteeg 603f621
Rename `f40` to `person` with `value` & `type` subfields (RPB-160)
fsteeg 10301a9
Don't create URIs for free text contribution values
fsteeg 85945ca
Rename `f60` to `corporateBody` with `value` & `type` (RPB-160)
fsteeg 0ff755a
Simplify contribution macros for unified `value` field (RPB-160)
fsteeg 4a61a76
Rename f24_ and f27_ to parallel- and alternativeTitle (RPB-160)
fsteeg dc7d416
Rename `f81_` to `note` with `value` subfield in Strapi (RPB-160)
fsteeg 156592a
Rename `f85_` to `isPartOf` w/ `value` subfield in Strapi (RPB-160)
fsteeg 69a4043
Rename `f30.f30_` to `subject.value` in Strapi data (RPB-160)
fsteeg 1d1deab
Rename `f32.f32_.f32_` to `subjectComponentList.subject.value`
fsteeg 605de82
Rename `f31.f31_` to `spatial.value` in Strapi data (RPB-160)
fsteeg 6e2b800
Rename `f70.f70_` to `bibliographicCitation.value` (RPB-160)
fsteeg bdf8b1b
Rename `f90.f90_` to `url.value`, `f90.n90` to `url.type` (RPB-160)
fsteeg 34ff746
Rename `f90a.f90a` to `item.value` in Strapi title data (RPB-160)
fsteeg c869675
Rename `f36_` to `type` in Strapi independent-work data (RPB-160)
fsteeg 2743d0c
Rename `f01` to `volumeIn` in Strapi independent-work (RPB-160)
fsteeg acffbde
Rename `f74_` to `publicationLocation`, `f75_` to `publishedBy`
fsteeg f1a7acf
Rename `f71_` to `edition`, include in lobid output (RPB-160)
fsteeg 4aa7bb1
Add `f20u` to `isPartOf` in Strapi independent-work data (RPB-160)
fsteeg e14d19a
Rename `f86_` to `otherId` in Strapi title data (RPB-160)
fsteeg 8c1d5b6
Rename `f87` to `isbn` in Strapi title data (RPB-160)
fsteeg b1a4316
Add `isbn` values to lobid title data (RPB-160)
fsteeg d52b660
Remove old fields after adding, rename & clean up macros (RPB-160)
fsteeg 4efc913
Rename `f00_` to `rpbId` in RPB authority data (RPB-160)
fsteeg ed203a1
Rename `f99z` to `type` in Strapi RPB authority data (RPB-160)
fsteeg 3a7e14e
Rename `f3na` to `preferredName` in Strapi authority data (RPB-160)
fsteeg 5f4436b
Rename `f3nz` to `otherInformation` in authority data (RPB-160)
fsteeg e374fc2
Rename `f3n` to `variantName`, `f3r` to `relatedEntity` (RPB-160)
fsteeg 4fd8064
Rename and clean up authority data macros (RPB-160)
fsteeg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,5 +57,6 @@ | |
"label" : "Autor/in" | ||
}, | ||
"type" : [ "Contribution" ] | ||
} ] | ||
} ], | ||
"edition" : [ "Nachdr. der Original-Ausg." ] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
{ | ||
"@context" : "http://lobid.org/resources/context.jsonld", | ||
"type" : [ "BibliographicResource", "Book" ], | ||
"rpbId" : "929t160199", | ||
"id" : "https://lobid.org/resources/929t160199", | ||
"hbzId" : "HT018859168", | ||
"isbn" : [ "978-3-7701-8016-5" ], | ||
"inCollection" : [ { | ||
"id" : "http://lobid.org/resources/HT013494180#!", | ||
"type" : [ "Collection" ], | ||
"label" : "Rheinland-Pfälzische Bibliographie" | ||
} ], | ||
"title" : "Wandern auf Rheinsteig und Rheinburgenweg", | ||
"extent" : "180 Seiten : Illustrationen, Diagramme, Karten", | ||
"note" : [ "Enthält Index" ], | ||
"isPartOf" : [ { | ||
"type" : [ "IsPartOfRelation" ], | ||
"hasSuperordinate" : [ { | ||
"label" : "DuMont aktiv" | ||
} ] | ||
} ], | ||
"responsibilityStatement" : [ "Manfred Böckling" ], | ||
"publication" : [ { | ||
"location" : [ "Ostfildern" ], | ||
"startDate" : "2012", | ||
"publishedBy" : [ "DuMont Reiseverlag" ], | ||
"type" : [ "PublicationEvent" ] | ||
} ], | ||
"subject" : [ { | ||
"id" : "http://purl.org/lobid/rpb#n102070", | ||
"label" : "Wandern / Führer", | ||
"type" : [ "Concept" ], | ||
"source" : { | ||
"id" : "http://purl.org/lobid/rpb", | ||
"label" : "Systematik der Rheinland-Pfälzischen Bibliographie" | ||
} | ||
}, { | ||
"type" : [ "ComplexSubject" ], | ||
"label" : "Rheinsteig | Rhein-Burgen-Wanderweg | Wandern", | ||
"componentList" : [ { | ||
"id" : "https://d-nb.info/gnd/7501137-2", | ||
"label" : "Rheinsteig", | ||
"source" : { | ||
"id" : "https://d-nb.info/gnd/7749153-1", | ||
"label" : "Gemeinsame Normdatei (GND)" | ||
} | ||
}, { | ||
"id" : "https://d-nb.info/gnd/7500776-9", | ||
"label" : "Rhein-Burgen-Wanderweg", | ||
"source" : { | ||
"id" : "https://d-nb.info/gnd/7749153-1", | ||
"label" : "Gemeinsame Normdatei (GND)" | ||
} | ||
}, { | ||
"id" : "https://d-nb.info/gnd/4064532-0", | ||
"label" : "Wandern", | ||
"source" : { | ||
"id" : "https://d-nb.info/gnd/7749153-1", | ||
"label" : "Gemeinsame Normdatei (GND)" | ||
} | ||
} ] | ||
} ], | ||
"spatial" : [ { | ||
"id" : "https://d-nb.info/gnd/4126432-0", | ||
"label" : "Mittelrheintal", | ||
"type" : [ "PlaceOrGeographicName" ], | ||
"source" : { | ||
"id" : "https://d-nb.info/gnd/7749153-1", | ||
"label" : "Gemeinsame Normdatei (GND)" | ||
} | ||
} ], | ||
"contribution" : [ { | ||
"agent" : { | ||
"id" : "https://d-nb.info/gnd/124591736", | ||
"label" : "Böckling, Manfred / 1970-", | ||
"type" : [ "Person" ] | ||
}, | ||
"role" : { | ||
"id" : "http://id.loc.gov/vocabulary/relators/aut", | ||
"label" : "Autor/in" | ||
}, | ||
"type" : [ "Contribution" ] | ||
} ], | ||
"description" : [ { | ||
"id" : "http://d-nb.info/1069609889/04", | ||
"label" : "http://d-nb.info/1069609889/04" | ||
} ], | ||
"edition" : [ "4., aktualisierte Auflage" ] | ||
} |
Empty file.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the output for elasticsearch, right? It does not look correct that the
id
field is filled with a non-URI string. There is the same problem in conf/output/test-output-65.json.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually kind of a fix: if the value in the source field is not actually an ID (but a label), we no longer prepend the base URI. For consistency (to always have
id
andlabel
), the label is used for the ID field. This might not be the final solution, but I think we can look into this when we tweak the web UI.