Rename fields in Strapi data (RPB-160) #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No change in lobid output data expected after running: `sbt "runMain rpb.ETL conf/rpb-test-titel-to-strapi.flux"` `sbt "runMain rpb.ETL conf/rpb-test-titel-to-lobid.flux"` Or, as a shortcut to run both: `sbt "test-only tests.EtlTest"`
And add filter to exclude in lobid transformation if `true` See `transformAndImportTest.sh` for testing Strapi import
Add record with `f21_` to test data
Noticed while testing import for RPB-160
To `volume`, `issue`, `year`, `pages`, `alternativeNumbering` Grouped as `bibliographicCitation` in lobid data
(Noticed while working on RPB-160)
(Is transformed to flat `note` array for lobid)
In Strapi title data; -> `subject.componentList` in lobid (RPB-160)
f01.f01_ -> volumeIn.numbering # Zählung (Vorlage) f01.f01s -> volumeIn.sortBy # Zählung (Sortierform) f01.f01u -> volumeIn.value # Verknüpfung zur MtM (ÜO)
In Strapi independent-work data (RPB-160)
Subfields `f87.f87_` to `isbn.value`, `f87.n87` to `isbn.valid`
fsteeg
changed the title
fsteeg
changed the title
acka47
requested changes
May 16, 2024
| @@ -65,7 +65,7 @@ | |||
| "type" : [ "Contribution" ] | |||
| }, { | |||
| "agent" : { | |||
| "id" : "https://d-nb.info/gnd/VCN 77", | |||
| "id" : "VCN 77", | |||
There was a problem hiding this comment.
This is the output for elasticsearch, right? It does not look correct that the id field is filled with a non-URI string. There is the same problem in conf/output/test-output-65.json.
There was a problem hiding this comment.
It's actually kind of a fix: if the value in the source field is not actually an ID (but a label), we no longer prepend the base URI. For consistency (to always have id and label), the label is used for the ID field. This might not be the final solution, but I think we can look into this when we tweak the web UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://jira.hbz-nrw.de/browse/RPB-160