Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a hard limit on loaded chunks #29

Closed
wants to merge 1 commit into from

Conversation

Baughn
Copy link

@Baughn Baughn commented Sep 12, 2016

As I find that the server can get overloaded, bogged down and stop working if too many chunks are generated at once.

This patch attempts to detect that condition, and pause until it's written out more chunks. The default limit of 3000 chunks is pretty generous, but is intended to let chunkgen keep working even on a populated server.

It's intended to be applied to the 1.7.10 branch. Couldn't find it, though.

@marvin-bitterlich
Copy link
Contributor

@gecgooden Any way this can be merged to the 1.10.2 branch?

@gecgooden
Copy link
Owner

@Kostronor I'm planning on it, but haven't got the chance to yet.

@marvin-bitterlich
Copy link
Contributor

marvin-bitterlich commented Sep 28, 2016

@gecgooden Any way I can help with that? Wich branch should I attempt to merge this into?

@gecgooden
Copy link
Owner

@Kostronor Sure, if you want to give it a go, that'd be great. You'll need to clone my chunkgen repository and apply Baughn's changes.

The master branch would be the best place to apply this as that's the main 1.10.2 branch

@marvin-bitterlich
Copy link
Contributor

@gecgooden Is the fix from #26 in the master branch?

@gecgooden
Copy link
Owner

Yes, it should be.

On Wed, 28 Sep 2016 at 15:58 Marvin Hofmann notifications@github.com
wrote:

@gecgooden https://github.com/gecgooden Is the fix from #26
#26 in the master branch?


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#29 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAukQ0c-ZbtnSV17iXwOBFfBp0dXGyNQks5quh4hgaJpZM4J65rs
.

marvin-bitterlich added a commit to ldtteam/chunkgen that referenced this pull request Sep 28, 2016
@gecgooden gecgooden closed this in #33 Oct 8, 2016
@Baughn Baughn deleted the chunklimit branch October 8, 2016 15:35
@Baughn Baughn restored the chunklimit branch October 8, 2016 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants