Upported changes and improved chunk queuing #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23
Closes #29
Closes #32
This pull request fixes above mentioned issues and prs.
It also adds a spiral chunk en-queuing. The region to load is split into regions 512x512 chunks and these regions are then split into 4x4 chunk Squares.
This pr will break skipChunks as I gave it up in favor of a better sorting. But we can now filter per region so we can mask regions to not be generated again once they complete. That is a imo way more failsafe approach to this.
Tested this pr on my server and it works perfectly fine.
Review please @gecgooden