Refactor existing tox test to pytest #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yongjunhong <kevin0928@naver.com>
Signed-off-by: yongjunhong <kevin0928@naver.com>
Signed-off-by: yongjunhong <kevin0928@naver.com>
- rename test methods - separate window, ubuntu test codes Signed-off-by: yongjunhong <kevin0928@naver.com>
Signed-off-by: yongjunhong <kevin0928@naver.com>
Signed-off-by: yongjunhong <kevin0928@naver.com>
Signed-off-by: yongjunhong <kevin0928@naver.com> Change path separator Signed-off-by: yongjunhong <kevin0928@naver.com>
Signed-off-by: yongjunhong <kevin0928@naver.com>
Signed-off-by: yongjunhong <kevin0928@naver.com>
Signed-off-by: yongjunhong <kevin0928@naver.com>
Signed-off-by: yongjunhong <kevin0928@naver.com>
MoonJeWoong
reviewed
Sep 29, 2024
Signed-off-by: yongjunhong <kevin0928@naver.com>
Signed-off-by: yongjunhong <kevin0928@naver.com>
Signed-off-by: yongjunhong <kevin0928@naver.com>
cjho0316
reviewed
Oct 1, 2024
ena-isme
reviewed
Oct 1, 2024
s-cu-bot
reviewed
Oct 1, 2024
5 tasks
Signed-off-by: yongjunhong <kevin0928@naver.com>
|
@YongGoose , Description 업데이트 부탁드리며 수정 완료된 커맨트는 Resolve Conversation 클릭해주십시오. |
Signed-off-by: yongjunhong <kevin0928@naver.com>
@soimkim |
soimkim
reviewed
Oct 3, 2024
Signed-off-by: yongjunhong <kevin0928@naver.com>
soimkim
reviewed
Oct 3, 2024
| @@ -1,5 +1,5 @@ | |||
| flake8==3.9.2 | |||
| pyinstaller | |||
| pyinstaller>=6.10.0 | |||
There was a problem hiding this comment.
pyinstaller 버전을 제한한 사유는 무엇인가요?
There was a problem hiding this comment.
pyinstaller: error: argument --add-binary: Wrong syntax, should be --add-binary=SOURCE:DEST
pyinstaller에서 에러가 발생하며 위 메시지가 발생하여 구문을 고치고 버전을 제한하게 됐습니다.
생각을 해보니 위 에러는 unix / window 환경 차이의 문제 같기도 합니다..! (조금 더 찾아봐야 할 것 같습니다)
개인적으로 1단계 이후 2,3단계도 개인적으로 진행 해보려고 합니다.
그 때 필요 없다고 판단이 되면 pyinstaller 원상복구 시키고 버전 제한도 삭제하도록 하겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrated the test suite from Tox to Pytest for improved readability, flexibility.
Type of change