Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor existing tox test to pytest #24

Merged
merged 19 commits into from
Oct 6, 2024
Merged

Refactor existing tox test to pytest #24

merged 19 commits into from
Oct 6, 2024

Conversation

ena-isme
Copy link
Contributor

@ena-isme ena-isme commented Sep 27, 2024 •
edited
Loading

Description

Refactoring existing tox test to pytest.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@soimkim soimkim added the chore [PR/Issue] Refactoring, maintenance the code label Sep 28, 2024
cjho0316
cjho0316 reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@cjho0316 cjho0316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ��고생하셨습니다!

MoonJeWoong
MoonJeWoong reviewed Oct 1, 2024
View reviewed changes
Copy link

@MoonJeWoong MoonJeWoong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다. 크게 고쳐야 할 부분은 보이지 않아서 코멘트 단 부분에 대해 의견달아주시면 감사하겠습니다!!

hkkim2021
hkkim2021 reviewed Oct 1, 2024
View reviewed changes
Copy link

@hkkim2021 hkkim2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 코드 잘 보고 갑니다:)

YongGoose
YongGoose reviewed Oct 1, 2024
View reviewed changes
Copy link

@YongGoose YongGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하게 잘 작성해주신 것 같습니다 :)
고생하셨습니다.

s-cu-bot
s-cu-bot approved these changes Oct 1, 2024
View reviewed changes
Copy link

@s-cu-bot s-cu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

특이사항 없습니다. 고생하셨습니다~

@soimkim
Copy link
Contributor

soimkim commented Oct 2, 2024

@ena-isme, Description에 수정 사항 작성 부탁드리며, 수정 완료된 커맨트에는 Resolve Conversation 클릭해주십시오

soimkim
soimkim reviewed Oct 3, 2024
View reviewed changes
@ena-isme
Copy link
Contributor Author

ena-isme commented Oct 5, 2024

@soimkim
코드리뷰 반영하였습니다!

@soimkim soimkim merged commit e4219af into fosslight:main Oct 6, 2024
5 of 6 checks passed
@soimkim
Copy link
Contributor

soimkim commented Oct 6, 2024

@ena-isme , 고생하셨습니다. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soimkim soimkim soimkim left review comments

@MoonJeWoong MoonJeWoong MoonJeWoong left review comments

@cjho0316 cjho0316 cjho0316 left review comments

@YongGoose YongGoose YongGoose left review comments

@hkkim2021 hkkim2021 hkkim2021 left review comments

@s-cu-bot s-cu-bot s-cu-bot approved these changes

Assignees

@ena-isme ena-isme

Labels
chore [PR/Issue] Refactoring, maintenance the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ena-isme @soimkim @MoonJeWoong @cjho0316 @YongGoose @s-cu-bot @hkkim2021