Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to Ng 19.1 #381

Merged
merged 13 commits into from
Jan 26, 2025

code cleanup

ce55dcf
Select commit
Loading
Failed to load commit list.
Merged

chore: Upgrade to Ng 19.1 #381

code cleanup
ce55dcf
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Jan 26, 2025 in 0s

7 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 7
           

Complexity increasing per file
==============================
- server/WebApi/Models/IndicatorListing.cs  1
- server/WebApi/Services/StartupServices.cs  1
- server/WebApi/Models/ChartThreshold.cs  1
- server/WebApi/Models/ChartConfig.cs  1
- server/WebApi/Models/IndicatorParamConfig.cs  1
- server/WebApi/Models/IndicatorResultConfig.cs  1
- server/WebApi/Services/Service.Quotes.Failover.cs  1
- server/WebApi/Models/ChartFill.cs  1
- server/WebApi/Endpoints.cs  2
- server/WebApi/Services/Service.Quotes.cs  3
- server/WebApi/Services/Service.Metadata.cs  1
- server/WebApi/Services/Service.Storage.cs  2
         

Complexity decreasing per file
==============================
+ server/Functions/UpdateQuotes.cs  -6
         

Clones removed
==============
+ server/WebApi/Services/Service.Metadata.cs  -3

See the complete overview on Codacy

Annotations

Check failure on line 7 in server/WebApi/Services/Service.Metadata.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

server/WebApi/Services/Service.Metadata.cs#L7 

Use the overloading mechanism instead of the optional parameters.

Check failure on line 35 in server/WebApi/Services/Service.Metadata.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

server/WebApi/Services/Service.Metadata.cs#L35 

Use the overloading mechanism instead of the optional parameters.

Check notice on line 3 in server/WebApi/Services/Service.Quotes.Failover.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

server/WebApi/Services/Service.Quotes.Failover.cs#L3 

'partial' is gratuitous in this context.

Check warning on line 3 in server/WebApi/Services/Service.Quotes.Failover.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

server/WebApi/Services/Service.Quotes.Failover.cs#L3 

Add a 'protected' constructor or the 'static' keyword to the class declaration.

Check notice on line 14 in server/WebApi/Services/Service.Quotes.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

server/WebApi/Services/Service.Quotes.cs#L14 

'partial' is gratuitous in this context.

Check failure on line 5 in server/WebApi/Services/Service.Storage.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

server/WebApi/Services/Service.Storage.cs#L5 

Use the overloading mechanism instead of the optional parameters.

Check notice on line 12 in server/WebApi/Services/Service.Storage.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

server/WebApi/Services/Service.Storage.cs#L12 

Remove the field '_containerName' and declare it as a local variable in the relevant methods.
View more details on Codacy Production