Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to Ng 19.1 #381

Merged
merged 13 commits into from
Jan 26, 2025
Merged

chore: Upgrade to Ng 19.1 #381

merged 13 commits into from
Jan 26, 2025

Conversation

DaveSkender
Copy link
Member

@DaveSkender DaveSkender commented Jan 26, 2025

and refactor API slightly

@Copilot Copilot bot review requested due to automatic review settings January 26, 2025 01:03

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

@DaveSkender DaveSkender requested a review from Copilot January 26, 2025 05:13
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 14 out of 29 changed files in this pull request and generated 1 comment.

Files not reviewed (15)
  • .devcontainer/devcontainer.json: Language not supported
  • .editorconfig: Language not supported
  • .vscode/extensions.json: Language not supported
  • .vscode/settings.json: Language not supported
  • .vscode/tasks.json: Language not supported
  • client/angular.json: Language not supported
  • client/package.json: Language not supported
  • server/Directory.Packages.props: Language not supported
  • client/src/polyfills.ts: Evaluated as low risk
  • server/Functions/UpdateQuotes.cs: Evaluated as low risk
  • server/Functions/Program.cs: Evaluated as low risk
  • server/WebApi/Models/ChartColors.cs: Evaluated as low risk
  • server/WebApi/Models/Emum.cs: Evaluated as low risk
  • server/WebApi/Models/ChartConfig.cs: Evaluated as low risk
  • server/WebApi/Models/ChartThreshold.cs: Evaluated as low risk
Comments suppressed due to low confidence (3)

server/WebApi/Endpoints.cs:9

  • Incorrect class declaration syntax. It should be 'public class Main : ControllerBase' with a separate constructor.
public class Main(IQuoteService quoteService) : ControllerBase

server/WebApi/Models/IndicatorParamConfig.cs:9

  • The comment for the 'Minimum' property is ambiguous. It should specify what the value is greater than.
public required double Minimum { get; init; } // greater than

server/WebApi/Models/IndicatorParamConfig.cs:10

  • The comment for the 'Maximum' property is ambiguous. It should specify what the value is less than.
public required double Maximum { get; init; } // less than

@DaveSkender DaveSkender changed the title chore: Upgrade to Ng 19 chore: Upgrade to Ng 19.1 Jan 26, 2025
@DaveSkender DaveSkender self-assigned this Jan 26, 2025
@DaveSkender DaveSkender enabled auto-merge (squash) January 26, 2025 08:13
@DaveSkender DaveSkender merged commit 0290360 into main Jan 26, 2025
10 checks passed
@DaveSkender DaveSkender deleted the refactor-upgrade branch January 26, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant