rpcdaemon: fix in eth_estimateGas/() with stateOverrides field #13772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskAlexSharov
approved these changes
Feb 21, 2025
somnathb1
pushed a commit
that referenced
this pull request
Feb 23, 2025
In case state Overrides - in NewReusableCaller() it is created the ibs and filled with stateOverrides - in DoCallWithNewGas() the intraBlockState is re-init losing previous initialization (r.intraBlockState = state.New(r.stateReader) ) - the NewReusableCaller() must be called in the execution loop to re-init intra block state with user configuration state changes and not state change from previous run --------- Co-authored-by: alex.sharov <AskAlexSharov@gmail.com>
Giulio2002
pushed a commit
that referenced
this pull request
Feb 23, 2025
…ix historical (#13903), qa-tests fix (#13909), and optimize for max contract gas used (#13913) (#13916) Needed for #13636 Cherry-pick #13772, #13903, #13909 and #13913 --------- Co-authored-by: Michelangelo Riccobene <michelangelo.riccobene@gmail.com> Co-authored-by: lupin012 <58134934+lupin012@users.noreply.github.com> Co-authored-by: alex.sharov <AskAlexSharov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case state Overrides
)