Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-Pick] jsonrpc: eth_estimateGas - stateoverrides (#13772), fix historical (#13903), qa-tests fix (#13909), and optimize for max contract gas used (#13913) #13916

Merged
merged 4 commits into from
Feb 23, 2025

Conversation

somnathb1
Copy link
Contributor

@somnathb1 somnathb1 commented Feb 23, 2025

Needed for #13636

Cherry-pick #13772, #13903, #13909 and #13913

Needed for #13636 (But doesn't optimally achieve the requirements yet)
@somnathb1 somnathb1 requested a review from mriccobene February 23, 2025 09:01
@somnathb1 somnathb1 changed the title Basic fix to historical eth_estimateGas (#13903) [Cherry-Pick] jsonrpc: fix to historical eth_estimateGas (#13903), rpc fix (#13909) and optimize for max contract gas used (#13913) Feb 23, 2025
In case state Overrides
- in NewReusableCaller() it is created the ibs and filled with
stateOverrides
- in DoCallWithNewGas() the intraBlockState is re-init losing previous
initialization (r.intraBlockState = state.New(r.stateReader)
)
- the NewReusableCaller() must be called in the execution loop to
re-init intra block state with user configuration state changes and not
state change from previous run

---------

Co-authored-by: alex.sharov <AskAlexSharov@gmail.com>
@somnathb1 somnathb1 changed the title [Cherry-Pick] jsonrpc: fix to historical eth_estimateGas (#13903), rpc fix (#13909) and optimize for max contract gas used (#13913) [Cherry-Pick] jsonrpc: eth_estimateGas - stateoverrides (#13772), fix historical (#13903), qa-tests fix (#13909), and optimize for max contract gas used (#13913) Feb 23, 2025
@somnathb1 somnathb1 requested a review from lupin012 February 23, 2025 09:15
@Giulio2002 Giulio2002 enabled auto-merge (squash) February 23, 2025 15:33
@Giulio2002 Giulio2002 merged commit 96c4dcb into release/3.0 Feb 23, 2025
8 checks passed
@Giulio2002 Giulio2002 deleted the som/pick13903 branch February 23, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants