Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: New layout, design and data storage features #578

Closed
8 of 10 tasks
rubenthoms opened this issue Feb 14, 2022 · 2 comments
Closed
8 of 10 tasks

Refactoring: New layout, design and data storage features #578

rubenthoms opened this issue Feb 14, 2022 · 2 comments
Assignees
Labels
CeeSol Task owned by Ceetron Solutions enhancement 🚀 New feature or request epic

Comments

@rubenthoms
Copy link
Collaborator

rubenthoms commented Feb 14, 2022

Based on the discussion between @anders-kiaer, @HansKallekleiv, @jorgenherje and me, here is a short summary of the results:

Short term changes

  • Icon used for collapsing expanded views should be changed to
    image
  • Switch from bootstrap's modal view to MaterialUI's draggable dialog (https://mui.com/components/dialogs/#draggable-dialog)
  • Implement a wrapper around each view in a plugin in order to provide an expand mechanism

Medium term changes

Long term changes

  • Use URL to share the exact same view with all set parameters (ask Dash/Plotly to implement a URL sharing feature)
  • Make it possible to implement a plugin group, i.e. one plugin with the same data but with different views that share the data - the views can either be accessible as subpages in the menu or as tabs in the plugin
    • Should tabs only be used when settings are shared between different views and subpages if only data but no settings are shared?
  • Store view settings in browser's client-side storage (e.g. menu's pinned state or expand/collapse state of settings' groups) https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Client-side_web_APIs/Client-side_storage
@rubenthoms rubenthoms changed the title Refactoring: New layout and design features Refactoring: New layout, design and data storage features Feb 14, 2022
@jorgenherje
Copy link
Collaborator

Good summary! Only one question: should the last bulletpoint Move plugin settings to a drawer that can be pinned (like the main menu) be a short term or medium term task instead?

@rubenthoms
Copy link
Collaborator Author

Closing this since most of the tasks have been completed in #599 and equinor/webviz-core-components#201. Moved the remaining tasks to #600 and #601.

@anders-kiaer anders-kiaer moved this to Done 🏁 in Webviz Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CeeSol Task owned by Ceetron Solutions enhancement 🚀 New feature or request epic
Projects
Status: Done 🏁
Development

No branches or pull requests

2 participants