Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing Webviz Layout Framework (WLF) #219

Merged

Conversation

rubenthoms
Copy link
Collaborator

@rubenthoms rubenthoms commented Jun 14, 2022

Based on equinor/webviz-config#578, this PR introduces all React components required by the new Webviz Layout Framework. That is (not exclusively):

  • WebvizContentManager: A context with a React reducer for storing layout information, such as which view or plugin is active
  • WebvizPluginLayoutColumn: A component for laying out view elements vertically
  • WebvizPluginLayoutRow: A component for laying out view elements horizontally
  • WebvizPluginLoadingIndicator: An indicator for the loading state of entire plugins
  • WebvizPluginsWrapper: A wrapper around all plugins on one page in a Webviz application - takes care of which plugin is active and notifies the user about it
  • WebvizPluginTour: A new implementation for displaying information about particular components in a plugin in a stepwise tour - able to change the active view and open the settings drawer and individual settings groups
  • WebvizPluginWrapper: A wrapper around an individual plugin - registers the plugin's information in the WebvizContentManager
  • WebvizSettings: A React component for displaying the contents of a settings groups
  • WebvizSettingsDrawer: A drawer containing a view selector, the current plugin's/view's settings groups and other actions (e.g. screenshot, full screen etc.) - can be expanded or collapsed
  • WebvizSettingsGroup: A wrapper around a settings group - enables toggling of expansion state
  • WebvizView: A wrapper around a view - enables downloading of view dependent files
  • WebvizViewElement: A wrapper around an individual view element - enabling toggling full screen, taking screenshots and opening a settings dialog

Furthermore, this PR introduces:

  • Pinned dash version to 2.4.x in GitHub workflow
  • Added output of Node and npm versions as well as installed npm packages output to GitHub workflow
  • Switched to older React (and related packages) versions in order to keep old packages working
  • Adjusted Overlay and ScrollArea components

rubenthoms and others added 30 commits February 23, 2022 16:13
Co-authored-by: Jørgen Herje <jorgen.herje@ceetronsolutions.com>
Co-authored-by: Jørgen Herje <jorgen.herje@ceetronsolutions.com>
Co-authored-by: Jørgen Herje <jorgen.herje@ceetronsolutions.com>
Co-authored-by: Jørgen Herje <jorgen.herje@ceetronsolutions.com>
Co-authored-by: Jørgen Herje <jorgen.herje@ceetronsolutions.com>
…ugin

- Only show depracation warnings snackbarn when clicking button
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😲🥇👏 Amazing.

I had a couple of questions below. Should add a CHANGELOG.md before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants