-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing Webviz Layout Framework (WLF) #219
Merged
rubenthoms
merged 90 commits into
equinor:master
from
CeetronSolutions:EQ_585-adjust-toggle-button
Jun 16, 2022
Merged
Introducing Webviz Layout Framework (WLF) #219
rubenthoms
merged 90 commits into
equinor:master
from
CeetronSolutions:EQ_585-adjust-toggle-button
Jun 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jørgen Herje <jorgen.herje@ceetronsolutions.com>
Co-authored-by: Jørgen Herje <jorgen.herje@ceetronsolutions.com>
Co-authored-by: Jørgen Herje <jorgen.herje@ceetronsolutions.com>
Co-authored-by: Jørgen Herje <jorgen.herje@ceetronsolutions.com>
Co-authored-by: Jørgen Herje <jorgen.herje@ceetronsolutions.com>
Also improved test demo
…ops' into EQ_585-adjust-toggle-button
…ugin - Only show depracation warnings snackbarn when clicking button
…on' into EQ_585-adjust-toggle-button
…EQ_585-plugin-fullscreen-animation"
Adjusted React version to be compatible with `Plotly/react-colorscales`
Adjusted lock file in react dir
anders-kiaer
approved these changes
Jun 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😲🥇👏 Amazing.
I had a couple of questions below. Should add a CHANGELOG.md
before merge.
This was referenced Jul 13, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on equinor/webviz-config#578, this PR introduces all React components required by the new Webviz Layout Framework. That is (not exclusively):
WebvizContentManager
: A context with a React reducer for storing layout information, such as which view or plugin is activeWebvizPluginLayoutColumn
: A component for laying out view elements verticallyWebvizPluginLayoutRow
: A component for laying out view elements horizontallyWebvizPluginLoadingIndicator
: An indicator for the loading state of entire pluginsWebvizPluginsWrapper
: A wrapper around all plugins on one page in a Webviz application - takes care of which plugin is active and notifies the user about itWebvizPluginTour
: A new implementation for displaying information about particular components in a plugin in a stepwise tour - able to change the active view and open the settings drawer and individual settings groupsWebvizPluginWrapper
: A wrapper around an individual plugin - registers the plugin's information in theWebvizContentManager
WebvizSettings
: A React component for displaying the contents of a settings groupsWebvizSettingsDrawer
: A drawer containing a view selector, the current plugin's/view's settings groups and other actions (e.g. screenshot, full screen etc.) - can be expanded or collapsedWebvizSettingsGroup
: A wrapper around a settings group - enables toggling of expansion stateWebvizView
: A wrapper around a view - enables downloading of view dependent filesWebvizViewElement
: A wrapper around an individual view element - enabling toggling full screen, taking screenshots and opening a settings dialogFurthermore, this PR introduces:
dash
version to 2.4.x in GitHub workflowNode
andnpm
versions as well as installednpm
packages output to GitHub workflowOverlay
andScrollArea
components