Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks related to #578 #585

Closed
9 tasks done
rubenthoms opened this issue Mar 16, 2022 · 1 comment
Closed
9 tasks done

Tasks related to #578 #585

rubenthoms opened this issue Mar 16, 2022 · 1 comment
Assignees
Labels
CeeSol Task owned by Ceetron Solutions enhancement 🚀 New feature or request

Comments

@rubenthoms
Copy link
Collaborator

rubenthoms commented Mar 16, 2022

We have already implemented some of the features in #578 in https://github.com/CeetronSolutions/webviz-config/tree/EQ_578-new-plugin-layout (wc) and https://github.com/CeetronSolutions/webviz-core-components/tree/settings-menu-and-views-dash-adjusted (wcc). This issue gives an overview over the remaining tasks in both branches (since most of the work is overlapping).

difficult/time consuming 🔴🟠🟡🔵🟢 easy/quick

  • 🟡 Create a more advanced/complex demo plugin / page (J&R)
  • 🔵 Include contact person, screenshot filename, download and deprecation warnings in the new setup (WebvizPluginWrapper) (J)
  • 🔵 Implement download and screenshot per view element (J)
  • 🟠 Find a better way to generate screenshots and implement it in WebvizPluginWrapper (R)
  • 🟢 Check if the new setup works with "old" plugins - make sure that the new layout does not come as a breaking change - if a plugin does not have the app member, the usual layout function should be used (J)
  • 🔵 Implement full screen function for whole plugin (J)
  • 🔴 Refactor how a plugin tour works in the new setup (with views) by keeping the old implementation working and implement it accordingy in React (J&R)
  • 🟢 Adjust style of ToggleSettings button in WebvizSettingsDrawer to style of other buttons in this component (R)
  • 🟠 Implement new View/SettingsGroup/ViewElement classes based on the aforeimplemented ABC classes which provide convenience functions for quickly creating new views, settings etc. (J&R)
view: WebvizView = WebvizPluginABC.make_view()
WebvizPluginABC.add_view(object_of_class_based_on_WebvizViewABC)

shared_settings_group: WebvizSharedSettingsGroup = WebvizPluginABC.make_shared_settings_group()
WebvizPluginABC.add_shared_settings_group(object_of_class_based_on_WebvizSharedSettingsGroupABC)

view_element: WebvizViewElement = WebvizView.make_view_element()
WebvizViewABC.add_view_element(object_of_class_based_on_WebvizViewElementABC)

settings_group: WebvizSharedSettingsGroup = WebvizViewABC.make_settings_group()
WebvizViewABC.add_settings_group(object_of_class_based_on_WebvizSharedSettingsGroupABC)
@rubenthoms rubenthoms added enhancement 🚀 New feature or request CeeSol Task owned by Ceetron Solutions labels Mar 16, 2022
@rubenthoms
Copy link
Collaborator Author

Closed by #599.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CeeSol Task owned by Ceetron Solutions enhancement 🚀 New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants