controller: adds secret watcher to trigger extproc config updates #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
commented
Jan 29, 2025
| if awsCreds.CredentialsFile != nil { | ||
| key = getSecretNameAndNamespace(awsCreds.CredentialsFile.SecretRef, backendSecurityPolicy.Namespace) | ||
| } | ||
| // TODO: OIDC. |
There was a problem hiding this comment.
@aabchoo TODO left to you here!
|
this is a core code addition but i want to unblock Aaron and the doc change (left as TODO in #214) relying on this, so i am merging. Anyone feel free to leave comments even after the merge... |
|
i am adding an e2e test for this now... maybe there's some bug |
mathetake
added a commit
that referenced
this pull request
Jan 29, 2025
**Commit Message**: Without triggering pods into the reconcile loop of k8s server, the config map updates will take a few minutes to be picked up and reflected on the actual file of the pod [^1]. This commit changes the config sink so that it will add the config uuid to the extproc pods annotations. [^1]: https://neonmirrors.net/post/2022-12/reducing-pod-volume-update-times/ **Related Issues/PRs (if applicable)**: Follow up on #219 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
This adds a secret watcher controller that enables the
hot reload of any secret referenced by backendTrafficPolicy.
Related Issues/PRs (if applicable):
Follow up on #43 #106 #161
Supersede #185