Skip to content

Commit

Permalink
docs: removes the instruction to restart extproc (#227)
Browse files Browse the repository at this point in the history
**Commit Message**:

This was necessary before #219 and #224 landed
the main branch. Now the secret updates will be 
automatically picked up by the extproc without restarts.
This behavior is already being tested in an e2e test.

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
  • Loading branch information
mathetake authored Jan 29, 2025
1 parent 13cacf4 commit 23c93ee
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
5 changes: 2 additions & 3 deletions site/docs/getting-started/connect-providers/aws-bedrock.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ The credentials will be stored in Kubernetes secrets.

### 2. Apply Configuration

Apply the updated configuration and wait for the Gateway pod to be ready, and restart the ext-proc to pick up the updated secrets:
Apply the updated configuration and wait for the Gateway pod to be ready. If you already have a Gateway running,
then the secret credential update will be picked up automatically in a few seconds.

```shell
kubectl apply -f basic.yaml
Expand All @@ -56,8 +57,6 @@ kubectl wait pods --timeout=2m \
-l gateway.envoyproxy.io/owning-gateway-name=envoy-ai-gateway-basic \
-n envoy-gateway-system \
--for=condition=Ready

kubectl rollout restart deployment/ai-eg-route-extproc-envoy-ai-gateway-basic
```

### 4. Test the Configuration
Expand Down
5 changes: 2 additions & 3 deletions site/docs/getting-started/connect-providers/openai.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ The key will be stored in a Kubernetes secret.

### 2. Apply Configuration

Apply the updated configuration and wait for the Gateway pod to be ready, and restart the ext-proc to pick up the updated secrets:
Apply the updated configuration and wait for the Gateway pod to be ready. If you already have a Gateway running,
then the secret credential update will be picked up automatically in a few seconds.

```shell
kubectl apply -f basic.yaml
Expand All @@ -41,8 +42,6 @@ kubectl wait pods --timeout=2m \
-l gateway.envoyproxy.io/owning-gateway-name=envoy-ai-gateway-basic \
-n envoy-gateway-system \
--for=condition=Ready

kubectl rollout restart deployment/ai-eg-route-extproc-envoy-ai-gateway-basic
```

### 3. Test the Configuration
Expand Down

0 comments on commit 23c93ee

Please sign in to comment.