-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cabal-docspec and hlint #90
Conversation
@@ -8,3 +8,7 @@ | |||
|
|||
# this doesn't work well with Rank2Types | |||
- ignore: {name: Eta reduce} | |||
- ignore: {name: Unused LANGUAGE pragma} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked to see if the suggestions that hlint
provides here are reasonable? I'm not necessarily opposed to ignoring certain hlint
warnings, but if the warnings are reasonable, I'd prefer just applying the suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair. I cleaned up the other warnings but left LANGUAGE
one. It has false positives (DeriveTraversable
not always implies DeriveFunctor
, e.g.) so I just left it.
The build is green except notification sending failed |
Urk, it looks like this conflicted with another concurrent use of the nick In any case, thanks. Let's land this. |
I think I'm half-seriously thinking of making an IRC bot just for these, which would keep persistent connection. |
That's certainly one way to solve the problem. As an alternative, we could generate unique nicks for each notification, but perhaps that's overkill. |
No description provided.