Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal-docspec and hlint #90

Merged
merged 2 commits into from
Jan 10, 2021
Merged

cabal-docspec and hlint #90

merged 2 commits into from
Jan 10, 2021

Conversation

phadej
Copy link
Contributor

@phadej phadej commented Jan 10, 2021

No description provided.

@phadej phadej changed the title Cabal docspec cabal-docspec and hlint Jan 10, 2021
@@ -8,3 +8,7 @@

# this doesn't work well with Rank2Types
- ignore: {name: Eta reduce}
- ignore: {name: Unused LANGUAGE pragma}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked to see if the suggestions that hlint provides here are reasonable? I'm not necessarily opposed to ignoring certain hlint warnings, but if the warnings are reasonable, I'd prefer just applying the suggestions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair. I cleaned up the other warnings but left LANGUAGE one. It has false positives (DeriveTraversable not always implies DeriveFunctor, e.g.) so I just left it.

@phadej
Copy link
Contributor Author

phadej commented Jan 10, 2021

The build is green except notification sending failed

@RyanGlScott
Copy link
Collaborator

< :beckett.freenode.net 433 * github-actions :Nickname is already in use.

Urk, it looks like this conflicted with another concurrent use of the nick github-actions. I wonder if this limitation is inherent in the way these sorts of IRC notification bots work, or if it would be worth investigating another IRC action (e.g., notify-irc).

In any case, thanks. Let's land this.

@RyanGlScott RyanGlScott merged commit 6edd6c6 into ekmett:master Jan 10, 2021
@phadej phadej deleted the cabal-docspec branch January 10, 2021 22:05
@phadej
Copy link
Contributor Author

phadej commented Jan 10, 2021

I think notify-irc has the same problem, i.e. everything which connects on run is not gonna work.

I'm half-seriously thinking of making an IRC bot just for these, which would keep persistent connection.

@RyanGlScott
Copy link
Collaborator

I'm half-seriously thinking of making an IRC bot just for these, which would keep persistent connection.

That's certainly one way to solve the problem. As an alternative, we could generate unique nicks for each notification, but perhaps that's overkill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants