Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build mandelbrot-iter on CI & use cabal-docspec #206

Merged
merged 2 commits into from
Jan 13, 2021

Conversation

phadej
Copy link
Contributor

@phadej phadej commented Jan 13, 2021

There are plenty of prop> in free, but most of them aren't "decidable", e.g.

src/Control/Monad/Free/Church.hs:--   prop> fmap f . fmap g == fmap (f . g)
src/Control/Monad/Trans/Iter.hs:-- prop> runIter . iter == id

(or/and would require quite a large setup to ctually run, QuickCheck instances etc.).


With this PR I'm able to run cabal-docspec on a single kmettverse project at once. That is quite cool.

@phadej phadej changed the title Build mandelbrot-iter on CI Build mandelbrot-iter on CI & use cabal-docspec Jan 13, 2021
Copy link
Collaborator

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall that I originally disabled mandelbrot-iter due to xpika/hgl#3, but fortunately, it seems that a fix for that issue has made its way into HGL-3.2.3.2 on Hackage. In light of this, can you remove the following comments from free-examples?

-- This example depends on the HGL library which, unfortunately, fails to
-- compile on GHC 8.4 or later. (See https://github.com/xpika/hgl/issues/3.)
-- Build at your own risk.

@RyanGlScott
Copy link
Collaborator

Thanks for all your work on this, @phadej! If you apply my suggestion in #206 (review), then I'll merge this.

@phadej
Copy link
Contributor Author

phadej commented Jan 13, 2021

I changed the mandelbrot-iter example: removed the comment and added lowerbound on HGL

@RyanGlScott RyanGlScott merged commit f6e65c4 into ekmett:master Jan 13, 2021
@phadej phadej deleted the mandelbrot-iter branch January 13, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants