-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#420: Create Windows Installer with WixToolset #978
Conversation
Pull Request Test Coverage Report for Build 13564776342Details
💛 - Coveralls |
This comment was marked as outdated.
This comment was marked as outdated.
…#420-create-win-installer
Is added but has to be tested when #1084 is merged. |
…/alfeilex/IDEasy into devonfw#420-create-win-installer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alfeilex thanks for this PR and finding a solution to this tricky story 👍
I checked the following aspects:
- installation is happening via new approach (
ideasy -f install
) - the installation is triggered from the correct directory (workaround for bug Fix CWD for InstallCommandlet #1084)
- uninstallation is happening correctly (
ideasy -f uninstall
) - license agreement is implemented nicely with the proper license (via RTF and follow up issue Add Conversion of LICENSE.adoc to RTF Format #1056 was created)
- what I am unsure is if the user can pick the installation location and that will be honored by the installation (I was expecting that IDE_ROOT would be set according to the users choice before
ideasy -f install
is called) - all is integrated into nightly build and looks sane to me. However, I do not immediately understand if the native image will be included in the MSI.
- Release download link to MSI was added
- CHANGELOG was adopted
So IMHO this is already in a great state, even though it is not entirely completed.
I would therefore merge it as is and test it with a nightly build, download MSI and test it.
Then we can improve and complete in a follow up PR.
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Fixes: #420
This PR implements the creation of a MSI file for Windows Installer with WixToolset
It includes:
C:\projects
) or customizeideasy.exe -f install
Nightly Build
andRelease
workflow