Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#420: Create Windows Installer with WixToolset #978

Merged
merged 56 commits into from
Feb 27, 2025

Conversation

alfeilex
Copy link
Member

@alfeilex alfeilex commented Jan 22, 2025

Fixes: #420

This PR implements the creation of a MSI file for Windows Installer with WixToolset

It includes:

  • The Windows Installer Build Package with UI Sequence:
    • Accept License
    • Continue with default installation (default C:\projects) or customize
      • Volume Drive
      • Root Folder or User Home Folder
    • Copy files into installation folder and run ideasy.exe -f install
  • The integration of the WixToolSet build logic into the Nightly Build and Release workflow

@coveralls
Copy link
Collaborator

coveralls commented Jan 22, 2025

Pull Request Test Coverage Report for Build 13564776342

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.255%

Totals Coverage Status
Change from base Build 13563968558: 0.0%
Covered Lines: 7867
Relevant Lines: 11077

💛 - Coveralls

@alfeilex alfeilex self-assigned this Jan 22, 2025
@alfeilex

This comment was marked as outdated.

@alfeilex
Copy link
Member Author

@alfeilex now that my PR #1055 is merged, your MSI installer only needs to call ideasy.exe -f install:

./bin/ideasy -f install

Is added but has to be tested when #1084 is merged.

@alfeilex alfeilex marked this pull request as ready for review February 26, 2025 15:28
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex thanks for this PR and finding a solution to this tricky story 👍
I checked the following aspects:

  • installation is happening via new approach (ideasy -f install)
  • the installation is triggered from the correct directory (workaround for bug Fix CWD for InstallCommandlet #1084)
  • uninstallation is happening correctly (ideasy -f uninstall)
  • license agreement is implemented nicely with the proper license (via RTF and follow up issue Add Conversion of LICENSE.adoc to RTF Format #1056 was created)
  • what I am unsure is if the user can pick the installation location and that will be honored by the installation (I was expecting that IDE_ROOT would be set according to the users choice before ideasy -f install is called)
  • all is integrated into nightly build and looks sane to me. However, I do not immediately understand if the native image will be included in the MSI.
  • Release download link to MSI was added
  • CHANGELOG was adopted

So IMHO this is already in a great state, even though it is not entirely completed.
I would therefore merge it as is and test it with a nightly build, download MSI and test it.
Then we can improve and complete in a follow up PR.

@hohwille hohwille merged commit 79af9f3 into devonfw:main Feb 27, 2025
4 checks passed
julia-cap pushed a commit to julia-cap/IDEasy that referenced this pull request Feb 28, 2025
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
windows specific for Microsoft Windows OS
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Create installer for Windows
3 participants