Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bin duplication in artifact path #1081

Closed
alfeilex opened this issue Feb 25, 2025 · 1 comment
Closed

Fix bin duplication in artifact path #1081

alfeilex opened this issue Feb 25, 2025 · 1 comment
Labels
blocker bug Something isn't working bugfix commandlet install installation process of IDE + tools and install commandlet

Comments

@alfeilex
Copy link
Member

Expected behavior

The installation commandlet ideasy.exe install should also work if bin is already in current path.

Actual behavior

When running ideasy install from a path, where bin is part of the current path, e.g. C:\projects\_ide\bin\ideasy, then bin is appended to the artifactPath extra, like C:\projects\_ide\bin\bin. That leads to a invalid path.

Steps to reproduce

Run C:\projects\_ide\bin\ideasy.exe install or navigate inside the bin folder and run ideasy.exe install there. Then enter yes and you should get this output. Otherwise you can also run with -f directly. Be sure that IDEasy is not installed on your system. Remove software/maven and also the env

Missing required file bin
Missing required file functions
Missing required file internal
Missing required file system
Missing required file IDEasy.pdf
Missing required file setup
IDEasy release is inconsistent at C:\projects\_ide\bin

Related/Dependent Issues

PR #978 needs this fix, because the MSI installer uses the absolute path to the ideasy.exe

Comments/Hints:

While debugging, I realized the extra appending of bin and the if-statement leading to the error message in this spot:

Path artifactPath = cwd.resolve(artifactName);
if (Files.exists(artifactPath)) {

@alfeilex alfeilex added the bug Something isn't working label Feb 25, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Feb 25, 2025
@alfeilex alfeilex added blocker commandlet install installation process of IDE + tools and install commandlet bugfix labels Feb 25, 2025
@alfeilex
Copy link
Member Author

Closed because of misunderstanding of the problem

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in IDEasy board Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Something isn't working bugfix commandlet install installation process of IDE + tools and install commandlet
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant