Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#929: optimize upgrade settings using file access #1078

Merged
merged 11 commits into from
Feb 27, 2025
Merged

#929: optimize upgrade settings using file access #1078

merged 11 commits into from
Feb 27, 2025

Conversation

mbilda
Copy link
Contributor

@mbilda mbilda commented Feb 25, 2025

Fixes: #929

  • added new function to FileAccess interface: exists()
  • added new function to FileAccessImpl: exists()
  • refactored updateLegacyFolder with new FileAccess implementation
  • used the move function from FileAccess instead of Files
  • Changed the catching exception

@mbilda
devonfw#929 : Optimized upgradeSettings updateLegacyFolder with FileA…
24e33b0 
…ccess

- added new function to FileAccess interface: exists()
- added new function to FileAccessImpl: exists()
- refactored updateLegacyFolder with new FileAccess implementation
@mbilda
devonfw#929 : Optimized upgradeSettings updateLegacyFolder with FileA…
61c82d1 
…ccess

- used the move function from FileAccess instead of Files
- Changed the catching exception
@mbilda mbilda self-assigned this Feb 25, 2025
@mbilda mbilda added the enhancement New feature or request label Feb 25, 2025
@coveralls
Copy link
Collaborator

coveralls commented Feb 25, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13562360737

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 147 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 68.255%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/commandlet/UpgradeSettingsCommandlet.java 6 78.36%
com/devonfw/tools/ide/io/FileAccessImpl.java 141 66.43%
Totals Coverage Status
Change from base Build 13562322837: 0.03%
Covered Lines: 7867
Relevant Lines: 11077
💛 - Coveralls

jan-vcapgemini
jan-vcapgemini reviewed Feb 26, 2025
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've added some CRs to resolve. Please check.

@mbilda
devonfw#929 : Optimized upgradeSettings updateLegacyFolder with FileA…
f5a9429 
…ccess

- PR remarks
- added StandardCopyOption.REPLACE_EXISTING parameter to the FileAccessImpl class to not lose the configuration
- refactored the whole class with FileAccess instead of Files
jan-vcapgemini
jan-vcapgemini reviewed Feb 26, 2025
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my last CR, should be ready for review afterwards.

@mbilda
devonfw#929 : Optimized upgradeSettings updateLegacyFolder with FileA…
d078528 
…ccess

- PR remarks
- added StandardCopyOption.REPLACE_EXISTING parameter again to the function call
- extended the custom move function in FileAccess with optional CopyOption
@mbilda
Merge remote-tracking branch 'origin/fix/929-optimize-upgrade-setting…
ab18624 
…s-using-file-access' into fix/929-optimize-upgrade-settings-using-file-access
hohwille
hohwille approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbilda thanks for your PR. Well done and ready for merge 👍

@hohwille hohwille added this to the release:2025.02.002 milestone Feb 27, 2025
@hohwille hohwille changed the title #929 optimize upgrade settings using file access #929: optimize upgrade settings using file access Feb 27, 2025
@hohwille hohwille merged commit 1d91d41 into devonfw:main Feb 27, 2025
4 checks passed
julia-cap pushed a commit to julia-cap/IDEasy that referenced this pull request Feb 28, 2025
@mbilda @jan-vcapgemini
@hohwille @julia-cap
devonfw#929: optimize upgrade settings using file access (devonfw#1078)
dd65c22 
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

@jan-vcapgemini jan-vcapgemini Awaiting requested review from jan-vcapgemini

Assignees

@mbilda mbilda

Labels
enhancement New feature or request
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2025.02.002
Development

Successfully merging this pull request may close these issues.

Optimize UpgradeSettings updateLegacyFolder to use FileAccess
4 participants
@mbilda @coveralls @hohwille @jan-vcapgemini