#929: optimize upgrade settings using file access

cli/src/main/java/com/devonfw/tools/ide/commandlet/UpgradeSettingsCommandlet.java

@@ -1,15 +1,14 @@
 package com.devonfw.tools.ide.commandlet;
 
-import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.Path;
-import java.nio.file.StandardCopyOption;
 import java.util.function.Function;
 
 import com.devonfw.tools.ide.context.IdeContext;
 import com.devonfw.tools.ide.environment.EnvironmentVariables;
 import com.devonfw.tools.ide.environment.EnvironmentVariablesPropertiesFile;
 import com.devonfw.tools.ide.environment.EnvironmentVariablesType;
+import com.devonfw.tools.ide.io.FileAccess;
 import com.devonfw.tools.ide.merge.DirectoryMerger;
 import com.devonfw.tools.ide.tool.mvn.Mvn;
 import com.devonfw.tools.ide.tool.repository.CustomToolsJson;
@@ -55,16 +54,17 @@ private void updateLegacyFolders() {
   }
 
   private void updateLegacyFolder(Path folder, String legacyName, String newName) {
+    FileAccess fileAccess = this.context.getFileAccess();
 
     Path legacyFolder = folder.resolve(legacyName);
     Path newFolder = folder.resolve(newName);
-    if (Files.isDirectory(legacyFolder)) {
+    if (fileAccess.isExpectedFolder(legacyFolder)) {
       try {
-        if (!Files.exists(newFolder)) {
-          Files.move(legacyFolder, newFolder, StandardCopyOption.REPLACE_EXISTING);
+        if (!fileAccess.exists(newFolder)) {
+          fileAccess.move(legacyFolder, newFolder);
           this.context.success("Successfully renamed folder '{}' to '{}' in {}.", legacyName, newName, folder);
         }
-      } catch (IOException e) {
+      } catch (IllegalStateException e) {
         this.context.error(e, "Error renaming folder {} to {} in {}", legacyName, newName, folder);
       }
     }

cli/src/main/java/com/devonfw/tools/ide/io/FileAccess.java

@@ -43,6 +43,12 @@ public interface FileAccess {
    */
   boolean isFile(Path file);
 
+  /**
+   * @param file the {@link Path} to check.
+   * @return {@code true} if the given {@code file} points to an existing file, {@code false} otherwise (the given {@link Path} does not exist
+   */
+  boolean exists(Path file);
+
   /**
    * @param folder the {@link Path} to check.
    * @return {@code true} if the given {@code folder} points to an existing directory, {@code false} otherwise (a warning is logged in this case).

cli/src/main/java/com/devonfw/tools/ide/io/FileAccessImpl.java

@@ -219,6 +219,11 @@ public boolean isFile(Path file) {
     return true;
   }
 
+  @Override
+  public boolean exists(Path file) {
+    return Files.exists(file);
+  }
+
   @Override
   public boolean isExpectedFolder(Path folder) {